7 Feb 2008, 10:39 AM
Passed
- Join Date:
- Aug 2004
- Location:
- Belfast, Northern Ireland
- Posts:
- 2,480
- Plugin Contributions:
- 4
[Done v1.3.9] 1.3.8a - Fix for small bugs in Coupon Admin
Hi,
The status and page variables weren't being passed for the insert and e-mail buttons, so clicking "cancel" brought the user back to the first page of active coupons, regardless of the previous page and status selection.
Problem found in all versions of Zen Cart up to 1.3.8a
Diff follows:
--- C:\Users\Bob\Downloads\zen-cart-v1.3.8a-full-fileset-12112007\admin\coupon_admin.php 2007-09-26 07:59:08.000000000 -0000
+++ C:\Users\Bob\Downloads\coupon_admin.php 2008-02-07 10:33:51.000000000 -0000
@@ -1065,13 +1065,13 @@
<tr>
<td class="smallText"> <?php echo $cc_split->display_count($cc_query_numrows, MAX_DISPLAY_SEARCH_RESULTS_DISCOUNT_COUPONS, $_GET['page'], TEXT_DISPLAY_NUMBER_OF_COUPONS); ?> </td>
<td align="right" class="smallText"> <?php echo $cc_split->display_links($cc_query_numrows, MAX_DISPLAY_SEARCH_RESULTS_DISCOUNT_COUPONS, MAX_DISPLAY_PAGE_LINKS, $_GET['page'], (isset($_GET['status']) ? '&status=' . $_GET['status'] : '')); ?> </td>
</tr>
<tr>
- <td align="right" colspan="2" class="smallText"><?php echo '<a href="' . zen_href_link(FILENAME_COUPON_ADMIN, 'page=' . $_GET['page'] . '&cid=' . $cInfo->coupon_id . '&action=new') . '">' . zen_image_button('button_insert.gif', IMAGE_INSERT) . '</a>'; ?></td>
+ <td align="right" colspan="2" class="smallText"><?php echo '<a href="' . zen_href_link(FILENAME_COUPON_ADMIN, 'page=' . $_GET['page'] . '&cid=' . $cInfo->coupon_id . '&action=new' . (isset($_GET['status']) ? '&status=' . $_GET['status'] : '') . (isset($_GET['page']) ? '&page=' . $_GET['page'] : '')) . '">' . zen_image_button('button_insert.gif', IMAGE_INSERT) . '</a>'; ?></td>
</tr>
</table></td>
</tr>
</table></td>
<?php
@@ -1156,13 +1156,13 @@
COUPON_PRODUCTS . ' :: ' . $prod_details . '<br />' .
COUPON_CATEGORIES . ' :: ' . $cat_details . '<br />' .
DATE_CREATED . ' :: ' . zen_date_short($cInfo->date_created) . '<br />' .
DATE_MODIFIED . ' :: ' . zen_date_short($cInfo->date_modified) . '<br /><br />' .
COUPON_ZONE_RESTRICTION . ' :: ' . zen_get_geo_zone_name($cInfo->coupon_zone_restriction) . '<br /><br />' .
($cInfo->coupon_id != '' ?
- '<center><a href="'.zen_href_link(FILENAME_COUPON_ADMIN,'action=email&cid='.$cInfo->coupon_id,'NONSSL').'">'.zen_image_button('button_email.gif','Email ' . TEXT_DISCOUNT_COUPON).'</a>' .
+ '<center><a href="'.zen_href_link(FILENAME_COUPON_ADMIN,'action=email&cid='.$cInfo->coupon_id . (isset($_GET['status']) ? '&status=' . $_GET['status'] : '') . (isset($_GET['page']) ? '&page=' . $_GET['page'] : ''),'NONSSL').'">'.zen_image_button('button_email.gif','Email ' . TEXT_DISCOUNT_COUPON).'</a>' .
'<a href="'.zen_href_link(FILENAME_COUPON_ADMIN,'action=voucheredit&cid='.$cInfo->coupon_id . (isset($_GET['status']) ? '&status=' . $_GET['status'] : '') . (isset($_GET['page']) ? '&page=' . $_GET['page'] : ''),'NONSSL').'">'.zen_image_button('button_edit.gif','Edit ' . TEXT_DISCOUNT_COUPON) .'</a>' .
'<a href="'.zen_href_link(FILENAME_COUPON_ADMIN,'action=voucherdelete&cid='.$cInfo->coupon_id . (isset($_GET['status']) ? '&status=' . $_GET['status'] : '') . (isset($_GET['page']) ? '&page=' . $_GET['page'] : ''),'NONSSL').'">'.zen_image_button('button_delete.gif','Delete ' . TEXT_DISCOUNT_COUPON).'</a>' .
'<br /><a href="'.zen_href_link('coupon_restrict.php','cid='.$cInfo->coupon_id . (isset($_GET['status']) ? '&status=' . $_GET['status'] : '') . (isset($_GET['page']) ? '&page=' . $_GET['page'] : ''),'NONSSL').'">'.zen_image_button('button_restrict.gif','Restrict').'</a><a href="'.zen_href_link(FILENAME_COUPON_ADMIN,'action=voucherreport&cid='.$cInfo->coupon_id . (isset($_GET['status']) ? '&status=' . $_GET['status'] : '') . (isset($_GET['page']) ? '&page=' . $_GET['page'] : ''),'NONSSL').'">'.zen_image_button('button_report.gif',TEXT_DISCOUNT_COUPON . ' Report').
'<a href="'.zen_href_link(FILENAME_COUPON_ADMIN,'action=vouchercopy&cid='.$cInfo->coupon_id . (isset($_GET['status']) ? '&status=' . $_GET['status'] : '') . (isset($_GET['page']) ? '&page=' . $_GET['page'] : ''),'NONSSL').'">'.zen_image_button('button_copy.gif','Copy ' . TEXT_DISCOUNT_COUPON) . '</a></center>'
: ' who ' . $cInfo->coupon_id . ' - ' . $_GET['cid'])
);
```All the best...
Conor
[Ceon](http://ceon.net)