Shopping Cart Error when enabling inline shipping estimator?

Is it possible that this fix I applied could be responsible for my problem? http://www.zen-cart.com/forum/showpost.php?p=487733&postcount=10

Thanks!

BlessIsaacola:

Is it possible that this fix I applied could be responsible for my problem? http://www.zen-cart.com/forum/showpost.php?p=487733&postcount=10

Thanks!

Unlikely

DrByte, I sent you and Wilt a PM of the code that was output on the screen. It looks like googlecheckout is the culprit. Here is what I suspect:

$products = $cart->get_products();
require_once(DIR_WS_CLASSES . 'order.php');
$order = new order;
$order_items = $order->products;

The above google is from googlecheckout/gcheckout.php. Obviously if GCO is loading php require_once(DIR_WS_CLASSES . 'order.php'); that would explain why it cannot be redeclared. Of course I don't how to convert this so GCO only load ```php
require_once(DIR_WS_CLASSES . 'order.php');

I am not even sure where I am going with this but please take a look at your PM and see if you can guide me in the right direction.

BlessIsaacola:

It looks like googlecheckout is the culprit.

I'm not surprised. Hence the suggestion to compare all files vs originals and look for any and all differences.
Of course, checking that each contribution is correctly installed is important too.

Perhaps re-reviewing the GC module files and bugfixes would be appropriate?
Granted, if your site is running an older version of Zen Cart than what the latest GC code is designed for, you could get confusing behavior.

DrByte:

I'm not surprised. Hence the suggestion to compare all files vs originals and look for any and all differences.
Of course, checking that each contribution is correctly installed is important too.

Perhaps re-reviewing the GC module files and bugfixes would be appropriate?
Granted, if your site is running an older version of Zen Cart than what the latest GC code is designed for, you could get confusing behavior.

You lost me DrByte because your post really is not a solution or suggestion of what to do :) Comparing files actually did not pick up this problem because this is not a standard Zen Cart feature. I was comparing ZC1.3.8a in production to a fresh download of zc1.3.8a to make sure I have the same thing in production. There is not original GCO file to compare to because it's not a Zen Cart core.

I am also using GCO version 1.4.7 which is intended for ZC 1.3.8a. The GCO is no longer supported but I will post in that thread to see if someone have a solution. It's still baffling that the shipping estimator is the action that is triggering this. It would actually have been smarter for shipping estimator and google checkout to both check if something has been declared before trying to redeclare it.

Oops ... Somehow I'd thought you'd said you were running 1.3.7 still. Hence the version difference comment.

I can't vouch for the quality of coding of the Google checkout module, nor for any of their reasons behind it being "no longer supported". I can say though that the shipping estimator functions work fine on a clean install of Zen Cart that hasn't been tainted by the GC code.

Technically the "require_once" means ... "only ever load this once, so that 'redeclare' errors cannot happen".

Hopefully someone who's been using or writing the GC code will be able to help you find a way to not start the order class when it's not needed.

Of course if you want to hack up your own Zen Cart code just to accomodate their methods, you could try adding additional code before the require_once statements to check if the $order variable isset() or not, and/or check to see if the order class has been declared yet, and skip the require if it has been. But, that's all hacking about in ZC all because of an addon that's mussing things up ... You can see where I'm going with that thought ...

Wilt, I just want to update that your fix worked. We've been live with the code changes for about a week now without a single error in the log. Thank you so much. I am surprised that this problem didn't surfaced until now.

Hello there,

I am having the same exact problem. Thought I have 1.38a zencart. But it is definitely when googlecheckout is enabled, inline shipping estimator and when somebody is logged in and viewing shopping cart.

I would be grateful for the fix Wilt gave, this has been driving me crazy for months. lol

Regards,

Heathenmagic :smile:

in includes/modules/shipping_estimator.php at line 84
chnge it from

require(DIR_WS_CLASSES . 'order.php');

to

require_once(DIR_WS_CLASSES . 'order.php');

THANKYOU! THANKYOU! THANKYOU!

You are a star, bless you. That fixed it. That has been driving me mad for ages and ages!

Most grateful,

Heathenmagic:smile:

You are certainly welcome but Thanks to Wilt who actually took the time to come up with the solution. The problem was blamed on GCO for a long time but the fix needed to happen in ZC because of the way GCO changes things :smile:

Yes thankyou to Wilt. And of course to you BlessIsaacola for getting back to me. I knew it was connected to GCO somehow.

All the best,

Heathenmagic :smile: