[Done v2.0.0] Divide by Zero error with ot_coupon.php

I have read the thread at http://www.zen-cart.com/forum/showthread.php?t=82619&highlight=ot_group_pricing
And DrByte's post #10

Seeing this type of error during checkout when applying a coupon and getting:

Warning: Division by zero in /includes/modules/order_total/ot_coupon.php on line 365
Code at 365

$ratioTax = $adjustedTax/$order->info['tax'];

Any insight as to where in this file would a correction be applied and what would it be?

I could have sworn I posted this fix, but of course I can't find it now.

If you just move this line down into the foreach loop, you'll be fine.

Hi,

I have the same issue with kobra. It gives me the following when I applied the discount code at the order confirmation page.

public_html/includes/modules/order_total/ot_coupon.php on line 364

$ratioTax = $adjustedTax/$order->info['tax'];

The checkout still works (at least till at paypal page which I stopped at) but it has affected some parts of the site layout at that page.

swguy, apologies about this but what do you mean "move this line down into the foreach loop"?

Hope to get this rectify soon as my customers will use the coupon soon. Thanks!

I have the same issue with kobra. It gives me the following when I applied the discount code at the order confirmation page.
I actually went back to a demo install that I have and this has only default files and this works there without a hitch.

I am off to check my overrides files

kobra:

I actually went back to a demo install that I have and this has only default files and this works there without a hitch.

I am off to check my overrides files
Keep us updated kobra. :)

My site currently running on Zen Cart 1.3.8a.

Normal checkout processing works fine without a hitch. It's only when coupon code is applied then the error appeared and it screws up the layout as well. Be it for individual or for group usage. Fortunately, it allows checkout to the payment page still. I found out the bug only when I did a test myself with a valid coupon code.

Keep us updated
When I switced to the classic template I did not have the issue and so knew this had to do with some overridden template file - If you are using overrides religiously you can try the same thing

And/or list the Module additions you have

kobra:

When I switced to the classic template I did not have the issue and so knew this had to do with some overridden template file - If you are using overrides religiously you can try the same thing
Yes, my site using overrides.
When you say to try the same thing, do you mean swguy's remedy? He mentioned "If you just move this line down into the foreach loop" What does that mean in layman terms?

kobra:

And/or list the Module additions you have
These are the modules installed. Some remain unused.

Order Total Modules:
Discount Coupon*
Group Discount (unused)
Gift Certificates (unused)
Low Order Fee (unused)
Shipping
Sub-Total
Tax (Installed but I don't include tax at all)
Total

*This module is installed
true

Sort Order
280

Include Shipping
false

Include Tax
false

Re-calculate Tax
Standard

Tax Class
--none--

Shipping Modules
Flat Rate
Zone Rates

Payment Modules
PayPal IPN - Website Payments Standard

When you say to try the same thing, do you mean swguy's remedy?
No, I meant switching to the classic template to see if this corrects it as it did for me - indicating that some override file was the culprit

swguy:

I could have sworn I posted this fix, but of course I can't find it now.

If you just move this line down into the foreach loop, you'll be fine.

Thanks, this fixed it for me.

reden:

Thanks, this fixed it for me.

Would someone please kindly post the actual fix and how it should be implemented?

Thanks!

Change this

            $ratioTax = $adjustedTax/$order->info['tax'];

to this

            if (isset($order->info['tax']) && ($order->info['tax'] != 0)) { 
                 $ratioTax = $adjustedTax/$order->info['tax'];
             } else { 
                $ratioTax = 0; 
             }

Thanks swguy. New Zen Cart user here. I was having the same problem and I tried your recommendation of simply replacing...

             $ratioTax = $adjustedTax/$order->info['tax'];

with...

        if (isset($order->info['tax']) && ($order->info['tax'] != 0)) { 
             $ratioTax = $adjustedTax/$order->info['tax'];
         } else { 
            $ratioTax = 0; 
         }

on ot_coupon.php

But that causes a whole new issue and gives me the following error...

Parse error: syntax error, unexpected T_CLASS in /home2/teddecom/public_html/store/includes/modules/order_total/ot_coupon.php on line 1

What have I missed?

Ah Ha! Presto. Got it to work just as you said. Struggled for hours then right after I posted this I realized there was something screwy happening with my text editor when saving my new ot_coupon.php. Fixed that issue and now your fix works like a champ!

Glad to hear it worked out for you.

Thanks guys, I had the same problem and the above code worked perfectly.

swguy:

Change this

        $ratioTax = $adjustedTax/$order->info['tax'];

> 
> 
> ```
            if (isset($order->info['tax']) && ($order->info['tax'] != 0)) { 
                 $ratioTax = $adjustedTax/$order->info['tax'];
             } else { 
                $ratioTax = 0; 
             }

Can I create an override file under modules/order_total/MYTEMPLATE/ot_coupon.php ?

shocker:

Can I create an override file under modules/order_total/MYTEMPLATE/ot_coupon.php ?
Sorry, no. You'll need to edit the original file directly.

Thanks for the update!!! I wish I had seen this sooner, we launched a big coupon newsletter, and I forgot to test it myself. DANG!

Anyway, glad it was an easy fix.

I have tried all the methods above ,but failed .the warning still show up .Who has else better solution ,Thanks