[DONE v1.3.9a] Shipping estimator not making cheapest option BOLD when logged in

Hi!

I'm having issues on a site I'm working on.

I have USPS, FedEx, and ZipShip shipping modules turned on. I have shipping estimator set to show ON the shopping cart page.

I'm having issues where the shipping estimator doesn't bold the absolute cheapest option. After doing some testing, it seems that if I am logged in, then the SHIPPING ESTIMATOR always bolds the cheapest USPS option, even though there are other shipping options that are cheaper. If NOT logged into my account, it works correctly and WILL BOLD the cheapest option of them all.

When logged in, and I press "checkout", it DOES pre-select the cheapest option as it should. The error only occurs when logged in, when viewing the shipping estimator.

Update:

The issue seems to happen when you have two shipping addresses. If you choose Address A as the shipping estimator address, it will highlight the cheapest option. If you shift to address B, it won't highlight the cheapest shipping for address B, it will keep the option that was cheapest for Address A highlighted. If I delete shipping address A, I still have to log out and back in for the cheapest rate for address B to be highlighted.

SO, perhaps its an updating issue, zen cart isn't recalculating the "Cheapest" every time? I guess this won't happen for everyone, but perhaps a guru can see what the error is.

I have found this true between National and International rates so far ...

I will have to play with this further ... this has been moved to Bug Reports, thanks! :smile:

I have a similar problem and wondering if the bug has been fixed. I have enabled flat rate, now when we estimate, flat rate is always bolded even if it is not the cheapest way to ship. But I only have 1 shipping address not like the above post.

Let me know if anyone has solved this.

What are all of the Shipping Module(s) that you are using?

Store Pickup
Flat Rate

United States Postal Service (1 x 7.18lbs) United States Postal Service

Express Mail (1 - 2 days)
Priority Mail (2 - 3 days)

United Parcel Service (1 x 7.18lbs) United Parcel Service
UPS
Next Day Air Early AM
Next Day Air Saver
2nd Day Air
3 Day Select
Ground

FedEx Ground
FedEx Home Delivery®
FedEx Express
FedEx First Overnight®
FedEx Priority Overnight®
FedEx Standard Overnight®
FedEx 2Day®
FedEx Express Saver®

Freeshipper

here is a screenshot http://www.mendweb.com/zcerror1.gif

using 1.3.7

I will have to try to find an old v1.3.7 as I cannot recall off hand what issues there are with it on shipping ...

NOTE: You should still check that you're using the updated May 2008 USPS shipping module, referenced on the Security Patches:
http://www.zen-cart.com/forum/showthread.php?t=131115

Ok - let me know what you find. Do you think upgrading to 1.3.8a will solve the problem?

Good chance it will as I cannot reproduce this problem in v1.3.8 with all the Known Bug Fixes:
http://www.zen-cart.com/forum/showthread.php?t=82619

and Security Patches and Upgrades:
http://www.zen-cart.com/forum/showthread.php?t=131115

Just tested this in another store running 1.3.8a and the bolding issue still exists if you are not logged in.

Linda can you test while not being logged in and tell me what you get?

Anyone else have this problem and solve it?

Here is the screen shot of the 1.3.8a store with estimator bolding problem while not logged in.

Here is a screen shot http://www.mendweb.com/zcerror2.gif

Thanks

Try this, edit the file:
/includes/modules/shipping_estimator.php

Comment out the three lines:

      $selected_quote = $shipping_modules->quote($method, $module);

Find the line below them:

  $shipping=$selected_shipping;

and change to read:

      $selected_quote = $shipping_modules->quote($method, $module);
  $shipping=$selected_shipping;

Does this change your results in the shipping_estimator?

So far it looks like this may be the solution. Thank you very much. I ran through the code and I just dont understand to logic on that error? What was happening? I can see what you did but dont understand why. I code quite a bit so I would love to understand this.

Thanks Linda.

From what I was seeing it was repeating the code in the wrong places and catching one value and not really looking for another ...

By placing the check for cheapest after, it was able to set and reset the right "cheapest" code ...

Thanks for confirming that worked for you ... :smile:

I didn't follow the "comment out 3 lines" portion of your change description. Here's the section of shipping_estimator.php I believe you're referring to:

    if (zen_not_null($module)){
      $selected_quote = $shipping_modules->quote($method, $module);
      if($selected_quote[0]['error'] || !zen_not_null($selected_quote[0]['methods'][0]['cost'])){
        $selected_shipping = $shipping_modules->cheapest();
        $order->info['shipping_method'] = $selected_shipping['title'];
        $order->info['shipping_cost'] = $selected_shipping['cost'];
        $order->info['total']+= $selected_shipping['cost'];
      }else{
        $order->info['shipping_method'] = $selected_quote[0]['module'].' ('.$selected_quote[0]['methods'][0]['title'].')';
        $order->info['shipping_cost'] = $selected_quote[0]['methods'][0]['cost'];
        $order->info['total']+= $selected_quote[0]['methods'][0]['cost'];
        $selected_shipping['title'] = $order->info['shipping_method'];
        $selected_shipping['cost'] = $order->info['shipping_cost'];
        $selected_shipping['id'] = $selected_quote[0]['id'].'_'.$selected_quote[0]['methods'][0]['id'];
      }
    }else{
      $selected_shipping = $shipping_modules->cheapest();
      $order->info['shipping_method'] = $selected_shipping['title'];
      $order->info['shipping_cost'] = $selected_shipping['cost'];
      $order->info['total']+= $selected_shipping['cost'];
    }

Which of these lines need be commented out?

Find this code:

  // begin shipping cost
  if(!$free_shipping && $_SESSION['cart']->get_content_type() !== 'virtual'){
    if (zen_not_null($_POST['scid'])){
      list($module, $method) = explode('_', $_POST['scid']);
      $_SESSION['cart_sid'] = $_POST['scid'];
    }elseif ($_SESSION['cart_sid']){
      list($module, $method) = explode('_', $_SESSION['cart_sid']);
    }else{
      $module="";
      $method="";
    }
    if (zen_not_null($module)){
//      $selected_quote = $shipping_modules->quote($method, $module);
      if($selected_quote[0]['error'] || !zen_not_null($selected_quote[0]['methods'][0]['cost'])){
        $selected_shipping = $shipping_modules->cheapest();
        $order->info['shipping_method'] = $selected_shipping['title'];
        $order->info['shipping_cost'] = $selected_shipping['cost'];
        $order->info['total']+= $selected_shipping['cost'];
      }else{
//        $order->info['shipping_method'] = $selected_quote[0]['module'].' ('.$selected_quote[0]['methods'][0]['title'].')';
        $order->info['shipping_cost'] = $selected_quote[0]['methods'][0]['cost'];
        $order->info['total']+= $selected_quote[0]['methods'][0]['cost'];
        $selected_shipping['title'] = $order->info['shipping_method'];
        $selected_shipping['cost'] = $order->info['shipping_cost'];
        $selected_shipping['id'] = $selected_quote[0]['id'].'_'.$selected_quote[0]['methods'][0]['id'];
      }
    }else{
//      $selected_shipping = $shipping_modules->cheapest();
      $order->info['shipping_method'] = $selected_shipping['title'];
      $order->info['shipping_cost'] = $selected_shipping['cost'];
      $order->info['total']+= $selected_shipping['cost'];
    }
  }
  // virtual products need a free shipping
  if($_SESSION['cart']->get_content_type() == 'virtual') {
    $order->info['shipping_method'] = CART_SHIPPING_METHOD_FREE_TEXT . ' ' . CART_SHIPPING_METHOD_ALL_DOWNLOADS;
    $order->info['shipping_cost'] = 0;
  }
  if($free_shipping) {
    $order->info['shipping_method'] = MODULE_ORDER_TOTAL_SHIPPING_TITLE;
    $order->info['shipping_cost'] = 0;
  }

      $selected_quote = $shipping_modules->quote($method, $module);
  $shipping=$selected_shipping;
  if (SHOW_SHIPPING_ESTIMATOR_BUTTON == '1') {
    $show_in = FILENAME_POPUP_SHIPPING_ESTIMATOR;
  } else {
    $show_in = FILENAME_SHOPPING_CART;
  }

See if this helps ... :smile:

Thanks a bunch, it's all better now.

Thanks for the update that this worked for you ... :smile:

Hi,
I am looking at another issue regarding the shipping estimator and notice that on a fresh install of 1.38a (with no other patches applied) the cheapest shipping method is marked in bold correctly whereas applying this patch causes no shipping method to be marked in bold at all.
On reading this thread (a bit) more carefully I am not sure if this patch IS for 1.38a?

regards

Steve

Sorry to bump this thread after so long, but I just want to make something clear.
In this post : http://www.zen-cart.com/forum/showpost.php?p=205866&postcount=5

Linda wrote that storepickup won't be picked up in bold, even if it's the cheapest option.

Is this indeed true ?
if yes, how can I have 2 flat rate shipping modules ? one for my domestic zone and one for all the internationals ?

Clone the Flat Rate flat shipping module ...

A search on:
clone flat
clone item

should give you examples of how to do this ...