[Done v1.3.9] PayPal IPN not triggering some usual checkout notifiers (v1.3.8)

I've been having a problem with a mod I created which uses the Notifier NOTIFY_CHECKOUT_PROCESS_AFTER_SEND_ORDER_EMAIL. However if anyone uses PayPal IPN it never gets called. I checked through the code and it seems that the IPN before_process function redirects to the checkout success which means a number of notifiers do not get called- Including the one I hook to.

I've been having a problem with a mod I created
How is it a bug to be reported here when it is something that you wrote?

The bug comes from the Notifier I hook to not being called- Even though the flow of checkout_process would indicate that the notifier would be called. It's not a bug with my code because my code does not get called.

It works as intended - just not as you speculated that it would called from your code...

kobra:

It works as intended - just not as you speculated that it would called from your code...

That's not the way the notifier system should work. The notifiers are there to allow ZenCart extensions to be added without impacting the core code. However if these get bypassed by other "official mods" it makes the whole observer/notifier system redundant even obsolete. The only way around this would be to publish what Notifiers get ignored with the added modifications.

I'm not surprised that it misses some of the usual notifiers you're used to ... because it has to do a very different checkout process.

You're lucky it does any notifiers at all ... it didn't prior to 1.3.8.

If it continues to be supported in 1.4, we'll review the checkout notfiers to see if there's a way to hook similarly if not identically to the usual places.

Thanks DB- In the meantime I think I'll hook to the ORDER_EMAIL notifier- as the PayPal mod does at least send an email confirming the order.

Further to this I have hooked to notifiers called in both order->create and order->send_order_email. These are called fine during the normal checkout_process but are not called at all by the ipn_main_handler. It looks like ipn_main_handler does not attach any user created hooks.