Printable View
yeah im busy recoding/upgrading edit_orders to 3.5
Are you having the following issue:
after you edit the order, the tax values get changed / overwritten ?
when you VIEW the order, it is correct, once u edit the order (edit orders), the tax values change and become incorrect. (when you VIEW the order after editing it)
Yes, a priori the order is ok, but after update taxes are duplicated.
perfect, as i said earlier, easy fix.
using table orders_products instead of table orders_total will NOT fix the problem :P
BTW: every-time you use edit_orders v3.0 it corrupts your orders total table by overwriting the values.
Wont be an issue in 3.5
Ok, this is called "support" forum. Smirking is not as good as real advice...
I do so hope you have some sort of time estimate for 3.5!
Like all FREE Zen modules, these are labors of love and done when the contributor's free time permits.. So the best time estimate you can get is this: It's in development right now, and you will see an announcement about when it's ready posted here soon..Quote:
Originally Posted by kalastaja
But of course.... But where do you fit in Diva, somehow xcooling would have been the proper commentator!?
The only reason for asking is to establish if oneself has to do it, or whether I'm prepared to wait!
technically 3.0 is her module.
I run very large zen cart stores, and thus have rewritten most of the modules for my own use.
Edit order was one of them. I offered to merge my edit_orders with diva's edit orders and add some features :P
Right now, I am testing 3.5 in a production environment. Once i have all the bugs nailed, ill release it to diva to test.
When she is happy, It will then be ready for the public.
What ive completed to far (a few things not mentioned)
Code:// Add: Verify edit orders module options to prevent errors and issues.
// Add: GOB Package Trackers (unlimited carriers), which is much better than TY Trackers. *You can use None, TY or GOB trackers with this module*
// Add: multiple update buttons, due to requests from clients
// Add: product language support
// Add: product weights
// Add: order total weights
// Add: initial calculate shipping costs
// Add: edit and view product links
// Edit: minor template/style changes
// Edit: tweak input sizes, tweak icon/image placements
// Add: alternating row colors and mouse over highlighting of active row
// Edit: indent and neaten source code
// Edit: Rename SO_SWITCH -> EDIT_ORDERS_SO_SWITCH (prevent duplicate defines, default: false)
// Add: EDIT_ORDERS_MULTI_SUBMIT_SWITCH (allow multiple submit buttons, default: false)
// Add: EDIT_ORDERS_LAYOUT (specify the alignment of the edit order page, default: left)
// Remove: Double Nested Tables
// Add: Prevent double form submissions. *most users are impatient and will submit more than once*
// Edit: Merge 'update_order' code blocks (None,TY, GOB). *Smaller, more consistent code (~1100 redundant lines)*
// Edit: cast all id's to integer values (int), *$oID = zen_db_scrub_in($_GET['oID']); -> $oID = (int)($_GET['oID']);*
// Edit: cast all amount/tax values to floats
// Edit: zen_db_input(stripslashes($string)) -> zen_db_scrub_in($string) *safer, more accurate*
// Fix: Sanitize Product: id, name, model, qty, tax, final_price
// Add: Only update customer info items that have been changed. *safer, less database writes*
// Add: Only update product info items that have been changed.
// Add: Only update totals that have been changed.
// Fix: Prevent Nuking address information with NULLS.
// Fix: Display a message if no updates are performed.
// Fix: Correctly quote all SQL statements
// Add: Prevent working with nulls. *better be safe than sorry*
// Fix: Update Notifications
Ok! Sounds like it's worth waiting for...
My comment was a general comment with regards to modules/time lines and such which I would have posted regardless of my involvement with the upcoming release (which xcooling has explained).. I think it's important to make sure it's clear that those who develop modules have to be given a little latitude since these are volunteer efforts.. xcooling is a busy person and his OUTSTANDING effort on this next release is being done on his time. So I am willing to wait patiently until he passes it off to me for testing as I realize he has paying customers to attend to first..:smile:Quote:
Originally Posted by kalastaja
and while on this same topic I am going to respectfully ask the community to be patient while development and testing is taking place..
To be clear: I will not be not be sending out any "pre-launch" versions of Edit Orders to anyone once xcooling has passed his code over to me for testing.. In my experience this only leads to confusion post release.. Most importantly I no longer send out "pre-launch" versions because most people seem only to want an "advanced" copy of the module and will not properly test and provide feedback (which is the only reason to do a "pre-release" version).
We have beta testers already who have proven themselves WILLING to properly test for us before releasing and so we will not need anymore volunteers in this regard. Also once testing is complete and the new version is submitted to the downloads section, I will be making sure that the admins are given the proper amount of time to approve modules before deciding if it is warranted to temporarily host the new fileset (making the new version available to the public during the admin review and approval process)..
Hello,Quote:
Originally Posted by xcooling
I have the same or similar problem, even when i only want to edit an address line to add the number of the street, as soon as i click update it sort of recalculates the amount (despite the fact that products weren't even touched) and it will then have the wrong order total in the order.
Totally undesirable off course, do you have a pointer where i need to fix this?
I don't want any of the amounts touched when i don't update the products in the order preferably, if that is undoable based on the mechanisms of the original code i would like edit orders to at least take the correct amount of the order so the price doesn't change when i edit something in the address line.
Any (technical) help would be highly appreciated. (would prefer not to wait for a next version to fix this)
Thanks!
Jeroen
its FIXED 3.5, my advice is to wait.
3.5 is almost done. Busy cleaning code, fixing bugs and adding enhancements my clients require.
Basically the the entire code block for updates will need to be rewritten +/- 1000 lines. Best would be to wait.
Below is an example of how you do it.
PHP Code:if(isset($_POST['update_delivery_country'])){
if(($temp =zen_db_scrub_in($_POST['update_delivery_country'])) != zen_db_scrub_in($order->delivery['country'])){
$Query .= "delivery_country = '" . $temp . "', ";
}
}
I'm very excited about v3.5 and looking forward to seeing it in action! Tons of thanks to Diva and xcooling for the effort and time spent developing and supporting such a wonderful tool that helps us run our businesses more smoothly and efficiently :clap:
All thanks REALLY goes to xcooling for his hard work on this upcoming release.. I will only be doing UAT of the new version of the module and updating the readme files..:smile:
Quote:
Originally Posted by ScriptJunkie
I'll take your advice, appreciate the response, thanksQuote:
Originally Posted by xcooling
The issues with how Edit Orders currently handles taxes goes back a number of years (and module versions). It is my understanding that these issues were never fully addressed as the corrections required were a tad complex.. (though xcooling's work looks like it will address many of these issues..)
That said, I wanted to post all of the posts from the old support threads which center around theses known issues so it's FULLY documented (some of these issues have been recently reported here in this support thread as well)
Edit Orders issues regarding support for taxes:
In particular there is no support for split taxes and the shipping taxes do not calculate correctly.
The following threads speak to some of the current issues:
- http://www.zen-cart.com/forum/showpo...&postcount=148
- Split taxes: http://www.zen-cart.com/forum/showpo...&postcount=149
- Split taxes: http://www.zen-cart.com/forum/showpo...&postcount=150
- Split taxes: http://www.zen-cart.com/forum/showpo...&postcount=151
- http://www.zen-cart.com/forum/showpo...&postcount=274
- http://www.zen-cart.com/forum/showpo...&postcount=246
- http://www.zen-cart.com/forum/showpo...&postcount=247
- http://www.zen-cart.com/forum/showpo...&postcount=223
- http://www.zen-cart.com/forum/showpo...&postcount=224
- http://www.zen-cart.com/forum/showpo...&postcount=168
The issues with how Edit Orders currently handles products attributes also goes back a number of years (and module versions). These outstanding issues were never fully addressed and I think it was probably a matter of time constraints on the part of previous contributors..
Edit Orders and product attributes
- Issue 1 - No support for "optional" attributes
Currently when adding products to an order, the first option value is selected by default with no options provided to not select an attribute at all. (Not all options are required in the storefront, and therefore this same optional attribute ability needs to be provided when you edit an order)- Issue 2 - Edit Orders lacks the ability to delete attributes from products
When editing an order, a store admin should be able to delete an attribute from a product. Current functionality includes an “Advanced Attributes Editor” which ONLY allows you to remove attribute pricing data, but the NOT attribute itself from the product.
Details on the attributes issues posted here:
Yeah, but that doesn't discount the all the work you've done before, nor the ongoing support for the Mod :) Plus, you and I both know that writing a good ReadMe is actually more like writing a process document - it's very detailed, tedious, and time consuming work to make sure you've covered all your bases, gotten your steps in the correct order, didn't leave out any steps, is understandable to the masses, etc. And girl, your ReadMe's are fabulous! :clap:Quote:
Originally Posted by DivaVocals
Awwww thanks..:blush: I'm glad the effort is appreciated.. There are some contributors here who really write fabulous readme documents, and I took cues (and even document formats:laugh:) from them when crafting the readme files for this and Super Orders.. (Kuroi, Conor, and QHome to name a few) Trying to make things as "bullet proof" as possible for newbies in particular..Quote:
Originally Posted by ScriptJunkie
Off topic http://www.buddy-icons.info/img/smile/1704.gif:
This weekend, I'm gonna submit a minor update to IH2 (by the fabulous nagelkruid:smile:), and I plan to include a revamped IH2 readme document in the new update..
Woot! :jump:
A couple of weeks ago, I came here because I had some problems with the Edit Orders v3 add-on, mostly due to the fact I was using 2 languages and was getting blank pages due related to that.
Thanks to the updated version 3.3, this problem was solved, but I still had a couple of small problems - including one with the totals after an order had been edited. To be honest, I linked those issues to the fact I kept updating my files without making a clear re-installation of the latest ZC version.
So finally, I decided to pick up the latest 1.3.9h ZC version and add one by one mods I wanted, including of course Edit Orders and Super Orders. While the result is much better than what I had so far (this is still a test environment, of course), I still have a problem with Edit Orders 3.3 :
When I change the price of an article, the grand total of the order is set to 0.00.
For example, starting from
I changed the price from 10.00 to 9.95, and got the following :Code:Produit Modle Taxe Prix (sans taxe) Prix Total (sans taxe) Total
25 x test article TEST-10 0.00% CHF 10.00 CHF 10.00 CHF 250.00 CHF 250.00
Total: CHF 250.00
Note the 0.00 for the grand total. I do not use any tax in my ZC shop, so this should not be related to that issue.Code:Produit Modle Taxe Prix (sans taxe) Prix Total (sans taxe) Total
25 x test article TEST-10 0.00% CHF 9.95 CHF 9.95 CHF 248.75 CHF 248.75
Total: CHF 0.00
Should this problem be corrected in 3.5 ?
Can't say that this will be resolved for YOU in the next version as it isn't a problem for the current version...Quote:
Originally Posted by sanji
Screen prints from v3.03Quote:
Originally Posted by DivaVocalsCan't say that this will be resolved for YOU in the next version as it isn't a problem for the current version...Quote:
Originally Posted by sanji
Fair enough. Do you have it working if the tax is set to 0% ?
Since this is a fresh install, I was wondering if it could come from a setting of the shop rather than from the code itself...
Thanks,
sanji
Yep.. I only have one product setup as taxable in this test store..Quote:
Originally Posted by sanji
Possible, but off the top of my head I couldn't say which setting this might be..Quote:
Originally Posted by sanji
DivaVocals,
Could you please direct me to the part of the code where the total is calculated and put into the database? I will try to understand where the issue could come from...
And another question : in the orders_total table, once I change a price and hence the total, the value of "sort_order" changes to 999 - the usual value - to 1. Is that normal?
Thanks again for your continuous support,
sanji
Quote:
Originally Posted by soxophoneplayer
I am having same exact issue, I lose the ADMIN login as soon as I install the admin/includes/functions/extra_functions/common_orders_functions file
and what error are you getting??Quote:
Originally Posted by letsmod
Blank page = Error
Post the information from the log file that would have been generated as a result of the error..
Great mod, but how do I get this to work with fec mod... the orders.php file was winmerged and got a 404 when trying to edit...
All I can suggest is using Winmerge or Beyond Compare to merge the orders.php file from FEC with the one that comes with Edit Orders.Quote:
Originally Posted by rxalex
UGH. I have version PHP Version 5.1.6
Why will it only work with 5.2.X?
Are there some minor code changes I could make to make this work?
Screw it. I went ahead and updated PHP. Curious though the files overwrite the core files as there are no instructions to manually edit the code. So I'm wondering are the mod files 1.3.9h? I don't want to overwrite my vanilla 1.3.9h core files with mod files with 1.3.9g or less code.
TIA!
And there won't be as we don't know what other mods you may have made to the same core files for other modules.. So you will need to compare them side by side and merge the required (and CLEARLY MARKED) modifications.Quote:
Originally Posted by willie bee
From the readme (please not what's highlighted in red:
Won't hurt ANYTHING to download the module, read through the readme and see if this module works for your needs.. The readme covers the most frequently asked questions..Quote:
Rename the YOUR_ADMIN_FOLDER folders in the 2_Required_Core_Edits folder to match the name of your store's admin folder
As with ANY module, any files which override existing cart files should be merged using a tool like Winmerge or Beyond Compare before you install the module.
Because these are core files, they have been separated in our install fileset so they are easily identified. If you have installed any mods which make changes to the files in this folder, you will need to use a tool like Winmerge or Beyond Compare to incorporate those changes into these files.
I got it working. I just overwrote the core files because it is a vanilla install.Quote:
Originally Posted by DivaVocals
Cool..:cool:Quote:
Originally Posted by willie bee
Just installed Edit Order V3.03 to a vanilla base zen cart (we've been using the template system for over-rides, but not for anything other than look and feel) and got a couple PHP Warnings in the cache/debug log:
[23-Mar-2011 21:59:49] PHP Warning: asort() expects parameter 1 to be array, null given in /home/xstimpr/public_html/tuxedoparkbrewers-com/Admin/edit_orders.php on line 2350
[23-Mar-2011 21:59:49] PHP Warning: Invalid argument supplied for foreach() in /home/xstimpr/public_html/tuxedoparkbrewers-com/Admin/edit_orders.php on line 2351
Edit_Orders.php lines are as follows:
asort($ProductList[$add_product_categories_id]);
foreach($ProductList[$add_product_categories_id] as $ProductID => $ProductName)
If anyone could make any sense of them as far as how buggy these couple lines of code really are, it would be appreciated. We really just wanted a way to quickly edit a cash order before it was totalled and filled, other than simply creating a second to append to the first. Our store is new and being designed and run by noobs, so GREAT APPRECIATION comes from us to you and hopefully restraint and patience comes back our way : )
Admin has been renamed, I just supplied the default on the forum to cover my tracks.
Thanks in advance...
JJ
I hate replying to my own reply but I couldn't find an "edit" button the reply. Still new! And I figured if you looked and bothered to reply to the first question, you might squeeze in some additional quick advice:
Can you delete items from an order simply by deleting the line item from the "edit order" page?
Furthermore, if this is the case, will the inventory be re-posted to the category for the store, or is that something Admin has to do independently of editing the order quantities of the items.
TIA.
JJ
I received this same "blank page" error. My error log contained the following:Quote:
Originally Posted by DivaVocals
"[30-Mar-2011 11:12:35] PHP Fatal error: Cannot redeclare zen_get_country_id() (previously declared in /MY_DOMAIN/MY_CATALOG/MY_ADMIN/includes/functions/extra_functions/edit_orders_functions.php:33) in /MY_DOMAIN/MY_CATALOG/MY_ADMIN/includes/functions/extra_functions/DELETEedit_orders.php on line 45"
I had just renamed the edit_orders.php file instead of deleting it. Once I deleted it, all was well and working fine. :)
UPDATE: Discovered deletion of items can occur by making quantity zero. Still assuming that inventory is replenished (haven't bothered to test for certain at this point).
JJ
Hello.
I have not been able to find answers I am hoping for help. I have recently updated to Zen Cart 1.3.9.h and I want to update to Super Orders 3. It says to upgrade my Edit Orders first.
I have uploaded and tested several times including the patch but always get blank pages. I was not even able to go back to admin and install the sql patches. I had to go into phpmyadmin to install them but it is still not working.
I have checked that all the files go into the correct folder and deleted the edit_order.php file that the installation instructions informs.
I am running linux and php v. 5.2.17
If anyone could assist with this that would be great as I would love to update this and Super Orders.
Thanks Again.
GS
Quote:
Originally Posted by guitarstore
Blank pages often mean you have a syntax error somewhere. Here's what you need to look at:
- Your cache folder located at store root/cache. See what the error logs are saying. They will point you in the right direction in terms of what's causing the blank page error.
- Your merged files (if any) - check to see if you made any syntax errors to the files you merged when you installed this mod.
For example, I use a custom logo in my packing slips and invoices, so I had to merge my customizations from admin/invoice with admin/super_invoice and admin/packingslip with admin/super_packingslip, so if I had a blank page, I would check the syntax in those files after I check the error logs in my cache folder.
Hi Scriptjunkie.
Thanks for your quick reply and for you help.
I checked the log and this is what it said:
PHP Fatal error: Cannot redeclare zen_get_country_id() (previously declared in /public_html/store/MY_ADMIN/includes/functions/extra_functions/edit_orders.php:34) in /public_html/store/MY_ADMIN/includes/functions/extra_functions/edit_orders_functions.php on line 44
Would be great if you can assist with this.
Best Regards,
GS
Ok,
I actually fixed it. I had renemed my admin/includes/functions/extrafunctions/edit_order.php
to copy_edit _order.php
I though I would just rename it in case I needed it for backup but it still had an effect on the site. I now deleted it and seems to be working fine.
Thanks again,
GS
Glad you figured it out! FYI, one thing I've learned here on the forum (I think even in this very thread), is that ZC gets a bit testy when there are files with duplicate or near duplicate names, such as filename.php and filename_backup.php or filename_copy.php, etc.Quote:
Originally Posted by guitarstore
If you need to keep a copy for back up, simply open it, copy it, and paste it into a notepad file. Then save it on your PC with it's regular file name (instead of on the server).
What follows is an off topic discussion of file back up and storage, for which I know I'll be forgiven because it is so important:
I keep a clean copy of all of ZCs files from the zip file pack that I use to install the cart, as well as a clean copy of all files from all mods I have installed. This way, if I need them again, it's a simple upload.
I also keep copies of any file I've modified, using the same type of file renaming listed above - but again it's on my PC vs. on the server. This way, I have a clean copy of everything - original AND modified files for all ZC and Mod files.
Lastly, anything I have saved on my PC's hard drive I also have backed up on 2 separate pieces of removable storage (an external hard drive and a plug in pocket drive) - because I've learned the hard way that just one form of back up is NOT enough. When my OS blew up and wrecked my hard drive - I was thanking heaven for my external hard drive...until I tried to plug it in to a new computer only to find out that it too had failed.
Ever since then, I've kept two external copies in addition to my PC copy (this is in addition to the working original files on the server).
So you're definitely doing the right thing trying to save a copy for back up purposes, you just saved it in the wrong place (on your server instead of your own PC).
You might want to periodically go into your Cpanel and download a copy of all your databases (zen cart, word press, whatever you have, etc) PLUS have cpanel create a back up of your entire site. Most hosting companies will allow you to store one full back up of your site on your server.
It is crucially important to do this before installing or upgrading any mods or making any significant customizations to your store or website.
That is good advice. I do keep some backups on the server but I will change this now. I also do regular backups of my entire site on 2 different devices and I especial backup before I do any major mod installs etc.
Thanks again!
GS
You know I love you so I'm TOTALLY gonna forgive you!!:laugh::laugh::laugh:
Plus this is important information.. I'm gonna add another tip.. a quick search of this thread would have revealed the source of the issue.. Now I tell people to search all the time.. WHY.. Because I'VE learned a TONE from searching this forum or support threads.. Often times my question is already addressed..
You have to be CREATIVE when searching too.. I've learned through trial and error not to search for WHOLE error messages.. a well placed partial search will usually yield good results.. In this case I would have searched for "Cannot redeclare zen". Searching this support thread for this would have turned up the reason.. AND because people like to leave backup copies of files on their live stores this error has come up FREQUENTLY in this support thread..
ScriptJunkie is right, if you want to keep a "protective" copy of your store's files when installing modules, back the WHOLE store up locally.. It may sound like a hassle, but having a backup of the store files and the database LOCALLY will allow you to rollback to a previous state in relatively short order, and it is a better practice to do this versus leaving backup files all over your live (or test) store..
When working on a client site, I have three versions of the store
- Vanilla Version (Zen Cart with basic setup/configuration in place NO MODULES)
- Working copy this is the last WORKING version of my store + any new modules I plan to install.. Initially this copy and the vanilla copy will look alike.
- Backup copy - This is the is the last WORKING version of my store.
The way this works is as follows:
When I am getting ready to install a new module, I make a backup of the last working version of my store and put it in my backup folder..
I make a copy of the backup and put it in the working folder..
I make all the changes/merges/updates to the working store files and upload the changes back to my site.. If all tests out well, I make a new back up and put it in my backup folder.
If it goes wrong and I back myself into a corner or decide I no longer want the module, I can easily roll back to my backup copy..
Quote:
Originally Posted by ScriptJunkie
Awwwww thank you :smile:Quote:
Originally Posted by DivaVocals
Great tips in your post! At first, it seems like a hassle, but very quickly one becomes used to backing up and working "redundantly"...and if you've ever had to say goodbye to your precious data and start from scratch....then you know that no amount of "redundancy" is too much! Better safe than sorry!
Can anyone tell me if this mod allows you to add additional shipping charges to an order and then charge the customers credit card without having to reauthorize the additional charges? I am using linkpoint/First Data for cc processing.
The situation we are in is selling perishable food items and if a customer orders an item and selects flat rate shipping during the summer then we would like to automatically upgrade them to 2nd day.
Sounds to me like you need to get rid of the option of flat rate, and only charge 2nd day in the summer months, if you are selling perishable food. If you leave the flat rate option and a customer picks flat rate you can't just charge there card upgrading there shipping without letting them know first. You need to make it clear on your site this is what you attend to do if they pick flat rat shipping.Quote:
Originally Posted by csimmons83
Maybe you need to just offer 2nd day that way there is no need to do what your asking. No offence but If you went back and upgrade my shipping without letting me know what going on I sure wouldn't buy from you again.
Short answer is no.. Any edits you make to an order which increase the amount of the order will not be re-authorized or re-charged.. You would need to process the difference manually..Quote:
Originally Posted by csimmons83
There are other options for tracking supplemental shipping. One option a client of mine uses requires the hideCategories module.. Basically she sets up hidden category an in this category is a supplemental shipping charge "product template". This "product template" is an inactive product and it's only purpose is to save her the trouble of having to create this product over and over again.. This "product template" is basically a shipping charge product which contains all the product details which will tell your customer that this is an additional shipping charge. She simply "clones" (using the copy product function) this product, updates the price and description as needed, sets the inventory quantity to "1" (so no one else can "accidentally" buy this one off product) and activates it.
Then she sends the customer a direct link to the product. The customer can then pay for the additional shipping charges without her having to process a manual credit card transaction or send out a separate PayPal invoice.
That is one method to accomplish this.. there are others.. (I gotta MILLION ideas:laugh:) The point is you may have to think out the box a little to achieve what you want.. Edit Orders will not reprocess a customer credit card..
**nods in agreement**:yes:Quote:
Originally Posted by countrycharm
Yep, IMHO, there are other options to get to the end result..
**nods in agreement**:yes:Quote:
Originally Posted by countrycharm
New install of 1.3.9h
first mod installed Stock by attributes, Edit orders, then ty tracker, usps click and ship, info at a glance, super orders, then uninstalled click and ship.
Having issues with Edit orders specifically, and stock totals.
Also, seems there are extra boxes created in the items total column. When I type something like an extra charge for handling, it totals it but creates a new set of empty boxes.
Under Admin > Configure > Edit orders there is only one option: to turn it on to work with super orders. Is that right?
Edit orders lets us add items, even those with attributes, :) even those with out of stock attributes :( (if you cancel order and choose to put the items back in stock, it puts the out of stock item in stock. Solution may be to delete items individually and choose no when asked if should put back? or is this a problem with my install? why did it not know i don't have "red" in stock?
just read this...thanks...any more insight helpful:
Details on the attributes issues posted here: links known issue
http://www.zen-cart.com/forum/showpo...&postcount=217
Another issue besides
extra empty boxes in the totals column...
also
gobbletegook emails sent when order status is updated.
updates from orders.php and super orders.php are fine.
this is what the email looks like that is generated when an update is done via the Edit orders page:
Code:?XG"KQp4cx,d@5 ĥ"$7(F8 a Dtl2C*"BtGP 2A RP12G$5^#RGP# C$""B ٙ l#z"Bфfѕh8Dpl>m3arZDp6) GTJ#Y"$ Fpb"%edp6Db%ah`;bwh8D"$KIB'c8 fu=Н tZrNIɹ r"Yj#l a## ]ό9 ="Lx 5;ӝSTi ; ۣ'U = ]n#yT$"'oq"=3 M U28hGeJ"=w0e #;}/9X 6Ff͢ |߱Q usF46Sts0E_7qGf0G8?cw>)ލz ffr4^A% q#fO&48)> [I? 7$3GKqFsi68>+ktTE0gsCkBfȹ 3d_nm k<>nMGCϙN=V2;Nό = X@ F"""h 4qElm;TS4ta}|Dq0fi qDDDG6*6?<ۧ{SFa~40P3u/ emֿ ?A|F g?4Ѓh+|DDDGitR_;_04t qѡ ȣ ilfk_+"vDtUq we^hUֿ;S>xF0gҼ&LѼMdR$eFI##yqh8ibv8{g? ;{Ip|9r0)FC,ב=D0Mt+G =ޏ4h>x1ANFF /?Fe>{)#9QF56+_S h=_tthϙ}vhd|0V`ra M ȃ݊Fg0M?Le>%_KQu~gF3z ͙ a &*3 +{_g##N:}OF|~cVz1`˖'q{l?IwL)v|FcB""""#o##㌿D{mf}EF:KF)G}lW# ]
zencart 1.3.9h new install
all mods installed cleanly and seem to be working enough for our store to be live without client side issues.
but our admin is another story:
i really need some help with this email issue. it only happens when notify customer is chosen when updating the notes section from edit_orders.php
I'm testing all our email functions and the emails are find from orders and super_orders.php.
I'm afraid that this issue seems unique to your store.. Can't replicate the issue, and therefore I can't begin to guess why it's happening to you..:dontgetitQuote:
Originally Posted by athena
It's possible that you have a corrupt download or that your FTP program may have corrupted the files.. Sorry this is the best guess I can provide.. Unless I can replicate this or others report the same issue (and this is the first time this issue has been reported) it's difficult to troubleshoot one off issues..
My suggestion is to download a fresh copy of Edit Orders and re-install again..
OK....I'm going back in.... :(
I found a file that i thought would fix the email issue:
I downloaded the edit_orders_v3.03 the end of march and in the admin/includes/functions/extra functions folder common_orders_functions.php is slightly different from the file in the newest version in the download section.
replacing this did not solve my issue however.
I wish I could provide more insight.. I cannot reproduce this issue nor has anyone else reported it.. Makes it nearly impossible to troubleshoot..Quote:
Originally Posted by athena
i will try and isolate it, and post if i find it, but may just re do the entire cart
I'm merging a fresh orders.php file from 1.3.9h with Edit orders core edits using Winmerge.
I've read here that there are three edits to orders.php but I'm seeing a difference in the files and fear merging the change when it is not notated to be Edit orders specific is part of my problem with my install.
Here is the original orders.php section about line 550..and i did a search here for class="dataTableHeadingContent with no results.
that same section in the edit orders version without any notation it is edit orders specific. Question: should this take the place of the above?:Code:<tr>
<td class="main">
<table border="1" cellspacing="0" cellpadding="5">
<tr>
<td class="smallText" align="center"><strong><?php echo TABLE_HEADING_DATE_ADDED; ?></strong></td>
<td class="smallText" align="center"><strong><?php echo TABLE_HEADING_CUSTOMER_NOTIFIED; ?></strong></td>
<td class="smallText" align="center"><strong><?php echo TABLE_HEADING_STATUS; ?></strong></td>
<td class="smallText" align="center"><strong><?php echo TABLE_HEADING_COMMENTS; ?></strong></td>
</tr>
Code:<tr>
<td class="main" valign="top">
<table border="1" cellspacing="0" cellpadding="5" width="60%">
<tr class="dataTableHeadingRow">
<td class="dataTableHeadingContent smallText" valign="top" width="21%"><strong><?php echo TABLE_HEADING_DATE_ADDED; ?></strong></td>
<td class="dataTableHeadingContent smallText" align="center" valign="top" width="18%"><strong><?php echo TABLE_HEADING_CUSTOMER_NOTIFIED;
?></strong></td>
<td class="dataTableHeadingContent smallText" valign="top" width="17%"><strong><?php echo TABLE_HEADING_STATUS; ?></strong></td>
<td class="dataTableHeadingContent smallText" valign="top" width="44%">
<strong><?php echo TABLE_HEADING_COMMENTS; ?></strong></td>
</tr>
i meant to say there are three button edits to orders.php, one icon edit to orders.php and one edit to include the css for Edit Orders. There are other differences with the files, but I ignored those. moving on....
i can see some potential with winmerge to save as the wrong file into your site folder.
one thing i notice is that the email being sent to the customer on an updated order from edit_orders.php on my test site...live site still sending scrambled code...
is that the email template is not the email_template_order_status.html but email_template_default.html
their is a problem with the Detail Invoice: link. It does not not hide the url in the email.
I've spent some time going over these files and can not see any difference in how the url is handled except the difference in the email template used by orders.php vs edit_orders.php
This tells me that there is some difference between your live server and your test server which is the cause of the scrambled customer e-mails.. Can't say what.. but it does sound like the issue is related to your server's configuration..Quote:
Originally Posted by athena
Hi ....yes, they are on two different servers but the live sight has a lot of mods on it.
I stripped my test sight bare... and reloaded everything.
Is the edit orders supposed to use the default email template? It does not look as nice...does not say Dear So and so....and that link showing the full url. Does this sound like I've edited something wrong in merging the files?
Edit Orders uses the same after order comments functions as found in the default orders.php. Like the default order comments, Edit Orders has NEVER had features which send out e-mails which look anything like the e-mails customer gets when the order is first placed..Quote:
Originally Posted by athena
When I first set up the new store a few weeks ago, I did merge my old email folder with the new. I went back and found that my style divs seemed to be causing an issue with edit_orders emails...so removed them and the weird code thing disappeared, but the full url to the invoice is still showing.
Reading the ZenCart manual on email formatting is priceless information...tend to forget I have this baby on the shelf.
So Edit Orders seems to be working as it should with Click and Ship ...Yeah!
Just a few tweaks to go...
You know, I wonder if someone who has orders.php inabled to work with edit orders, not hidden as is an option with super orders, could do a test to see if the email coming from edit_orders.php when you update from there is the email_template_default.
I've proven to myself that they are not sending the same email template.
I'm wondering if for some reason there is a by pass in place where if edit_orders.php doesn't like the email_template_order_status.html it goes to the default? Is that silly?
No not silly, and you are correct that edit orders does send the email_template_default.Quote:
Originally Posted by athena
To correct this open admin/edit_orders.php and find the following line of code (around line 187)
and replace it with this:Code:zen_mail($check_status->fields['customers_name'], $check_status->fields['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_NAME, STORE_OWNER_EMAIL_ADDRESS, $html_msg, NULL);
Code:zen_mail($check_status->fields['customers_name'], $check_status->fields['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_NAME, STORE_OWNER_EMAIL_ADDRESS, $html_msg, 'order_status');
I am working with 1.3.9h Edit Orders WITHOUT Super Orders. When the same product was updated from orders.php and edit_order.php, respectively, it generated two emails which are clearly different...not by much, but just different. The problem for me is I have no idea how to find the template used for each respective email.Quote:
You know, I wonder if someone who has orders.php inabled to work with edit orders, not hidden as is an option with super orders, could do a test to see if the email coming from edit_orders.php when you update from there is the email_template_default.
HTH.
JJ
**deleted**
Good good...thank you....i'm not alone.....we are on to something...
In the email folder:
your_shop > email
are all the templates that the site sends out.
In your Doc folder are instructions about how emails are used: 4.readme_html_email_templates.html
the order status email should have these fields:
but the default template only has these:Code:Order Status Updates from Admin
$EMAIL_CUSTOMERS_NAME (extracted from Orders table -- combines first/last names based on what's in DB)
$EMAIL_STORE_NAME
$EMAIL_TEXT_ORDER_NUMBER (Order Number from database)
$EMAIL_TEXT_INVOICE_URL (URL to access "My Account History")
$EMAIL_TEXT_DATE_ORDERED (Order Date)
$EMAIL_TEXT_STATUS_UPDATED ("Has been updated to:")
$EMAIL_TEXT_STATUS_LABEL ("New Status:")
$EMAIL_TEXT_NEW_STATUS (actual status description and comments)
$EMAIL_TEXT_STATUS_PLEASE_REPLY ("Please reply to this address if you have questions")
Code:$EMAIL_SUBJECT
$EMAIL_MESSAGE_HTML
oh, just saw this...thank you thank you...
there are two places where this code appears......change both or just the one?
oh i get it...one for text email the other for html
Quote:
Originally Posted by clydejones
Nice catch Clyde!!:clap:
Honestly as someone just pointed out, the difference is so subtle I never noticed this.. Wasn't something we were looking for or targeting specifically when we submitted this version..
As you know ALL of this module is based on the Scott's original contribution.. Other than cleaning a few things up and adding a few new behaviors (to support Super Orders the way this mod has always worked with the default orders.php), this is still all the original contributions code..
I'll test myself, and if my time permits, make this minor change and resubmit it..
Quote:
Originally Posted by clydejones
that must be the code that also has the url problem....
no text link..just the full url after Detail Invoice:
I'm sorry to say that did not fix it. It sent the right email template but the fields are not filled out. :(
It also did not send the copy of email to that set in the email admin
I just double checked and there is another line of code (around line 765) that should be changed also.Quote:
Originally Posted by DivaVocals
did your order update email look ok?
When we tested Edit Orders we tested it's functionality for those who would be using Super Orders and for those who would NOT be using Super Orders. We recognized that not all shopowners will be using Super Orders (nor are they required to). So we had to test for both types of shop configurations..
Meaning??
We did the kind of testing you are asking about.. We tested Edit Orders, and viewed the results of the order changes made in the Edit Orders mod (order comments, totals, and product updates) in the default orders.php view and in super_orders.php view.
The results of these tests??
the default orders.php results MATCH the super_orders.php results. (As Super Orders is based on the default orders.php, and as the readme indicated Super Orders ADDS to the default features -- versus modifying default features -- so the results came as no surprise)
We had NO ISSUES in any of our testing (and there were three of us testing) with the comments functions in Edit Orders working as expected..
I'll look at it this weekend.. But should this be the same change??Quote:
Originally Posted by clydejones
it is not working, guys...please let me know if your emails look the way they should. Mine order update email just had the fields...nothing filled out.
at least it is the right templateCode:Dear $EMAIL_CUSTOMERS_NAME,
$EMAIL_TEXT_ORDER_NUMBER
$EMAIL_TEXT_INVOICE_URL
$EMAIL_TEXT_DATE_ORDERED
$EMAIL_TEXT_STATUS_COMMENTS
$EMAIL_TEXT_STATUS_UPDATED
$EMAIL_TEXT_STATUS_LABEL
$EMAIL_TEXT_STATUS_PLEASE_REPLY
The edit Clyde suggested should not cause a blank e-mail.. And Since the unmodified version of Edit Orders also did not send out blank e-mails, this only leaves the likelyhood that you've made other edits to the files which are causing the issues you are reporting..
You need to double check your edits..
Quote:
Originally Posted by athena
Quote:
Originally Posted by athena
Did you check for a "plain text" email or are you only looking for an "html" email?Quote:
Originally Posted by athena
If you are looking for an "html" email then edit orders (as it is currently) does not have the necessary code in the sections that handle the email to provide that functionality.
likewise, the functionality to send a copy of the email is not included in the current version of edit orders.
The full URL after the detail invoice is the way the email section is coded. (<a href="' . zen_catalog_href_link(FILENAME_CATALOG_ACCOUNT_HISTORY_INFO, 'order_id=' . $oID, 'SSL') . '">' . zen_catalog_href_link(FILENAME_CATALOG_ACCOUNT_HISTORY_INFO, 'order_id=' . $oID, 'SSL') . "</a>)
ok..clyde..thanks ...ws typing as you posted....
but does that mean you need to set your preferences to text for default?
Are you talking about the customer or the admin side?Quote:
Originally Posted by athena
I'm looking at the emails that go the customer.....they have always been in html format for our store....I assume...yes i guess the customer can set a preference for text....have to check that...but what happens if they choose html...
I have mime set to true in admin > config > email
hmmmmm.....maybe I can disable the radio button for "notify customer" on the edit orders.php .....that seems messy
text emails look ok when i have the admin set for text only.....but why did it send the email_template_default with fields filled in. My only gripe with that at the time was the look of the email...it did get the message accross however.
tested by updating an order from a test customer with our email address on the edit_orders.php page.
I have no idea as to why the email_template_default was being used. Thats the way the author of the mod created it. As Diva said, except for the tweaks to make it work with super orders, ALL of the code is from the original edit orders mod.Quote:
Originally Posted by athena
Here's a modified version of edit_orders.php that should send the emails using the "email_template_order_status.html", It should also send a copy of the email to admin.
Attachment 9109
Just unzip the package and upload the edit_orders.php file to your admin folder.
thank you for helping with this.
i did replace my admin > edit orders.php with the file in the zip and got a blank page...
I think I'll just sit tight until a formal update to this mod comes along.
I appreciate everyone's input...and just knowing how edit orders is meant to work so I don't have unreasonable expectations.
Try this:Quote:
Originally Posted by athena
Attachment 9110
Well I suggest you don't do that.. I can only work on this in my SPARE time (this means no PAID client work and NO day job obligations)Quote:
Originally Posted by athena
It's MORE THAN likely that all I will do anyway is test, confirm, and submit Clyde's modifications posted above..
That said, one of the things I looked at doing one day when MY TIME permits, is to synchronize the Edit Orders comments code to look/act like the default orders.php. (for the record, this is ONE of the big changes we made that will be seen in the next Super Orders release -- AND BEFORE ANYONE ASKS -- when I get time to finalize it, I will release it -- I work on it a little bit at a time -- should be soon..)
It would be a CHALLENGE for me to do this since I am NOT really a coder, but I am not afraid!!!:laugh: This is also why it won't happen tomorrow, but it is on my "to-do" list (or should I say my "to-try list")..:laugh:
Hi clyde
ok..so this did send an email copy to spec address in admin > configuration > email options > send copy to admin order status etc.
but it was just this text:
The email that came to the customer had just "order update" in the subject line.Quote:
Subject line: [ORDERS STATUS] Order Update #6817
This email address was given to us by you or by one of our customers. If you
feel that you have received this email in error, please send an email to
[email protected]
This e-mail is sent in accordance with the US CAN-SPAM Law in effect
01/01/2004. Removal requests can be sent to this address and will be honored
and respected.
The email looked correct in every way and is email_template_order_status.html
but only the comments section was filled in.
then below that:
Quote:
EMAIL_TEXT_STATUS_UPDATED
EMAIL_TEXT_STATUS_LABEL
Please reply to this email if you have any questions.
I'll check some more: looks like the language file may need to be updated as well.Quote:
Originally Posted by athena
here is the code that is not cooperating:
there is a blank line below the comments
Code:$html_msg['EMAIL_TEXT_STATUS_UPDATED'] = str_replace('\n','', EMAIL_TEXT_STATUS_UPDATED);
$html_msg['EMAIL_TEXT_STATUS_LABEL'] = str_replace('\n','', sprintf(EMAIL_TEXT_STATUS_LABEL, $orders_status_array[$status] ));
$html_msg['EMAIL_TEXT_NEW_STATUS'] = $orders_status_array[$status];
complete email without header:
Dear Tommy Tester Tester,
Order Number: 6817
Detailed Invoice
Date Ordered: Friday 22 January, 2010
Comments:
testing if this will send copy email to me
EMAIL_TEXT_STATUS_UPDATED
EMAIL_TEXT_STATUS_LABEL
Please reply to this email if you have any questions.
My Shop
Hope this solves it.Quote:
Originally Posted by athena
unzip the package - rename the YOUR_ADMIN folder to match the name of your admin folder - upload/FTP to your server.
Attachment 9111
and let me add this.. I'm still not sure this is an actual "issue".. Though I've sorta followed all of this, I lost track of what is wrong or being fixed.. Sorry -- with all of the back to back to back posts, there's now THREE pages of stuff to sort through on this one "issue". So it's been difficult to get a real sense of "what's really WRONG here"..
On a high level, I do understand what Clyde did, but until I look at it in detail, I'm not completely sure that there is an actual issue here to be "fixed"..
All that to say I will still take a look at what has been done, test and update if necessary.. (Clyde I hope you don't mind that I may poke at ya with a few questions when I can take a look at this in depth:smile:)
Quote:
Originally Posted by DivaVocals
Clyde,
THis appears to be a success! Above link labeled--edit_orders3.zip--
admin > Edit_orders.php now appears to be not only cooperating with but also sending email_template_order_status.html when an order is updated and is successfully sending a copy of the email to the additional email address specified.
All the fields in email_template_order_status.html are filled out and the url link to the invoice has become a text link. All links work.
------------
Thank you so much for your no fuss response. I hope this helps others with this issue.
Thanks DivaVocals for encouraging me to hang in there and work with Clyde on this.
MY PROCESS:
Uploaded Clydes latest changes, namely "edit_orders3.zip" as directed to admin > edit_orders.php and admin > includes > languages > english > edit_orders.php
TEST:
*logon to admin
*send copy of admin orders status emails to - Status........."1"
*go to customers > orders > "Mr. test customer" > edit button to edit_orders.php > message posted with status "update"
RESULT:
*CUSTOMER EMAIL: edit_orders.php successfully sent customer the email_template_order_status.html rather than the email_template_default.html;
*all fields accounted for,
*text link in email works!
Admin copy - Text message complete:
Quote:
My Shop
------------------------------------------------------
Order Number: 6817
Detailed Invoice: Click here for your Detailed Invoice
Date Ordered: Friday 22 January, 2010
Comments:
testing the April 14 Clyde changes, including
languages/english/edit_orders.php should send email to admin copy and should
send the email_template_order_status.html with all fields accounted for.
Your order has been updated to the following status:
New status: Updated
Please reply to this email if you have any questions.
This email address was given to us by you or by one of our customers. If you
feel that you have received this email in error, please send an email to
[email protected]
This e-mail is sent in accordance with the US CAN-SPAM Law in effect
01/01/2004. Removal requests can be sent to this address and will be honored
and respected.
Not at all - All I did was replace the email code in edit_orders with the email code from orders.php.Quote:
Originally Posted by DivaVocals
Glad it worked out for you.Quote:
Originally Posted by athena
I'll take a look as my time permits this weekend.. Will probably bug you a tad.. :)Quote:
Originally Posted by clydejones