Printable View
That was the clue i was looking for.
Just before i saw your reply i tested edit order 1.5.3. on zencart 1.39e and there everything worked.
Since 1.39e many extra's are added to this init_sessions and the edit orders now falls in this if structure preventing it from working.
As far as i can see there is no problem adding this extra file to the line and after that everything works fine.
Maybe drByte can confirm this if he has some time left.
Thanks a lot for the hint
It is UNADVISABLE to make such an edit to init_sessions. You're basically just opening the door so anyone can edit your orders without logging in.
Something's wrong with your addon, and should be fixed there.
I understand your point in this DrByte that it is not good to open doors that should be shut but can you explain then what the difference is between opening the door for EDIT_ORDERS and opening it for FILENAME_PRODUCTS_PRICE_MANAGER for example.
It is the same door and somebody messing up your prices is also not real fun.
I could be wrong but to me an open door is open and it makes no difference who opened it.
ideas please...my edit orders has decided to not proceed to step 1. It was working in 1.3.9f and then in 1.3.9g...I have since done the "h" update.
I click the edit button to get the next page to edit the order, then I click the "add product" page and get sent to the main admin summary page not to the next part that allows me to add the product.
I replaced the edit orders files again and then I made sure the orders.php file in admin folder was still there and with the 2 required edits and still goes to summary admin page.
I had version 2 installed and thought that maybe digressing the version would help but nope it does not.
this is the link it should send me to the editing page to add an order on:
but it sends me to the main page instead...I checked the test store and it does the same thing too so it is something in the newest update that is not playing well with this mod.
can anyone tell me what I might need to do?
Edit the init_sessions file as written a few posts back
or
Replace the keyword action by something else.
(for instance 'actions=')
Ummm no.. I trust DrByte when he says not to make this particular change, and therefore I have to respectfully disagree with the suggestion that ANYONE make this change..Quote:
Originally Posted by asekeris
Quote:
Originally Posted by DrByte
Hey Angel.. I have not had a problem getting this to work with Zen v1.3.9f. (as I stated only mods I made were edits required for this to work with Super Orders)Quote:
Originally Posted by DarkAngel
I am currently working on upgrading my test store to 1.3.9h.. Because we're gonna bundle in the correctly edited files needed to use Edit Orders with Super Orders in the next SUper Orders release, I wanna test this add-on and see if I can replicate the issue.. (I have a few ideas on how to correct the issue (that don't create a security risk) if I can replicate it.. If you can hang tight (unless someone posts the right solution before I can post back) I'll let you know what I find out..
I gave two options.
The first one:
The first one was to do edit the init_sessions file what should according to DrByte give a security risk.
(I disagree on this point because the same action is done in that file for some core files and i refuse to see the difference between a core file and a third party mod and i am still hoping DrByte is willing to elaborate on that difference)
The second one:
Rewrite the mod on each point where the keyword 'action' is used and by doing that you go around the init_sessions problem because there the limitations are set much higher since the 1.39h uodate.
Personally i am against this because then we deviate from what is amost a standard in all mods.
I tested replacing action with aktie (dutch) and then everything works again.
Bypassing the security altogether is the wrong approach.
It would be wiser to actually recode things to ensure that the securityToken is set and checked, else you're leaving yourself open to XSS/CSRF vulnerabilities.
If thats all i will do that and thanks for the clue.
(between the lines i read that the other modules in the init_sessions file still need some rewriting to.)
I will try this and post my findings.
Hi Diva,
I shall await your findnigs. I know it worked prior to the "h" updated files because we have contests and when they win an item from the store I go in and add it to their order, which I did early in October.
Not sure what happened either and it is happening in both the test and live store...but not affeting the rest of the stuff either.
I even went in and added the files that the doc said could be deleted too and that did not make it behave.
Hey Angel..
I have updated my test store, and unfortunately my findings are the same as yours.. The "Add Products" function works for all versions of 1.3.9 versions Zen Cart prior to 1.3.9h.. Unfortunately it's beyond my skillset to fix this as DrByte recommends or I would surely give it a shot to try to correct this.:no:
I realize that the other "fix" posted works, but I trust DrByte when HE says that this is not the right approach to correcting this problem.. Hopefully someone will come along who knows how to fix this so that it is not bypassing the security, and follows DrBytes sage advice to "recode things to ensure that the securityToken is set and checked"..
Will keep plugging away at seeing if I can figure out how to make the correct change.. Will also be keeping an eye on this thread in case someone else comes up with the solution.. **sigh**
Quote:
Originally Posted by DarkAngel
Thanks Diva,
since i use version 2.03 I also went to his site and used his contact mail to alert him of how it is misbehaving....I even tried the whitepage page we created last time but to no avail...course I am not quite sure how to add it to that one anyway...lol
hope someone can figure out what to do cause I like this mod...ty
Yep I sent Scott an e-mail too.. Dunno if he has plans to update Edit Orders.. Hopefully something will get figured out..:smile: I like this mod too!!!Quote:
Originally Posted by DarkAngel
A possible fix is in the works. :)
yes Scott it works!!!
doing the happy dance over here in Kansas
ty
Glad to hear it works! :)
Fixed version 2.04 is now available via the link in my signature.
Please upload your fix to the Zen Cart Add Ons section.
Scott you are awesome!!!!Quote:
Originally Posted by srturner47
I am sorry to spoil the fun and happiness but srturner47 has chosen to follow the way i was discussing in some posts back to rename the keywords in something not fetched by the init_sessions and as DrByte stated as the wrong way because you are bypassing security.
The fix is as bad as the quickfix in init_sessions and even less complete.
I have to go with the advice of DrByte that the only good way is rewriting the mod to make it compatible with the new security measures (first steps for this where made in 1.38) and a mjor rewrite is not at all because the mod is and has been buggy always.
I will keep writing on a new release of this mod and in the moment the framework is rewritten and confiming to the new standards.
(post this in both threads if the moderators allow)
I used this mod since 2006 (when i started with zencart) and alway accepted its quirks because there has been many other mathers in the shop that needed attention first.
It has always been low priority to me because it worked more or less.
Alway made a smal fix (patch) for one problem at a time and neve came to a complute solution.
With the security taken to a much higher level i am facing similar problems in other mods i was developing and now it has high priority.
Because this mod has everything i need further on in my mod development i will rewrite this one first.
What i did until now:
Made the mod language aware.
Made the mod currency aware. (no more fixed $ signs)
Removed the fixed tax settings and follow the shops tax rules.
Changed some fields from text input to dropdown.
And last but not least confirmation to the security framework. (worked on at the moment, almost finished)
Some other mods i am using included in this one but still need some fine tuning for those not using this other mods.
After finishing up i will upload to the mods but since v2 is occupied i wonder how i should name this new version. (V3 ?)
well imho, snd that is all it is...an opinion
if it were me i would get with sturner with the changes...after all he is the one that made it to begin with.
**deleted**
I just got back from the store and took a look at the fix, and you are right.. While this addresses the IMMEDIATE issue, it does not address the underlying security concerns with this add-on.. It's BEYOND my little skill level to even BEGIN to address those.. (Requires a REAL programmer!! :laugh:)Quote:
Originally Posted by asekeris
If you are looking for testers would LOVE to test this.. Two Zenners and myself have been working on an update to Super Orders and we have all but removed all of the order edit features from Super Orders due to the incomplete nature of the order edit functions and the fact that Edit Orders really did what the Super Orders edit features were attempting to do in the first place. We knew Edit Orders wasn't perfect, but it was BETTER than the Super Order edit functions..Quote:
Originally Posted by asekeris
We wanted to include correctly edited super_orders.php and edit_orders.php files in the new Super Orders fileset to end a long standing belief that Super Orders and Edit Orders could not be used together. In doing so we did a fair amount of work to remove hardcoded text from the edit_orders.php file along with adding the current comments functionality (most notably the support for hidden "admin" comments) from Zen Cart 1.3.9.
We also modified the Edit Orders navigation as the various back buttons did not follow what we thought would be a "logical" workflow (based on feedback from clients). For example the back button in Add Products takes you back to the order list. It seemed to make more sense that you would want to either return to the order you were editing or return to the order details pages. Same with the edit_orders.php page too.. There was only a back button which returned you to the oder list, but no option to return to the order details page from the editing page.
Wow this sounds great..:clap: I say v3.0 sounds awesome and totally appropriate!!!!Quote:
Originally Posted by asekeris
Let me ask one thing.. Integration to use with Super Orders was a fairly simple matter with the current v2.03/2.04 versions.. Will yours be just as easy to link these two add-ons??
Angel, add-ons here have ALWAYS been an open affair, and never "owned" my any one person.. The LONG history of this mod is that it was an OC commerce mode ported for use with Zen Cart, and looking at it from that standpoit sturner is not THE original author..Quote:
Originally Posted by DarkAngel
That said sturner has maintained this mod since v1.5, but even he would admit he is not the originator of this mod.. (a quick looksee at the changelog will confirm this..) He has done an awesome job, but asekeris is correct there are some issues with this mod, that many of us have overlooked and even accepted since it MOSTLY did what it was supposed to do.. I welcome his new update especially since it sounds like the right direction for this mod..
Yes, you are correct. I am certainly not the original author of this mod. I just saw some things that annoyed me about it, and I fixed them and added some new features.
I don't really use this mod anymore anyway, so I've simply kept it up for the community at large. The changes asekeris is working on sound great! The biggest problem with Edit Orders is that it doesn't handle multiple taxes right. Not a problem if you only have one tax per order, but European countries that use multiple VATs have big issues with this. If your changes somehow address that, that would be a big boon for a lot of users!
I must admit, I really don't understand the security token that Zen Cart uses. I did find that with the newest version Zen Cart checks to see if there is a GET variable with certain things in it. One of those things is add_product. I assumed this was to prevent something from happening in Zen Cart. Edit Orders uses this value for a GET variable called action, so I just changed it to add_prdct. This GET variable, action, is used only within the edit orders file -- it calls itself through a link and does different things based on the GET and POST variables. It doesn't do anything with a standard Zen Cart file other than to load the headers, footers, db stuff, etc.... The way I fixed this doesn't affect any of the other Zen Cart files, as add_product is still not allowed in GET variables.
Furthermore, the only way someone can gain access to your admin is to get your password. If they've got that, you've got big problems anyway.
I suppose you could change it to a POST variable, which would also fix your problem. Then you'd need to change the link to a form with a post variable. Wouldn't be too difficult to do, but as it stands, I don't really see the point.
Maybe I am missing something, but this seems secure to me. As with anything in life though, you take your chances! :)
Hey Scott.. not for nothing your fix will allow me and my fellow Zenners to move forward with our Super Order release.. Admittedly (if I didn't make it clear before..) while I think I understand the issue, I don't profess to understand the full extent of the security concerns that DrByte pointed out.I leave that for real smart people to figure out and explain to the rest of us "little people"..:laugh::laugh: However, since the concern was brought up, I'm glad the real smart people are trying to work this out and improve this add-on even more..
Lest it sound like I meant otherwise, your hard work on this add-on has been appreciated.. Yeah we ALL know Edit Orders is far from perfect, but it gets the job done for a great deal of store owners so thank you for keeping it up for the community!!! Beyond that anything that makes this add-on better is a good thing regardless of whoever brings it to the the table..:smile:
Quote:
Originally Posted by srturner47
I am not attacking someone (even if it looks that way in my posts) just pointing to the problems.
A lot of good things have been done to the mod by scot and i am taking them all in account while rewriting.
At first i thought changing the redirecting to the new safer way was easy but after a few days struggling with the code i totally understand (i think) this new way of redirecting.
It is easier said then done.
I am working on it and getting closer and will release to the public as soon as possible so that everybody can take advantage of it.
Beacause the nature of this change the layout and flow of things has to change also and it is a lot of work to get this implemented and along the way clean up all the quik fixes and patches done by everyone in the past.
I don't think it will be appreciated if i explain here in full detail how to handle and use this new safety method to the public and just limit myself to rewriting and make the finished files available in the add-on section.
For now this is very high priority to me because i walked into the same problem with other mod's i was working on but because they are more complex i decided to use this mod for testing.
Working full days on this mod at the moment and hoping to release the first update this week.
Intrigued by this add_product dilemma, I am wondering whether the following edit concerning edit_cart_v1.3 and performed to
/includes/templates/template_default/templates/tpl_product_info_display.php,
as discussed in the following link, may have a bearing upon this problem.
http://www.zen-cart.com/forum/showpo...&postcount=145
I made this edit under 139c and have not experienced any problems with it (fingers crossed).
Cheers
dw08gm, this is about admin-related stuff. Your post is about non-admin related stuff.
While the "add_product" parameter is also used here, the concepts and issues at hand are entirely different.
DrByte
I feared as much. Thanks for the clarity.
Cheers
From me to you.. I totnally get that..(insert emoticon here:laugh:)Quote:
Originally Posted by asekeris
It's difficult when it comes to the written word to convey emotions, sentiment, or intent.. unfortunately on a forum sometimes folks assume emotions or intent that were not the TRUE feelings of the author.. I always thought we were just chatting in this thread!!:smile: So it's ALL GOOD!!!
Agreed, and if I didn't say it clearly to YOU, I am EXCITED that you are doing this and can't wait to see this!!!:clap:Quote:
Originally Posted by asekeris
Sounds AWESOME!! if you need folks to test, I am ABSOLUTELY willing to volunteer to test..:smile:Quote:
Originally Posted by asekeris
Today decided to make a extra fresh install on my test server with no other mods installed and only added dutch language.
Taking edit orders to the next level in this install so i am not fooled by other mods and an release can be done earlier.
At the moment doing the last code modifications and then testing, testing and testing again.
After that (i hope this evening) i will upload it to the add on section.
For now left out the automatic taxes and changing some fields to dropdown for the sake of release speed.
By leaving out all other mods i use the release will be much faster and everybody can test as he wants.
Maybe i will hold you to the offer for pre testing if i am in doubt.
DEFINITELY hold me to it..:smile: I am more than happy and willing to test this out for you.. I have my test store setup in such a way that I can EASILY roll back to a vanilla store setup to test.. I do that for the same reason as you do so that I can see how the add-on behaves without the influences of other add-ons..
Quote:
Originally Posted by asekeris
Quote:
Originally Posted by DrByte
Upon further investigation, I'm going to capitulate and take back my earlier comment.Quote:
Originally Posted by asekeris
While it *is* advisable to rewrite some of the addon's functionality to do things more securely and in so doing prevent XSS and CSRF risks, the edit suggested by cbensi shouldn't be as risky as initially expected.
Apologies for the confusion caused. :blush:
No problem at all.Quote:
Originally Posted by DrByte
It just gave me the push to do the long overdue overhaul of this mod.
I also found during this overhaul that following this method completely is nearly impossible for pages that need calling itself to complete updates or changes and is even more complicated when there are in between steps with 'normal links' instead of form submits.
This will make life much easier and will finish the update as soon as possible.
Just submitted an intermediate update to the add on section and waiting for aproval. (v 1.5.4)
Items taken care off:
1. Changed action keywords to be compatible with 1.39h.
2. Made the mod multi-language.
3. Made the mod multi-currency.
4. Included dutch language files.
5. Minor fix in the HTML header. (no more error display)
6. Removed fixed file names and replaced by FILENAME_ORDER_EDIT.
7. Upgraded order status and send email to the new layout. (Like the order details)
8. Changed the fixed texts in language defines.
9. A lot of cleaning up and rewriting to standard zen functions.
TO DO in next versions:
1. Automatic tax calculations following the settings in the store.
2. Integration of support for some other mods.
3. Change some input fields in dropdown.
4. a lot of code formatting for better readebility.
Sounds awesome.. Items 6-8 sound a lot like the changes that JTheed and I had made to the edit_orders.php file we were going to bundle in with new Super Orders..
Is it possible to get a copy of your version now?? I am bundling up the new Super Orders package as we speak and it would be nice if we could include what will be the latest and greatest version of Edit Orders versus having to do a second Super Orders release..
One small suggestion though..
Suggest that the version numbering should be updated to either 3.0 or 2.05 to avoid confusion.. Most of us have been working with ver 2.03 (now 2.04) of this add-on from Scott's site... rolling the version numbers backwards might be a source of confusion for many..
Quote:
Originally Posted by asekeris
Okay.. Not for nothing, but having a look at your 1.54 version it seems that your version is merely an update/enhancement of v1.53 available here in the Zen Cart downloads section. I'm sure you know that v1.5.3 is MILES AWAY from the most UPDATED version of Edit Orders which has been the subject of recent discussions in this support thread (v2.04).
There seem to be a TON of updates/enhancements/fixes which were incorporated into v2.xx of this module that are not in your version..
Given that DrByte has confirmed that two options originally proposed to correct the issues experience when using Edit Orders with Zen Cart 1.3.9h are "acceptable" solutions, why not update the version most of us are using (and indeed the version that a majority of the questions/hints/etc in this support thread are asking about) and submit that to the downloads section??
Quote:
Originally Posted by asekeris
Is is just an intermediate update to fix the 1.39h compatibility with some of the quirks fixed.
All other problems are worked on and in the end get into this version in the download section.
By then i will make a decision about the version number.
It's not the version numbering I am concerned about.. The version you submitted does not include ANY of the updates/enhancements/fixes which were incorporated into v2.xx of this module that most of us use.. (the version that sturner fixed) The version you submitted is a step back for those of us using the v2.xx versions of Edit Orders..Quote:
Originally Posted by asekeris
Ad,Quote:
Originally Posted by asekeris
I currently use v1.53 with the init_sessions mod. I have no trouble with that version or with Scott's v2x, but when I upload 1.54 I get nothing on the screen between the admin menu bar and the Zencart logo.
Not sure what's stopping the order from displaying on my test site. It could just be me but thought I'd mention it.
Ed
Hi Ed,
I think you did not edit the orders.php according the changed instructions in the 'read me first.txt'.
The way the order editor is called changed there (new keyword) and i will catch that situtation in the next update.
Quote:
Originally Posted by asekeris
I swear I'm not trying to be a PITA, but I would like to get an understanding about the direction you are taking this mod in. (and I think those that use this mod would like to know this as well)Quote:
Originally Posted by asekeris
MANY of us are using the 2.xx versions of this mod because of all of the MANY improvements and bug fixes it offers over the v 1.5x versions available here.. Now WHY the 2.xx version was never submitted to the downloads is a question that only sturner can best answer, but the fact is that Edit Orders 2.xx IS the BETTER version of Edit Orders and the one many of us use. Heck I'll be happy to submit it to the downloads just to end any "questions" about where to get it..
1.54 from what I can see is version 1.53 corrected for 1.3.9h compatibility. However 1.54 leaves out EVERY LAST ONE of the 2.xx enhancements/features/bugfixes. Using your submitted v1.54 of Edit Orders is a STEP DOWN in terms of features for those of us using v2.xx of Edit Orders, and I am trying to understand if you plan to re-introduce 2.xx features to your future releases or not..
The link from the order list works fine, that one has "action=modify" in the link.Quote:
Originally Posted by asekeris
The link for editing the order inside the order detail screen comes up as "action=edit", which doesn't work. I changed the code per your instructions but it didn't change the link. Again, maybe it's me...I'll check again.
Ed
I fixed it, that might be a separate link that I added myself, I don't remember if that link was part of the original mod.
Ed
**deleted**
These are the features/enhancements since v2.0 that are missing from v1.5.4. Will any of these features be included in your planned development??Quote:
Originally Posted by DivaVocals
From the 2.04 readme:
Quote:
v 2.0 10/15/2008 - Scott Turner
- Implemented new attributes handling in the following ways:
a) In addition to the more complicated (advanced) attribute editor, a simpler option is available.
- i) Select a new attribute from a drop-down menu in admin.
- ii) The new price will be automatically calculated by subtracting the old attribute price and adding the new attribute price.
b) Text attributes now are implemented through a text box.
c) Fixed attribute pricing for the following scenarios:
- i) One Time Charges Implemented
- ii) Price Factor & Offset Implemented
- iii) One Time Price Factor & Offset Implemented
- iv) Attributes Qty Price Implemented
- v) One Time Attributes Qty Price Implemented
- vi) Price Per Word & Free Words Implemented
- vii) Price Per Letter & Free Letters Implemented
- viii) Specials and Sales Implemented for Attributes When Option is Selected for Attribute
d) Product one time charges are easily editable.
e) You can switch back and forth between the old advanced attribute editor and the easier one using a text-link.
- i) The advanced attribute editor allows you to change the price and attribute option and value manually.
- ii) The simple attribute editor allows you to choose from the attributes listed in your database.
- iii) The advanced attribute editor will not update prices -- it leaves you to do this.
- iv) The simple attribute editor updates prices automatically.
- v) The simple attribute editor is the preferred method of altering attributes! The advanced is useful for advanced purposes.
f) Downloads are now implemented correctly and will change automatically when using the simple attribute editor.
g) All attribute data from TABLE_PRODUCTS_ATTRIBUTES now moves succesfully to TALBE_ORDERS_PRODUCTS_ATTRBIUTES when an attribute option is changed using the simple attribute editor.- Adding products has added a few new features.
a) You can choose whether or not new products use the special or sales price.
b) Text attributes now work with a text box.
c) Many new attribute options are implemented correctly when calculating the price for new products. See 1-c for more info.
d) Downloads are now implemented correctly.
e) All attribute data from TABLE_PRODUCTS_ATTRIBUTES now moves succesfully to TALBE_ORDERS_PRODUCTS_ATTRBIUTES when a new product is added with an attribute.- Coupon and group discounts now calculate correctly with taxes. To do so, the mod uses your average tax rate for all the products that were purchased.
- Fixed problem with quantity discounts adding to total instead of subtracting.
- Changed behavior so that clicking "details" on the order screen will give you the original edit orders page that Zen Cart has built in.
a) This allows you to choose which page you want to use. Click "details" for just the basics. Click "edit" to make some changes to an order.- Fixed problems with data in TABLE_ORDERS_PRODUCTS not updating includng products_price, products_tax, and final_price.
- You can now enter a value for shipping taxes and this will calculate correctly. Zen Cart doesn't store this info in the database, so this must be changed every time when editing orders. A compromise, but better than nothing.
- Added lines for edits to orders.php per popular demand on Zen Cart forums.
v 2.01 11/16/2008 - Scott Turner
- Fixed problem with TABLE_ORDERS not updating when adding a new product.
- Fixed problem with wrong currencies when adding a new product.
v 2.02 2/18/2009 - Scott Turner
- Fixed problem with adding products when they are in the Top Category (i.e. they aren't in a category folder).
- Fixed problem with adding products that are not on special being added at $0 when the apply special price box is checked.
v 2.03 2/21/2009 - Scott Turner
- Fixed problems with updating text attributes when more than one text attribute is used in Zen Cart.
- Fixed problems with adding a product with text attributes when more than one text attribute is used in Zen Cart.
- Fixed problem with using apostrophes in a text attribute when adding a product.
v 2.04 11/6/2010 - Scott Turner
- Fixed problem with add product page on v1.3.9h.
Just an FYI -
There is a bug with edit orders v2.03 and attributes (specifically checkbox option type) as I outlined in this thread (post #5):
http://www.zen-cart.com/forum/showthread.php?t=146652
I stopped using the mod a long time ago, but wanted to mention this bug since it appears a new author is taking over. There might also be some other quirks users brought up in that thread.
:yes:**nods in agreement**Quote:
Originally Posted by Crunch
Though I am aware of the checkbox issue, for my clients we worked out a pretty decent workaround for the checkbox issue.. The Edit Orders functionality was important enough to them to live with the current way this works..
Hopefully the author is going to be including all of the features from 2.03 as well as addressing the checkbox issue.. All in all 2.03 is a MUCH better version than 1.53 and I'd hate to see the loss of it's features...Quote:
Originally Posted by Crunch
As far as i know this has never been in the original mod and off course any link refering to the edit_orders.php has to be changed to the new keyword.Quote:
Originally Posted by edadk
DivaVocals:
If you read the stuff you are quoting so extensive you should have noticed that all enhancements made in the v2.0 fork should find its way in this one.
I will not respond to 2.0 issues because first the basic structure needs rewriting (for all those who sticked to the original 1.5.x branch) and after that when a much more solid framework is there i will start enhancing it with the work that sturner already did to the mod.
I am not taking over the mod only rewriting the official 1.5.x branche and for sure not the 2.x fork and issues regarding that should be addressed to sturner.
I am even puzzled why the moderators even allowed this v2 discussion here while it never is submitted to the add-ons and this still is the support thread for the 1.x.x version that is in the download section.
I will first make the basic structure according to ZC1.39 standards (and not ZC1.2 where it is now) before putting in new stuff or patchwork from others.
I have written it a few posts back buth repeat it here for clarity:
I respect the work others did to this mod and will incorporate the enhancements they made in a later stage.
For now i think it is better to forget the 2.0 in this thread for a while and concentrate first on the basic and keep this discussion for where it was intended for: orders 1.3.x support.
From here on i will spend my time on the mod and supporting it and not on endless discussions about what should be in because it is in some other version.
Thanks for the work on this.
FYI - My store is set up to charge tax on shipping but the mod is not picking this up. I think you know about this already but I thought I'd post it to be sure.
Ed
I asked because it really wasn't clear that this was your intent.. and for those of us using the "v2.0 fork" I was merely suggesting that it would be good to see those features make their way back into your work. However if you had different plans I wanted to know what those differences were.. Hence my questions..Quote:
Originally Posted by asekeris
I don't think anyone was asking you to address these issues now. I believe we were merely asking if your version of the add-on will address them.. sturner has already indicated that he would not be addressing these issues.. So getting your take on these issue with regards to your future plans for enhancing this add-on is useful information..Quote:
Originally Posted by asekeris
For better or worse, this is not the only add-on where the support thread has continued on with discussions that revolve around updated versions not available in the downloads section..Quote:
Originally Posted by asekeris
As for this particular add-on the bulk of the recent discussions have mostly been centered around v2. Most folks running 1.3.8 or better are indeed using this version.. Hence the reason the support thread has included discussion about that particular version..
Again it was not clear that this was the direction you were moving in.. Hence the reason I asked the question..Quote:
Originally Posted by asekeris
This won't stop others from continuing to ask questions about v2 or others from answering.. Since your version promises to be much improved versions of the currently available versions, perhaps a new support thread is in order??Quote:
Originally Posted by asekeris
Wasn't trying to start an endless discussion.. I merely asked for clarification on the direction you are moving in. Your answers have clarified things.. So I'll wait to see your releases as they are made available.. I'm sure that others wanted to know/understand the same things I was asking about.. Particularly those of us who use v2 of this add-on so that we can make decisions about our future use of this add-on.Quote:
Originally Posted by asekeris
Submitted v1.5.5 and waiting for approval.
Please give feedback here so that i receive notification of feedback and/or problems.
Again it is not the real thing yet and the more time i spend on this mod the more i discover how weird it is behaving.
The to-do list is growing and in the end i will get there it is only taking some time to get everything fixed.
With 1.5.5 clicking 'edit' brings up the edit orders screen as expected, but after this my whole admin breaks and no matter what I click next in the admin I get a blank screen.
The only way to fix this is to delete all cookies relating to my site, then it works again!
Dont know if thats related to the same error as above?
If anyone can help, it would be appreciated.
tone
Searching the Tutorials/FAQs for "blank screen" brings up this article: https://www.zen-cart.com/tutorials/index.php?article=82
First time after install (and in special when upgrading) this behaviour can be expected and i should have written that in the documentation.Quote:
Originally Posted by tone2
I am more interested in how it behaves after the cookie cleanup.
For DrByte: I have full access to the logs and nothing is there, also the testing is done in a setup not visible to the world with error reporting on and debug enabled.
As always with software if someone else than the programmer starts using it the problems pop up and that is the reason feedback is needed.
I have checked error logs, and nothing is there.Quote:
Originally Posted by asekeris
If I click to edit the order, that works ok. When I click update (whether I have changed anything or not) or if I now try and click anything else in the admin I get blank screen.
I now get the blank screen for every single admin page. Once I remove all cookies, the admin pages start working again but require a new login.
Cookie clean up solves the problem, but I have to do this everytime after accessing the edit order page, which of course makes the edit order page unusable.
Let me know if you need more info.
That is very strange and i will try to replicate the situation you have.
Because i do not have this problems i need more info like the zen version, browser, os, webserver and other mods installed because it could be a dependency with another mod.
I suspect another mod is playing tricks because i test with zen 1.39h, 4 browsers on 3 different operating systems and 2 versions of apache server.
One clean setup with only edit orders and the other with all mods installed as on my live shop.
Zen cart was recently updated to 1.3.9.h. This problem occurs with all browsers (Firefox, IE, Opera, Chrome and under Win XP and Linux) Server is Apache/2.2.3 (Fedora) PHP Version 5.2.10. Other mods.....I have a few installed, trying to think of ones that could interfere.......not really sure?Quote:
Originally Posted by asekeris
All was working fine to upgraded to 1.3.9h and upgraded edit orders to 1.5.5
I might try reverting back to an old version of edit orders.
Tony
I am not able to replicate your problem.
Your setup sounds the sme as my copy of the life shop.
Upfraded from 1.38a to 1.39h with edit-orders 1.53 installed.
This mod has alway been a troublemake and that is the reason is started modifiying with 1.53 as starting point.
Would you be so kind to roll back to edit orders 1.5.3 to see if the problem then disappears.
And if anyone is using 1.5.5. please report before i continue.
OK with 1.53 when I click edit orders I get and empty page (ie all the menus still there but nothing else). My admin still works after doing this.Quote:
Originally Posted by asekeris
With 1.55 when I click edit orders I get the edit orders page, but from then onwards my admin is broken and any other click results in a blank page. The only resolution to this is delete cookies.
So neither version works! Hopefully we can figure this out as this was a good add on.
Tony
The blank page with 1.53 is because you did not edited orders.php in the correct manner as described in the uninstall.txt.
If the 1.53 also does not work something else is wrong so please do this edit in the proper way.
Remember that with 1.53 in zen 1.39h it is not possible to add products.
Right thanks for that. I have edited the orders.php correctly now.Quote:
Originally Posted by asekeris
I can confirm that 1.53 is working now. I can edit prices and totals. Havn't tried adding products, but definitely not getting the same problems that I had with 1.55.
Tony
I will keep searching and it should be one of the edits after 1.5.3.
Thanks for trying.
Can you pm me a screendump of the server settings so that i can setup my test system the same as yours.
Hello, I installed and am using edit orders currently. I would like to know how or what I need to change in order to replace the "Zen Cart the art of e-commerce" logo on the top of my customers order confirmation emails they receive. Ideally I would like to replace it with my store logo. Please help! Thanks!
:blink:
That is not really a issue of the mod but general setup.Quote:
Originally Posted by CandyPlaza.com
The mod is using the same system and template as other emails from the system.
In the email dir is a file header.jpg that you can replace with your own file.
Text should be adjusted in the corresponding language files.
zc 1.3.9h
edit orders 1.5.5
made changes to orders.php
uploaded new files
after clicking edit order button i get
HTTP - 500 Internal Server Error
The page you are attempting to load returned an error
help?
thanks.
The internal server error is very general and could have many reasons.
Please check this out first:
https://www.zen-cart.com/tutorials/index.php?article=63
It could mean that 1 of the files is corrupted/missing during the upload or you uploaded to the wrong dir.
well done asekeris on updating (IMHO) and essential add on!!
just installed 1.5.5 and all works so far (not tested all feature, just the features i use (change address, add/remove items, order comments))
Good effort fella!
one minor thing, i get this in the cache folder
[04-Dec-2010 13:59:16] PHP Warning: ksort() expects parameter 2 to be long, string given in /home/xxxxx/public_html/renamedAdmin/includes/functions/extra_functions/edit_orders.php on line 76
I don’t know what it means, and everything seems to work... just thought you would like to know.
carry on with the great work!
Thank you
That is info i can work with.Quote:
Originally Posted by dutchy
Will sort it out and correct it.
Quote:
Originally Posted by srturner47
For those who have been using version 2.04 by Scott Turner, I just wanted to let you all know that (with Scott's blessing), this version is now available in the downloads section:Quote:
Originally Posted by Kim
http://www.zen-cart.com/index.php?ma...oducts_id=1818
Not trying to take anything away from the current direction of the 1.5x version of Edit Orders.. I am simply posting this here so that those interested in the v2.x version of Edit Orders can be directed to the proper place to get it.
That said, until now, THIS particular forum thread has supported ALL support related questions regarding BOTH Scott's 2.x versions of Edit Orders and the 1.5x versions of Edit Orders. To minimize confusion, I have created a NEW support thread for those who are using v2.x varieties of Edit Orders..
http://www.zen-cart.com/forum/showthread.php?p=968098
Just make that line a comment.Quote:
Originally Posted by dutchy
It is not used at the moment and is a prototype for solving the shipping tax problem planned for 1.5.6.
I think this release will never come because the previous post made the confusion even bigger in my opinion.
I see no good in having two mods with almost the same name and using the same file names and for that reason i will stop making updates public.
Maybe that i will release it later under a new name with a different set of file names after all basic problems are fixed but for now i retire this mod and this thread.
Behind the scenes I will continue to work on it because i don't need all the extra's of super-orders (and other graphic enhancements) and just need a basic editor to remove or add products with correct calculations of taxes.
I wish you all the best and good luck with V3
I get same error [30-Nov-2010 06:13:46] PHP Warning: ksort() expects parameter 2 to be long, string given in /var/www/html/admin_i-contacts/includes/functions/extra_functions/edit_orders.php on line 76Quote:
Originally Posted by asekeris