Order Editor 1.3.7 Issues

[edadk]

Is is just an intermediate update to fix the 1.39h compatibility with some of the quirks fixed.
All other problems are worked on and in the end get into this version in the download section.
By then i will make a decision about the version number.

Ad,

I currently use v1.53 with the init_sessions mod. I have no trouble with that version or with Scott's v2x, but when I upload 1.54 I get nothing on the screen between the admin menu bar and the Zencart logo.

Not sure what's stopping the order from displaying on my test site. It could just be me but thought I'd mention it.

Ed

[asekeris]

Hi Ed,

I think you did not edit the orders.php according the changed instructions in the 'read me first.txt'.

The way the order editor is called changed there (new keyword) and i will catch that situtation in the next update.

[DivaVocals]

Is is just an intermediate update to fix the 1.39h compatibility with some of the quirks fixed.
All other problems are worked on and in the end get into this version in the download section.
By then i will make a decision about the version number.

The way the order editor is called changed there (new keyword) and i will catch that situtation in the next update.

I swear I'm not trying to be a PITA, but I would like to get an understanding about the direction you are taking this mod in. (and I think those that use this mod would like to know this as well)

MANY of us are using the 2.xx versions of this mod because of all of the MANY improvements and bug fixes it offers over the v 1.5x versions available here.. Now WHY the 2.xx version was never submitted to the downloads is a question that only sturner can best answer, but the fact is that Edit Orders 2.xx IS the BETTER version of Edit Orders and the one many of us use. Heck I'll be happy to submit it to the downloads just to end any "questions" about where to get it..

1.54 from what I can see is version 1.53 corrected for 1.3.9h compatibility. However 1.54 leaves out EVERY LAST ONE of the 2.xx enhancements/features/bugfixes. Using your submitted v1.54 of Edit Orders is a STEP DOWN in terms of features for those of us using v2.xx of Edit Orders, and I am trying to understand if you plan to re-introduce 2.xx features to your future releases or not..

[edadk]

Hi Ed,

I think you did not edit the orders.php according the changed instructions in the 'read me first.txt'.

The way the order editor is called changed there (new keyword) and i will catch that situtation in the next update.

The link from the order list works fine, that one has "action=modify" in the link.

The link for editing the order inside the order detail screen comes up as "action=edit", which doesn't work. I changed the code per your instructions but it didn't change the link. Again, maybe it's me...I'll check again.

Ed

[edadk]

I fixed it, that might be a separate link that I added myself, I don't remember if that link was part of the original mod.

Ed

[DivaVocals]

**deleted**

[DivaVocals]

1.54 from what I can see is version 1.53 corrected for 1.3.9h compatibility. However 1.54 leaves out EVERY LAST ONE of the 2.xx enhancements/features/bugfixes. Using your submitted v1.54 of Edit Orders is a STEP DOWN in terms of features for those of us using v2.xx of Edit Orders, and I am trying to understand if you plan to re-introduce 2.xx features to your future releases or not..

These are the features/enhancements since v2.0 that are missing from v1.5.4. Will any of these features be included in your planned development??

From the 2.04 readme:

v 2.0 10/15/2008 - Scott Turner

1. Implemented new attributes handling in the following ways:
   a) In addition to the more complicated (advanced) attribute editor, a simpler option is available.
   
   • i) Select a new attribute from a drop-down menu in admin.
   • ii) The new price will be automatically calculated by subtracting the old attribute price and adding the new attribute price.
   
   b) Text attributes now are implemented through a text box.
   c) Fixed attribute pricing for the following scenarios:
   
   
   • i) One Time Charges Implemented
   • ii) Price Factor & Offset Implemented
   • iii) One Time Price Factor & Offset Implemented
   • iv) Attributes Qty Price Implemented
   • v) One Time Attributes Qty Price Implemented
   • vi) Price Per Word & Free Words Implemented
   • vii) Price Per Letter & Free Letters Implemented
   • viii) Specials and Sales Implemented for Attributes When Option is Selected for Attribute
   
   d) Product one time charges are easily editable.
   e) You can switch back and forth between the old advanced attribute editor and the easier one using a text-link.
   
   
   • i) The advanced attribute editor allows you to change the price and attribute option and value manually.
   • ii) The simple attribute editor allows you to choose from the attributes listed in your database.
   • iii) The advanced attribute editor will not update prices -- it leaves you to do this.
   • iv) The simple attribute editor updates prices automatically.
   • v) The simple attribute editor is the preferred method of altering attributes! The advanced is useful for advanced purposes.
   
   f) Downloads are now implemented correctly and will change automatically when using the simple attribute editor.
   g) All attribute data from TABLE_PRODUCTS_ATTRIBUTES now moves succesfully to TALBE_ORDERS_PRODUCTS_ATTRBIUTES when an attribute option is changed using the simple attribute editor.
2. Adding products has added a few new features.
   a) You can choose whether or not new products use the special or sales price.
   b) Text attributes now work with a text box.
   c) Many new attribute options are implemented correctly when calculating the price for new products. See 1-c for more info.
   d) Downloads are now implemented correctly.
   e) All attribute data from TABLE_PRODUCTS_ATTRIBUTES now moves succesfully to TALBE_ORDERS_PRODUCTS_ATTRBIUTES when a new product is added with an attribute.
3. Coupon and group discounts now calculate correctly with taxes. To do so, the mod uses your average tax rate for all the products that were purchased.
4. Fixed problem with quantity discounts adding to total instead of subtracting.
5. Changed behavior so that clicking "details" on the order screen will give you the original edit orders page that Zen Cart has built in.
   a) This allows you to choose which page you want to use. Click "details" for just the basics. Click "edit" to make some changes to an order.
6. Fixed problems with data in TABLE_ORDERS_PRODUCTS not updating includng products_price, products_tax, and final_price.
7. You can now enter a value for shipping taxes and this will calculate correctly. Zen Cart doesn't store this info in the database, so this must be changed every time when editing orders. A compromise, but better than nothing.
8. Added lines for edits to orders.php per popular demand on Zen Cart forums.

v 2.01 11/16/2008 - Scott Turner

1. Fixed problem with TABLE_ORDERS not updating when adding a new product.
2. Fixed problem with wrong currencies when adding a new product.

v 2.02 2/18/2009 - Scott Turner

1. Fixed problem with adding products when they are in the Top Category (i.e. they aren't in a category folder).
2. Fixed problem with adding products that are not on special being added at $0 when the apply special price box is checked.

v 2.03 2/21/2009 - Scott Turner

1. Fixed problems with updating text attributes when more than one text attribute is used in Zen Cart.
2. Fixed problems with adding a product with text attributes when more than one text attribute is used in Zen Cart.
3. Fixed problem with using apostrophes in a text attribute when adding a product.

v 2.04 11/6/2010 - Scott Turner

1. Fixed problem with add product page on v1.3.9h.

[Crunch]

Just an FYI -

There is a bug with edit orders v2.03 and attributes (specifically checkbox option type) as I outlined in this thread (post #5):
http://www.zen-cart.com/forum/showthread.php?t=146652

I stopped using the mod a long time ago, but wanted to mention this bug since it appears a new author is taking over. There might also be some other quirks users brought up in that thread.

[DivaVocals]

Just an FYI -

There is a bug with edit orders v2.03 and attributes (specifically checkbox option type) as I outlined in this thread (post #5):
http://www.zen-cart.com/forum/showthread.php?t=146652

**nods in agreement**

Though I am aware of the checkbox issue, for my clients we worked out a pretty decent workaround for the checkbox issue.. The Edit Orders functionality was important enough to them to live with the current way this works..

I stopped using the mod a long time ago, but wanted to mention this bug since it appears a new author is taking over. There might also be some other quirks users brought up in that thread.

Hopefully the author is going to be including all of the features from 2.03 as well as addressing the checkbox issue.. All in all 2.03 is a MUCH better version than 1.53 and I'd hate to see the loss of it's features...

[asekeris]

I fixed it, that might be a separate link that I added myself, I don't remember if that link was part of the original mod.

Ed

As far as i know this has never been in the original mod and off course any link refering to the edit_orders.php has to be changed to the new keyword.


DivaVocals:
If you read the stuff you are quoting so extensive you should have noticed that all enhancements made in the v2.0 fork should find its way in this one.


I will not respond to 2.0 issues because first the basic structure needs rewriting (for all those who sticked to the original 1.5.x branch) and after that when a much more solid framework is there i will start enhancing it with the work that sturner already did to the mod.

I am not taking over the mod only rewriting the official 1.5.x branche and for sure not the 2.x fork and issues regarding that should be addressed to sturner.

I am even puzzled why the moderators even allowed this v2 discussion here while it never is submitted to the add-ons and this still is the support thread for the 1.x.x version that is in the download section.

I will first make the basic structure according to ZC1.39 standards (and not ZC1.2 where it is now) before putting in new stuff or patchwork from others.
I have written it a few posts back buth repeat it here for clarity:
I respect the work others did to this mod and will incorporate the enhancements they made in a later stage.

For now i think it is better to forget the 2.0 in this thread for a while and concentrate first on the basic and keep this discussion for where it was intended for: orders 1.3.x support.

From here on i will spend my time on the mod and supporting it and not on endless discussions about what should be in because it is in some other version.