Printable View
I know Edit Orders (& Super Orders) was a TON of work, so missing a little thing like that is to be expected in my book! I've really been missing being able to edit my orders, so I'm so glad to have that functionality back! Thanks so much for all your hard work! :hug:Quote:
Originally Posted by DivaVocals
Aww thanks!!! it took a while between my super busy schedule and coordinating the free time of all the volunteers who worked on these two add-ons as well to get this all together.. That's why I put the finished code up on my site while I muddle through finishing up the readme docs so that peple didn't have to wait any longer.. So I appreciate that you were patient and waited on us to have something ready and clean versus something half baked and buggy.. There were a few trolls harassing me via PM and on my business e-mail during this wait time who downright rude and nasty about the wait time... **shrugs**Quote:
Originally Posted by laurelsstitchery
People can be completely ridiculous. They should be thrilled to be getting all this software for free - I know I am! I do have one more question. I can't figure out what to put in the orders.php file for TEXT_WHOIS_LOOKUP. If you could let me know what to do with that one, I would appreciate it. Thanks again! :)Quote:
Originally Posted by DivaVocals
Indeed they can.. One guy in particular didn't seem to get the concept that folks who work on/contribute free add-ons do so in their spare time because they WANT TO, not because they HAVE TO.. When I re-directed him to the support forum to pose questions/get the latest information he got VERY nasty, and when I asked him to simply stop sending me e-mail he continued to repeatedly e-mail me.. **SMH**Quote:
Originally Posted by laurelsstitchery
I'll give them all to you.. I was at work yesterday so I didn't have the files handy..Quote:
Originally Posted by laurelsstitchery
Quote:
define('ENTRY_CUSTOMER_ADDRESS', 'Customer Address:');
define('TEXT_MAILTO', 'mailto');
define('TEXT_STORE_EMAIL', 'web');
define('TEXT_WHOIS_LOOKUP', 'whois');
I'll give them all to you.. I was at work yesterday so I didn't have the files handy..[/QUOTE]
Thanks again, Diva! :)
If there is a beta download link for version 4, where is it? I may be frazzled and may have missed it, please excuse me, but 20 minutes of searching/skimming is my limit. THank you!
Post #470 in this threadQuote:
Originally Posted by GumboStandards
Let's be clear.. Not a BETA release.. a final release with an unfinished readme file.. and a search of this thread (using the thread search not forum search tool) for "Edit Orders v4.0" would have turned up the post laurel pointed you to..Quote:
Originally Posted by GumboStandards
Thank you, Lauren, I had tried that page but the lack of a signature attached to the post where the link was stated to be... well, I was frustrated by that point and came here.
My signature appears in EVERY ONE of my forum posts -- including the post where I announced that Edit Orders v4.0 is available on my site.. Are you saying you STILL haven't found it??Quote:
Originally Posted by GumboStandards
Getting this error up the top of the page, just want to make sure i am right to delete this file ?Quote:
The auto-loader /home/delights/public_html/store/control/includes/auto_loaders/config.eo.php has not been deleted. For this module to work you must delete this file manually.
I've installed Edit Orders v4 onto a clean Zen Cart 1.5.0 installation but have a nearly blank page at Admin Panel > Configuration > Edit Orders. And, yes, I got the install confirmation and then I got the "Added Edit Orders configuration menu" message. Yet all that appears on the Admin Panel > Configuration > Edit Orders page is the header and footer above and below a grey bar, respectively, with three headings, Title, Value and Action, but nothing else. If I was supposed to upload an SQL, my download only had edit_orders_uninstall.sql. I didn't install that patch obviously. So, what went wrong, if anything? Or what can I do to fix the config menu?
Here is the list of files I uploaded while logged into ap150:
ap150\edit_orders.php
ap150\edit_orders.xphp
ap150\orders.php
ap150\images\icon_billing.png
ap150\images\icon_comment_add.png
ap150\images\icon_customers.png
ap150\images\icon_details.gif
ap150\images\icon_edit.gif
ap150\images\icon_invoice.gif
ap150\images\icon_shipping.png
ap150\images\icon_track_add.png
ap150\images\Thumbs.db
ap150\includes\auto_loaders\config.edit_orders.php
ap150\includes\auto_loaders\config.eo.php
ap150\includes\edit_orders.css
ap150\includes\extra_configures\edit_orders.php
ap150\includes\extra_datafiles\edit_orders_defines.php
ap150\includes\extra_datafiles\edit_orders_extra_datafiles.php
ap150\includes\functions\extra_functions\edit_orders_functions.php
ap150\includes\init_includes\edit_orders\new_install.php
ap150\includes\init_includes\init_edit_orders_config.php
ap150\includes\init_includes\init_eo_config.php
ap150\includes\languages\english\edit_orders.php
ap150\includes\languages\english\images\buttons\button_add_product.gif
ap150\includes\languages\english\images\buttons\Thumbs.db
ap150\includes\languages\french
ap150\includes\languages\french\edit_orders.php
ap150\includes\languages\french\images
ap150\includes\languages\french\images\buttons
ap150\includes\languages\french\images\buttons\button_add_product.gif
Got Exact error this morning, couldn't find any similar reports...
Log into your shop:
Run the uninstall SQL file..
FTP the YOUR_ADMINl/includes/auto_loaders/config.eo.php to your site and click any link to re-run the installer..
As I have indicated in my posts and on my site, there is an auto-installer with edit Orders. NO external SQL file needed..Quote:
Originally Posted by GumboStandards
Thanks for a speedy reply,
I've tried this, more than once, still a blank on configuration, .... (just to note a complete fresh install,)
i'm not sure what configuration options there are?
so difficult to know where i need to look,
Regards
Then the only thing I can suggest is rolling back to the state your store was BEFORE installing Edit orders (files and DB) and start the install over.. You did back up before you installed this RIGHT???Quote:
Originally Posted by treefrog
The other thing you can try is to remove the Edit Orders DB entries from your tables manually using myPHPAdmin and reloading the auto-installer files..
I have all the backups, always! files and DB, could you advise what i should be seeing in the 'Edit orders configuration'
Regards
Dunno where the files in red came from, but they are not in the package available on my site..
Quote:
Originally Posted by GumboStandards
The SQL edits are found in this file:Quote:
Originally Posted by treefrog
YOUR_ADMIN/includes/init_includes/init_eo_config.php
Right, thank you, I understood that the first go-around and have made several installation attempts thereafter. Yet the blank config menu remains when navigating to Admin Panel > Configuration > Edit Orders after each installation attempt. 1. Might this have something to do with the following SQL holdover from Edit Orders v1.5.3?Quote:
Originally Posted by DivaVocals
2.Or am I missing some SQL (see below)? 3.Or what is needed to get the config menu installed or to display properly? Using a freshly installed, clean database on top of already clean, no-modded Zen Cart 1.5.0 files is not an option.Quote:
INSERT INTO `xzen_admin_files` (`id`, `page`, `header`, `submenu`) VALUES (93, 'edit_orders', 2, 0);
If I have to massage a database entry or two hundred, fine, but installing it again won't work any better than the four previous times. Here is all the SQL I could find in my database relating to "edit order" and "edit_order" (let me know if I should try another keyphrase, thanks):
Quote:
INSERT INTO `xzen_admin_activity_log` (`log_id`, `access_date`, `admin_id`, `page_accessed`, `page_parameters`, `ip_address`, `flagged`, `attention`, `gzpost`) VALUES (2308, '2012-07-09 08:38:25', 1, 'edit_orders.php', 'oID=122832&', '63.169.106.0', 0, '', '');
INSERT INTO `xzen_admin_files` (`id`, `page`, `header`, `submenu`) VALUES (93, 'edit_orders', 2, 0);
INSERT INTO `xzen_admin_pages` (`page_key`, `language_key`, `main_page`, `page_params`, `menu_key`, `display_on_menu`, `sort_order`) VALUES ('configEditOrders', 'BOX_CONFIGURATION_EDIT_ORDERS', 'FILENAME_CONFIGURATION', 'gID=51', 'configuration', 'Y', 55);
INSERT INTO `xzen_configuration` (`configuration_id`, `configuration_title`, `configuration_key`, `configuration_value`, `configuration_description`, `configuration_group_id`, `sort_order`, `last_modified`, `date_added`, `use_function`, `set_function`) VALUES (900, 'Ty Package Tracker Module Switch for Edit Orders v3.0 or Super Orders v3.0', 'TY_TRACKER', 'True', 'If you have the either Edit Orders v3.0 or Super Orders v3.0 installed, set this option to TRUE so that the Ty Package Tracker fields will display in Edit Orders or Super Orders<br><br><strong><font color=red>YOU MUST HAVE EDIT ORDERS v3.0 OR SUPER ORDERS v3.0 INSTALLED TO USE THIS FEATURE!!</font></strong><br><br>(Activating this flag without the required mod(s) installed <strong>WILL CAUSE ERRORS IN YOUR STORE!!!!</strong>)', 49, 175, '2012-07-09 07:50:32', '2012-07-09 07:48:22', NULL, 'zen_cfg_select_option(array(''True'', ''False''),'),
INSERT INTO `xzen_configuration` (`configuration_id`, `configuration_title`, `configuration_key`, `configuration_value`, `configuration_description`, `configuration_group_id`, `sort_order`, `last_modified`, `date_added`, `use_function`, `set_function`) VALUES (908, 'Edit Orders Version', 'EO_VERSION', '4.0', 'Installed Version', 52, 1, '2012-07-09 08:31:16', '2012-07-09 08:31:16', NULL, 'trim(');
INSERT INTO `xzen_configuration` (`configuration_id`, `configuration_title`, `configuration_key`, `configuration_value`, `configuration_description`, `configuration_group_id`, `sort_order`, `last_modified`, `date_added`, `use_function`, `set_function`) VALUES (909, 'Shipping Tax', 'SHIPPING_TAX', '0.0', 'Shipping tax is not stored in the database, but Edit Orders will use the value entered here to calculate the shipping tax and add it to the shipping totals', 52, 185, '2012-07-09 08:31:16', '2012-07-09 08:31:16', NULL, NULL);
INSERT INTO `xzen_configuration_group` (`configuration_group_id`, `configuration_group_title`, `configuration_group_description`, `sort_order`, `visible`) VALUES (52, 'Edit Orders', 'Settings for Edit Orders features', 52, 1);
It would have nothing at all to do with this since there was no SQL file in the 1.5.3 flavor of Edit Orders that I remember..Quote:
Originally Posted by GumboStandards
Based on ALL of your previous posts it appears you do not have the same installer that is currently available on my site. (see my response to your previous post)Quote:
Originally Posted by GumboStandards
Installing on a clean non-modded Zen Cart isn't necessary. However, the lowest hanging fruit and the shortest path to resolving your issues in my opinion is for you to roll back your store to where it was BEFORE you installed Edit Orders (files and DB). Download the fileset again from my website and start over.. This makes more sense than spending a whole lot of time trying to figure out how to fix what appears to be a fileset that doesn't behave/look like the one available on my website should behave, my suggestion
Sprry, yes, I did find it tonight and the other night by clicking the Profile link. BTW, signatures do fail to appear on occasion in the auto-updating version of my Chrome now up to date at 20.0.01132.47. Sometimes I see them, sometimes I don't. I typically try to browse with an automatic cache-cleaned, latest version of Firefox but I don't always manage to do so. Like now and earlier tonight. See attached screenshot.Quote:
Originally Posted by DivaVocals
Trust me, the shortest path is for me to figure out WHY your mod is failing in my environment by tracking down what it takes to manually fix this. At least that's been my experience with many, many, many mods when repeated downloads/installs fail. FWIW, the only difference between the zip I downloaded ~45hrs ago from http://overthehillweb.com/free-downloads?did=12 and the zip I downloaded about an hour ago is the messageStack difference in init_eo_config.php.Quote:
Originally Posted by DivaVocals
And installation still fails. I'll figure it out by doing a WinMerge of what I hope is a successful Edit Orders install on a clean Zen install on an empty DB against the before and after copies of my dirty test DB and files reflecting the impact of an Edit Orders' installation attempt. At least I hope that reveals something as to what might be going wrong. Anyway, I was just hoping someone else had had experienced what I am going through and there was a quick solution. If I can't even get a successful install on clean Zen files/DB, I'll look at my server. I'll try to remember to post an update when I get this resolved.
According to your earlier post you do indeed have files that are not part of the version of final version of Edit Orders tha I have on my site..
I do not know where you acquired this particular version of Edit Orders, but it is a version that I did NOT post on my site nor give out to many individuals. I only gave this version out to those volunteers who were offering to help with with testing/development.. These files were EARLY versions of the current auto-installer and it's more than likely that these files being a part of your environment is one of the chief reasons why your Edit Orders install went awry. Some of the Edit Orders SQL you posted in your earlier posts comes straight from these errant/deprecated/unused files. It is NOT the SQL that is in the FINAL version.Quote:
Originally Posted by GumboStandards
If you do not want to or cannot rollback to your pre Edit Orders state, then you need to remove ALL the Edit Orders entries from your tables. (admin_pages, configuration, and configuration_group tables) Then, you must remove those files from your environment that DO NOT belong to the final Edit Orders codebase that's on my site and try again..
Quote:
Originally Posted by GumboStandards
Now we're getting somewhere. Please provide a DIRECT LINK to the CORRECT zip file. And please DOUBLE CHECK it. Because I just downloaded it, again, for the third time, FROM YOUR SITE, http://overthehillweb.com/wp-content...load.php?id=12, and those files you're telling me that are not part of the zip are indeed part of the zip I am downloading from your site. Thank you!Quote:
Originally Posted by DivaVocals
Oops, I tried to attach the zip file I downloaded from your site but when it failed, I had intended to include the file listing of edit_orders_v4.0.1.zip. Here it is with the three files in question in bold red:
edit_orders_v4.0.1\LICENSE.TXT
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\edit_orders.php
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\edit_orders.xphp
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\images\icon_billing.png
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\images\icon_comment_add.png
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\images\icon_customers.png
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\images\icon_details.gif
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\images\icon_edit.gif
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\images\icon_invoice.gif
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\images\icon_shipping.png
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\images\icon_track_add.png
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\edit_orders.css
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\auto_loaders\config.e o.php
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\extra_configures\edit _orders.php
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\extra_datafiles\edit_ orders_defines.php
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\functions\extra_funct ions\edit_orders_functions.php
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\init_includes\init_eo _config.php
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\languages\english\edi t_orders.php
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\languages\english\ima ges\buttons\button_add_product.gif
edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\languages\english\ima ges\buttons\Thumbs.db
edit_orders_v4.0.1\2_Modified_Core_Files\YOUR_ADMIN_FOLDER\orders.php
edit_orders_v4.0.1\3_SQL\edit_orders_uninstall.sql
edit_orders_v4.0.1\4_Language_Packs\YOUR_ADMIN_FOLDER\includes\languages\french\ edit_orders.php
edit_orders_v4.0.1\4_Language_Packs\YOUR_ADMIN_FOLDER\includes\languages\french\ images\buttons\button_add_product.gif
edit_orders_v4.0.1\readme\edit_orders_readme.html
edit_orders_v4.0.1\readme\images\blank.gif
edit_orders_v4.0.1\readme\images\bw2_tab_left.gif
edit_orders_v4.0.1\readme\images\bw2_tab_right.gif
edit_orders_v4.0.1\readme\images\index.html
edit_orders_v4.0.1\readme\images\spacer.gif
edit_orders_v4.0.1\readme\images\Thumbs.db
edit_orders_v4.0.1\readme\includes\css\stylesheet.css
edit_orders_v4.0.1\readme\includes\jscript\jscript_tabs.js
edit_orders_v4.0.1\YOUR_ADMIN\includes\auto_loaders\config.edit_orders.php
edit_orders_v4.0.1\YOUR_ADMIN\includes\extra_datafiles\edit_orders_extra_datafil es.php
edit_orders_v4.0.1\YOUR_ADMIN\includes\init_includes\init_edit_orders_config.php
edit_orders_v4.0.1\YOUR_ADMIN\includes\init_includes\edit_orders\new_install.php
Ah, crap, I hadn't read your post to the end. Well, I sort of had, I skimmed it and meant to go back but I got ahead of myself, got interrupted and... Anyhow, I'll remove the files in red, rollback and give this a try in the morning. BTW, I had been rolling back with every Edit Orders installation I've tried. That's Troubleshooting 101, right?! I'd just been unwilling to rollback to pre-Edit Orders 1.5 files and database, which is why I was jus trying to get it working with a default install of Zen Cart 1.5.0. Cuz that was four years ago and 1.3.7 IIRC! Although I do still have the backup zip files for that development stage. :)
Glad this is over with. I couldn't sleep with this awaiting. :)
Thank you!
And all I really needed to do was add the SQL below and ensure continuity on configuration_group_id. Oh, well, live and learn (to not get so frustrated as it affects communication).
Code:INSERT INTO `configuration` (`configuration_id`, `configuration_title`, `configuration_key`, `configuration_value`, `configuration_description`, `configuration_group_id`, `sort_order`, `last_modified`, `date_added`, `use_function`, `set_function`) VALUES
(950, 'Shipping Tax', 'SHIPPING_TAX', '0.0', 'Shipping tax is not stored in the database, but Edit Orders will use the value entered here to calculate the shipping tax and add it to the shipping totals', 55, 185, '2012-07-10 01:26:49', '2012-07-10 01:26:49', NULL, NULL);
Don't need the zip.. just some information.. which you provided..
These files were included in the zip file inadvertently.. Didn't realize they were left in the the zip file.. Delete these files as they do not work. (which is why they were not supposed to be part of the final install package) I'll fix that this morning..Quote:
Originally Posted by GumboStandards
Part of troubleshooting is also trying to recreate a problem from start to finish.. which is why I was advocating rolling back.. I was unaware that those four files were inadvertently included in the fileset, and I could not recreate the issue. So rolling back and starting over is the best way to see what is occurring..Quote:
Originally Posted by GumboStandards
Actually if you have any of the SQL generated by those four files, you really do need to remove ALL of the Edit Orders DB entries, remove those four files, log into your store, re-upload the edit_orders_v4.0.1\1_Base_Files\YOUR_ADMIN_FOLDER\includes\auto_loaders\config.e o.php file and then click any link to properly re-run the install..Quote:
Originally Posted by GumboStandards
Just so it's clear for others following this post I WILL NOT post a direct link to anything available on my site on this forum. (besides I think it's pretty clear anyway where to go once you are on my site:blush:) I will also be asking the admins to remove all the direct links you've posted as well.. Now.. Let me clarify WHY..Quote:
Originally Posted by GumboStandards
There is a REASON why I WILL NOT post a direct link to anything available on my site on this forum.. there is a reason why I direct people to the link in my signature.. (and no I don't know that all browsers don't display the signatures on this forum.. how would I know this??) It is AGAINST the rules to post links or support modules that are NOT available in the Zen Cart downloads.. I ONLY made this add-on available on my site because I am a tad BUSY right now with work and projects.. I need to finalize the readme file BEFORE I submit this to the Zen Cart downloads. However, I KNEW folks were looking for this update.. So I put it up on my site for those folks who can get away with the down and dirty install instructions in the readme and don't need the fully vetted/edited readme right now. Once I submit this to the free-downloads (and I WILL do this as soon as I finish the readme this week), it will no longer be available on my site..
Hope that helps clear things up..
How do you add a new downloadable product to an order? I can't figure that out.
How to add a product has not changed (covered in the readme), but I don't know if adding a downloadable product will necessarily make the download available to the customer.. You will have to test this and let us know..Quote:
Originally Posted by jmsnyder23
Diva - I have a quick question. When a customer places an order that includes a discount coupon ($2.00 off for example), when I go back in and edit the order, sometimes the discount coupon gets reversed and added to the order total instead of being subtracted. I've noticed that happens only if I add an item to an order. If I make any other sort of change (delete item, edit shipping cost, etc.) the discount remains correct. Any idea on why this might be happening? It's no rush or anything on this. What I've been doing is just erasing the discount coupon, entering into the line below where it was and updating and then it works fine. I'd like to eventually eliminate that step though. :)
The changes to Edit Orders I have been involved in have been in the realm of cosmetic/esthetic changes, MINOR functional glitches/fixes, and integration with often asked about mods (namely Super Orders).Quote:
Originally Posted by laurelsstitchery
Meaning??
Well honestly I've made VERY few changes to the core code that drives Edit Orders, and I won't pretend that I know how to fix some of the MANY THINGS that's wrong with it.. otherwise I woulda tried to address the KNOWN issues I have posted about. :laugh: I'll take a look, but don't hold your breath hoping I'll know how to fix this..:laugh:
:laugh: Like I said, no big deal. :) I definitely won't hold my breath! :laugh:Quote:
Originally Posted by DivaVocals
Please don't an anbulance on a Sunday drive will get there faster..:laugh:Quote:
Originally Posted by laurelsstitchery
Thank you, Diva! I was wondering why the convoluted procedure. I realized the mod hadn't been approved yet by "Zen Cart, Inc." but was unaware of the link rules, which is/was a bit baffling, but I am sure the reasoning behind it is sound. Namely, that I totally agree that once a mod is in Zen Cart's downloads area, no links to it existing outside should exist (or at least the mod should remove it from wherever) and managing the links to the "beta"/external version posted in the forum would be a nightmare. This also clears up why Edit Orders 2 is separate from Edit Orders 3 and why Edit Orders 4 will be separate from Edit Orders 3.Quote:
Originally Posted by DivaVocals
Thanks again for all that you do for Zen Cart. I've been running across other mods of yours that I may be putting into use in the future. Your readmes and installation procedures make things a step or three above many other mods out there.
You're welcome.. :smile:Though I wouldn't call directing people to my site versus a direct link convoluted.. It's pretty clear when you get there how to get to the downloads, and the add-ons are all clearly named/labeled. Going forward, if I post an add-on on my site pre-submission I will continue to simply direct people to the link to my site in my signature. So far there's been no problems with folks finding things..Quote:
Originally Posted by GumboStandards
As for the rules... The reasons have been made very clear.. the Zen cart admins do not want to allow this forum to be used to support add-ons which are not available in the downloads section. (the rules for the forum are clearly posted) There seems to be a LITTLE wiggle room for "beta" or "pre-release" versions. So when it seems appropriate I will continue to post pre-submission add-ons on my site, but if the admins direct me to stop this, then trust me I am NOT going to get banned from this forum over ANY free download.
As for why the various Edit Orders versions are separated, the reason there is quite simple too (and I have posted these reasons before). They are separated because they are meant for different versions of Zen Cart, and SHOULD be seperated so it's CLEAR for folks when they download it that they are for different versions of Zen Cart. Hence the major version number change (versus a minor version number change) Edit Orders 2 was NEVER hosted on the Zen Cart site. struner (a LONG TIME maintainer of the add-on) was hosted it on his site for a very long time..
I appreciate that..:smile: Though honestly all I've done is tidied up some stuff and made better user docs.. the folks who've helped me with some of these updates truly deserve the REAL credit!!!:yes:Quote:
Originally Posted by GumboStandards
If the code above works (and I haven't tested it to know if it resolved the issues it was supposed to resolve) I believe that the code below is the better way of going about this.. I haven't tested this and I'll need someone to grade my homework and let me know if I got this right.. It should avoid anyone having to hard code in table names and language IDs. (which the posted code does and is not recommended) I've included the approximate line numbers to make finding things easier..Quote:
Originally Posted by abcisme
in YOUR_ADMIN_FOLDER/edit_orders.php
Around line 2267 find:
Replace with:PHP Code:// ############################################################################
// Get List of All Products
// ############################################################################
$result = $db -> Execute("SELECT products_name, p.products_id, categories_name, ptc.categories_id FROM " . TABLE_PRODUCTS . " p LEFT JOIN " . TABLE_PRODUCTS_DESCRIPTION . " pd ON pd.products_id=p.products_id LEFT JOIN " . TABLE_PRODUCTS_TO_CATEGORIES . " ptc ON ptc.products_id=p.products_id LEFT JOIN " . TABLE_CATEGORIES_DESCRIPTION . " cd ON cd.categories_id=ptc.categories_id ORDER BY categories_name");
Around line 2371 find:PHP Code:// ############################################################################
// Get List of All Products
// ############################################################################
$result = $db -> Execute("SELECT products_name, p.products_id, categories_name, ptc.categories_id FROM " . TABLE_PRODUCTS . " p LEFT JOIN " . TABLE_PRODUCTS_DESCRIPTION . " pd ON pd.products_id=p.products_id LEFT JOIN " . TABLE_PRODUCTS_TO_CATEGORIES . " ptc ON ptc.products_id=p.products_id LEFT JOIN " . TABLE_CATEGORIES_DESCRIPTION . " cd ON cd.categories_id=ptc.categories_id where pd.language_id = '" . (int)$_SESSION['languages_id'] . "' ORDER BY categories_name");
Replace with:PHP Code:// Get Options for Products
$result = $db -> Execute("SELECT * FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa LEFT JOIN " . TABLE_PRODUCTS_OPTIONS . " po ON po.products_options_id=pa.options_id LEFT JOIN " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov ON pov.products_options_values_id=pa.options_values_id WHERE products_id='$add_product_products_id'");
PHP Code:// Get Options for Products
$result = $db -> Execute("SELECT * FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa LEFT JOIN " . TABLE_PRODUCTS_OPTIONS . " po ON po.products_options_id=pa.options_id LEFT JOIN " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov ON pov.products_options_values_id=pa.options_values_id WHERE products_id='$add_product_products_id' AND pov.language_id = '" . (int)$_SESSION['languages_id'] . "' AND po.language_id = '" . (int)$_SESSION['languages_id'] . "'");
Just tested and this does work. I knew there was a better way of doing it, but with limited knowledge, I did the best I could! Thanks for sorting it out properly! :)
Quote:
Originally Posted by DivaVocals
I really didn't do much.. You are the one that posted the changes in code that were needed and where in the code to make the changes (I sure as he!! didn't know that much!!:laugh:) Thanks for confirming the change I posted works.. I''ll bundle it into the final release..Quote:
Originally Posted by abcisme
Any update or solution for this debug error? I receive exactly the same too.Quote:
Originally Posted by buildingblocks
Thanks
Ok so I've followed the directions for 4.0.2 from your site 3 times. Each time, I get notification that the install was successful (I completely uninstalled it each time when trying again), however when I click on Customers -> Orders, I get a blank page. This blank page that shows up is completely blank with no coding behind it at all (right click -> View Source). I have no other mods to orders or any other admin files that Edit Orders uses.
Suggestions on where I should be looking?
Blank page = errors..Quote:
Originally Posted by justynp
check your cache folder for error logs.. you need to post the error message.. (most are clear as to what the issue is so you may figure it out after seeing the error log)
Forgot about those! I will take a peek.Quote:
Originally Posted by DivaVocals
Ok so it's this line
Saying that the file doesn't exist, and it doesn't... There's an order_status.php but it contains nothing for emailing.Code:require(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . 'order_status_email.php');
Just a quick reply. I commented out that line and it now works. Not sure what that require is for since the email portion of the order system is integrated into another Language define file...
Great plugin though! It will be very helpful for us :)
It was included an error.. You can delete this line altogether.. I fixed it on the version on my local server, but did not update the package on my site.. I just uploaded the correct version to my site.. The corrected version also includes the changes abcisme posted a few weeks ago so that attributes display in the correct language.Quote:
Originally Posted by justynp
This might be the solution.. Apparently the same issue is a part of Super Orders v3.x
http://www.zen-cart.com/showthread.p...51#post1112251
HTH
Quote:
Originally Posted by picandnix
Sorry folks, but I have been slammed and have had absolutely NO TIME to finish the readme..http://www.zen-cart.com/images/smilies/blush.gif I am working on finishing the readme editing, but it is a SLOW process.. So for now if you want Edit Orders 4.0 for Zen Cart v1.5, it is available on my site. (link in siggy)
As SOON as I finish the readme (hoping for mid August), I will submit it to the downloads, start a new support thread, and Edit Orders will no longer be available for download from my site.
Thanks for your patience..
Quote:
Originally Posted by DivaVocals
Quote:
Originally Posted by DivaVocals
Thank you kindly for that, I haven't tried the fix yet but thank you in advance.Quote:
Originally Posted by DivaVocals
Sure.. Just an FYI, I found that post by searching the forum for the error message you were getting.. Also I don't know if this fix works.. but it's the only thing I found similar..Quote:
Originally Posted by picandnix
It works, thank you very much :hug:Quote:
Originally Posted by picandnix
Hello, it seems that creating a new Admin profile, and then logging in with that profile restricts access to editing orders. When I am in Admin/Customers/Orders and click on "edit" from a particular order, I get the "Sorry, your security clearance does not allow you to access this resource" message. Is there a workaround to this? I need to create new profiles to protect clients from themselves, you know, from screwing with important settings (I assume the main reason why Admin Profiles was integrated into ZC 1.5).
I've searched frantically and can't find a thing. Oh yeah- this is my first post. Hello everyone.
Welcome to the Zen Cart forum, @InkVine. From a superuser account (your main admin account), you can go to admin access management-> admin users to figure out the profile of your other account. Then go to admin access management->admin profiles, and edit that profile, and check the box for edit orders.
Hey swguy, thanks for the response. I have done all that. I don't see a check box for edit orders. I even went so far as to creating a new profile with all the check boxes checked (essentially creating a second superuser). Access denied. The only boxes that i have under CUSTOMERS is "Customers, Orders, Group Pricing, Invoice, Packing Slip". Is there supposed to be a check box? I have even uninstalled and then re installed Edit Orders v3.03 (data base files & server files).
Whoops! I think I should point out that two things:
1) I accidentally put v4.0 in the subject of my post. I'm using v3.0.
2) Edit orders works perfectly when logged in as a superuser.
I've got a metting with a client tommorow, so if anyone has a workaround (temporary, even frankenstienish, I can fix it properly later) just so I don't confuse my client.
thank you, thank you!
Read back through this thread.. (alwys a good idea BEFORE install any add-on) v3.0 isn't compatible with v1.5..Quote:
Originally Posted by inkvine
Heh. didn't see that. I'm usually pretty good at that. Well, I did install the version 4.0.2 from your site, thanks for all the hard work, I WILL donate after this project is finished (it's only fair). Unfortunately, nothing has changed, except that comment bug (so at least that means version 4 was installed correctly). So still no access to editing an order with any other profile other than a superuser. Any thoughts?
I don't know what happened but i have my Edit order which isn't working anymore... i have added a script called: performance
and now when i hit edit order that give me this url:
http://www.storeurl/store/MYADMINFOL...02&action=edit
at the end and bring me to my store main page.. i have uninstalled and install it again 3 times and still nothing.. the url look weird once i have uploaded the order.php in my admin folder?
Also i'm on 1.3.9 as i'm slowly upgrading my huge store.. :(
don' t know what to do :(
It looks like you clobbered includes/filenames.php and removed the define for the Edit Orders page.
swgy what do you mean? cuz when i see this problem i just removed the edit order from my store and did a new install, did it 3 times, ans still the same problem.. :(
the path change only when i upload the order.php in the admin folder ...
Nope.. would have to test you particular scenario to see if I can replicate your result. Been a bit tied up so I'm not sure when I'll be able to test this out.. hoping someone else has some ideas in the meantime...Quote:
Originally Posted by inkvine
Quote:
Originally Posted by swguy
what he is saying is that (based on your initial post) you've installed something which probably modified some of the same files used by Edit Orders. You have inadvertently removed code Edit Orders needs. That is why you get the odd URLs. The odd URL means that required code in another file is missing.Quote:
Originally Posted by lilly06
Please try re-doing your Edit Orders install. Please be sure that when installing other add-ons which modify the SAME files as other add-ons you've installed that you use a file comparison program as we suggest in the readme file for Edit Orders..
Thank you so much for answering me , well i use zencart since 3 years, and the module performance has been installed by the creator and no files in common and no rewritten files as i just checked..
as i use your module edit order daily!! i love it! and just installed it in a new zencart with 1.5 this time..
Hope i can fix this ..
Quote:
Originally Posted by DivaVocals
well i just backup my admin before the performance module, and the edit is working again, so i 'm going to contact the script maker to see what was the problem...
thanx again for help!
Quote:
Originally Posted by lilly06
If you are saying the performance module author installed the performance module I would venture to say that he removed or modified files used by Edit Orders and caused the issue you had.. (see Scott's original reply to you)Quote:
Originally Posted by lilly06
I tried to install Edit Orders as instructed.
I did get the message that the program successfully installed. However I get a blank page going into "Orders"
The Debug error checkers says
[22-Aug-2012 09:59:14] PHP Warning: require(includes/languages/english/order_status_email.php) [<a href='function.require'>function.require</a>]: failed to open stream: No such file or directory in /home/XXX/public_html/XXXX/includes/languages/english/orders.php on line 10
[22-Aug-2012 09:59:14] PHP Fatal error: require() [<a href='function.require'>function.require</a>]: Failed opening required 'includes/languages/english/order_status_email.php' (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/XXXX/public_html/XXXX/includes/languages/english/orders.php on line 10
require(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . 'order_status_email.php');[/QUOTE]
line 10 in admin/includes/languages/english/orders.php
Delete the line.. (BTW, the forum code tags work better when quoting code)Quote:
Originally Posted by milobloom
GREAT ADD-ON. I have a client who wants to know when they edit an order - it puts a Modified Order * next to the information...is this at all possible? Am I missing something?
It's software.. Nearly anything you need it to do is possible.. However, this requires some modifications to Edit Orders to achieve.. I don't know what specifically is required to add this specific functionality, but perhaps another community member has some ideas they wish to share.. Your other option is to hire a developer to make these changes for you..Quote:
Originally Posted by vandydavid
Just installed edit orders 4.02 into my test environment. The installation went very smooth!
I would recommend removing the "Thumbs.db" files from image locations in your zip file (maybe a little picky) :D
I have found a few minor issues related to adding products to an existing order. I've attached a patch file of changes I needed to make to admin/edit_orders.php. If I find any other bugs during my testing and integration (with some custom pricing modules), I'll pass any fixes I make your way.
Attachment 11036
Not a "official" package yet so not a big deal that the "Thumbs.db" files are there.. They would of course be removed from the final package (when I finally find time to make that happen)Quote:
Originally Posted by lhungil
Your patch would be even more helpful if you could explain the issues you found and at a high level at least walk through how you resolved them.. This way I can do my own testing to see if I too can replicate the problem before applying any fixes to my package..
I figured out a solution, maybe not the best one.
In the file:
/mallet_2012/includes/init_includes/init_admin_auth.php
Look for the lines that are around line 50
if (!in_array($page, array(FILENAME_DEFAULT,FILENAME_ADMIN_ACCOUNT,FILENAME_LOGOFF,FILENAME_ALERT_PAG E,FILENAME_PASSWORD_FORGOTTEN,FILENAME_DENIED,FILENAME_ALT_NAV)) &&
!zen_is_superuser())
{
if (check_page($page, $_GET) == FALSE)
{
zen_redirect(zen_href_link(FILENAME_DENIED, '', 'SSL'));
}
}
Add-
Before section: if (basename($_SERVER['SCRIPT_FILENAME']) != 'FILENAME_ORDER_EDIT') {
after section:}
Keep in mind that someone whom may not be authorized, may be able to access the Edit Order modules. If i come up with a more secure version I will post it here.
Larry
and this reason is why this should not be implemented..Quote:
Originally Posted by bislewl
When I get some time I'll look at this.. May be a while for me to look at this as I am MAD busy..
So if anyone has right solution which maintains the admin profile securities, please post..
Very basic, thus the patch file. Two lines were changed.Quote:
Originally Posted by DivaVocals
a) Fixed the name of a variable to be compatible with *nix hosts. Basically a case-sensitivity change. Fixes a error with a SQL check prior to updating order totals (tax or no tax).
b) Added a check to make sure the selected category (when selecting a product to add) has products. If it does not, the page stays at step 1 of adding a product. Removes extraneous warning and errors in log files. Can probably be improved upon by using the message stack or some such to provide active feedback.
Good stuff!!! Thanks for the patch.. I'll have a looksee this weekend if I can squeeze a little time out and update the files on my site..Quote:
Originally Posted by lhungil
I've taken a look at this issue and believe I have a fix. The configuration page was registered as an admin page, but the actual edit_orders page was not. On the profile permissions page it will add a new admin page under "modules" to control access to the file "edit_orders".
Patch Details:
a) Added a new definition. Required to support an additional "admin page".
b) I've added a snippet to the init file. First it checks for the presence of a specific function added in Zen Cart 1.5. If present, it checks to see if the admin page has already been registered. If not already registered, it finds an appropriate page sort order and registers the new "admin page".
I've taken the liberty of moving the edit orders configuration admin page code into the block created in b). More of a personal preference, I prefer doing a check to undoing the registration. Feel free to move the code back outside if desired.
Attachment 11044
Address Editing
This works really well from what I have observed. During integration I have noticed Edit Orders directly modifies the addresses in the order table. This makes complete sense as changes a customer may make to their address book will not affect the address information supplied for the order (also supports better order address history).
Request
However it would be "nice" to have the option of selecting an address from the customer's address book to overwrite these fields. This would save some administrative time if the customer contacts the store to change the shipping address of the order (prior to the order shipping). I'm sure there are a few other cases where this could be useful.
Scenario
- Customer (or admin) places an order.
- Customer receives confirmation email and notices they have the wrong address.
- Customer updates address in their address book.
- Customer contacts store and requests the order be sent to the updated address.
- Order Manager updates shipping address on the order (if not already shipped).
Notes
This is just a feature request, not a bug / issue. The current Edit Order module already supports changing the addresses for the order by manually typing in the new address information. It would just be nice in some cases to also be able to select the new address from the customer's address book.
After taking a little longer look, the patch "a (edit_orders_defines)" is not needed and is already included correctly in this module. Only patch "b (init_eo_config)" is needed to correct the admin profile issue.
I will be adding a new patch shortly with corrections. Please disregard Edit-Orders-4.02-patch2.zip
Alright, here is the admin profiles patches with corrections. Two files were modified in this patch. I've included both the patches and copies of the files I used when testing the changes.
Enjoy!
So I have searched several ways in the thread and haven't found if the attributes bug from the older version was ever fixed. This is the bug where if you are adding a new product and it has attributes and the "use specials/sale price" box is checked it will add the original price plus the sale price to give the wrong price.
None of the tax or attribute bugs were addressed at all.. In my announcement post I list out the fixes/changes made..Quote:
Originally Posted by lankeeyankee
I saw that but also noticed other folks chipping in bits here and there so thought I'd search first and ask after. Thanks, guess I will have to finally have a crack at it, I'm training new people on certain functions, editing orders being one, and it's a pain to have to teach them about this bug and workaround and that bug and workaround....:blink::shocking::laugh:
Nope.. I had someone who volunteered to work on the attributes bugs for this release.. He started like gangbusters, then sadly his work got sloppy and he clearly wasn't testing the code he was writing nor did he seem to have a grasp on the attribute issues with this add-on (despite my providing LOTS of documentation and mockups). He eventually bailed out of helping with this update and left me with the MESS of having to excise all his half working code out.. **sigh** It is WAY over my head to fix the attributes and tax bugs with Edit Orders.. So I targeted the low hanging fruit of making sure this add-on was v1.5 ready and a few minor changes that I could easily make..Quote:
Originally Posted by lankeeyankee
OK, I *think* I have the attributes bug fixed when adding new products with attributes. At least it's working for me with a variety of scenarios, but there could be problems from the way other users have their attributes set up. Mine are all priced by attributes, this may or may not affect this functionality. So, hopefully some folks will try this out and report back their results.
To reiterate, the problem I was having was when adding products with attributes and the products are using the sale/special price and that checkbox is selected on the finial step when entering quantity. It was adding up prices incorrectly, really large prices as if combining the sale price with the regular price.
Here's what I did:
in admin/edit_orders.php on line 1294 of an unaltered file find:
and change it to this:PHP Code:or die("Failed to connect database: ");
while($row10a=mysql_fetch_array($result10a, MYSQL_NUM)) {
if ($row10a[2] == 1 && $_POST[applyspecialstoprice])
$newpricechange = zen_get_discount_calc($add_product_products_id, $row10a[3], $row10a[0], $add_product_quantity);
If anyone else wants to try it out and let me know what you experience I will try to fix any problems that arise. Hopefully it won't cause any problems and it will all work the way it should in every scenario.:smile:PHP Code:or die("Failed to connect database: ");
$new_attributes_price= '';
$attributes_values = $result10a;
$attributes_price_final = zen_get_attributes_price_final($attributes_values->fields["products_attributes_id"], 1, $attributes_values, 'false');
$attributes_price_final_value = $attributes_price_final;
$attributes_price_final = $currencies->display_price($attributes_price_final, zen_get_tax_rate(1), 1);
if ($attributes_values->fields["attributes_discounted"]) {
$new_attributes_price = zen_get_attributes_price_final($attributes_values->fields["products_attributes_id"], 1, '', 'false');
$new_attributes_price = zen_get_discount_calc($add_product_products_id, true, $new_attributes_price);
if ($new_attributes_price != $attributes_price_final_value) {
$new_attributes_price = $currencies->display_price($new_attributes_price, zen_get_tax_rate(1), 1);
} else {
$new_attributes_price = '';
}
}
while($row10a=mysql_fetch_array($result10a, MYSQL_NUM)) {
if ($row10a[2] == 1 && $_POST[applyspecialstoprice])
$newpricechange = $new_attributes_price;
scratch that, it only works if there is one attribute with a price, if you have more than one attribute that adds to the price this won't work. This is what happens when you have been working on the computer all day and you start digging into code after 1am and forget the basic principals of testing thoroughly before opening your big mouth.:blush::laugh:
I will give it another whirl tomorrow when I am fresher and more on the ball.:smile:
:laugh: I get it.. go to bed.. I have a software demo to conduct tomorrow morning and I need to hit the rack myself..Quote:
Originally Posted by lankeeyankee
I'm currently working on the handling of attributes, not sure how far I will get in the process, but just wanted to let anyone else who may be working on these know. Maybe we can pool our efforts?
The first part of attribute handling I am tackling are improvements to filter out attributes not used for pricing. My current changes appear to be correctly filtering out read only attributes not used for pricing during "add products (step 3)". Still testing the changes and verifying it does not break anything in my test environments.
Next I will attempt to modify the pricing code to parse the submitted information, convert it to the format expected by Zen Cart 1.5 functions, and then use the pricing functions for products. This should hopefully provide a good starting point for further fixes and enhancements to the handling of product attributes.
As always, once I start posting more of my patches, I will welcome others to test the changes and provide constructive feedback.
You are my hero!!!:clap: Sounds like you are tackling some of the old attribute issues that have PLAGUED this add-on forever.. AWESOME... Gotta take a look at the changes you posted already and bundle them into the version available on my site.. I am hoping to kick loose some of the conversion work that has kept me tied up and finally get the readme updated and this version SUBMITTED officially..Quote:
Originally Posted by lhungil
If you are going to filter out attributes not directly related to pricing you are still going to include them in the product addition? I am not sure that this is really necessary to get this working correctly and you want to include all attributes when adding a product. The sticking point here is in admin/edit_orders.php on line 1296:Quote:
Originally Posted by lhungil
Start making changes here and you change the pricing results for sales and specials prices. In looking at the rest of the code that includes this variable I haven't cracked the change to make it work right. What is happening is if you have a product priced by attributes and there are two or more attributes with contributing prices it will add the 1st attribute price, the 1st attribute price again with the 2nd and 3rd, 4th etc. If there are more than 1 attribute but the 2nd and on do not add to the price then my initial change works correctly and the sale price is displayed. So we need to just figure out why it's adding the 1st price twice when the 2nd and beyond contribute to the price and then we're sorted and everything is working fine.PHP Code:if ($row10a[2] == 1 && $_POST[applyspecialstoprice])
$newpricechange = zen_get_discount_calc($add_product_products_id, $row10a[3], $row10a[0], $add_product_quantity);
I haven't had any free time lately to go back and look at this again since my last, fruitless stab. There is somewhere that is either adding $row10a[0] - which is the attribute price returned from the db array - as well as $newpricechange, or is calling $newpricechange twice and adding them together. I will have free time this weekend since my family will be out of town and I can work without distractions and I am determined to get this sorted since it's an enormous time waster the way it is and we use it daily.
If I may interject here.. Given my skillset, I certainly can't contribute any code to this effort.. :smile: However, I do have some usability observations to make.. I think any code which affects attributes needs to be planned out so that one change doesn't have an inadvertent side effect for shop owners.
IMHO using blanket methods to exclude attributes will lead to an undesired effect. To exclude attributes that are truly "optional" product attributes, I think there needs to be a means for a shopowner to explicitly flag/mark which attributes they want excluded from the add/edit products function.
One of my client's paid to have a v1.5 ready version of Stock by Attributes which includes a similar feature. This allows him to specify which attributes will be excluded from stock variants.
OK, I *think* I have the attributes issue sorted. If someone else would like to test it out in as many scenarios as possible to double check this works 100% correctly please let me know the results. I don't use one time charges, text attributes, price factors, or quantity discounts so I haven't tested for any of these.
In admin/edit_orders.php on line 1364 change:
to this:PHP Code:$Query = "insert into " . TABLE_ORDERS_PRODUCTS . " set
orders_id = $oID,
products_id = $add_product_products_id,
products_model = '$p_products_model',
products_name = '" . str_replace("'", "'", $p_products_name) . "',
products_price = '$product_price_woa',
final_price = '" . ($product_price_woa + $AddedOptionsPrice) . "',
products_tax = '$ProductsTax',
products_quantity = $add_product_quantity,
onetime_charges = $AddedOptionsPrice_OneTime;";
So far, if something is on special the price is correct with multiple attributes selected. This is with some attributes being discounted when on sale/special and some not, all attributes being discounted, and even if it's on sale/special but you uncheck the "Use Specials/Sales Price" box in step 4 of adding the product then the non-discounted prices are used correctly.PHP Code:if ($_POST[applyspecialstoprice] && zen_get_products_special_price((int)$add_product_products_id) && $AddedOptionsPrice != 0) {
$Query = "insert into " . TABLE_ORDERS_PRODUCTS . " set
orders_id = $oID,
products_id = $add_product_products_id,
products_model = '$p_products_model',
products_name = '" . str_replace("'", "'", $p_products_name) . "',
products_price = '$product_price_woa',
final_price = '" . ($products_details["final_price"] + $AddedOptionsPrice) . "',
products_tax = '$ProductsTax',
products_quantity = $add_product_quantity,
onetime_charges = $AddedOptionsPrice_OneTime;";
} else {
$Query = "insert into " . TABLE_ORDERS_PRODUCTS . " set
orders_id = $oID,
products_id = $add_product_products_id,
products_model = '$p_products_model',
products_name = '" . str_replace("'", "'", $p_products_name) . "',
products_price = '$product_price_woa',
final_price = '" . ($product_price_woa + $AddedOptionsPrice) . "',
products_tax = '$ProductsTax',
products_quantity = $add_product_quantity,
onetime_charges = $AddedOptionsPrice_OneTime;";
}
Hopefully this won't need any more changes! But I am not holding my breath!!:laugh:
The code changes I'm working with are not to filter out based upon guesses. I'm using the existing functions (used by zen cart when adding a product to an order) and running the attributes through the same filters (which are based on if the product uses attributes for pricing, if the attribute is read only, settings in the admin configuration, and several other factors).
Pricing is currently handled by Zen Cart based upon the attributes added to an order. You can price products by attributes (no product price) or by a combination of base / special pricing and attribute pricing. To take all of this into consideration and have the pricing stay consistent with how Zen Cart handles pricing, we need to use the Zen Cart functions for pricing and attribute handling.
The current code in Edit Orders uses it's own custom code for pricing and order totals instead of integrating with the functions built into Zen Cart. I have already come to the conclusion I will need to remove all the existing attribute handling code from Edit Order and start over. I also want to remove all the direct MySQL calls, so future porting to MsSQL, PostgreSQL, or even SQlite is more feasible.
Doing a complete rewrite of the attribute and pricing code will also ensure anyone who has made changes (or has add-ons) to the Zen Cart pricing functions will have the correct prices used when adding a product via the administrative interface. This change should also make upgrading in the future far simpler, since the code will be using internal Zen Cart functions as much as possible.
The downside to the changes I am working on... Well a complete rewrite of the sections used to handle attributes is not a small undertaking... It will take some time and testing... I will not be able to release portions of the fixes to someone running on a different code base, since changes impact other areas of the code. What I am doing is pretty much a fork of the existing (and very awesome) Edit Orders 4.x code base.
It may be best (leaving the decision up to DivaVocals of course), to release 4.x before any of my attribute based changes are complete.
The portion of the code I started with (display and selection of attributes when adding a product) are close to complete. I've added integration with existing Zen Cart configuration variables, filtering based upon the same code used by Zen Cart (when adding a product to an order and fields used on the add product page), and handling for attributes of types: checkbox, radio, text / textarea, dropdown, and readonly (user-added are treated as readonly). I've not added support for "file" attribute types at this point.
Once I'm done with the display and selection portion, I will be moving into the "price calculation, product price adjust, and adding the product to an order" section. I plan to utilize existing Zen Cart functions as much as possible in this section, and may be including classes from the non admin site to accomplish the end goal - consistent and accurate pricing of the product including attributes.
Now before anyone starts complaining they need to be able to adjust prices... You still will be able to by directly editing the product price, tax, etc AFTER the product is added to the order. Just the "add products" pricing will be consistent with adding a product to the shopping cart or order.
Another aspect I have been tackling is optimization of SQL calls... The old code used a large number of SQL calls to pull in and change information. The same could be accomplished with far less calls. While minor, some of my clients are on hosting which rate limits SQL calls... so changes to lower the number of SQL calls and utilization of caching where appropriate are changes I will be adding (and yes, caching can be turned off). This code should also integrate well with QueryCache, which all of my clients (but not all my test environments) utilize.
Looks like an improvement to me, thank you for submitting. I like the use of one of the built-in Zen Cart pricing functions ;)Quote:
Originally Posted by lankeeyankee
I am not going to be able to test, as the attribute / pricing code I'm working with no longer looks vaguely similar (and utilizes more of the built-in pricing functions - and the pricing_prefix).
It sounds like the shortfalls of edit orders that I could never address (don't have the skillset to tackle) with regards to pricing, attributes are FINALLY being properly addressed.:clap: I'm assuming that the long standing issues with taxes will be "fixed" as a by-product of the pricing changes?? That would be awesome if it was..
Understood and did not mean to imply that's the direction you were taking at all.. My concern was that filtering needed to not be based on a single setup tis all.:smile: I think what you are doing is WONDERFUL!! There was a volunteer who offered to make these fixes, but they dropped out of the scene leaving me with half working code that I ended up with the unenviable task of having to remove just to get things at least working with the old (albeit flawed) functionality.. So I am happy to see someone taking on these sections of Edit Orders.. It was on my wishlist, but outside of my skillset to complete..Quote:
Originally Posted by lhungil
Based on all the changes you've made, I think that the Edit Orders v4.0 release should be YOUR code with all the RIGHT changes for pricing and attributes in place, and consider the Edit Orders on my site a working beta release.. I'll be happy to update the readme file if you like, but your code is JUST what Edit Orders has needed for a while..Quote:
Originally Posted by lhungil
Quote:
Originally Posted by lhungil
Very excited to finally see some improvements for the better happening here!! :smile:Quote:
Originally Posted by lankeeyankee
Quote:
Originally Posted by DivaVocals
Very excited to finally see some improvements for the better happening here!!:smile:
**nods in agreement** :yes: