Direct Bank Deposit

Hi. I have downloaded and installed the Direct Bank Deposit (Aust) addon. It is showing up as a module, so I have installed it via admin - but it is still not showing as an option at checkout. All of my products are virtual, so I have deleted teh following from includes>modules>payments/dirbankaus.php:

// disable the module if the order only contains virtual products
if ($this->enabled == true) {
if ($order->content_type == 'virtual') {
$this->enabled = false;
}
}

If someone could shed some light on what i might be doing wrong, i'd appreciate it.

You can see the site here: www.mossvaleshow.com.au/zen

thanks
kathy

There is probably something amiss with your zones settings.

I've had this problem myself, and since I don't really care what country/zone people wish to pay from, and apparently I had higher priority issues at the time, I took the 'easy' solution.

---------- locate the code that reads like -----
if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANK_ZONE > 0) ) {
$check_flag = false;
$check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ ................
--------------------------------------------------

And change the $check_flag = false ; to $check_flag = true ;

Cheers
Rod.

Thanks, Rod. Sadly, that hasn't made any difference. Still nothing.

I have the payment module set to zone: "none".

Any thoughts happily received.

Thanks
kathy

Hi Kathy

If am looking at it right now and it should work.

If you are using this version

http://www.zen-cart.com/downloads.php?do=file&id=60

I am the current maintainer of it.

My wife uses the same version (albeit the NZ part), and her store only sells virtual products, We commented out the piece of code you mentioned and virtual products work fine.

If your site is still testing, try adding a new product, not a virtual product, then go to check out with only that product in your basket and see if the option comes up?

I will do a quick test on my test site shortly

Please do report back how it goes or if you have solved the issue. Cheers

Hi Kathy

I have just tested the Aussie version and it works as expected, once this piece of code is removed or commented out

// disable the module if the order only contains virtual products
// if ($this->enabled == true) {
// if ($order->content_type == 'virtual') {
// $this->enabled = false;
// }
// }


You can try making a test account on my test server to check if you wish

http://grumpykiwi.com/

the very first category contains only virtual products

oh my goodness, nigel. you rock. thanks.

kathy

Quote:

---

Originally Posted by Kathy_

oh my goodness, nigel. you rock. thanks.

kathy

---

Gee, and here I was under the impression that you'd already deleted that peice of code... Now where did I get that idea? Oh yeah...

Quote:

---

Originally Posted by Kathy_

. All of my products are virtual, so I have deleted teh following from includes>modules>payments/dirbankaus.php:

// disable the module if the order only contains virtual products
if ($this->enabled == true) {
if ($order->content_type == 'virtual') {
$this->enabled = false;
}
}

---

Anyway, I'm glad it is now working for you, BUT, if you now go back and revert the change I suggested, I'll wager that it will stop working again. The reason being is that the *cause* of the problem has something to do with your zone files.

You need(ed) BOTH changes to make it work. Hmmhpp, I feel like I've been shunned. :laugh:

Cheers
Rod

oh no rod. don't feel shunned. you're probably right. i did delete that part of the code, without improvement. then i made another mysterious change that broke the whole thing - and so reinstalled those files. no doubt if i were more competent, i could tell you if it is a zone issue.

k

@nigelt74

I installed the mod, it is great,but after installing fast and easy checkout, the page not shown, it shows just as
Attachment 10728

could you move the page to previous page, namely, put the information on checkout page,but not confirm page. how will i do to fix it?

With Bank Deposit, the details will be included in the email sent to the customer,
You could possibly add the info to the

includes\languages\english\modules\payment\dirbankusa.php

I think around line 32

define('MODULE_PAYMENT_DIRBANKUSA_TEXT_TITLE', 'Direct Bank Deposit - USA');

try changing it to
define('MODULE_PAYMENT_DIRBANKUSA_TEXT_TITLE', 'Direct Bank Deposit - USA<br/> Acc No: 1234567890<br/> Bank: Acme Banking<br/>Branch: Waikikamookau');

And see if that gets the info onto the right page

And yes i realise i am not pulling the variables from the database, but its school holidays here and I have loud 3 and 4 foot terroroists charging around the house

Is there any way of getting this to work in the UK?

AndyB

you beat me to it there. I'd would like to know how to do this.

Yes, tell me what fields you need for the UK, and I can add it into the next version

Quote:

---

Originally Posted by nigelt74

Yes, tell me what fields you need for the UK, and I can add it into the next version

---

the UK bank direct credit is similar to the US but routing is called sort code 6 digit No: 00-00-00 might need the swift code to not sure I only trade in the uk. someone else might chime in with more info.

Quote:

---

Originally Posted by nigelt74

Yes, tell me what fields you need for the UK, and I can add it into the next version

---

For the UK required;

Account Number -
Sort Code -
Account Name -
Bank -
Reference - (Can this be tied to the invoice number?)

For overseas payment;

Swift code -
IBAN no. -



AndyB

Quote:

---

Account Number -
Sort Code -
Account Name -
Bank -
Reference - (Can this be tied to the invoice number?)

For overseas payment;

Swift code -
IBAN no. -

---

This is incorrect. I will put up a new list when I have worked out the correct listing

Anybody prepared to test the UK version?

PM me, i have had it sitting here a while and thought I may as well put it out there.

Any news of this UK version? Did you get your testing done? Really could do with this!

Nope its sitting on my desktop here, if you are wanting to test it you are most welcome, it should work fine.

Have sent you a PM, happy to test it. How do I get hold of it?

Here is the Version containing the UK one, this will probably be submitted in the next few days, once i have had feedback from UK users Hopefully Attachment 11875

Thanks for that, will install over the weekend and hopefully have some feedback for you early next week.

Quote:

---

Originally Posted by nigelt74

Here is the Version containing the UK one, this will probably be submitted in the next few days, once i have had feedback from UK users Hopefully Attachment 11875

---

Hi Nigel

It works well on my end. Just a question: Since the bank account info is included in the email, is it absolutely necessary to have it displayed during checkout?

Quote:

---

Originally Posted by Thannaree

Hi Nigel

It works well on my end. Just a question: Since the bank account info is included in the email, is it absolutely necessary to have it displayed during checkout?

---

FWIW I only reveal bank account info in the email, never during checkout?

Quote:

---

Originally Posted by dw08gm

FWIW I only reveal bank account info in the email, never during checkout?

---

How do you do that?

Quote:

---

Originally Posted by Thannaree

Since the bank account info is included in the email, is it absolutely necessary to have it displayed during checkout?

---

No, not absolutely necessary, but *I* do a lot of online shopping, often using Direct Bank Deposit, and I get very frustrated/annoyed if the bank details aren't available to me during the checkout process.

Waiting on emails for this info is a PITA, especially if/when the emails take a while to arrive (often up to an hour or more).. Or worse, the emails never arrive at all.

My point being, is you need to make it easy for the customer to pay you, and not have them wait for an email that may or may not arrive.

I have no problems in making my Banking details 'publicly' available for this purpose, after all, people can only make use of them for deposits, not withdrawals.

Just my 5cents worth.

Cheers
Rod

Quote:

---

Originally Posted by Thannaree

Hi Nigel

It works well on my end. Just a question: Since the bank account info is included in the email, is it absolutely necessary to have it displayed during checkout?

---

No its not essential, i have just always done it, simply because emails often end up in junk mail and it encourages the purchaser to to the deposit there and then as the details are in front of them.

To hide the Bank account Details you would go to
includes/languages/english/modules/payment/dirbankuk.php

at line 35 to 45

replace this

PHP Code:

---


  define('MODULE_PAYMENT_DIRBANKUK_TEXT_TITLE', 'Direct Bank Deposit - UK');
   define('MODULE_PAYMENT_DIRBANKUK_TEXT_DESCRIPTION', 
  '<BR>Please use the following details to transfer your total order value:<br><pre>' . 
  "\nAccount No.:    " . MODULE_PAYMENT_DIRBANKUK_ACCNUM .
  "\nSort Code:" . MODULE_PAYMENT_DIRBANKUK_SORTCODE .  
  "\nAccount Name:   " . MODULE_PAYMENT_DIRBANKUK_ACCNAM . 
  "\nBank Name:      " . MODULE_PAYMENT_DIRBANKUK_BANKNAM .
  "\nReference:    Please use Order Number as reference"  .
  "\nSwift/BIC Code:   " . MODULE_PAYMENT_DIRBANKUK_SWIFT . 
  "\nIBAN Number:   " . MODULE_PAYMENT_DIRBANKUK_IBAN . 
  '</pre><p>Thanks for your order which will ship immediately once we receive payment in the above account.'); 


---

with this

PHP Code:

---


  define('MODULE_PAYMENT_DIRBANKUK_TEXT_TITLE', 'Direct Bank Deposit - UK');
   define('MODULE_PAYMENT_DIRBANKUK_TEXT_DESCRIPTION', 
  '<BR> Our account details will be emailed to you once you have pressed the confirm order button below.'); 


---

Thanks Rod and Nigel.

Thanks Rod and Nigel

Nigel - that is what I did.

Rod - I may reconsider my stance in light of your comments.

Just a quick ???

I am not in the USA but in CAN....I have been trying to remove all instances of USA to the wording. No luck as of yet as causes errors. I am wondering what files I would be able to change to remove the USA part and have it read CAN???

I tried the includes/languages/english/modules/payment/dirbankusa.php

Quote:

---

Originally Posted by lnsenterprises

Just a quick ???

I am not in the USA but in CAN....I have been trying to remove all instances of USA to the wording. No luck as of yet as causes errors. I am wondering what files I would be able to change to remove the USA part and have it read CAN???

I tried the includes/languages/english/modules/payment/dirbankusa.php

---

You will need to clone the whole USA mod and in the cloned copy rename every instance of usa to can - including the file names such as dirbankusa.php to dirbankcan.php etc etc

In your example above includes/languages/english/modules/payment/dirbankusa.php the clone needs to read includes/languages/english/modules/payment/dirbankcan.php

Best to carefully read through every single line of every file of the original dirbankusa mod to be sure you have not missed anything.

ok thanks so much I will give it a shot

If you get stuck, let me know as I have just completed a clone of the USA module

Have got it I believe....only issue was after you checkout, it appears prior to getting payment, you need to invoice the customer. I am only in test mode though and do not have all the bank information entered...it may do more once i have all this entered

thankx for the support, muchly appreciated

Quote:

---

Originally Posted by lnsenterprises

Have got it I believe....only issue was after you checkout, it appears prior to getting payment, you need to invoice the customer. I am only in test mode though and do not have all the bank information entered...it may do more once i have all this entered

thankx for the support, muchly appreciated

---

Just bear in mind that the clone uses the USA specific bank details. So, if Canadian banks require other codes then you will need to make necessary amendments.

if you are really desperate use this

Attachment 12558

It may need a bit of tweaking, but should work fine

again tankx so much...I believe mine was working as well....but I will use yours as the file size is different, and doing a file compare all looks good as well...I turst you more....again tankx a ton

Hi
Looks like a great add on but have a question or 2 please
Can I ask how do you know if the money has been placed in your account after checkout ..or is it something you will have to check manually and does it pick up fake details ..
Also have you a test website I can take a peek at if possible

thanks

Quote:

---

Originally Posted by ATSWorld

Can I ask how do you know if the money has been placed in your account after checkout ..or is it something you will have to check manually

---

It provides details only, to customers about your bank account.
Its up to you to check and despatch when they finally pay
Its not real time like poli polipayments(dot)com

Quote:

---

Originally Posted by ATSWorld

and does it pick up fake details ..

---

Not sure what you mean by fake details?

Hi
jees you were quick ..I've installed it anyway and had a look and now see how it works .You get the details from the email..
I use fast easy checkout as well ..... lol about fake I thought they put their details in and sent it to bank :)

Not for me right now but nice useful feature none the less

Is there a way that I can put a logo either before "Direct Bank Deposit" or just after it - on the same line?

Hi,

Yes, there is a way.
Open the file for your payment module.
The file is on the following folder /includes/modules/payment/

Look for the following function
function selection() {

That function returns an array, you should add a new element to the array like this:

Code:

---

                'icon' => '<img src="images/payment_logo.gif" />'

---

Is there a way to turn off/hide the module for a particular product? I can do it for the moneyorder module but cannot see how to do it here.

Quote:

---

Originally Posted by gilby

It provides details only, to customers about your bank account.
Its up to you to check and despatch when they finally pay
Its not real time like poli polipayments(dot)com

---

Have read through the entire thread. It does look like this adds value for some markets. I wanted to confirm, this plugin is used to provide information to a shopper on how they could use an electronic transfer to deposit money directly into a bank account. It doesn't handle the transaction of taking the money from their account and depositing it into the store's account.

Did I understand that correctly?

Quote:

---

Originally Posted by mc12345678

Have read through the entire thread. It does look like this adds value for some markets. I wanted to confirm, this plugin is used to provide information to a shopper on how they could use an electronic transfer to deposit money directly into a bank account. It doesn't handle the transaction of taking the money from their account and depositing it into the store's account.

Did I understand that correctly?

---

That is correct.

I have my sites set up that my bank details are not publicly displayed on the site but are ebing emailed to the customer within the order confirmaton email.

Quote:

---

Originally Posted by frank18

That is correct.

I have my sites set up that my bank details are not publicly displayed on the site but are ebing emailed to the customer within the order confirmaton email.

---

Yeah, I think it was when the discussion turned towards the choice of emailing versus providing on screen that I began questioning why either was considered important, and then caught on that it is this information the customer needed to finish their side of the transaction. (Leads to the thought of needing to balance the books, does one ship before payment is received, invoicing, etc.) But hey if it works to get more business and the customers are happy, as I said works in some markets. Might for us, but wanted to understand from the forum what it's all about. :). Thank you for your time.

Quote:

---

Originally Posted by mc12345678

.... (Leads to the thought of needing to balance the books, does one ship before payment is received, invoicing, etc.) ....

---

I never let stock go out of the house before the crow did what it needed to do, sh.. in the nest! Only when the money is in the bank, the order is shipped.

The only problem with this module is (as I see it) that you need to ask for the customer's bank details in order to issue a refund should anything go wrong with the order.

Quote:

---

Originally Posted by mc12345678

does one ship before payment is received

---

No. That's asking for trouble. HOWEVER, I rarely have any qualms shipping a product if the customer sends a copy of an online bank transfer rather than waiting for their payment to appear in our account, about the only exception being if the order is abnormally large or appears suspicious in some way.

This still carries a little bit of risk, but I have the philosophy that most people are basically honest.

Cheers
RodG

Has anybody placed this information on the invoice and how would you do that
we now have customers that need invoice with goods.

Peter

Quote:

---

Originally Posted by tenthilltoys

Has anybody placed this information on the invoice and how would you do that
we now have customers that need invoice with goods.

Peter

---

Not quite sure what you are asking?
The Invoice will show the payment method as "Direct Bank Deposit"

I can't see that you would need more than this as you wouldn't ship without the payment being processed
So its not informing the customer what bank account to pay it into
The same as if paying by cc the cc details are not on the Invoice.

The bank account details are shown on the "order confirmation email" for the customer to pay into.

We are dealing with government schools who unless we setup new payment gateways (they are not allowed to use PayPal or have PayPal mentioned on the invoice) the invoice with banking details then goes to accounts department to be paid.

Pete

Quote:

---

Originally Posted by tenthilltoys

We are dealing with government schools who unless we setup new payment gateways (they are not allowed to use PayPal or have PayPal mentioned on the invoice) the invoice with banking details then goes to accounts department to be paid.

Pete

---

In that case you will need to modify
admin/invoice.php around lines 136-7 which shows this

PHP Code:

---

      <tr>
        <td class="main"><b><?php echo ENTRY_PAYMENT_METHOD; ?></b></td>
        <td class="main"><?php echo $order->info['payment_method']; ?></td>
      </tr>

---

to add the info that you want on the invoice

Being in NZ, direct bank deposit accounts for about 50% of my sales, and have noticed two problems with it I would like some advice on before I just change it.
1/ There are no reference instructions shown, so it is hard to match payments with orders.
I believe that if I add the last line here that will add it to the email (but I haven't tested it yet because of issue 2)

Code:

---

define('MODULE_PAYMENT_DIRBANKNZ_TEXT_EMAIL_FOOTER',
  "Please use the following details to transfer your total order value:\n\n" .
  "\nAccount No.:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNUM .
//  "\nRouting Number:" . MODULE_PAYMENT_DIRBANKNZ_ROUTING .
  "\nAccount Name:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNAM .
  "\nBank Name:    " . MODULE_PAYMENT_DIRBANKNZ_BANKNAM .
  "\nReference:    ".$zf_insert_id .

---

From my research it seems the order number cannot be added to the checkout_confirmation page as it does not exist yet, and while people have suggested workarounds of getting the last order and adding one, that is an approximation that will fail at some point.

2/ Probably more significant, I had an issue a little while back where someone just deposited money into my account with no details and no order! It could be a worse problem:D, but there was nothing I could do other than wait until someone complained that they didn't get their order and then sort it out. Less than ideal. I was confused about how they had got my bank details without an order, and then it came to me - the customer followed the process to checkout_confirmation, got the bank details, made the deposit and then exited the process, leaving me with no information on the "order" they thought they made.

These two issues suggest to me that the best solution is to have the following process: checkout_confirmation page shows a message like "you have chosen bank deposit, the account details will be shown once your order is confirmed"
checkout_success shows the account details along with the order number.

Does this make sense or have I missed something important (happens a lot:P)

Oh, and thanks to everyone for their work on making this the rest of zencart, it quite simply makes the impossible possible!

Thanks for your advice.
Pat

Quote:

---

Originally Posted by PatClay

From my research it seems the order number cannot be added to the checkout_confirmation page as it does not exist yet, and while people have suggested workarounds of getting the last order and adding one, that is an approximation that will fail at some point.

---

The order number is part of the standard 'Order Confirmation' email - so the order number does in fact exist when the email goes out.

Quote:

---

Originally Posted by PatClay

2/ Probably more significant, I had an issue a little while back where someone just deposited money into my account with no details and no order! It could be a worse problem:D, but there was nothing I could do other than wait until someone complained that they didn't get their order and then sort it out. Less than ideal. I was confused about how they had got my bank details without an order, and then it came to me - the customer followed the process to checkout_confirmation, got the bank details, made the deposit and then exited the process, leaving me with no information on the "order" they thought they made.

---

I only reveal the bank details in my 'Order Confirmation' email - they do not appear on any of my sites. So I never have this issue. They need to complete the order, get the email and there are the details.

This is the wording I have on the 'Order Confirmation' page (mysite.com/index.php?main_page=checkout_confirmation):

Quote:

---

Payment Method:

Direct Bank Deposit - Australia

We will email you our bank details for the transfer of your total order value

Thank you for your order which will be processed as soon as we receive payment in our account.

---

Cheers / Frank

@PatClay

My file includes/languages/english/modules/payment/dirbankaus.php (minus the header..):

Code:

---


  define('MODULE_PAYMENT_DIRBANKAUS_TEXT_EMAIL_FOOTER', 
  "Please use the following details to transfer your total order value:\n\n" .
  "\nAccount No.:  " . MODULE_PAYMENT_DIRBANKAUS_ACCNUM .
  "\nBSB Number:  " . MODULE_PAYMENT_DIRBANKAUS_BSB . 
  "\nAccount Name: " . MODULE_PAYMENT_DIRBANKAUS_ACCNAM . 
  "\nBank Name:    " . MODULE_PAYMENT_DIRBANKAUS_BANKNAM .
  //"\nSwift Code:  " . MODULE_PAYMENT_DIRBANKAUS_SWIFT . 
  "\n\n<b>Thank you for your order which will be processed as soon as we have received payment in the above account.</b>\n");
 
  define('MODULE_PAYMENT_DIRBANKAUS_TEXT_TITLE', '<b>Direct Bank Deposit - Australia</b>');
  define('MODULE_PAYMENT_DIRBANKAUS_TEXT_DESCRIPTION', 
  '<div class="important"><br />We will email you our bank details for the transfer of your total order value<br />' . 
  //"\nAccount No.:  " . MODULE_PAYMENT_DIRBANKAUS_ACCNUM .
  //"\nBSB Number:  " . MODULE_PAYMENT_DIRBANKAUS_BSB . 
  //"\nAccount Name: " . MODULE_PAYMENT_DIRBANKAUS_ACCNAM . 
  //"\nBank Name:    " . MODULE_PAYMENT_DIRBANKAUS_BANKNAM .
  //"\nSwift Code:  " . MODULE_PAYMENT_DIRBANKAUS_SWIFT . 
  '<p><br />Thank you for your order which will be processed as soon as we receive payment in our account.<p><br /></div>');

---

Also try:

Code:

---

"\nReference:    " .$zf_insert_id .

---

instead of

Code:

---

"\nReference:    ".$zf_insert_id .

---

(note the space between " and .$zf_insert_id . )

Suggest you do a test order as customer using the codes above

Cheers / Frank

Thanks for your comments Frank.

My original post was not completely clear about the checkout steps, and they have different names in different areas of the screen (I am using cherry zen, and checkout without account, so that may have caused the differences), so I will try to clarify:
Step 4/5
Page: index.php?main_page=checkout_confirmation
Page title: Order Review

This is where the default setup shows the bank account details, but from what I have read, the order number has not been created yet, until someone clicks "confirm order" and moves to:
Step 5/5
index.php?main_page=checkout_success
Page title: Thank You! We Appreciate your Business!/Checkout Successful
At this point you actually have an order.

I have been doing some experimenting and have some answers, but none of them are good:(.

Code:

---

define('MODULE_PAYMENT_DIRBANKNZ_TEXT_EMAIL_FOOTER',
  "Please use the following details to transfer your total order value:\n\n" .
  "\nAccount No.:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNUM .
//  "\nRouting Number:" . MODULE_PAYMENT_DIRBANKNZ_ROUTING .
  "\nAccount Name:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNAM .
  "\nBank Name:    " . MODULE_PAYMENT_DIRBANKNZ_BANKNAM .
  "\nReference:    " . $zv_orders_id .                     
  "\n\nThanks for your order which will ship immediately once we receive payment in the above account.\n");

---

Doesn't add the order number to the email. I guess that the variable $zv_orders_id is not available to that page. Adding "global $zv_orders_id" doesn't work either.

I could just tell the customer to look it up, but that is a hassle for them and I think the less effort for customers, the more $ for me.

As far as the web pages go, I am thinking something along this line:

Code:

---

define('MODULE_PAYMENT_DIRBANKNZ_TEXT_DESCRIPTION',
  '<BR>You have chosen to pay by direct deposit, our bank account details will be displayed on the next screen when you confirm your order.');

---

And then modify includes/templates/MY_TEMPLATE/templates/tpl_checkout_success_default.php
to check to see if the payment method was DIRBANKNZ and if so display the account details.

Unfortunately at this point I am stuck. I can see several people wanting to do similar things in the forums, but no notes about anyone actually succeeding. I can see arrays with the information I need, but any attempts at getting the information end up with error messages along the lines of "you obviously know nothing about php, arrays or classes, here is a banana, now go away" Or at least they seem that way to me :unsure:

Any pointers would be appreciated.

Pat

I have had partial success:
Change dirbanknz.php to:

Code:

---

define('MODULE_PAYMENT_DIRBANKNZ_TEXT_DESCRIPTION',
  '<BR>You have chosen to pay by direct deposit, our bank account details will be displayed on the next screen when you confirm your order.');

---

add the following to MY_TEMPLATE/templates/tpl_checkout_success_default.php

Code:

---

?>
  <div class="content">
  <?php
  IF ($order_summary['payment_module_code']=="dirbanknz") {
    echo "Please use the following details to transfer your total order value:\n\n" .
  "<BR>Account No.:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNUM .
  "<BR>Account Name:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNAM .
  "<BR>Bank Name:    " . MODULE_PAYMENT_DIRBANKNZ_BANKNAM .
  "<BR>Reference:    " . $zv_orders_id.                     
  "<BR>Thanks for your order which will ship immediately once we receive payment in the above account.<BR>";
  }
  ?>
  </div>
<?php

---

Still no luck on getting the order number on the emails though - several threads have asked about it, but no-one has published a solution.

I have now managed to get the emails to show the invoice number:
Change
languages/english/modules/payment/dirbanknz.php to

Code:

---

define('MODULE_PAYMENT_DIRBANKNZ_TEXT_EMAIL_FOOTER',
  "Thanks for your order which will ship once we receive payment in the account below:\n\n" .
  "\nAccount No.:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNUM .
  "\nAccount Name:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNAM .
  "\nBank Name:    " . MODULE_PAYMENT_DIRBANKNZ_BANKNAM );

---

The reference number will be added after this, so you want the last line to be part of the bank details, not instructions.

Add the following to /classes/order.php (code segment starts at about line 1060.

Code:

---

if (is_object($GLOBALS[$_SESSION['payment']])) {
      $cc_num_display = (isset($this->info['cc_number']) && $this->info['cc_number'] != '') ? /*substr($this->info['cc_number'], 0, 4) . */ str_repeat('X', (strlen($this->info['cc_number']) - 8)) . substr($this->info['cc_number'], -4) . "\n\n" : '';
      $email_order .= EMAIL_TEXT_PAYMENT_METHOD ;
      $email_order .=EMAIL_SEPARATOR . "\n";
      $payment_class = $_SESSION['payment'];
      $email_order .= $GLOBALS[$payment_class]->title . "\n\n";
      $email_order .= (isset($this->info['cc_type']) && $this->info['cc_type'] != '') ? $this->info['cc_type'] . ' ' . $cc_num_display . "\n\n" : '';
      $email_order .= ($GLOBALS[$payment_class]->email_footer) ? $GLOBALS[$payment_class]->email_footer . "\n" : '';
      //addition to add invoice number as reference for bank details
      IF($_SESSION['payment']=="dirbanknz") {
          $email_order.="Reference:    ".$zf_insert_id."\n";
      }

---

It isn't fully tested yet,, and I only send out plain text emails, but it gets the job done for me.

If I have committed major sins in the "right way to do things in Zen Cart" please let me know. I hope that these help someone else.

Pat

Pat, let us know if this displays properly when sending html emails (theoretically it should...)

Cheers / Frank

Sorry Frank, reality is different to theory here.

It doesn't show the reference for the html emails, I am not sure why, but I send out text emails, so it does the job for me. I am sure someone who knows this better than I will be able to fix the html part

Quote:

---

Originally Posted by PatClay

Sorry Frank, reality is different to theory here.

It doesn't show the reference for the html emails, I am not sure why, but I send out text emails, so it does the job for me. I am sure someone who knows this better than I will be able to fix the html part

---

Tested your suggestion - same result. I have another way of implementing this but time restraints are preventing me from doing this right now.

Keep you posted.

I was wondering if there was any way to add the Swift Code to the US version? I know when getting international transfers, a Swift code is needed, which our site does get international wire transfer to pay for some items. If thought about just using the Australian version, but it uses BSB numbers and what not and wouldn't really work. Thanks!

Yep just add the field to the code in both files and make sure you add it to the database insert statement in the file as well

Quote:

---

Originally Posted by RyanEOD

I was wondering if there was any way to add the Swift Code to the US version? I know when getting international transfers, a Swift code is needed, which our site does get international wire transfer to pay for some items. If thought about just using the Australian version, but it uses BSB numbers and what not and wouldn't really work. Thanks!

---

If you have this payment module already installed, uninstall it first but take note of your details as you will need them again later.

Open includes/languages/english/modules/payment/dirbankusa.php

find the 2 instances of

Code:

---

  "\nBank Name:    " . MODULE_PAYMENT_DIRBANKUSA_BANKNAM .

---

just after each of the 2 lines add this

Code:

---

  "\nSwift Code:  " . MODULE_PAYMENT_DIRBANKUSA_SWIFT .

---

Then open includes/modules/payment/dirbankusa.php

find

Code:

---

    $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Bank Account No.', 'MODULE_PAYMENT_DIRBANKUSA_ACCNUM', '12345678', 'Bank Account No.', '6', '1', now());");
    $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Bank Account Name', 'MODULE_PAYMENT_DIRBANKUSA_ACCNAM', 'Joe Bloggs', 'Bank Account Name', '6', '1', now());");

---

and change to

Code:

---

    $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Bank Account No.', 'MODULE_PAYMENT_DIRBANKUSA_ACCNUM', '12345678', 'Bank Account No.', '6', '1', now());");
    $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Swift Code.', 'MODULE_PAYMENT_DIRBANKUSA_SWIFT', '12345678', 'Swift Code.', '6', '1', now());");
    $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Bank Account Name', 'MODULE_PAYMENT_DIRBANKUSA_ACCNAM', 'Joe Bloggs', 'Bank Account Name', '6', '1', now());");

---

In the same file now change

Code:

---

    function keys() {
      return array('MODULE_PAYMENT_DIRBANKUSA_STATUS', 'MODULE_PAYMENT_DIRBANKUSA_ZONE', 'MODULE_PAYMENT_DIRBANKUSA_SORT_ORDER', 'MODULE_PAYMENT_DIRBANKUSA_ROUTING', 'MODULE_PAYMENT_DIRBANKUSA_ACCNUM', 'MODULE_PAYMENT_DIRBANKUSA_ACCNAM',  'MODULE_PAYMENT_DIRBANKUSA_BANKNAM', 'MODULE_PAYMENT_DIRBANKUSA_ORDER_STATUS_ID');
    }

---

to read

Code:

---

    function keys() {
      return array('MODULE_PAYMENT_DIRBANKUSA_STATUS', 'MODULE_PAYMENT_DIRBANKUSA_ZONE', 'MODULE_PAYMENT_DIRBANKUSA_SORT_ORDER', 'MODULE_PAYMENT_DIRBANKUSA_ROUTING', 'MODULE_PAYMENT_DIRBANKUSA_ACCNUM', 'MODULE_PAYMENT_DIRBANKUSA_ACCNAM', 'MODULE_PAYMENT_DIRBANKUSA_SWIFT',  'MODULE_PAYMENT_DIRBANKUSA_BANKNAM', 'MODULE_PAYMENT_DIRBANKUSA_ORDER_STATUS_ID');
    }

---

Upload your changed files and reinstall the mod in your admin.

Let us know if this works for you.

Cheers / Frank

Quote:

---

Originally Posted by PatClay

Sorry Frank, reality is different to theory here.

It doesn't show the reference for the html emails, I am not sure why, but I send out text emails, so it does the job for me. I am sure someone who knows this better than I will be able to fix the html part

---

Managed to get the reference number (= the order id) to show up in the order confirmation email (HTML email) directly below the emailed bank details.

The reference number will only show in the email when Direct Bank Deposit is selected as payment method.

To get this working you need to

1. create a language define file includes/languages/english/extra_definitions/dirbankaus.php asf:

PHP Code:

---

<?php 
/** 
 * @package languageDefines 
 * @copyright Copyright 2003-2006 Zen Cart Development Team 
 * @copyright Portions Copyright 2003 osCommerce 
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0 
 * @version $Id: dirbankaus.php v1.51 $ 
 */ 
// $Id: DIRBANKAUS.php 1975 2014-03-23 02:48:21Z frank18 $ 
// 
 
// this is used to display the order number as reference number in the order confirmation email 
define('EMAIL_TEXT_REFERENCE_NUMBER', 'Reference Number:');  
 
?>

---

2. Open includes/classes/order.php and find this code:

PHP Code:

---

    $html_msg['PAYMENT_METHOD_TITLE']  = EMAIL_TEXT_PAYMENT_METHOD;
    $html_msg['PAYMENT_METHOD_DETAIL'] = (is_object($GLOBALS[$_SESSION['payment']]) ? $GLOBALS[$payment_class]->title : PAYMENT_METHOD_GV );
    $html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']]) && $GLOBALS[$payment_class]->email_footer != '') ? nl2br($GLOBALS[$payment_class]->email_footer) : (isset($this->info['cc_type']) && $this->info['cc_type'] != '' ? $this->info['cc_type'] . ' ' . $cc_num_display . "\n\n" : ''); 


---

Change to:

PHP Code:

---

    $html_msg['PAYMENT_METHOD_TITLE']  = EMAIL_TEXT_PAYMENT_METHOD;
    $html_msg['PAYMENT_METHOD_DETAIL'] = (is_object($GLOBALS[$_SESSION['payment']]) ? $GLOBALS[$payment_class]->title : PAYMENT_METHOD_GV );
    $html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']]) && $GLOBALS[$payment_class]->email_footer != '') ? nl2br($GLOBALS[$payment_class]->email_footer) : (isset($this->info['cc_type']) && $this->info['cc_type'] != '' ? $this->info['cc_type'] . ' ' . $cc_num_display . "\n\n" : '');
    // BOF add invoice number as reference number for direct bank transfer
    if($_SESSION['payment']=="dirbankaus") {
    $html_msg['FOOTER_REFERENCE_NUM_TITLE'] = EMAIL_TEXT_REFERENCE_NUMBER;
    $html_msg['FOOTER_REFERENCE_NUMBER']    = $zf_insert_id;
        } else {
    $html_msg['FOOTER_REFERENCE_NUM_TITLE'] = '';
    $html_msg['FOOTER_REFERENCE_NUMBER']    = '';
        }
    // EOF add invoice number as reference number for direct bank transfer 


---

3. Open email/email_template_checkout.html and find this code:

Code:

---

<td class="payment-footer">$PAYMENT_METHOD_FOOTER</td>
      </tr>

---

Change to:

Code:

---

<td class="payment-footer">$PAYMENT_METHOD_FOOTER<br /><b>$FOOTER_REFERENCE_NUM_TITLE $FOOTER_REFERENCE_NUMBER</b></td>
      </tr>

---

That's it

If you want to use this modification for countries other than Australia you need to change every instance of dirbankaus in the above coding to the corresponding dirbankxxx - eg dirbanknz or dirbankusa or dirbankcan - whatever....

Backup your live files then upload the changed/new files

I have not tested this with text emails. Any feedback relating to text emails is most welcome!

Cheers / Frank

Hi nigelt

I am using your linked version and I have also made the changes like below and I still can't see it on the check out page. It only displays PayPal option. My version zencart is 1.5.3

Can you please suggest what else can be done to make it work. I have also re uploaded files using FTP and still no luck.


---------- locate the code that reads like -----
if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANK_ZONE > 0) ) {
$check_flag = false;
$check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ ................
--------------------------------------------------

And change the $check_flag = false ; to $check_flag = true ;

Just upgraded a site to 1.5.4 running on PHP 5.4.39 and had this error whilst testing:

Quote:

---

[13-Apr-2015 12:09:16 Australia/Brisbane] PHP Warning: Illegal string offset 'id' in /home/XXXXXXX/public_html/includes/modules/payment/dirbankaus.php on line 50

---

To fix this open your /includes/modules/payment/dirbankaus.php

Change

PHP Code:

---

// class methods 
    function update_status() { 
      global $order, $db; 
 
      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0) ) { 
        $check_flag = false; 


---

to this

PHP Code:

---

// class methods 
    function update_status() { 
      global $order, $db; 
       
      if ($this->enabled && (int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0 && isset($order->billing['country']['id'])) { 
        $check_flag = false; 


---

Note that I am in Australia, if you are using the USA equivalent replace DIRBANKAUS with DIRBANKUSA and similar for other countries.

Hi. I'm using Zen Cart v1.5.4. I noticed Direct Bank Deposit - Version 1.5.2 contributed by nigelt74 below is for Zen Cart v1.3.9, v1.5.0 and v1.5.1.

http://www.zen-cart.com/downloads.php?do=file&id=60

I wonder if it's compatible with Zen Cart v1.5.4 as well? If not, is there one that can be used by Zen Cart v1.5.4? Or is there a similar module that can be used instead? I'll be using local bank transfer as the only payment method.

Thanks.

Quote:

---

Originally Posted by jolliejollie

Hi. I'm using Zen Cart v1.5.4. I noticed Direct Bank Deposit - Version 1.5.2 contributed by nigelt74 below is for Zen Cart v1.3.9, v1.5.0 and v1.5.1.

http://www.zen-cart.com/downloads.php?do=file&id=60

I wonder if it's compatible with Zen Cart v1.5.4 as well? If not, is there one that can be used by Zen Cart v1.5.4? Or is there a similar module that can be used instead? I'll be using local bank transfer as the only payment method.

Thanks.

---

It works with ZC 1.5.4 - have used it for years and upgraded 3 stores through the "ranks" (versions) without problems.

Just apply the fix I have posted above and you won't get any errors.

Quote:

---

Originally Posted by frank18

It works with ZC 1.5.4 - have used it for years and upgraded 3 stores through the "ranks" (versions) without problems.

Just apply the fix I have posted above and you won't get any errors.

---

Is it just this fix below I have to apply?

Quote:

---

Originally Posted by frank18

Just upgraded a site to 1.5.4 running on PHP 5.4.39 and had this error whilst testing:



To fix this open your /includes/modules/payment/dirbankaus.php

Change

PHP Code:

---

// class methods 
    function update_status() { 
      global $order, $db; 
 
      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0) ) { 
        $check_flag = false; 


---

to this

PHP Code:

---

// class methods 
    function update_status() { 
      global $order, $db; 
       
      if ($this->enabled && (int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0 && isset($order->billing['country']['id'])) { 
        $check_flag = false; 


---

Note that I am in Australia, if you are using the USA equivalent replace DIRBANKAUS with DIRBANKUSA and similar for other countries.

---

Quote:

---

Originally Posted by frank18

Just upgraded a site to 1.5.4 running on PHP 5.4.39 and had this error whilst testing:



To fix this open your /includes/modules/payment/dirbankaus.php

Change

PHP Code:

---

// class methods 
    function update_status() { 
      global $order, $db; 
 
      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0) ) { 
        $check_flag = false; 


---

to this

PHP Code:

---

// class methods 
    function update_status() { 
      global $order, $db; 
       
      if ($this->enabled && (int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0 && isset($order->billing['country']['id'])) { 
        $check_flag = false; 


---

Note that I am in Australia, if you are using the USA equivalent replace DIRBANKAUS with DIRBANKUSA and similar for other countries.

---

Just noticed "zone" and "billing country" from the codes above. Does it check the customers' addresses before allowing customers to check out using this payment option? Or does it check where I am located? I'm in Hong Kong and my customers are also in Hong Kong. I think there isn't a Hong Kong version of Direct Bank Deposit, is there? I originally planned to use the New Zealand version since the info displayed is the same as that is required for Hong Kong bank account transfers and I would just change the name of the payment method displayed in:

1. order confirmation page by changing:
includes\languages\english\modules\payment\dirbanknz.php:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_TITLE', 'Direct Bank Deposit - NZ');
change to:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_TITLE', 'Direct Bank Deposit - HK');

2. order confirmation email (changing 'Direct Bank Deposit - NZ' to 'Direct Bank Deposit - HK' but haven't found out how to do that yet. some advice would be appreciated.)

I thought I would be able to use the NZ version of this payment module though my customers and I are actually in Hong Kong after making the above changes. Does it work like that? Does it help if I set my Store Zone as “None” and leave my Store Address blank in my Admin Settings?

Thanks.

Quote:

---

Originally Posted by jolliejollie

Just noticed "zone" and "billing country" from the codes above. Does it check the customers' addresses before allowing customers to check out using this payment option? Or does it check where I am located? I'm in Hong Kong and my customers are also in Hong Kong. I think there isn't a Hong Kong version of Direct Bank Deposit, is there? I originally planned to use the New Zealand version since the info displayed is the same as that is required for Hong Kong bank account transfers and I would just change the name of the payment method displayed in:

1. order confirmation page by changing:
includes\languages\english\modules\payment\dirbanknz.php:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_TITLE', 'Direct Bank Deposit - NZ');
change to:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_TITLE', 'Direct Bank Deposit - HK');

2. order confirmation email (changing 'Direct Bank Deposit - NZ' to 'Direct Bank Deposit - HK' but haven't found out how to do that yet. some advice would be appreciated.)

I thought I would be able to use the NZ version of this payment module though my customers and I are actually in Hong Kong after making the above changes. Does it work like that? Does it help if I set my Store Zone as “None” and leave my Store Address blank in my Admin Settings?

Thanks.

---

In its simplest form this mod doesn't check anything at all.
It provides a way to present the website bank details to the customer as a form of payment.
It also doesn't check if the payment was made or anything else.

So, Yes the NZ version should work just fine.

If you do want to restrict it to certain customers or certain countries?
Then that will require more coding

Quote:

---

Originally Posted by gilby

....
If you do want to restrict it to certain customers or certain countries?
Then that will require more coding

---

Restriction to certain countries is done in the admin, you simply set Payment Zone to Australia, Hong Kong or whatever. Does not require extra coding.

Restricting to specific customers - yes, that does require a hack.

Quote:

---

Originally Posted by frank18

Restriction to certain countries is done in the admin, you simply set Payment Zone to Australia, Hong Kong or whatever. Does not require extra coding.

Restricting to specific customers - yes, that does require a hack.

---

Indeed, the country can be set in the admin. (I have been using it for years and haven't needed to change that)

For anyone interested in this payment module, it can be downloaded here

I have installed Direct Bank Deposit 1.5.3 for AUS. Installed and works fine. However in the email order confirmation the font for the bank details etc is like a Times New Roman font rather than Arial like the rest of the email content.

How do you change the font for the DBD text in the order confirmation email?

Quote:

---

Originally Posted by blueskyhigh

I have installed Direct Bank Deposit 1.5.3 for AUS. Installed and works fine. However in the email order confirmation the font for the bank details etc is like a Times New Roman font rather than Arial like the rest of the email content.

How do you change the font for the DBD text in the order confirmation email?

---

Did you install/upload all files in that package?

If so, can you give us a link or screenshot?

Quote:

---

Originally Posted by frank18

For anyone interested in this payment module, it can be downloaded here

---

Mod needs to be upgraded for 154 as per #67.

Since this is a payment module, I am interested to know for the update_status function of includes\modules\payment\dirbankaus.php whether:
1) "delivery" should be changed to "billing"
2) and the code that checks for "virtual products" should be removed

such that replace

Code:

---

    function update_status() {
      global $order, $db;

    if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->delivery['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }

        if ($check_flag == false) {
          $this->enabled = false;
        }
      }
// disable the module if the order only contains virtual products
      if ($this->enabled == true) {
        if ($order->content_type == 'virtual') {
          $this->enabled = false;
        }
      }
    }

---

with

Code:

---

    function update_status() {
      global $order, $db;
    if ($this->enabled && (int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0 && isset($order->billing['country']['id'])) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->billing['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->billing['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }

        if ($check_flag == false) {
          $this->enabled = false;
        }
      }
// disable the module if the order only contains virtual products
//      if ($this->enabled == true) {
//        if ($order->content_type == 'virtual') {
//          $this->enabled = false;
//        }
//      }
    }

---

link to this or a new support thread needs to be added to downloads page for this plugin

Has anyone used this for Canada?

I downloaded this plugin, but Canada is not listed. Is there an update for Canadian users?

I have clients in Canada that use email money transfer successfully. We cloned the zen check/money order payment module in each cart regardless of version and made the edits needed.

Hello, Please I need Ghana version of this module. Am using zencart 1.5.5f and our banking details for local deposit and international deposit are just below.
Account Name:
Routing Number:
Bank Name:
Account Number:
SWIFT Code:

===========================
TO INSTALL
===========================
Copy the includes folder for your country to the root of your Zen Cart store (This section confuses me so kindly direct me as to where to find this root of the store since when I click on my public html and my zencart store, there is an include folder already).

I have Zen cart 1.5.6b with PHP 7.3 and getting the below warning

[23-Jun-2019 13:53:33 Australia/Melbourne] Request URI: /xxxx/orders.php?cID=20525&page=1&oID=20993&action=edit, IP address: 49.197.64.63
#1 dirbankaus->update_status() called at [/home/x/public_htmlxxx/includes/modules/payment/dirbankaus.php:41]
#2 dirbankaus->dirbankaus() called at [/home/xxxx/public_html/gdadmin/orders.php:420]
--> PHP Warning: Illegal string offset 'id' in /home/xxxxx/public_html/includes/modules/payment/dirbankaus.php on line 50.


line 50 dirbankaus.php is below:
$check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");

From my reading I don't think this error can be fixed in line 50. It might need to be fixed in line 41 below?:
if (is_object($order)) $this->update_status();

I'll try and add Japanese bank transfer (local, not international) support to the module and report back.
What I want/need:
1. Bank name
2. Bank code (optional)
3. Account type (current, savings, etc.)
4. Branch name
5. Branch code (optional)
6. Account holder name

I'm going to start hacking at the code, the Indian bank account support appears most close to what I need for Japan (and South Africa for that matter). I'm also interested in supporting multiple bank accounts, not sure from the description whether only one account is currently supported. Will see..

I've hacked up a version for Japan, see attachment. Would work for any other country that has similar settings, or can remove/comment out as needed.
I've made it support up to two extra (total three) accounts, optionally settable in the module settings. Makes the description and text message creation a bit harder, have to stitch it together in the module code rather than just reading in descriptions from the language files.
Hope it is useful, of course any improvements/suggestions by the maintainer or other members would be much appreciated as well.

The fields I defined:
1. Bank name
2. Bank code (optional)
3. Branch name
4. Branch code (optional)
5. Account type (current, savings, etc.)
6. Account Number
7. Account holder name

Updated: added Japanese language file, removed temporary files left in accidentally, arranged columns with spaces.
Note: could not figure out how to delete old upload, really just want to replace the previous one.

I do have a question, could be answered generally, but specifically in regard to this module, where the parameters for accounts are directly entered into the configuration DB: how would it be possible to make the module multilingual?

The configure table does not have a language parameter as far as I can tell. So with the current setup, I imagine one could do it like this, as a workable hack:
1. Add named configuration parameters for extra languages (bank name, branch name, account type, account holder name).
2. Change the code to check the language and choose the right parameter to display.

A more thorough way, which would involve re-writing the module, might be to use specific tables for the module, one or more as required could have language parameters.

Any advice most appreciated. I am happy to work on a long-term solution, but a short-term solution (let's say, for users who only need 2 languages) would be fine for now also.

Hi all,
I've gone ahead and added Japanese versions of bank name, branch name, account type, and account holder name, to the configuration.
And 3 accounts in total.
Attachment 18571

Hi - I wonder if there is any way to have the Direct Bank transfer for Australia behave the same as for New Zealand ?
I do not require or want cheques and money orders - or the email notification - just the "Please use the following details to transfer your total order value"
Many Thanks for any guidance on this issue...

For anyone trying to install this when running later versions of PHP it seems you need to make the following change.

Quote:

---

\includes\modules\payment\dirbank.php

---

PHP Code:

---

 class dirbank {
    var $code, $title, $description, $enabled;

// class constructor
    function dirbank() {
      global $order; 


---

Needs to be changed to

PHP Code:

---

  class dirbank {
    var $code, $title, $description, $enabled;

// class constructor
    function __construct() {
      global $order; 


---

Quote:

---

Originally Posted by Brent

For anyone trying to install this when running later versions of PHP it seems you need to make the following change.

PHP Code:

---

 class dirbank {
    var $code, $title, $description, $enabled;

// class constructor
    function dirbank() {
      global $order; 


---

Needs to be changed to

PHP Code:

---

  class dirbank {
    var $code, $title, $description, $enabled;

// class constructor
    function __construct() {
      global $order; 


---

---

Hmmm... my version I downloaded already has this in it for 1.5.7, it appears to have installed okay except that it's not showing up for my customers in the cart.... anyone got any suggestions as to what I may have missed....?

Have you installed it under Admin Payment Modules so it is showing a green button?

I'm using v1.5.3 Aus version with zc157a in test.

If you receive an error re indexes customer_id and customer_last_name not defined I placed

Code:

---

// Undefined index: customer_id, customer_last_name bof
@$id=$_SESSION['customer_id'];
@$ln=$_SESSION['customer_last_name'];
// eof

---

at the beginning of the code in includes/languages/english/modules/payment/dirbankaus.php

environment Test: Zen Cart 157a; Apache 2.4.46; PHP 7.4.9; MySQL 5.7.31; Windows 10

Yes, I have the green light showing on the admin page. It doesn't show on the payment options page at all for the customer.... I'm on 1.5.7

Hmmm... it's a zone thing... it will only accept one of my zones, not the New Zealand Zone...

Dirbank is tied to the Tax Rates defined under Admin | Locations /Taxes | Tax Rates.

The zones referenced are under Admin | Locations/Taxes | Zone Definitions - Taxes, Payment and Shipping
I have created two zones:
first zone is: zone Name = "Australia", Description = "Australia - GST";
under Details: Country=Australia, Zone= All zones
under Tax Rate: Priority=1, Tax Class Title=GST, Zone=Australia [note this references the Zone under zone definitions], tax Rate=10, Description = GST

second zone is: zone-name= "Outside Aus", Description =World-excluding Australia"
under Details: Country= every country except Australia, Zone= All zones
under Tax Rate: Priority=0, Tax Class Title=No Tax, Zone=Outside Aust [note this references the Zone under zone definitions], tax Rate=0, Description = GST Free


So if you have two countries with the same tax rate you can combine them into one Zone.

There must be a green dot against the entries in Zone Definitions - Taxes, Payment and Shipping

Under Admin | Configuration | My Store I have
Basis of Product Tax = Shipping. and
Basis of Shipping Tax = Shipping

so Zen Cart will add tax based on shipping address. Aus customers see Dirbank, Customers outside Aus don't see Dirbank.

1.5.7b PHP 7.3.25 MySQL 5.7.32
OPC
Edit Orders
PayPal Express
Zone Shipping
No other Payment or Shipping Mods Installed

Using dirbanknz.php

Warning log

Code:

---

[05-Jan-2021 13:36:10 US/Central] Request URI: /******/index.php?cmd=orders&page=1&oID=1596&action=update_order&language=NZ, IP address: 122.##.###.###
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [/******/orders.php:266]
#3 require(/******/orders.php) called at [/******/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

---

Latest code from download of file

Code:

---

// class methods    function update_status() {
      global $order, $db;


      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKNZ_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->delivery['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }


        if ($check_flag == false) {
          $this->enabled = false;
        }
      }

---

Assuming the item in red is the problem but not sure of the solution.

Quote:

---

Originally Posted by dbltoe

1.5.7b PHP 7.3.25 MySQL 5.7.32
OPC
Edit Orders
PayPal Express
Zone Shipping
No other Payment or Shipping Mods Installed

Using dirbanknz.php

Warning log

Code:

---

[05-Jan-2021 13:36:10 US/Central] Request URI: /******/index.php?cmd=orders&page=1&oID=1596&action=update_order&language=NZ, IP address: 122.##.###.###
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [/******/orders.php:266]
#3 require(/******/orders.php) called at [/******/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

---

Latest code from download of file

Code:

---

// class methods    function update_status() {
      global $order, $db;


      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKNZ_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->delivery['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }


        if ($check_flag == false) {
          $this->enabled = false;
        }
      }

---

Assuming the item in red is the problem but not sure of the solution.

---

2 tips:
1. If this store is using this module for "all addresses", eg no zone restrictions, you could just put "return;" as the first line of the update_status() function and skip that part altogether.
2. The parameters passed to the zone lookup query in many older shipping/payment modules' update_status() functions are quite possibly incorrect. Compare with the update_status() function in current built-in shipping/payment modules to see what may be incorrect. It's also easy to test whether the change you make has any undesired side-effects: just test whether the module works both with and without zone restrictions applied for a given address.

Please help I need the following corrected - see image
Attachment 19531

Reference - can this be changed to only show the order #?
How do you change MODULE_PAYMENT_DIRBANKAUS_ADDRESS - looks like something is missing.
Can Swift Code be removed?

Thanks for the help!