-
[Closed] FEEDBACK ON BETA of v1.5.5
This thread is for collecting feedback on problems with the v1.5.5 beta code, available at: https://github.com/zencart/zencart/archive/v155.zip
If you're reporting multiple unrelated issues, please post them in separate replies, as this allows us to reply more easily about specific individual fixes.
As fixes are made, they will be committed to the github repo directly.
(If you have fixes you'd like to offer, feel free to submit a pull-request on github, but be sure your github branch is forked from the v155 branch and not the v160 default. More about github and pull-requests here: http://docs.zen-cart.com/Contributing )
This discussion thread will be closed after v155 is officially released.
-
Re: FEEDBACK ON BETA of v1.5.5
A couple known-issues we're working on in the new responsive_classic template include:
- Need to fix uneven margins in desktop 3 column layout. Example: right margin of the center column on every page is wider than the left.
- Product detail page has a lot of empty space under the product image in desktop layout
- ...More Info button under product images overlapping in the list view (ie: main_page=featured_products)
- Refresh icons overlapping Qty. box in main_page=shopping cart in 1024x768 view
- Automatically turn on the CSS Buttons
(Yes, I posted these all as one post, but that's because they're being worked on in one batch :) )
-
Re: FEEDBACK ON BETA of v1.5.5
Initial install (localhost/XAMPP). Created fresh directory and copied distribution zip-files, brand-new database.
Started the install process. In the "System Inspection" step, I'm presented with the error:
Code:
Your configure.php file is an old version and requires updating before we can continue.
... but this is a fresh install, so the configure.php file was created as part of the installation process, right? The file's there, it's 0-bytes in length.
-
Re: FEEDBACK ON BETA of v1.5.5
Admin Setup Phase. Same fresh install as my previous posting. Message appears before the admin directory name that was chosen:
Code:
We did not change your admin directory automatically as it already seems to have been changed from the default.
Well, yes, it was changed from the default ... by the installation process. The message should be reworded as it's going to cause confusion for people that are installing for the first time.
-
Re: FEEDBACK ON BETA of v1.5.5
Initial admin login! Why was the hit counter started on 11/30/1999?
-
Re: FEEDBACK ON BETA of v1.5.5
Initial store view. Fresh install with demo products.
Click the "Test Examples" category link; the product listing page's "Add Selected Products" button is way-too-big.
Storefront: Shouldn't the responsive template use CSS buttons?
-
Re: FEEDBACK ON BETA of v1.5.5
Debug-log file created as part of the fresh-install process:
Code:
[17-Dec-2015 14:38:46 America/New_York] PHP Warning: file_put_contents(/includes/configure.php): failed to open stream: No such file or directory in C:\xampp\htdocs\zc155\zc_install\includes\classes\class.zcConfigureFileWriter.php on line 66
[17-Dec-2015 14:38:46 America/New_York] PHP Warning: file_put_contents(/admin/includes/configure.php): failed to open stream: No such file or directory in C:\xampp\htdocs\zc155\zc_install\includes\classes\class.zcConfigureFileWriter.php on line 66
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
Initial store view. Fresh install with demo products.
Click the "Test Examples" category link; the product listing page's "Add Selected Products" button is way-too-big.
Storefront: Shouldn't the responsive template use CSS buttons?
Yes they should have been turned on by default.
Update: They are now turned on by default.
-
Re: FEEDBACK ON BETA of v1.5.5
NOTE: The zip has been updated (it's updated in-real-time as commits are made): https://github.com/zencart/zencart/archive/v155.zip
-
Re: FEEDBACK ON BETA of v1.5.5
Fresh install.
The first thing I did once installation was complete was to go to Tools - Banner Manager - then turn all banners off. Result was broken site. Error log reads:
[17-Dec-2015 23:15:52 America/Phoenix] PHP Fatal error: Call to a member function RecordCount() on a non-object in /home/XXXXXX/public_html/includes/modules/sideboxes/banner_box.php on line 26
-
Re: FEEDBACK ON BETA of v1.5.5
Returned to admin and turned all banners on again. Full site returned. Next step was to turn off the sideboxes. Banner still displaying in main_page.
Once ckeditor is installed, I'll work on changing that and see what happens.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
Ajeh
Yes they should have been turned on by default.
Update: They are now turned on by default.
Won't that, then, mess the configuration up for the Contemporary Green template?
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
Admin, Tools->Developers Tool Kit. It looks like either the CSS or layout was changed so that a mono-type font is now used for the display:
Attachment 15872
It's quite ugly (IMO) now and very difficult to read. Can this be changed back?
P.S. I do like the new highlighting of the searched-for term!
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
A couple known-issues we're working on in the new responsive_classic template include:
- Need to fix uneven margins in desktop 3 column layout. Example: right margin of the center column on every page is wider than the left.
- Product detail page has a lot of empty space under the product image in desktop layout
- ...More Info button under product images overlapping in the list view (ie: main_page=featured_products)
- Refresh icons overlapping Qty. box in main_page=shopping cart in 1024x768 view
- Automatically turn on the CSS Buttons
(Yes, I posted these all as one post, but that's because they're being worked on in one batch :) )
I just sent over a fix for the margins and more info buttons.
Thanks,
Anne
-
2 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
Now sure this is an error or something specific to my test store but posting it in case it is.
When I am in the orders page if I click on the little "e" beside a customer the next page opens with the customer's order details however, it stops just after the "credit card details". I get the following error;
"an error has occurred, refresh the page and try again"
I've attached 2 snap shots to show what I see.
However, when I click on the "edit" button it opens the customer's order and everything appears just fine
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
charmedbytina2
Returned to admin and turned all banners on again. Full site returned. Next step was to turn off the sideboxes. Banner still displaying in main_page.
Once ckeditor is installed, I'll work on changing that and see what happens.
I did not create a banner group for the image in the define main page since it is not a separate banner group in the classic template. Let me know if this should be a new banner and I can add the code.
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
Initial store view. Fresh install with demo products.
Click the "Test Examples" category link; the product listing page's "Add Selected Products" button is way-too-big.
Storefront: Shouldn't the responsive template use CSS buttons?
What device are you using? If on a desktop, what monitor size and browser are you using?
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
picaflor-azul
What device are you using? If on a desktop, what monitor size and browser are you using?
Thanks,
Anne
Desktop, 1920x900, all-of-them. FWIW, setting the Use CSS Buttons setting to true made it look a whole lot better!
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
Desktop, 1920x900, all-of-them. FWIW, setting the Use CSS Buttons setting to true made it look a whole lot better!
Yes, the template uses css buttons and I believe that they are now turned on by default ;)
Thanks,
Annecom
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
picaflor-azul
I did not create a banner group for the image in the define main page since it is not a separate banner group in the classic template. Let me know if this should be a new banner and I can add the code.
Thanks,
Anne
If the sidebox is OFF (banner_box), and ALL the banners are also OFF (SideBox-Banners) the page won't display correctly the right column. For example if you switch a sidebox from left to right, it won't display.
If you enable at least 1 banner (even if the sidebox is OFF), the right column will display correctly then.
-
Re: FEEDBACK ON BETA of v1.5.5
NOTE: The zip has been updated (it's updated in-real-time as commits are made): https://github.com/zencart/zencart/archive/v155.zip
-
Re: FEEDBACK ON BETA of v1.5.5
This seems to be a semi-responsive template, not fully responsive. For example, if I resize the screen below 768px breakpoint, there are no menus or any navigation available. The mobile version does have a menu, but I'd expect it to exist in the desktop version as well if it's responsive.
-
Re: FEEDBACK ON BETA of v1.5.5
The "more info" button is outside the container on product listing pages.
http://s6.postimg.org/mom0wftx9/2015_12_19_023011.jpg
-
Re: FEEDBACK ON BETA of v1.5.5
What were you using when seeing that?
Are you using the latest updates with the changes to the CSS?
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
Ajeh
What were you using when seeing that?
Desktop, 1920x1080px, Firefox and Chrome. Fresh (vanilla) install on localhost.
Screenshot is from "Test Examples" category page (index.php?main_page=index&cPath=23)
Quote:
Originally Posted by
Ajeh
Are you using the latest updates with the changes to the CSS?
I think so - I didn't get a chance to test until now and I used your link from post #21.
-
Re: FEEDBACK ON BETA of v1.5.5
Thanks for the update ... we will continue to work on updates so your observations help to know ... :smile:
-
Re: FEEDBACK ON BETA of v1.5.5
Don't want to be a pain in the a**, but was there any reason why this was ignored? IMHO, an important fix...
And, probably less important, this. :smile:
-
Re: FEEDBACK ON BETA of v1.5.5
Looks like the change was made to stylesheet.css on line 270 but commented out.
Code:
.list-more{display:block;background:#333;padding:8px 20px;color:#fff !important;float:right;text-align:center;text-decoration:none !important;/*margin-top:-50px;*/width:50%;}
Uncomment
Code:
/*margin-top:-50px;*/
Quote:
Originally Posted by
balihr
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
rbarbour
Looks like the change was made to stylesheet.css on line 270 but commented out.
Code:
.list-more{display:block;background:#333;padding:8px 20px;color:#fff !important;float:right;text-align:center;text-decoration:none !important;/*margin-top:-50px;*/width:50%;}
Uncomment
Code:
/*margin-top:-50px;*/
IMHO, not much of a solution. Notice the different positioning...
http://s6.postimg.org/3jntjslkt/2015_12_19_043002.jpg
-
Re: FEEDBACK ON BETA of v1.5.5
on 2 installs if i go to hardware - cdrom drives on sample data the right column drops below footer
seems to happen on empty categories but layout seems ok on categories with products the right column appears in correct position
bn
-
Re: FEEDBACK ON BETA of v1.5.5
This also happens if the image is bigger and changes the height of it.
Quote:
Originally Posted by
balihr
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
balihr
This seems to be a semi-responsive template, not fully responsive. For example, if I resize the screen below 768px breakpoint, there are no menus or any navigation available. The mobile version does have a menu, but I'd expect it to exist in the desktop version as well if it's responsive.
That is because the template is using php mobile detect. You need to either view the template on the device to see the mobile or tablet views, use the links in the home page paragraph to switch the user agent, or use something like chrome web developer tools.
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
balihr
Desktop, 1920x1080px, Firefox and Chrome. Fresh (vanilla) install on localhost.
Screenshot is from "Test Examples" category page (index.php?main_page=index&cPath=23)
I think so - I didn't get a chance to test until now and I used your link from post #21.
I just submitted a fix for this.
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
ideasgirl
This also happens if the image is bigger and changes the height of it.
I just submitted a fix for the more info bug and image size. See my demo:
http://zenlyzen.com/pic/index.php?ma...index&cPath=23
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
bn17311
on 2 installs if i go to hardware - cdrom drives on sample data the right column drops below footer
seems to happen on empty categories but layout seems ok on categories with products the right column appears in correct position
bn
Great catch! I'll work on this and submit an update.
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
ideasgirl
If the sidebox is OFF (banner_box), and ALL the banners are also OFF (SideBox-Banners) the page won't display correctly the right column. For example if you switch a sidebox from left to right, it won't display.
If you enable at least 1 banner (even if the sidebox is OFF), the right column will display correctly then.
I can not replicate this. I turned off the banner_box sidebox. Then I turned off all of the banners in the admin--tools--banner manager. Then I switched the document_categories sidebox from the left hand column to the right hand column and all is working. Can you post a link to your demo so that I can see the problem?
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
bn17311
on 2 installs if i go to hardware - cdrom drives on sample data the right column drops below footer
seems to happen on empty categories but layout seems ok on categories with products the right column appears in correct position
bn
I just submitted a fix for this ;)
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
I don't think that I am this dense but attempting to install to my sandbox account, within a subfolder is confusing.
I am not sure that this is the proper place to make comments from a non-coder attempting to install the beta.
lat9's report of the RED error regarding configure files is confusing because it indicates that I need to do something.
Cannot step backwards in the install procedure.
Cannot find any settings in the db setup screen that will be accepted.
1045:Access denied for user 'THISISMYUSERNAME'@'localhost' (using password: YES)
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
picaflor-azul
I can not replicate this. I turned off the banner_box sidebox. Then I turned off all of the banners in the admin--tools--banner manager. Then I switched the document_categories sidebox from the left hand column to the right hand column and all is working. Can you post a link to your demo so that I can see the problem?
Thanks,
Anne
if ive followed this correctly here is what i get
www.catchagrip.co.uk
bn
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
RixStix
I don't think that I am this dense but attempting to install to my sandbox account, within a subfolder is confusing.
I am not sure that this is the proper place to make comments from a non-coder attempting to install the beta.
Yes, I can be that dense. Now continuing with install.
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
hi,
on mobile template what does the button with arrow do in header
Attachment 15881
thanks
bn
-
Re: FEEDBACK ON BETA of v1.5.5
Takes you to the top of the page ...
-
Re: FEEDBACK ON BETA of v1.5.5
thank you,
now i know what its for it definately works
bn
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
bn17311
Are there any error logs in your logs folder?
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
I have some ideas on the banner issues but we haven't finished them yet ... :smile:
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
picaflor-azul
Are there any error logs in your logs folder?
Thanks,
Anne
[19-Dec-2015 20:20:39 Europe/London] PHP Fatal error: Call to a member function RecordCount() on a non-object in /home/catchagr/public_html/includes/modules/sideboxes/banner_box.php on line 26
bn
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
picaflor-azul
Are there any error logs in your logs folder?
Thanks,
Anne
on my other test site
[19-Dec-2015 20:46:35 UTC] PHP Fatal error: Call to a member function RecordCount() on a non-object in /home/27410-31075.cloudwaysapps.com/sythqdywhp/public_html/includes/modules/sideboxes/banner_box.php on line 26
[19-Dec-2015 20:46:35 UTC] PHP Stack trace:
[19-Dec-2015 20:46:35 UTC] PHP 1. {main}() /home/27410-31075.cloudwaysapps.com/sythqdywhp/public_html/index.php:0
[19-Dec-2015 20:46:35 UTC] PHP 2. require() /home/27410-31075.cloudwaysapps.com/sythqdywhp/public_html/index.php:97
[19-Dec-2015 20:46:35 UTC] PHP 3. require() /home/27410-31075.cloudwaysapps.com/sythqdywhp/public_html/includes/templates/responsive_classic/common/tpl_main_page.php:125
[19-Dec-2015 20:46:35 UTC] PHP 4. require() /home/27410-31075.cloudwaysapps.com/sythqdywhp/public_html/includes/modules/column_left.php:31
-
Re: FEEDBACK ON BETA of v1.5.5
give me a few almost done ...
-
Re: FEEDBACK ON BETA of v1.5.5
NOTE: The zip has been updated (it's updated in-real-time as commits are made): https://github.com/zencart/zencart/archive/v155.zip
Fixes issues related to ajax.php
Fixes the Authorize net AIM issues on checkout
Fixes Banner issues
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
Ajeh
banner issue seems fixed
thanks
bn
-
Re: FEEDBACK ON BETA of v1.5.5
NOTE: The zip has been updated (it's updated in-real-time as commits are made): https://github.com/zencart/zencart/archive/v155.zip
Fixes template issues on categories with no products
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
Ajeh
works for me
thanks
-
Re: FEEDBACK ON BETA of v1.5.5
Thanks a lot your feedback is a big help to us on this and other issues ... :smile:
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
in mobile device if you go to
all products / featured products / specials / new products
there needs to be at least 5 pages so all products shows the error easiest
go to page 2 or further 3 4 5 etc
Attachment 15882
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
in mobile template if you click contact us link it takes to you part way down page missing out the store name etc
you wouldnt naturally think to scroll up for store name phone no etc
Attachment 15883
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
on desktop template with right column switched off
sample data - category big linked and mixed product types the add button is hidden slightly
Attachment 15884
bn
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
bn17311
in mobile device if you go to
all products / featured products / specials / new products
there needs to be at least 5 pages so all products shows the error easiest
go to page 2 or further 3 4 5 etc
Attachment 15882
Yes, the screen size on a small mobile device is very small so the number of visible pages should be limited to 4 or less in admin--maximum values--Prev/Next Navigation Page Links. I don't see another way to solve this. Let me know if anyone has any suggestions. Maybe an if statement can be written here to only limit the visible links to 4 or less only on mobile devices?
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
yes 3 looks good, didnt realise you could change that in admin,
maybe 3 should become the default setting so it works with mobile out of the box
bn
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
bn17311
yes 3 looks good, didnt realise you could change that in admin,
maybe 3 should become the default setting so it works with mobile out of the box
bn
Just remember that the configuration setting applies to all views of the site; setting the value to 3 will look pretty chintzy for widescreen desktop/laptop (and some tablet) views.
-
Re: FEEDBACK ON BETA of v1.5.5
Just a quick note to say that the install on 1and1.com went smoothly (i.e. nothing new/different to report). Running PHP 5.6.15, mySQL 5.1.73.
-
Re: FEEDBACK ON BETA of v1.5.5
Another question: Looking through /zc_install/sql/updates/mysql_update_zencart_155.sql (which is a utf8 w/o BOM encoded file), there are a couple of updates of the form:
Code:
UPDATE countries set countries_name = 'Åland Islands' where countries_iso_code_3 = 'ALA';
UPDATE countries set countries_name = 'Réunion' where countries_iso_code_3 = 'REU';
UPDATE countries set countries_name = "Côte d'Ivoire" where countries_iso_code_3 = 'CIV';
Won't those non-ASCII (and utf8-encoded) country names get mangled if the store-being-upgraded uses a latin1 collation?
-
Re: FEEDBACK ON BETA of v1.5.5
Wow - tons of exciting updates just in the last few days! Thanks for your hard work, Zen Cart team and Picaflor (and all testers)!
-
Re: FEEDBACK ON BETA of v1.5.5
Problems with banner_box = solved
Problems with product listing row height = solved
Let's continue the testing... :)
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
Initial admin login! Why was the hit counter started on 11/30/1999?
Corrected in this morning's zip-file.
-
Re: FEEDBACK ON BETA of v1.5.5
Can you try again with latest code.
Quote:
Originally Posted by
lat9
Initial install (localhost/XAMPP). Created fresh directory and copied distribution zip-files, brand-new database.
Started the install process. In the "System Inspection" step, I'm presented with the error:
Code:
Your configure.php file is an old version and requires updating before we can continue.
... but this is a fresh install, so the configure.php file was created as part of the installation process, right? The file's there, it's 0-bytes in length.
-
Re: FEEDBACK ON BETA of v1.5.5
Hi
Agreed,
the messages should only show if the admin directory is called 'admin'
Working on this :)
Quote:
Originally Posted by
lat9
Admin Setup Phase. Same fresh install as my previous posting. Message appears before the admin directory name that was chosen:
Code:
We did not change your admin directory automatically as it already seems to have been changed from the default.
Well, yes, it was changed from the default ...
by the installation process. The message should be reworded as it's going to cause confusion for people that are installing for the first time.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
Your configure.php file is an old version and requires updating before we can continue.
for me the configure problem is now gone with latest download, i did get a warning about php below 5.5 which i didnt get before
bn
-
Re: FEEDBACK ON BETA of v1.5.5
Hi
Yes, because of the work flow in the installer, some warnings may not appear immediately.
Strictly, we should be erroring on PHP <= 5.4 as this is not supported anymore, but given 1.5.5 does not use any >5.4 specific code we are allowing for hosts that haven't updated yet.
Although I would worry if my host is using an out of date php version.
Quote:
Originally Posted by
bn17311
for me the configure problem is now gone with latest download, i did get a warning about php below 5.5 which i didnt get before
bn
-
Re: FEEDBACK ON BETA of v1.5.5
Install went smooth as without a single glitch.
Server environment:
HTTP Server: LiteSpeed
PHP Version: 7.0.0 (Zend: 3.0.0)
PHP File Uploads: On Upload Max Size:2M
PHP Memory Limit: 128M
POST Max Size: 8M
Database: MySQL 5.5.46-cll
Database Data Size: 366 kB
Database Index Size: 527 kB
Ofc I need to do further testing on several devices and with different admin settings - time permitting.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
wilt
Hi
Yes, because of the work flow in the installer, some warnings may not appear immediately.
Strictly, we should be erroring on PHP <= 5.4 as this is not supported anymore, but given 1.5.5 does not use any >5.4 specific code we are allowing for hosts that haven't updated yet.
Although I would worry if my host is using an out of date php version.
I got this error on first install and my PHP Version is 5.6.16. I haven't done a 2nd install.
-
Re: FEEDBACK ON BETA of v1.5.5
I haven't had an error on php 5.6.15 ... ensure that you have the latest release of the v155 beta ...
-
Re: FEEDBACK ON BETA of v1.5.5
Fresh install, using zip-file created at approximately 10am EST.
System Setup step. Need to determine whether you're going to use the US or UK spelling of license/licence:
Code:
License
Agree to licence terms:
(Check the box to agree to GPL 2 licence terms. Click the title in the left column to view the license.)
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
wilt
Can you try again with latest code.
Verified corrected using a zip-file created about 10am EST this morning.
-
Re: FEEDBACK ON BETA of v1.5.5
zc_install, Step: Database Setup.
Click on the link entitled Database Tablename Prefix. The help text reads:
Code:
What is the prefix you would like used for database tables? Example: 'zen_' TIP: Leave empty if no prefix is needed.
You can use prefixes to allow more than one store to share the same database.
My thought is that some more literally-inclined people are going to include the single-quotes because the example text contained them:
Perhaps use either bold or italic to emphasize the zen_, moving the "TIP" to the next line?
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
Ajeh
I haven't had an error on php 5.6.15 ... ensure that you have the latest release of the v155 beta ...
That was with first zip release, first install. I haven't reinstalled new versions.
-
Re: FEEDBACK ON BETA of v1.5.5
Hi.
Will take a look at both and see if we can shoehorn something in.
Quote:
Originally Posted by
balihr
Don't want to be a pain in the a**, but was there any reason why
this was ignored? IMHO, an important fix...
And, probably less important,
this. :smile:
-
Re: FEEDBACK ON BETA of v1.5.5
Hi
Have pushed change for this.
Quote:
Originally Posted by
lat9
zc_install, Step: Database Setup.
Click on the link entitled Database Tablename Prefix. The help text reads:
Code:
What is the prefix you would like used for database tables? Example: 'zen_' TIP: Leave empty if no prefix is needed.
You can use prefixes to allow more than one store to share the same database.
My thought is that some more literally-inclined people are going to include the single-quotes because the example text contained them:
Perhaps use either bold or italic to emphasize the
zen_, moving the "TIP" to the next line?
-
Re: FEEDBACK ON BETA of v1.5.5
I re-ordered the tpl_product_info_display.php and the right sideboxes drop to the footer area and move to the left.
You can see it here
I also want to add a background image and it will not appear when background coding is added to the stylesheetin the "body" area.
-
Re: FEEDBACK ON BETA of v1.5.5
Are you sure that you have the latest Zip of v155 installed? I cannot repeat this issue ...
What sideboxes on the right column are turned on?
Can you zip and attach your file for the tpl_product_info.php
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
Ajeh
Are you sure that you have the latest Zip of v155 installed? I cannot repeat this issue ...
What sideboxes on the right column are turned on?
Can you zip and attach your file for the tpl_product_info.php
On the right side, I have Search and Product Notifications
zip file attachedAttachment 15885
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
charmedbytina2
I re-ordered the tpl_product_info_display.php and the right sideboxes drop to the footer area and move to the left.
You can see it
here
I also want to add a background image and it will not appear when background coding is added to the stylesheetin the "body" area.
The background image is working. If you want it to show you would need to remove the background color from the #headerWrapper and #mainWrapper.
There is a bug in the tpl_header.php file and I just submitted a fix for it ;)
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
picaflor-azul
The background image is working. If you want it to show you would need to remove the background color from the #headerWrapper and #mainWrapper.
There is a bug in the tpl_header.php file and I just submitted a fix for it ;)
Thanks,
Anne
Anne,
Thanks! I'll look for the updated file and try the background image again.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
charmedbytina2
On the right side, I have Search and Product Notifications
zip file attached
Attachment 15885
If I compare your file to the original there appears to be a lot of extra </div> in it and if I remove those it seems to fix it ...
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
Ajeh
If I compare your file to the original there appears to be a lot of extra </div> in it and if I remove those it seems to fix it ...
Ok - I'll try that! Thanks
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
charmedbytina2
Ok - I'll try that! Thanks
There was a misplaced </div> in the tpl_header.php file. You can see the new zip file for the correction.
You may also have mismatched tags in your page that will cause problems. The easiest way to find any errors is to run the page through the w3c html validator ;)
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by picaflor-azul
The easiest way to find any errors is to run the page through the w3c html validator
They all appear to be template errors not associated with ZenCart coding
https://jigsaw.w3.org/css-validator/...lang=en#errors
-
Re: FEEDBACK ON BETA of v1.5.5
Thanks for the input. I've implemented the suggestions by Ajeh and Anne. Looking better!
Now, I have a new error. Product Listings are not displaying in the same format.
Look at the attached pages.
First Product
Second Product
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
Fresh install, using zip-file created at approximately 10am EST.
System Setup step. Need to determine whether you're going to use the US or UK spelling of license/licence:
Code:
License
Agree to licence terms:
(Check the box to agree to GPL 2 licence terms. Click the title in the left column to view the license.)
Quote:
Originally Posted by
lat9
zc_install, Step: Database Setup.
Click on the link entitled Database Tablename Prefix. The help text reads:
Code:
What is the prefix you would like used for database tables? Example: 'zen_' TIP: Leave empty if no prefix is needed.
You can use prefixes to allow more than one store to share the same database.
My thought is that some more literally-inclined people are going to include the single-quotes because the example text contained them:
Perhaps use either bold or italic to emphasize the
zen_, moving the "TIP" to the next line?
Verified that these are corrected in the zip-file just created/downloaded.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
charmedbytina2
Thanks for the input. I've implemented the suggestions by Ajeh and Anne. Looking better!
Now, I have a new error. Product Listings are not displaying in the same format.
Look at the attached pages.
First Product
Second Product
If you want the image and description to be centered you need to check the css and html. For example, right now, there is a float:left; on the #productMainImage. In the html there is also a class "forward" which will float right if not removed.
Don't forget that with a responsive design, any changes you make on a desktop may effect the tablet and mobile layout. Be sure to check your changes on various devices and orientations as you go along.
Thanks,
Anne
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
Just noticed this: In admin - tools - developer tools.
I did a search and the results returned look a little wonky. See image attached.
Attachment 15887
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
charmedbytina2
Just noticed this: In admin - tools - developer tools.
I did a search and the results returned look a little wonky. See image attached.
Attachment 15887
Yes, that's another side-effect of the change to use either <pre> or <code> to format the results, as I'd mentioned here.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
Yes, that's another side-effect of the change to use either <pre> or <code> to format the results, as I'd mentioned
here.
Derh! Maybe it's too early for "eggnog"? I guess I should have looked at this thread a little closer - apologies!
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
charmedbytina2
Derh! Maybe it's too early for "eggnog"? I guess I should have looked at this thread a little closer - apologies!
It's never too early for eggnog! Your posting included the jagged output display (which I was too lazy to include), so it's all good.
-
Re: FEEDBACK ON BETA of v1.5.5
The file /admin/customers.php has been changed from the ZC1.5.4 base, but the header comments still reflect last-changed in v1.5.4.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
Admin, Tools->Developers Tool Kit. It looks like either the CSS or layout was changed so that a mono-type font is now used for the display:
Attachment 15872
It's quite ugly (IMO) now and very difficult to read. Can this be changed back?
P.S. I
do like the new highlighting of the searched-for term!
Quote:
Originally Posted by
charmedbytina2
Just noticed this: In admin - tools - developer tools.
I did a search and the results returned look a little wonky. See image attached.
Attachment 15887
FWIW, I changed the file /admin/includes/developers_tool_kit.css, removing the lines highlighted to restore the display to a non-monospaced font:
Code:
/*
* @package Admin
* @copyright Copyright 2003-2015 Zen Cart Development Team
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: Author: DrByte Modified in v1.6.0 $
*/
.dtk-highlite {font-weight: bold; color: rgb(255, 10, 5);}
.dtk-foundline, .dtk-foundline-multi {font-family: courier;}
.dtk-foundline-multi {background-color: rgba(4, 211, 216, 0.12);}
.dtk-contextline {font-family: courier;}
.dtk-linenum {font-family: courier;}
-
Re: FEEDBACK ON BETA of v1.5.5
Code:
/*
* @package Admin
* @copyright Copyright 2003-2015 Zen Cart Development Team
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: Author: DrByte Modified in v1.6.0 $
*/
.dtk-highlite {font-weight: bold; color: rgb(255, 10, 5);}
.dtk-foundline, .dtk-foundline-multi {font-family: courier;}
.dtk-foundline-multi {background-color: rgba(4, 211, 216, 0.12);}
.dtk-contextline {font-family: courier;}
.dtk-linenum {font-family: courier;}
You could just change those to Verdanda, sans-serif to cover 90% of the issue ...
-
Re: FEEDBACK ON BETA of v1.5.5
That's, in essence, what the font falls back to with those lines removed!
-
Re: FEEDBACK ON BETA of v1.5.5
is there any additional documentation on how to install and/or setup the responsive design stuff?
-
Re: FEEDBACK ON BETA of v1.5.5
What are you trying to setup?
-
Re: FEEDBACK ON BETA of v1.5.5
Changes made to sql statements in includes/functions/functions_lookups did not use $db->bindVars(
Code:
function zen_has_product_attributes_downloads_status($products_id) {
if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
return false;
}
$query = "select pad.products_attributes_id
from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
on pad.products_attributes_id = pa.products_attributes_id
where pa.products_id = " . (int) $products_id;
global $db;
return ($db->Execute($query)->RecordCount() > 0);
}
Could/should be:
Code:
function zen_has_product_attributes_downloads_status($products_id) {
if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
return false;
}
$query = "select pad.products_attributes_id
from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
on pad.products_attributes_id = pa.products_attributes_id
where pa.products_id = :products_id:";
global $db;
$query = $db->bindvars($query, ':products_id:', $products_id, 'integer');
return ($db->Execute($query)->RecordCount() > 0);
}