Event Calendar v3

[DivaVocals]

Yeah, it is really up to the individual, that's why it is in with the language defines. I had "Event Info File" because those terms applied to both docs and images. For the 2nd one, yeah, you are right the way the program works it deselects the file by just deleting the reference in the db. I don't think the program ever did delete the files. We could add another option to "delete physical file", it would only work if the deselect was checked...your call.

Happy to leave out "delete physical file", as I prefer to do such tasks manually and always after creating a backup.

Respectfully I disagree with leaving this out..

In looking at this from the NOVICE shopowner POV (the ones who most FREQUENTLY ask questions on the forum), I think that adding an option to physically remove the file is in order.. After all Zen Cart includes this feature for both product and category images.. AND to use IH4 as an example it too adds this ability.. This module should include as many features which are designed for a wide audience of varying skillsets..

The point is I have dealt with enough novice shop owners who do not do any kind of routine cleanup of their image folders, so it makes sense that an option to physically remove attachment files is in order..

Re: stripping css and js from events manager.
I largely agree, although I am not adverse to inline css. I can handle the css but am a bit green with js. Should js be shoved into a function file?

CSS and JS should as much as possible be moved to their own external files.. Inline CSS is almost NEVER needed.. (and it's old school) There would be no reason for you to edit JS, but the CSS will be easier to manage in it's own file.

[DivaVocals]

It may be the collapse setting, you could try removing both lines temporarily just to test it. Those settings, the way they are written will apply to all tables and td's that don't have those attributes set.

Now if you remove them and it works I then know and can go in and create those attributes in a class for the tables/td's in the events manager which then will override yours.

Okay.. Got my appearance issues all fixed.. I made some changes as follows to my custom settings in my admin stylesheet:

/* BOF Added so that the configuration settings displayed will wrap correctly */

table.configTable {
border-collapse:collapse; table-layout:fixed;
}
table.configTable td.dataTableContent,
word-wrap:break-word;vertical-align:top;

/* EOF Added so that the configuration settings displayed will wrap correctly */

I modified my configuration.php file to include the new table class.. This fixed the appearance problems I was having with events calendar, but my configuration layout settings for my custom template are not quite right now as the table cell contents for these two configuration settings are not wrapping as they should (a seperate issue having nothing to do with this module that I will deal with seperately if ONLY I could figure out what the HECK the issue is)

[LaCamus]

Both gif's and png's. Had no trouble with other types, although did not test for docx as I had none at hand.

If one "other" type file works for testing then all will, the function just creates a raw link (href) to the file with the default "click" image used to make it look pretty.

Happy to leave out "delete physical file", as I prefer to do such tasks manually and always after creating a backup.

I'll let you and Diva hash that one out, I'm open to either way...remember we can always have a define that triggers whether or not the question is ever asked.

Re: stripping css and js from events manager.
I largely agree, although I am not adverse to inline css. I can handle the css but am a bit green with js. Should js be shoved into a function file?

I've pulled the bulk of my inline css out but haven't gone through it all, I look at this as a starting point...I have 3 new files on the admin side...1 each for extra php functions, javascript, and css. Give me a few more days before you add anything of significance, this is creating lots of changes...I don't know if you just want to take my files and clean out the remarks, it will save you some time.

Re: developer attributions
Since you have done so much work upon certain files, I believe it more than fair to give yourself credit as in events_manager_drop_dns.php

Thanks, I had made that one change as a reference and never went back to change it, I didn't do it on any others because I didn't want to overstep my bounds. I had actually taken it out last night (the reference in drop_dns). I'll leave it to your discretion.

Generally, I am standing in awe at your rapid responses and prompt solutions, and feel I should almost check myself for experiencing so much pleasure in our dealings. I have been at this for years and have never gained so much in so short a time.

Wow, thank you my friend, great praise coming from someone who has done so much for this mod...really, thank you.

Rus

[DivaVocals]

I'll let you and Diva hash that one out, I'm open to either way...remember we can always have a define that triggers whether or not the question is ever asked.

What's to hash out here?? This isn't introducing anything that isn't already a part of core Zen Cart (product and category images have a function to delete the files from the server)

This module should be FLEXIBLE and cover all levels of shopowners not just the ones who know how to do stuff on their own.. IJS.. If it's easy enough to add a delete file function AND you are willing to do the work to add this code (beacause afterall this is something we'd be asking YOU to do), then it really SHOULD be a part of the mod.. Not everyone is going to know HOW to clean out their images or even that they should, AND adding this feature doesn't preclude those who know how to do this themselves from doing it themselves.. I'm just not a fan of keeping features out of the module simply because some shopowners may know how to do something on their own.. Many shopowners who come here for help are DIYers and many aren't even that familiar with ALL the things they can do with their FTP tools, and others barely know how to use their cPanel file managers.. This feature is for THAT shopowner not folks like the ones participating in this discussion.. The features should be based on the POV of the NOVICE shopowner, not the advanced shopowner or site/code developers.. That said as long as there is flexibility for more advanced users then this should be a non-issue..

That's my three cents.. (if it matters.. )

[dw08gm]

What that did was create a reference with 2 open brackets ( <img class="c1" <img ). The zen_image function actually has support for additional parameters. It (probably) should have been written like this:

In a nutshell, this is the error of my ways. Don't ask me how I came to put zen_image function within an <img> tag, but it should have been the following all along.

<!-- bof event image - scales and fits images to outer div -->
<?php 
  if ($event_array['image']!="") {
?>
  <div class="event_image_outer">
    <div class="event_image_inner">
	  <img class="c1" src="<?php echo DIR_WS_IMAGES .'events_images/' . $event_array['image'];?>"/>
	</div>
    <div class="clearLeft"> </div>
  </div>
<?php 
  }
?>
<!-- eof event image -->

This works for all image types, but may need to add your code for the other info types.

[LaCamus]

In a nutshell, this is the error of my ways. Don't ask me how I came to put zen_image function within an <img> tag, but it should have been the following all along.

<!-- bof event image - scales and fits images to outer div -->
<?php 
  if ($event_array['image']!="") {
?>
  <div class="event_image_outer">
    <div class="event_image_inner">
	  <img class="c1" src="<?php echo DIR_WS_IMAGES .'events_images/' . $event_array['image'];?>"/>
	</div>
    <div class="clearLeft"> </div>
  </div>
<?php 
  }
?>
<!-- eof event image -->

This works for all image types, but may need to add your code for the other info types.

So...

echo event_flink_small($event_array['image'], $event_array['title'], 'class="c1" hspace="0" vspace="0"');

...didn't work?

I think I see why...both of zen carts' image functions read the height and width and feed the tag back with them embedded. I changed my event_flink_small function to feed the tag back with no height and width (this is set as the default)...just replace the old one with the new one below. It is located in:
/home/shootwise.com/www/includes/functions/extra_functions/events_calendar_functions.php

//**rus.02:start
//** function to decipher images verses docs
//** a different version of this function is also used (at the end of file) in admin/events_manager.php
function event_flink_small($inff, $alt='', $params='', $usew=false) {
  $events_img_exts = strtolower(trim(EVENTS_IMAGE_EXTS));
  $events_oth_exts = strtolower(trim(EVENTS_OTHER_EXTS));
  $events_all_exts = trim($events_img_exts . ' ' . $events_oth_exts);
  $orf = trim($inff);
  $wf  = DIR_WS_IMAGES .'events_images/' . $orf;
  if ($orf=='') {
    return '';
  } else {
    $fileext = strtolower(strrchr($orf, "."));
    if ($events_all_exts=='' || in_array($fileext,explode(" ",$events_img_exts))) {   //** it's an image or everything is considered an image
      $dumi = ($usew ? zen_image_OLD($wf, $alt, '', '', $params) : ('<img src="'.$wf.'" alt="'.$alt.'" title=" '.$alt.' " '.$params.' />'));
      return $dumi;
    } else {                                               //** must be other file type
      $dumi = '<a href="' . $wf . '" target="_blank">' . zen_image(DIR_WS_IMAGES .'events_images/event_cal_info_doc.png', $alt, '', '', $params) . '</a>';
      return $dumi;
    }
  }
}
//**rus.02:stop

Then...
in: includes/templates/your_template/templates/tpl_events_calendar_default.php

  <div class="event_image_outer">
    <div class="event_image_inner">
      <?php echo event_flink_small($event_array['image'], $event_array['title'], 'class="c1" hspace="0" vspace="0"'); ?>
    </div>
    <div class="clearLeft"> </div>
  </div>

...will work.

For those who still want to utilize the auto size detection feature of zen carts' image functions, they should use:

  <div class="event_image_outer">
    <div class="event_image_inner">
      <?php echo event_flink_small($event_array['image'], $event_array['title'], 'class="c1" hspace="0" vspace="0"',true); ?>
    </div>
    <div class="clearLeft"> </div>
  </div>

Thanks,
Rus

[Snean]

hey,

i installed zen-cart 1.5.0 and the event calendar plugin. On the shop main page i can see the new box.
In my admin menu is now no possibility to add a new event. Nothig was added.
I try to install some different versions but nothing work for 150.

Can somebody help?

[dw08gm]

Snean

Moves are currently underway to upgrade this mod for 150+. If you can bear with us, the upgrade should not be far away.

cheers

[DivaVocals]

hey,

i installed zen-cart 1.5.0 and the event calendar plugin. On the shop main page i can see the new box.
In my admin menu is now no possibility to add a new event. Nothig was added.
I try to install some different versions but nothing work for 150.

Can somebody help?

What different versions are you referring to??

If you installed any of the files attached to the posts here in this support thread that LaCamus & dw08gm and I have been discussing over the last few days/pages of this support thread, I hope you understand that those files are NOT meant for any production (live) store. If you read through the discussion over the last few days/pages here between LaCamus & dw08gm and myself, you would see that we are TESTING those files and NONE of the files attached to any of the posts here have been officially submitted as a release for this module.. If this is what you mean by "I try to install some different versions" I would suggest you NOT install any of those files on a live production site, and simply wait for LaCamus & dw08gm and I to complete our testing and vetting and for the official submission of the upcoming release of Events Calendar for Zen Cart v1.5.1.

[DivaVocals]

So...

echo event_flink_small($event_array['image'], $event_array['title'], 'class="c1" hspace="0" vspace="0"');

...didn't work?

I think I see why...both of zen carts' image functions read the height and width and feed the tag back with them embedded. I changed my event_flink_small function to feed the tag back with no height and width (this is set as the default)...just replace the old one with the new one below. It is located in:
/home/shootwise.com/www/includes/functions/extra_functions/events_calendar_functions.php

//**rus.02:start
//** function to decipher images verses docs
//** a different version of this function is also used (at the end of file) in admin/events_manager.php
function event_flink_small($inff, $alt='', $params='', $usew=false) {
  $events_img_exts = strtolower(trim(EVENTS_IMAGE_EXTS));
  $events_oth_exts = strtolower(trim(EVENTS_OTHER_EXTS));
  $events_all_exts = trim($events_img_exts . ' ' . $events_oth_exts);
  $orf = trim($inff);
  $wf  = DIR_WS_IMAGES .'events_images/' . $orf;
  if ($orf=='') {
    return '';
  } else {
    $fileext = strtolower(strrchr($orf, "."));
    if ($events_all_exts=='' || in_array($fileext,explode(" ",$events_img_exts))) {   //** it's an image or everything is considered an image
      $dumi = ($usew ? zen_image_OLD($wf, $alt, '', '', $params) : ('<img src="'.$wf.'" alt="'.$alt.'" title=" '.$alt.' " '.$params.' />'));
      return $dumi;
    } else {                                               //** must be other file type
      $dumi = '<a href="' . $wf . '" target="_blank">' . zen_image(DIR_WS_IMAGES .'events_images/event_cal_info_doc.png', $alt, '', '', $params) . '</a>';
      return $dumi;
    }
  }
}
//**rus.02:stop

Then...
in: includes/templates/your_template/templates/tpl_events_calendar_default.php

  <div class="event_image_outer">
    <div class="event_image_inner">
      <?php echo event_flink_small($event_array['image'], $event_array['title'], 'class="c1" hspace="0" vspace="0"'); ?>
    </div>
    <div class="clearLeft"> </div>
  </div>

...will work.

For those who still want to utilize the auto size detection feature of zen carts' image functions, they should use:

  <div class="event_image_outer">
    <div class="event_image_inner">
      <?php echo event_flink_small($event_array['image'], $event_array['title'], 'class="c1" hspace="0" vspace="0"',true); ?>
    </div>
    <div class="clearLeft"> </div>
  </div>

Thanks,
Rus

Rus & dw08gm,

I have been working on moving some of the "settings options" into an admin menu in my test store. (I think it will be easier if some of the "settings" were accessible via an admin menu like other Zen Cart modules versus editing a definition file -- again keeping NOVICE shopowners in mind here.. I was going to share the changes I made in support of that effort with you and dw08gm once I tested it and was sure it was working..

That said, this code you posted code and the two options looks like a candidate for that effort.. Wrapping this inside a conditional statement with an admin setting to choose one or the other is what I had in mind.. However, help me understand the difference between these two options.. I've tried to follow the conversation between you and dw08gm, but I am not exactly sure what the two different options here do..