Page 347 of 373 FirstFirst ... 247297337345346347348349357 ... LastLast
Results 3,461 to 3,470 of 3721
  1. #3461
    Join Date
    Feb 2010
    Posts
    2,159
    Plugin Contributions
    17

    Default Re: Image Display Size Restriction

    Quote Originally Posted by pewe View Post
    Raymond.

    I am not trying to steal your thunder, but at the same time as I saw your post I had just uploaded a new copy of slimbox.php to my site and it works.
    Last nigh before retiring I found the code for a responsive version of slimbox.js on google groups which I copied to replace the code in the zen lightbox .php script.

    I haven't fully tested it, but it appears to work - it is attached if you'd like to compare it to yours and for anyone else to test for issues.
    That's great, seems to work. One less plugin I have to upload and maintain.

  2. #3462
    Join Date
    Jan 2007
    Location
    Los Angeles, California, United States
    Posts
    10,023
    Plugin Contributions
    32

    Default Re: Image Display Size Restriction

    Quote Originally Posted by pewe View Post
    Raymond.

    I am not trying to steal your thunder, but at the same time as I saw your post I had just uploaded a new copy of slimbox.php to my site and it works.
    Last nigh before retiring I found the code for a responsive version of slimbox.js on google groups which I copied to replace the code in the zen lightbox .php script.

    I haven't fully tested it, but it appears to work - it is attached if you'd like to compare it to yours and for anyone else to test for issues.
    and to be clear for others following this.. you replaced the slimbox.php file in includes/classes/zen_lightbox with the one you attached right???
    My Site - Zen Cart & WordPress integration specialist
    I don't answer support questions via PM. Post add-on support questions in the support thread. The question & the answer will benefit others with similar issues.

  3. #3463
    Join Date
    Aug 2006
    Posts
    134
    Plugin Contributions
    0

    Default Re: Image Display Size Restriction

    Quote Originally Posted by DivaVocals View Post
    and to be clear for others following this.. you replaced the slimbox.php file in includes/classes/zen_lightbox with the one you attached right???
    Correct.

  4. #3464
    Join Date
    Nov 2009
    Posts
    285
    Plugin Contributions
    5

    Default Re: Image Display Size Restriction

    pewe,
    I merged in your updates and submitted a new version.
    I have also created a github repo to make collaboration easier (if anyone else here uses github).

    daniel

  5. #3465
    Join Date
    Aug 2006
    Posts
    134
    Plugin Contributions
    0

    Default Re: Image Display Size Restriction

    Quote Originally Posted by niestudio View Post
    pewe,
    I merged in your updates and submitted a new version.
    I have also created a github repo to make collaboration easier (if anyone else here uses github).

    daniel

  6. #3466
    Join Date
    Sep 2008
    Location
    DownUnder, overlooking South Pole.
    Posts
    976
    Plugin Contributions
    6

    Default Re: Image Display Size Restriction

    Quote Originally Posted by pewe View Post
    I haven't fully tested it, but it appears to work - it is attached if you'd like to compare it to yours and for anyone else to test for issues.
    Are the following values=100 from includes\classes\zen_lightbox\slimbox.php expressed in percentages?

    Code:
    				initialWidth: 100, //1024
    				initialHeight: 100, //768
    Thanks in advance.

  7. #3467
    Join Date
    Dec 2009
    Location
    Amersfoort, The Netherlands
    Posts
    2,846
    Plugin Contributions
    25

    Default Re: Image Display Size Restriction

    Quote Originally Posted by niestudio View Post
    pewe,
    I merged in your updates and submitted a new version.
    I have also created a github repo to make collaboration easier (if anyone else here uses github).

    daniel
    just forked and submitted a small change

  8. #3468
    Join Date
    Aug 2006
    Posts
    134
    Plugin Contributions
    0

    Default Re: Image Display Size Restriction

    Quote Originally Posted by Design75 View Post
    just forked and submitted a small change
    What was the small change - did you find a problem somewhere?
    (Github shows all the files as being last changed 2 days ago.)
    Last edited by pewe; 12 Nov 2013 at 01:09 PM.

  9. #3469
    Join Date
    Aug 2006
    Posts
    134
    Plugin Contributions
    0

    Default Re: Image Display Size Restriction

    Quote Originally Posted by dw08gm View Post
    Are the following values=100 from includes\classes\zen_lightbox\slimbox.php expressed in percentages?

    Code:
    				initialWidth: 100, //1024
    				initialHeight: 100, //768
    Thanks in advance.
    I, for one, don't know - but maybe one of the other guys will have the answer.

  10. #3470
    Join Date
    Jul 2012
    Posts
    16,751
    Plugin Contributions
    17

    Default Re: Image Display Size Restriction

    Quote Originally Posted by pewe View Post
    What was the small change - did you find a problem somewhere?
    (Github shows all the files as being last changed 2 days ago.)
    Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

 

 

Similar Threads

  1. Free Shipping Rules addon [Support Thread]
    By numinix in forum Addon Shipping Modules
    Replies: 36
    Last Post: 2 Dec 2016, 01:56 PM
  2. v151 Reviews Reply addon [Support Thread]
    By mikestaps in forum All Other Contributions/Addons
    Replies: 9
    Last Post: 17 Oct 2014, 01:29 AM
  3. Jquery Lightbox [Support thread]
    By yellow1912 in forum All Other Contributions/Addons
    Replies: 257
    Last Post: 2 Aug 2012, 10:57 PM
  4. File Upload Required addon [Support Thread]
    By 1100101 in forum All Other Contributions/Addons
    Replies: 21
    Last Post: 10 Dec 2011, 03:00 AM
  5. [Support Thread] IE only JavaScripts and Stylesheets Addon
    By Meshach in forum All Other Contributions/Addons
    Replies: 16
    Last Post: 31 May 2011, 08:18 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR