Edit Orders v4.0 Support Thread

[lat9]

This same file /admin/edit_orders.php has a
switch($optionInfo['type']) block, with case references to:


PRODUCTS_OPTIONS_TYPE_RADIO
PRODUCTS_OPTIONS_TYPE_SELECT
PRODUCTS_OPTIONS_TYPE_TEXT
PRODUCTS_OPTIONS_TYPE_FILE
PRODUCTS_OPTIONS_TYPE_READONLY
PRODUCTS_OPTIONS_TYPE_CHECKBOX


These don't appear to be defined anywhere, so nothing matches. (bug?)


I've 'fixed' this problem by making the following edits to
/admin/includes/classes/attributes.php
(I thought this was from the SBA mod, but I've since found it to be from the Edit orders mod)


Added these defines at the beginning of the file
------------------------------------------------------------
define('PRODUCTS_OPTIONS_TYPE_RADIO', 'Radio') ;
define('PRODUCTS_OPTIONS_TYPE_SELECT', 'Dropdown');
define('PRODUCTS_OPTIONS_TYPE_TEXT', 'Text') ;
define('PRODUCTS_OPTIONS_TYPE_FILE', 'File') ;
define('PRODUCTS_OPTIONS_TYPE_READONLY', 'Read Only') ;
define('PRODUCTS_OPTIONS_TYPE_CHECKBOX', 'Checkbox') ; // is this a valid option? It doesn't appear in the database as such?
-------------------------------------------------------------

Oh no! Don't do that! Those constants are defined in the database and provide a mapping to the products_options_types table row associated with that option name.

[RodG]

Oh no! Don't do that! Those constants are defined in the database and provide a mapping to the products_options_types table row associated with that option name.

They're NOT defined in the database of the clients site that I'm working on.

They ARE defined in the configuration database of my own test site though (not associated with the clients site).

(That's why I suggested they should probably be checked to prevent a possible redefine).

I've not figured out how or where they got defined on my site, or more importantly, why they *didn't* get defined on the clients site during whatever upgrade performed this function.

Time to follow this lead to see where it takes me. It'll probably avoid the need for those other changes I made :)

.... Other than the case 'ot_coupon' changes (which was for a different issue). If you can foresee any potential problems with that could you please let me know?

Thanks
RodG

[lat9]

They're NOT defined in the database of the clients site that I'm working on.

They ARE defined in the configuration database of my own test site though (not associated with the clients site).

(That's why I suggested they should probably be checked to prevent a possible redefine).

I've not figured out how or where they got defined on my site, or more importantly, why they *didn't* get defined on the clients site during whatever upgrade performed this function.

They've been part of the Zen Cart "standard" database install since at least v1.3.8a (I've got a client that started with v1.3.7 and the constants are in that database). What Zen Cart version did your client start out with?

[DivaVocals]

They're NOT defined in the database of the clients site that I'm working on.

They ARE defined in the configuration database of my own test site though (not associated with the clients site).

(That's why I suggested they should probably be checked to prevent a possible redefine).

I've not figured out how or where they got defined on my site, or more importantly, why they *didn't* get defined on the clients site during whatever upgrade performed this function.

Time to follow this lead to see where it takes me. It'll probably avoid the need for those other changes I made :)

.... Other than the case 'ot_coupon' changes (which was for a different issue). If you can foresee any potential problems with that could you please let me know?

Thanks
RodG

Honestly Rod, the discount coupon thing aside (which is a functional issue not a "bug"), I'm starting to wonder if the "bugs" you are finding are UNIQUE to the client site you are working on.. Otherwise it would stand to reason that others would have reported the same issues you are having..

[RodG]

Honestly Rod, the discount coupon thing aside (which is a functional issue not a "bug"), I'm starting to wonder if the "bugs" you are finding are UNIQUE to the client site you are working on.. Otherwise it would stand to reason that others would have reported the same issues you are having..

Wonder no more. It is most certainly unique to this clients site.
Until this thread I really wasn't sure (and arguably, could still be in doubt), because this is the 1st store in which I've had the combination of

-----------------------------------
ZenCart V1.5.1
Edit Orders 4.1.2
Super Orders 4.0.7
Stock by Attribute 1.5.1.2
-----------------------------------

Although I'm now pretty much convinced the problem(s) pertain to the store/data itself, can you (or anyone) be 100% sure that there *isn't* a bug with this specific combination of inter related modules?

Again, I will stress that I'm now of the opinion that when I find what else is amiss with the data in this store that these versions of these modules will almost certainly behave as expected. Without reporting the 'bugs' and what I've needed to do to 'fix' them I don't think I could have gotten the feedback I needed to put me back on the right track. :)

Cheers
Rod

[OldNGrey]

I had problems installing Edit Order on a vanilla install of ZC. The solution / workaround is shown below.

The resulting error is:
"PHP Fatal error: 1366:Incorrect integer value: '' for column 'configuration_group_id' at row 1 :: INSERT INTO `zen_configuration_group` VALUES ('', 'Edit Orders', 'Settings for Edit Orders', '36', '1') in E:\web\zc151\includes\classes\db\mysql\query_factory.php on line 120
"

I have tracked it down to
admin\includes\auto_loaders\config.eo_onetime.php
--> admin\includes\init_includes\init_eo_install.php
--> admin\includes\classes\eo_plugin.php
--> admin\includes\classes\plugin.php
LINE 435
// Create configuration group
$db->Execute(
'INSERT INTO `' . TABLE_CONFIGURATION_GROUP . '` ' .
'VALUES (\'\', \'' . $this->getUniqueName() . '\', ' .
'\''. $this->getDescription() . '\', \'' . $max_sort . '\', \'1\')'
);]
The solution that works on my environment is to change to the value of configuration_group_id from '' to NULL
$db->Execute(
'INSERT INTO `' . TABLE_CONFIGURATION_GROUP . '` ' .
'VALUES (NULL, \'' . $this->getUniqueName() . '\', ' .
'\''. $this->getDescription() . '\', \'' . $max_sort . '\', \'1\')'
);

This can be replicated on a fresh database and Zen Cart demo installation

Configuration
PHP 5.3.8
Apache 2.2.21
MySQL 5.1
Windows 7 (test server)

I have posted the problem and the workaround here for future reference.

I have persevered with this as I have been using Edit Order on many version of ZC and simply find it difficult to admin a ZC site without it.

[lhungil]

I had problems installing Edit Order on a vanilla install of ZC.
...
The resulting error is:
"PHP Fatal error: 1366:Incorrect integer value: '' for column 'configuration_group_id' at row 1 :: INSERT INTO `zen_configuration_group` VALUES ('', 'Edit Orders', 'Settings for Edit Orders', '36', '1') in E:\web\zc151\includes\classes\db\mysql\query_factory.php on line 120
"
...

Thank You for catching this, reporting the issue, and providing a workaround / solution!

For the next release (of both Edit Orders and the Plugin module), I'll be replacing most UPDATE and INSERT statements with the "zen_db_perform" function.

[lunabug]

I'm curious as to why you "Changed the "local_sales_tax" line to no longer be editable (automatically generated based upon the order)" when "Not all order total modules are fully supported"???

As this is the case for my site (I'm running the Better Together addon), and I have to update the database directly with the correct sales tax (AND the total) as Edit Orders is not taking this discount into consideration when calculating the tax. I'd much rather be able to update it directly on the order edit page.

Thank,
Leslie

[lhungil]

Wonder no more. It is most certainly unique to this clients site.
Until this thread I really wasn't sure (and arguably, could still be in doubt) ...

Thank You for reporting back, if you see / saw any database pieces you feel could be "commonly" damaged, feel free to send me a PM / email with the information. If nothing else an installation check might be in order :)