Westminster New

[kalastaja]

Thanks!
Another question - does the template alter /includes/modules/pages/featured_products/header_php.php? Now my featured products listing breaks.

[DivaVocals]

Thanks!
Another question - does the template alter /includes/modules/pages/featured_products/header_php.php? Now my featured products listing breaks.

You have the files for BOTH templates.. If you see a /includes/modules/pages/featured_products/header_php.php file in the install package, consider it modified... **simple**

or you could answer your own question and compare the /includes/modules/pages/featured_products/header_php.php file in the install package to the default Zen Cart version of the file..

Either way, this is a pretty easy DIY kind of answer..

[kalastaja]

Either way, this is a pretty easy DIY kind of answer..

Sorry. Wrong question. Any idea why the westminster file breaks for me? This what the system says:

[05-Feb-2015 19:29:58 Europe/Helsinki] PHP Fatal error:  1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'limit 10' at line 1 ::  limit 10 ==> (as called by) /home/fh2fuvvy/public_html/includes/templates/template_default/templates/tpl_modules_products_featured_listing.php on line 23 <== in /home/fh2fuvvy/public_html/includes/classes/db/mysql/query_factory.php on line 155

If I replace it with ZenCart original it works.

[picaflor-azul]

Sorry. Wrong question. Any idea why the westminster file breaks for me? This what the system says:

[05-Feb-2015 19:29:58 Europe/Helsinki] PHP Fatal error:  1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'limit 10' at line 1 ::  limit 10 ==> (as called by) /home/fh2fuvvy/public_html/includes/templates/template_default/templates/tpl_modules_products_featured_listing.php on line 23 <== in /home/fh2fuvvy/public_html/includes/classes/db/mysql/query_factory.php on line 155

If I replace it with ZenCart original it works.

This file is not in the template package:

/includes/templates/template_default/templates/tpl_modules_products_featured_listing.php

Thanks,

Anne

[kalastaja]

This file is not in the template package:
/includes/templates/template_default/templates/tpl_modules_products_featured_listing.php

Ok, but the problem would seem to be the header_php.php, because if I change it to file that comes with ZenCart, it works!
As far as I can understand the header-file does (or doesn't) do something, which the backfires in the tpl_modules_products_featured_listing-file

[DivaVocals]

Wanted to share this.. In the reviews sidebox, the text color is white on a white background.. This is a no no with the search engines.. Here's Google's policy:

Hidden text and links

Hiding text or links in your content to manipulate Google’s search rankings can be seen as deceptive and is a violation of Google’s Webmaster Guidelines. Text (such as excessive keywords) can be hidden in several ways, including:

• Using white text on a white background
• Locating text behind an image
• Using CSS to position text off-screen
• Setting the font size to 0
• Hiding a link by only linking one small character—for example, a hyphen in the middle of a paragraph

I changed the following in the stylesheet to address

.sideBoxContentItem a, #reviewsContent a {
    font-weight: normal;
    clear: both;
    color: #FFF;
    margin-bottom: 20px;
    padding-bottom: 10px;
}
}

Note I simply removed the color:#fff;.. The links should now inherit the default links colors.

[picaflor-azul]

Wanted to share this.. In the reviews sidebox, the text color is white on a white background.. This is a no no with the search engines.. Here's Google's policy:



I changed the following in the stylesheet to address

.sideBoxContentItem a, #reviewsContent a {
    font-weight: normal;
    clear: both;
    color: #FFF;
    margin-bottom: 20px;
    padding-bottom: 10px;
}
}

Note I simply removed the color:#fff;.. The links should now inherit the default links colors.

Thanks for catching this bug. The text is not supposed to be white. I'll put this on the list for a future update.

Thanks,

Anne

[picaflor-azul]

Just wanted to post an update to the jquery.slimmenu.min.js file. I believe that this update fixes the problem that some users were having with long category lists and the menu collapsing on touch devices.

Just replace the includes/templates/westminster_new/jscript/jquery.slimmenu.min.js file with the following:

/**
 * jquery.slimmenu.js
 * http://adnantopal.github.io/slimmenu/
 * Author: @adnantopal
 * Copyright 2013, Adnan Topal (atopal.com)
 * Licensed under the MIT license.
 * update by dusty73 https://github.com/dusty73/slimmenu/commit/70d5c15bdbefeb2bad8f96d6387719c88b84d1e6
 */
(function(e,t,n,r){function u(t,n){this.element=t;this.$elem=e(this.element);this.options=e.extend({},s,n);this.init()}var i="slimmenu",s={resizeWidth:"768",collapserTitle:"Main Menu",animSpeed:"medium",easingEffect:null,indentChildren:false,childrenIndenter:"&nbsp;&nbsp;"};var o=0;u.prototype={init:function(){var n=this.options,r=this.$elem,i='<div class="menu-collapser">'+n.collapserTitle+'<div class="collapse-button"><span class="icon-bar"></span><span class="icon-bar"></span><span class="icon-bar"></span></div></div>',s;r.before(i);s=r.prev(".menu-collapser");r.on("click",".sub-collapser",function(t){t.preventDefault();t.stopPropagation();var r=e(this).closest("li");if(e(this).hasClass("expanded")){e(this).removeClass("expanded");e(this).find("i").html("▼");r.find(">ul").slideUp(n.animSpeed,n.easingEffect)}else{e(this).addClass("expanded");e(this).find("i").html("▲");r.find(">ul").slideDown(n.animSpeed,n.easingEffect)}});s.on("click",".collapse-button",function(e){e.preventDefault();r.slideToggle(n.animSpeed,n.easingEffect)});this.resizeMenu({data:{el:this.element,options:this.options}});e(t).on("resize",{el:this.element,options:this.options},this.resizeMenu)},resizeMenu:function(n){var r=e(t),i=n.data.options,s=e(n.data.el),a=e("body").find(".menu-collapser");if(o==r.width()){return}o=r.width();s.find("li").each(function(){if(e(this).has("ul").length){if(e(this).has(".sub-collapser").length){e(this).children(".sub-collapser i").html("▼")}else{e(this).append('<span class="sub-collapser"><i>▼</i></span>')}}e(this).children("ul").hide();e(this).find(".sub-collapser").removeClass("expanded").children("i").html("▼")});if(i.resizeWidth>=r.width()){if(i.indentChildren){s.find("ul").each(function(){var t=e(this).parents("ul").length;if(!e(this).children("li").children("a").has("i").length){e(this).children("li").children("a").prepend(u.prototype.indent(t,i))}})}s.find("li").has("ul").off("mouseenter mouseleave");s.addClass("collapsed").hide();a.show()}else{s.find("li").has("ul").on("mouseenter",function(){e(this).find(">ul").stop().slideDown(i.animSpeed,i.easingEffect)}).on("mouseleave",function(){e(this).find(">ul").stop().slideUp(i.animSpeed,i.easingEffect)});s.find("li > a > i").remove();s.removeClass("collapsed").show();a.hide()}},indent:function(e,t){var n="";for(var r=0;r<e;r++){n+=t.childrenIndenter}return"<i>"+n+"</i>"}};e.fn[i]=function(t){return this.each(function(){if(!e.data(this,"plugin_"+i)){e.data(this,"plugin_"+i,new u(this,t))}})}})(jQuery,window,document)

I will include this in the next template update also.

Thanks,

Anne

[DivaVocals]

Just wanted to post an update to the jquery.slimmenu.min.js file. I believe that this update fixes the problem that some users were having with long category lists and the menu collapsing on touch devices.

Just replace the includes/templates/westminster_new/jscript/jquery.slimmenu.min.js file with the following:



I will include this in the next template update also.

Thanks,

Anne

If this is one of the two posted fixes in the Slim Menu Github repo, then YEP they both work and solve the problem finally.. There are pull requests for both, but last time I checked the author hadn't yet accepted either pull request.

[RixStix]

Don't have time today to troubleshoot, but that change made no positive difference.

Galaxy Tab 3 800x1280 px
No initial detectable difference, Android/FireFox. menu still collapses
Android/Chrome replaces menu triangles (or arrows) with question marks. Collapsing menu still exists.

Just wanted to post an update to the jquery.slimmenu.min.js file. I believe that this update fixes the problem that some users were having with long category lists and the menu collapsing on touch devices.