Known Bugs (and fixes) with v1.5.5 , a, b, c, d, e, f

This thread is an announcement area where any bugs detected for v1.5.5 will be summarized.

The first is that the first zip dated 03-17-2016 had a couple errors:

a) The list of changed files in /docs/changed-files-in-v155.html was incomplete. You can find the updated version at: www.zen-cart.com/docs

b) The /admin/orders.php file had some incorrect classes in forms.

c) The zc_install "system inspection" might timeout with a blank screen while inspecting.

d) The /includes/languages/english/classic/header.php file was missing a new define:```
define('SEARCH_DEFAULT_TEXT', 'search here');

**The above issues were fixed in the 03-18-2016 zip.**

A new zip **03-21-2016 **has been posted, which includes the following fixes:

a) zc_install when upgrading configure.php file contents, was assuming SSL was enabled, and accidentally enabled the ENABLE_SSL, ENABLE_SSL_CATALOG settings and set the Admin HTTP_SERVER to the old HTTPS_SERVER value. It now reads the old settings more intelligently.

b) zc_install was running into SQL schema problems if the old data had zero-dates in previous fields in the admin table. It now attempts to fix that data first.

c) zc_install has now been updated to auto-insert 3 old configuration table entries that sometimes got deleted by old plugins containing incorrect install SQL code.

d) zc_install was not properly honouring table-name prefixes during some cleanup phases of the db-upgrade process.

e) The Admin english.php file was updated to add a missing define for TEXT_PRICED_BY_ATTRIBUTES, which was only a problem on the admin screen for copying products between categories (ref: Missing english definition for products_to_categories):

/admin/includes/languages/english.php:

  define('TEXT_PRICED_BY_ATTRIBUTES', 'Priced by Attributes');

A new zip dated 03-24-2016 has been posted, which includes the following fixes:

a) Small typos in the changed_files.html list.
b) Link to zen-cart.com not in admin header menu
Details for the above at: Add "Support" link back to Admin menu; update typo in changed_files.html

c) State/Province dropdown is not displayed the same as other fields (Fix is in that same linked thread)

d) Fix sort-order of shipping/payment modules when sort-orders contain mixed multiple-digits

e) bug since at least v138: admin/customers.php span tags not closed

f) bug since at least v152: Uninitialized string offset in function zen_random_name()

Symptom: Admin order page shows yellow circle for comments on PayPal Express Checkout orders, when there are no comments.

**ONLY AFFECTS v1.5.5 PayPal Express Checkout
**

To fix it, edit /includes/modules/payment/paypalwpp.php, line 1838 and change: 'order_comment' => urldecode($response['NOTE']) . ' ' . urldecode($response['PAYMENTREQUEST_0_NOTETEXT']),to this:```
'order_comment' => (isset($response['NOTE']) || isset($response['PAYMENTREQUEST_0_NOTETEXT']) ? urldecode($response['NOTE']) . ' ' . urldecode($response['PAYMENTREQUEST_0_NOTETEXT']) : ''),

Additional CSS fixes for alignment of the State/Country pulldown/input boxes in Responsive Classic:

/includes/templates/responsive_classic/css/stylesheet.css

Line 84: Change from

select#country, .wrapperAttribsOptions select, #advSearchDefault select{height:40px;}

to

select#country, .wrapperAttribsOptions select, #advSearchDefault select[B], select#stateZone[/B] {height:40px;}
[B]select#country, select#stateZone, #state {margin-left:0;}
[/B]

Then delete this line 460 :

#loginDefault #country, #createAcctDefault #country{margin-left:0;}

PROBLEM: Can't choose from other addresses during checkout, without getting a "required field missing" error.

As posted at https://www.zen-cart.com/showthread.php?t=219842

If you are having difficulty changing addresses during checkout ... specifically, choosing addresses from previous address-book entries, it could be that the HTML5 field validations are overriding the javascript validations.

SOLUTION:
The fix is to change the tpl_checkout_shipping_address_default.php and tpl_checkout_payment_address_default.php pages to have two separate forms, instead of just one.

For the technically minded, the code changes to make can be viewed here: https://github.com/zencart/zencart/commit/b151f45390c8bd0eb23eb41da3b12480cbe001da
Edit: And this one here too: https://github.com/zencart/zencart/pull/904/files

Or download them individually from here:
responsive_classic:
https://github.com/zencart/zencart/raw/v155/includes/templates/responsive_classic/templates/tpl_checkout_shipping_address_default.php
https://github.com/zencart/zencart/raw/v155/includes/templates/responsive_classic/templates/tpl_checkout_payment_address_default.php

template_default
https://github.com/zencart/zencart/raw/v155/includes/templates/template_default/templates/tpl_checkout_shipping_address_default.php
https://github.com/zencart/zencart/raw/v155/includes/templates/template_default/templates/tpl_checkout_payment_address_default.php

*UPDATE: The double-continue button is fixed by making the change shown here: *https://github.com/zencart/zencart/pull/904/files

New 03-29-2016 zip for v155 released today contains:

a) the fixes listed above:

• choose from address-book during checkout (but not the fix to the double-continue-buttons)
• CSS fixes in responsive_classic
• PayPal Express Checkout empty "comments" showing comment flag

b) Update to the Admin URL Sanitizer code to allow deeper recursion -- fixes errors happening in Admin plugins such as Edit Orders
https://github.com/zencart/zencart/pull/886/files

NOTE: Further changes included in the new v155a release, published on 05/05/2016

Symptom: Currency-rate updates using BOC giving division-by-zero error

Solution: Small code change as posted here: https://github.com/zencart/zencart/pull/911/files
Described here: https://www.zen-cart.com/showthread.php?220093-Updating-Currencies&p=1309991#post1309991

NOTE: New v155a release zip published, which fixes the above-posted issues, and several more.
Details: https://www.zen-cart.com/showthread.php?219730-Zen-Cart-v1-5-5a-released!&p=1310272#post1310272

The Admin Request Sanitizer infrastructure has been updated to work more amicably with various plugins.

In your Admin if you're getting & converted into & unexpectedly then you probably need to apply the following updates.

These changes are applicable to v1.5.0-thru-v1.5.5a:
a) /admin/includes/classes/AdminRequestSanitizer.php
b) /admin/includes/init_includes/init_sanitize.php
c) /admin/includes/auto_loaders/config.adminSanitize.php (this file doesn't require changing if you already have v155a)

DrByte:

The Admin Request Sanitizer infrastructure has been updated to work more amicably with various plugins.

In your Admin if you're getting & converted into & unexpectedly then you probably need to apply the following updates.

These changes are applicable to v1.5.0-thru-v1.5.5a:
a) /admin/includes/classes/AdminRequestSanitizer.php
b) /admin/includes/init_includes/init_sanitize.php
c) /admin/includes/auto_loaders/config.adminSanitize.php (this file doesn't require changing if you already have v155a)
These files have been updated today to fix a few more admin cases where things like & symbols are incorrectly being converted to & amp;

The links above will always give you the latest version of the file compatible with v155x

Additional small fixes available:

• Fix alert to accommodate out-of-stock variations in shopping basket

• Authorize.net has changed their rollout plan for Akamai - update submission URL for faster performance.

• Shipping tax calculation on confirmation page, affecting only some stores in certain locales

Symptom: Admin Login "broken" in v1.5.5 - v1.5.5a with Google Chrome error: "Aw, snap"

Google Chrome 54.0.2840.59 is now forcefully disallowing the use of javascript function declarations of 'animate'. This interferes with the "spinner" that appears during admin login since v1.5.0

The fix, which will be included in v155b, is simple:

1. Open /admin/login.php in a code-safe text editor, such as Sublime Text:
2. Find and replace "animate(" with "waiting_spinner(". There will be 3 occurrences.
3. Save
   That's it. Login should now work again.

For a visual example of the changes, see: https://github.com/zencart/zencart/pull/1321/files
(exact position and line numbers may differ between Zen Cart versions)

Discussion: https://www.zen-cart.com/showthread.php?221226-Chrome-Browser-54-0-2840-59-64-bit-windows-cannot-log-into-admin

Update: v1.5.5b has been released, and addresses the issues listed earlier in this thread.

Details of inclusions and changed files: https://www.zen-cart.com/showthread.php?219730-Zen-Cart-v1-5-5b-released!&p=1321070#post1321070

v1.5.5c has been released!

**This fixes a critical bug in PHPMailer, which is the subsystem used for sending emails in Zen Cart. (PATCH REQUIRED FOR ALL ZEN CART VERSIONS)
**
Also addresses the following since v155b:

• Fix serious PHPMailer bug (upgraded to 5.2.19) -- [EDIT: Updated in v1.5.5d to 5.2.21]
• Fix some variable strict-type rule enforcement issues for better PHP 7 compatibility
• Fix sanitizer (admin) overzealous cleaning for Attribute Option Comments
• Fixed bug preventing sending Coupon and GV emails to "all customers"
• Fixed rarely-triggered bug with product-type overrides for delete/copy logic
• Fixed problem where deleting a customer wouldn't delete old product-notification requests associated with that customer
• Fixed PayPal Standard to no longer transmit a comma as thousands-separator. (PayPal is being more strict about this in 2017.)
• Fixed shopping-basket quantity alert problem where changing quantities didn't always fire if min/mix rules were set
• Make null-exception treatment consistent in admin to match catalog

AFFECTS ONLY v1.5.5c and v1.5.5d :

Symptom: SQL error: Incorrect datetime value: 'null' when editing products in the Admin.

Solution:
The quickest fix is to revert the /admin/includes/functions/database.php file to what was in v155b, by changing the 2 uppercase 'NULL' back to lowercase 'null' in the zen_db_perform() function, on lines 26 and 42:

          case 'NULL':

becomes

          case 'null':

https://github.com/zencart/zencart/commit/7adbc61c93ee09af3cfb5ff201ee18989eadd481

https://www.zen-cart.com/showthread.php?221640-v1-5-5d-database-php-Incorrect-datetime-value-null&p=1323749#post1323749

NOTE: IN FUTURE VERSIONS IT WILL BE CHANGED BACK TO UPPERCASE 'NULL'. So if you're using something newer than v1.5.5d, THE ABOVE "fix" DOES NOT APPLY TO YOU

v1.5.5e fixes a bug introduced in v1.5.5c related to deleting customers:

Symptom: If you try to delete a customer via the Admin, it would delete but would result in a blank page or an error message.

Fix: See: https://github.com/zencart/zencart/pull/1398/files

Symptom:
PHP Warning: A non-numeric value encountered in /includes/functions/functions_taxes.php on line 172

**Fix (applies to ZC v1.3.8-to-v1.5.5e): **
https://github.com/zencart/zencart/pull/1437/files