One-Page Checkout [Support Thread]

[lat9]

@simon1066, thanks for the report. I've created a GitHub issue to track the change required.

... and now that I've done that, I find that the 'as-shipped' Zen Cart orders.php doesn't include such a link.

What plugins do you have installed that 'participate' in orders' updates?

[gernot]

Hi @lat9

Some feedback from my translations.
I noticed that the language files for ot_coupon.php, ot_gv.php, and checkout_confirmation.php are from pretty old versions of ZC. Probably good to include modified versions from the latest 1.5.6c.
In particular, checkout_confirmation has some old text about out of stock items that can be put on backorder. As I understand it this is now in the main english.php file.
Hope I did not mess up something and get this wrong.

[simon1066]

... and now that I've done that, I find that the 'as-shipped' Zen Cart orders.php doesn't include such a link.

What plugins do you have installed that 'participate' in orders' updates?

Oh. I hadn't realised the link was non-stock. I can't think of a plugin off hand. I'll do some digging and get back.

[simon1066]

... and now that I've done that, I find that the 'as-shipped' Zen Cart orders.php doesn't include such a link.

What plugins do you have installed that 'participate' in orders' updates?

Not sure but I don't think that the orders.php is where we should be looking. The account_history_info link in the order update email is generated in includes/functions/functions_osh_update.php, starting line #116 - I believe this (and more?) code was moved out of orders.php in ZCv1.56

 //send emails
                $email_text =
                    STORE_NAME . ' ' . OSH_EMAIL_TEXT_ORDER_NUMBER . ' ' . $orders_id . "\n\n" .
                    OSH_EMAIL_TEXT_INVOICE_URL . ' ' . zen_catalog_href_link(FILENAME_CATALOG_ACCOUNT_HISTORY_INFO, "order_id=$orders_id", 'SSL') . "\n\n" .
                    OSH_EMAIL_TEXT_DATE_ORDERED . ' ' . zen_date_long($osh_info->fields['date_purchased']) . "\n\n" .
                    strip_tags($email_message) .
                    $status_text . $status_value_text .
                    OSH_EMAIL_TEXT_STATUS_PLEASE_REPLY;
           
                $html_msg['EMAIL_CUSTOMERS_NAME']    = $osh_info->fields['customers_name'];
                $html_msg['EMAIL_TEXT_ORDER_NUMBER'] = OSH_EMAIL_TEXT_ORDER_NUMBER . ' ' . $orders_id;
                $html_msg['EMAIL_TEXT_INVOICE_URL']  = '<a href="' . zen_catalog_href_link(FILENAME_CATALOG_ACCOUNT_HISTORY_INFO, "order_id=$orders_id", 'SSL') .'">' . str_replace(':', '', OSH_EMAIL_TEXT_INVOICE_URL) . '</a>';
                $html_msg['EMAIL_TEXT_DATE_ORDERED'] = OSH_EMAIL_TEXT_DATE_ORDERED . ' ' . zen_date_long($osh_info->fields['date_purchased']);
                $html_msg['EMAIL_TEXT_STATUS_COMMENTS'] = nl2br($email_message);
                $html_msg['EMAIL_TEXT_STATUS_UPDATED'] = str_replace("\n", '', $status_text);
                $html_msg['EMAIL_TEXT_STATUS_LABEL'] = str_replace("\n", '', $status_value_text);
                $html_msg['EMAIL_TEXT_NEW_STATUS'] = $new_orders_status_name;
                $html_msg['EMAIL_TEXT_STATUS_PLEASE_REPLY'] = str_replace("\n", '', OSH_EMAIL_TEXT_STATUS_PLEASE_REPLY);
                $html_msg['EMAIL_PAYPAL_TRANSID'] = '';

[simon1066]

... and on a slightly related note, I've now noticed I have osh_updated_by_functions.php in MY_STORE/includes/functions/extra_functions

That's one of your files @lat9, not really sure how it got there other than it seems part of your Orders Status History mod. I couldn't find the file in any of my plugin archives and had to resort to Google to find out what it was.

I don't know if it's being used by my site, I trust it's ok for me to delete it?

[simon1066]

... and on a slightly related note, I've now noticed I have osh_updated_by_functions.php in MY_STORE/includes/functions/extra_functions

That's one of your files @lat9, not really sure how it got there other than it seems part of your Orders Status History mod. I couldn't find the file in any of my plugin archives and had to resort to Google to find out what it was.

I don't know if it's being used by my site, I trust it's ok for me to delete it?

Never mind, it does look as though it's a remant of the 'Orders Status History - Updated By' plugin whose function was incorporated into ZCv1.56 last year.

[gernot]

I've just tested OPC guest checkouts on my testshop with Paypal express, and with Square (creating a new App for the testshop), works wonderfully.
I have a question about the Paypal setup though, could not find any mention of this in the documentation.
For standard 3-page checkout processing, the Paypal return URL is supposed (I think) to be set to:
https://www.mysite.com/MY_SHOP/index...eckout_process
For OPC, is this supposed to be kept as is, or better changed to something specific to OPC?

[lat9]

I've just tested OPC guest checkouts on my testshop with Paypal express, and with Square (creating a new App for the testshop), works wonderfully.
I have a question about the Paypal setup though, could not find any mention of this in the documentation.
For standard 3-page checkout processing, the Paypal return URL is supposed (I think) to be set to:
https://www.mysite.com/MY_SHOP/index...eckout_process
For OPC, is this supposed to be kept as is, or better changed to something specific to OPC?

For OPC, it's to be kept as-is.

OPC provides a combination of the checkout_shipping, checkout_payment and checkout_confirmation pages. The actual order-processing remains the same.

[gernot]

For OPC, it's to be kept as-is.

OPC provides a combination of the checkout_shipping, checkout_payment and checkout_confirmation pages. The actual order-processing remains the same.

Thank you very much indeed!