One-Page Checkout [Support Thread]

[jeking]

Zen Cart 1.5.5f
Template is M o z e n (forum won't let me post that word without the spaces)
OPC 2.3.4

I did follow the steps for 1.5.5f on GitHub

When trying to checkout, I'm getting a 500 error:
[26-Oct-2020 09:29:39 America/Chicago] PHP Parse error: syntax error, unexpected ')', expecting :: (T_PAAMAYIM_NEKUDOTAYIM) in /XXX/includes/modules/pages/checkout_one/header_php.php on line 355

Clearly this file is not the root cause. But if that's not the cause, where do I go looking for the real issue?

[strelitzia]

I'm having problems with Payment form styling changing if a user makes a change to the default shipping method after OPC page has loaded.
After inspecting the page in both conditions I've discovered that on initial page load the form fields all have

class="form-control"

But as soon as a shipping method is changed that class is removed from the form fields, messing up the form style.

Is there a fix for this, or do I need to modify my forms so they look nice without the "form-control" class?

[lat9]

I'm having problems with Payment form styling changing if a user makes a change to the default shipping method after OPC page has loaded.
After inspecting the page in both conditions I've discovered that on initial page load the form fields all have

class="form-control"

But as soon as a shipping method is changed that class is removed from the form fields, messing up the form style.

Is there a fix for this, or do I need to modify my forms so they look nice without the "form-control" class?

What version of Zen Cart and OPC is in use?
What template is in use? I'll note that the default OPC templating doesn't include any form-control classes.

[strelitzia]

What version of Zen Cart and OPC is in use?
What template is in use?

OPC version: 2.3.4
ZC version: 1.5.7
Template is a heavily modified template default that has undergone many changes/upgrades since it was first used by the client way back on zc 1.5.1
All the form fields have class="form-control" to provide uniform styling.

[lat9]

OPC version: 2.3.4
ZC version: 1.5.7
Template is a heavily modified template default that has undergone many changes/upgrades since it was first used by the client way back on zc 1.5.1
All the form fields have class="form-control" to provide uniform styling.

Did this issue start 'recently'?

Was the template and OPC working together on a previous version of Zen Cart?

Have you applied all the patches identified for zc157 (https://www.zen-cart.com/showthread....1-5-7-series)?

[strelitzia]

Did this issue start 'recently'?

Was the template and OPC working together on a previous version of Zen Cart?

Have you applied all the patches identified for zc157 (https://www.zen-cart.com/showthread....1-5-7-series)?

The site was using FEC up until the recent upgrade to 1.5.7, so no idea if OPC would have the same issues on an older version of zen cart.
Yes, all bug fixes listed in that thread have been implemented.

To be clear, I have no issue with the form at all when OPC page first loads. But as soon as a shipping method selection is changed, the class is removed from the payment method fields, breaking their layout. I can only assume something in the OPC code is doing this as it doesn't expect that class to exist. They still perform their task, just don't look pretty.

[lat9]

The site was using FEC up until the recent upgrade to 1.5.7, so no idea if OPC would have the same issues on an older version of zen cart.
Yes, all bug fixes listed in that thread have been implemented.

To be clear, I have no issue with the form at all when OPC page first loads. But as soon as a shipping method selection is changed, the class is removed from the payment method fields, breaking their layout. I can only assume something in the OPC code is doing this as it doesn't expect that class to exist. They still perform their task, just don't look pretty.

OPC's AJAX handler (which comes into play when the shipping method is changed) loads the current template's version of the various tpl_modules_opc_*.php files.

Are there, perchance, some leftover FEC files that are coming into play?

[carlwhat]

Zen Cart 1.5.5f
Template is M o z e n (forum won't let me post that word without the spaces)
OPC 2.3.4

I did follow the steps for 1.5.5f on GitHub

When trying to checkout, I'm getting a 500 error:
[26-Oct-2020 09:29:39 America/Chicago] PHP Parse error: syntax error, unexpected ')', expecting :: (T_PAAMAYIM_NEKUDOTAYIM) in /XXX/includes/modules/pages/checkout_one/header_php.php on line 355

Clearly this file is not the root cause. But if that's not the cause, where do I go looking for the real issue?

look for a double colon , ie ::

T_PAAMAYIM_NEKUDOTAYIM: It’s a name for the :: operator in PHP. It literally means "double colon". For some reason they named it in Hebrew. Check your code syntax, and put a :: where appropriate.

best.

[lat9]

Zen Cart 1.5.5f
Template is M o z e n (forum won't let me post that word without the spaces)
OPC 2.3.4

I did follow the steps for 1.5.5f on GitHub

When trying to checkout, I'm getting a 500 error:
[26-Oct-2020 09:29:39 America/Chicago] PHP Parse error: syntax error, unexpected ')', expecting :: (T_PAAMAYIM_NEKUDOTAYIM) in /XXX/includes/modules/pages/checkout_one/header_php.php on line 355

Clearly this file is not the root cause. But if that's not the cause, where do I go looking for the real issue?

I don't know where that header_php.php file 'came from', but that file hasn't changed since November of 2019.

Line 355 of the as-shipped version of the file is highlighted below:

// -----
// Determine if there are any payment modules that are in the confirmation-required list.
//
// The generated list is used within the /includes/modules/pages/checkout_one/jscript_main.php module to determine what text to
// display for the order-submittal text/title.
//
$required_list = '';
if (!empty(CHECKOUT_ONE_CONFIRMATION_REQUIRED)) {
    $confirmation_required = explode(',', CHECKOUT_ONE_CONFIRMATION_REQUIRED);
    $required_list = '"' . implode('", "', $confirmation_required) . '"';
}

[jeking]

I don't know where that header_php.php file 'came from', but that file hasn't changed since November of 2019.

Line 355 of the as-shipped version of the file is highlighted below:

// -----
// Determine if there are any payment modules that are in the confirmation-required list.
//
// The generated list is used within the /includes/modules/pages/checkout_one/jscript_main.php module to determine what text to
// display for the order-submittal text/title.
//
$required_list = '';
if (!empty(CHECKOUT_ONE_CONFIRMATION_REQUIRED)) {
    $confirmation_required = explode(',', CHECKOUT_ONE_CONFIRMATION_REQUIRED);
    $required_list = '"' . implode('", "', $confirmation_required) . '"';
}

This is why I'm confused. That's what's in the file: https://prnt.sc/v76rm3