
Originally Posted by
DrByte
After only a cursory look at the alpha code, I would like to just mention that it might be prudent to consider looking at the admin module code in consideration of overrides (yes, there "are" some overrides in the admin, but they're not template-related).
/admin/includes/modules/*.php -- these are "master" files
/admin/includes/modules/PRODUCT_TYPE/*.php -- these are the per-product-type overrides of the master
In the case of the product_music type, you'll see that several of the "master" files also exist (with some changes inside) in the product_music subfolder.
However, in the case of the main/base "product" product_type, you'll see only a couple files related to entering product details.
This mod makes changes to the copy_to_confirm.php module. However, by changing the "master" version of this file, you suddenly affect *all* product types on your site. If you're only using "product general", then I suppose it doesn't matter. But if you also have document products and perhaps products that use the free-shipping product type, or maybe a 3rd party addon product type such as books, then your changes to the 'master' modules *might* adversely affect those other product types as well.
Then again, MAYBE that IS what you want ... but if that's the case, you might need to document what changes will be required to the core code of those other product types as well.
I'm not sure whether your PC Configurator needs its own dedicated product-type, as I haven't inspected in great detail as yet. Nevertheless, that could be another option that might help prevent some confusion among product types.
It's not an urgent issue, and not a huge mistake ... but I thought I'd mention it for consideration while you're looking at refining things. What you choose depends on your goals.
The general rule would be ... if you're finding a need to touch a file in the /admin/includes/modules folder, you *most likely* should be putting your changes in the subfolder related to the product-type your changes specifically affect ... even if there's not already a file by that name IN that subfolder.
Bookmarks