Reward Points Module for ZC v13x

[kenwahl]

Here's a new version of the ot_reward_points_display.php- This should sort out the Google Checkout problem. Again copy it to includes\modules\order_total.

Thanks Hem

This version of ot_reward_points_display.php greatly improves its working with Google checkout. Below is an image of Google checkout now using the new php.



It now calculates $0 for the points but doesn't show any earned. Also doesn't seem to award them any points (I have it set to award on Google New, Google Processing and Earned on Google Shipped) but shows correct amount earned on invoice in ZenCart. I can manually give them their points for now though.

Thanks
Ken

[hem]

Thanks Hem

This version of ot_reward_points_display.php greatly improves its working with Google checkout. Below is an image of Google checkout now using the new php.



It now calculates $0 for the points but doesn't show any earned. Also doesn't seem to award them any points (I have it set to award on Google New, Google Processing and Earned on Google Shipped) but shows correct amount earned on invoice in ZenCart. I can manually give them their points for now though.

Thanks
Ken

Ken- that's as it should be. I've passed a 0 value to the reward_points_display. I'm going to talk to the author of the Google Checkout mod and see if we can't remove it from the actual checkout, but for now at least it is not coming up as a chargeable item.

As for the points not being awarded- As the points are calculated off of your order there should not be any difference. The reward_point_display mod is just that- a display mod and none of the values calculated are used anywhere else.

[hem]

Ken- that's as it should be. I've passed a 0 value to the reward_points_display. I'm going to talk to the author of the Google Checkout mod and see if we can't remove it from the actual checkout, but for now at least it is not coming up as a chargeable item.

Here's a quick hack of the googlecheckout.php which adds the reward_points_display module to Google Checkouts list of Order Total mods to ignore. Unfortunately is list is hard coded rather than databased hence the code change.

Just extract the php file to includes/modules/payment/

[kenwahl]

Here's a quick hack of the googlecheckout.php which adds the reward_points_display module to Google Checkouts list of Order Total mods to ignore. Unfortunately is list is hard coded rather than databased hence the code change.

Just extract the php file to includes/modules/payment/

Thanks Hem

This change works great. It no longer shows the Rewards points line in Google checkout like before.


I don't know how familiar you are with Google Checkout but it works different than most payment modules. Once the customer goes to Google Checkout (they don't log into zencart) they don't come back to the site. Thus, checkout success page isn't hit. Zen cart gets a notification via responsehandler.php that a purchase was made and passes all the info on the order to zencart. It doesn't seem that something is getting triggered to award them there points when their order is created after notification from the responsehandler. Though it does show how many points were awarded on their invoice.

I have Reward Point Status Track set to:

Pend: [Pending, Processing, Google New, Google Processing] Earn: [Shipped, Google Shipped]

I have both Pending & Processing set because I had a problem with it changing from Pending to Processing so fast that it was like it was never in Pending status and didn't award points.

Thanks
Ken

[hem]

Thanks Hem

This change works great. It no longer shows the Rewards points line in Google checkout like before.


I don't know how familiar you are with Google Checkout but it works different than most payment modules. Once the customer goes to Google Checkout (they don't log into zencart) they don't come back to the site. Thus, checkout success page isn't hit. Zen cart gets a notification via responsehandler.php that a purchase was made and passes all the info on the order to zencart. It doesn't seem that something is getting triggered to award them there points when their order is created after notification from the responsehandler. Though it does show how many points were awarded on their invoice.

I have Reward Point Status Track set to:

Pend: [Pending, Processing, Google New, Google Processing] Earn: [Shipped, Google Shipped]

I have both Pending & Processing set because I had a problem with it changing from Pending to Processing so fast that it was like it was never in Pending status and didn't award points.

Thanks
Ken

Ken, I've checked it out and it's because the responsehandler does not call any of the ZenCart notifiers. As the "store points awarded" code is hooked to NOTIFY_CHECKOUT_PROCESS_AFTER_ORDER_CREATE_ADD_PRODUCTS this is never called and therefore no points get stored. I'm afraid that it's something the Google Checkout team will need to address.

[kenwahl]

Ken, I've checked it out and it's because the responsehandler does not call any of the ZenCart notifiers. As the "store points awarded" code is hooked to NOTIFY_CHECKOUT_PROCESS_AFTER_ORDER_CREATE_ADD_PRODUCTS this is never called and therefore no points get stored. I'm afraid that it's something the Google Checkout team will need to address.

Thanks Hem

Thats what I was afraid would be the case.

Just one more question on Google Checkout. Do you think it would be possible in some way to pass the info to Reward Points via Google Checkouts AddThirdPartyTracking in googlecheckout/library/googlecart.php (around line 389)? I know that is what JROX affiliate module has to do. an example line for JROX is:

$cart->AddThirdPartyTracking("www.YOURDOMAIN.com/JAMINSTALLATION/sale.php?",array('trans_id','amount' => 'order-total'));

Thanks
Ken