GOB Package Trackers module - Support Thread

Am I in the support thread?

Seriously? If your going to make something for the community, you need to support it as well.

scupoli:

Seriously? If your going to make something for the community, you need to support it as well.
LOL ... in a perfect world!

Maybe you should try this: https://www.zen-cart.com/tutorials/index.php?article=82

This did nothing. I have "Strict Error Reporting Is On" On the top of my screen but it isn't showing any errors. And there clearly is a error cause of the white screen.

Tested on your site with your account. Gives an error 500.

Have checked the module. All is running absolutely good on my computer. Have access to the previous Orders normally with the tracking numbers displayed.

The module is good, if not, other people would have noticed me that pb long time before.

Certainly you have a typo introduced by cutting and pasting.
See commas at at of lines.
Recheck or use 'debug error utility' from ZC modules to get the bad line.

PS: Im not online everyday to do support for customers and their shops. Its GPL.

Can I get a hint on where the mistake would be. Error Reporting isn't working for me. Would it be front end code or back end code where the admin area code is?

Please, just post your code here so I can see what I did wrong.

Or you can just look at my code. Please if someone can help I would appreciate it.

http://www.keysandmice.com/code.zip

The FAQ article I quoted FIRST tells you to install the Debug Logging tool. What did that reveal when you did it?
Enabling Strict Error Reporting is something ELSE to do as a secondary idea, not the first step.

gob33 has generously responded and looked at your site and confirmed that the module itself is not the problem. Perhaps comparing your code to the original module code would be a good step?

I've done this three times.

Generously? Generously would be actually looking at my code. Would take a few minutes. I can see where this is going. So I'm going to unistall the damn thing.

Thanks for nothing.

Before anyone judges me, I asked politely for help via PMs and here on the forums. These people didn't lift a finger to help. They seem very arrogant and too busy to help anyone here.

Incredible!

Attached are my working files with tracking incorporated for the store front.
400+ people have downloaded that damn module without returning problems.

Thank you!!!

I really appreciate you getting back to me and trying to help.
I was missing a syntax on header.php. I fixed it.

Thank you, Scott
Pb fixed. Be warned, users, to be carefull when patching the source.

When changing to this:

6. Edit "admin/orders.php"

6.1) Line 589, add 1 piece :

              <tr>
                <td class="main"><strong><?php echo ENTRY_NOTIFY_CUSTOMER; ?></strong> <?php echo zen_draw_checkbox_field('notify', '', true); ?></td>
                <!-- GOB_PACKAGE_TRACKERS_MODIFICATION_BEGIN -->
                <td class="main"><strong><?php echo ENTRY_NOTIFY_TRACKING; ?></strong> <?php echo zen_draw_checkbox_field('notify_tracking', '', true); ?></td>
                <!-- GOB_PACKAGE_TRACKERS_MODIFICATION_END -->
                <td class="main"><strong><?php echo ENTRY_NOTIFY_COMMENTS; ?></strong> <?php echo zen_draw_checkbox_field('notify_comments', '', true); ?></td>
              </tr>

from this:

              <tr>
                <td class="main"><strong><?php echo ENTRY_NOTIFY_CUSTOMER; ?></strong> [<?php echo zen_draw_radio_field('notify', '1', true) . '-' . TEXT_EMAIL . ' ' . zen_draw_radio_field('notify', '0', FALSE) . '-' . TEXT_NOEMAIL . ' ' . zen_draw_radio_field('notify', '-1', FALSE) . '-' . TEXT_HIDE; ?>]   </td>

                <!-- GOB_PACKAGE_TRACKERS_MODIFICATION_BEGIN -->
                <td class="main"><strong><?php echo ENTRY_NOTIFY_TRACKING; ?></strong> <?php echo zen_draw_checkbox_field('notify_tracking', '', true); ?></td>
                <!-- GOB_PACKAGE_TRACKERS_MODIFICATION_END -->

                <td class="main"><strong><?php echo ENTRY_NOTIFY_COMMENTS; ?></strong> <?php echo zen_draw_checkbox_field('notify_comments', '', true); ?></td>

Your emails are not sent!

If I use the second code above it works fine. What is the problem here?

In addition why are no tracking numbers sent if there are no comments on the order?

1. No problem there.
   The modifs to do are between the labels <!--GOB_PACKAGE_TRACKERS_MODIFICATION_XXXX --> only.
   You have copied a line from ZC 1.3.8 (when that module was published).
   That line has been changed in 1.3.9 in:

      <td class="main"><strong><?php echo ENTRY_NOTIFY_CUSTOMER; ?></strong> [<?php echo zen_draw_radio_field('notify', '1', true) . '-' . TEXT_EMAIL . ' ' . zen_draw_radio_field('notify', '0', FALSE) . '-' . TEXT_NOEMAIL . ' ' . zen_draw_radio_field('notify', '-1', FALSE) . '-' . TEXT_HIDE; ?>]   </td> 

Simply insert the modif between labels without changing the code.

2. This is the standart behaviour of orders emails in ZC.
   A comment or an order status change is needed for the email to be send.
   Line 122 of admin\orders.php says:

        if ( ($check_status->fields['orders_status'] != $status) || zen_not_null($comments)) {
          $db->Execute("update " . TABLE_ORDERS . "
          .....

If you need to send an email, put some char like '-' in the comments.

gob,

Thanks for getting back to me on this.

Yes, that is the mistake I was making. I was changing the whole section of the code that appeared in your installation guide.
It seems to be working great now! This is a perfect little contribution for setting up tracking codes for shipping, and makes our shop's life a lot easier now we don't have to manually enter the tracking numbers each time!
The only thing that was slightly confusing was the layout of the installation instructions.

Thanks GOB!

gob33,

Great mod. Thanks for the contribution. I found a couple of errors in the package_trackers_install_so.txt file for those want to use this mod with super orders.

I was having problems getting the customer notified indicator to update properly with a green check mark on the status history display. When i checked my database, the customer_notified field was set to 0 even though I select to notify customer and received the status update email.

Reviewing your php modifications, i found the following issues:

package_trackers_install_so.txt says:
4) Edit "admin/includes/functions/extra_functions/super_orders_functions.php"
4.1) Line 392, find the function:

/////////////////
// Function    : update_status
// Arguments   : oID, new_status, notified(optional), comments(optional)
// Return      : none
// Description : Adds a new status entry to an order
/////////////////
function update_status($oID, $new_status, $notified = 0, $comments = '') {
  global $db;

  if ($notified == 'on')
       $cust_notified = 1;
  else
       $cust_notified = 0;

should say ($notified == 'no' replaced by $notified == '1'):

/////////////////
// Function    : update_status
// Arguments   : oID, new_status, notified(optional), comments(optional)
// Return      : none
// Description : Adds a new status entry to an order
/////////////////
function update_status($oID, $new_status, $notified = 0, $comments = '') {
  global $db;

  if ($notified == '1')
       $cust_notified = 1;
  else
       $cust_notified = 0;

also package_trackers_install_so.txt says:
7) Edit "admin/super_orders.php"
...
7.4) Line 118, change these 3 lines:

          update_status($oID, $status, $notify, $comments);

          if ($customer_notified == '1') {
            email_latest_status($oID);
          }

to these lines:

          // GOB_PACKAGE_TRACKERS_MODIFICATION_BEGIN
          update_status($oID, $status, $notify, $comments, $tracker_id, $tracking_numbers);
          // GOB_PACKAGE_TRACKERS_MODIFICATION_END

should say ($notify replaced by $customer_notified):

          update_status($oID, $status, $customer_notified, $comments);

          if ($customer_notified == '1') {
            email_latest_status($oID);
          }

to these lines:

          // GOB_PACKAGE_TRACKERS_MODIFICATION_BEGIN
          update_status($oID, $status, $customer_notified, $comments, $tracker_id, $tracking_numbers);
          // GOB_PACKAGE_TRACKERS_MODIFICATION_END

Once I made these changes, the customer_notified field correctly would update to value 1 on future status updates where notification was sent. Also green check mark showed up on customer notified field in super orders status history.

Software Guy has changed the code of Super Orders a little since v2.0rev47 by Frank Koehl.
I suppose users have compared the code when doing modifications and adapted accordingly.
Thanks for noticing these 2 changements.

Thank you for great contribution, works great on 1.3.9.e! Maybe one thing which i would like to change - in orders, your contrib added customer comments - i rather like box with track id of package. (less clicks to see the status) but otherwise, it´s really cool! thanks a lot!:clap: