[Done v1.3.9e/f] 139c DoExpressCheckoutPayment variables missing

I noticed the PayPal emails returning sales info were missing the products details. I checked some data and found these variables were not being sent via DoExpressCheckoutPayment when using 139c versus 138.

L_NUMBER(x)
L_QTY(x)
L_NAME(x)
L_AMT(x)
L_TAXAMT(x)

It should only skip those kinds of items when there are discounts or calculation problems which would throw off PayPal's validation.

I'd need to see your detailed PayPalXXXXXXXXXX.log debug log files to know more why it's doing that.

OK, see attachment.
for password see PM

I know this was not marked as fixed for 139d but I though I would see what it does. I installed the boilerplate store with no template changes. Installed PayPal express. Changed the price of an item to one dollar. And made a purchase.

Still missing. See attachment
L_NUMBER(x)
L_QTY(x)
L_NAME(x)
L_AMT(x)
L_TAXAMT(x)

This information is useful as a backup to the Zen Cart data. And PayPal can use it for "items not as described" complaints.

The following modification fixed the issue for me. I warn it may not fix it for others.

replace a line 1262 in file paypalwpp.php
if ($sumofLineItems == 0) {

with
if ($sumofLineItems === 0) {

There must be a difference between being Equal and Identical. Or the change may just shut down the equation altogether and bypass the needed logic. I don't know, not smart enough. I need the line items and am willing to take the chance at the moment.

Dennis

I may have found the bug.
Is
$sumofLineItems
and
$sumOfLineItems

two different varaiables?

Yes, that would be a problem. The uppercase "O" should be used.
We'll roll that fix into v1.3.9e.

Dennis does the happy fat man dance around the house. Happy to make the find.:clap:

Thank You Stagebrace ! Recently upgraded from 1.3.8a to 1.3.9d and found that order details were now missing from PayPal packing slips. Correcting the misspelling of the variable $sumOfLineItems solved the problem immediately. My PayPal packing slips are important to the business and now they work correctly.

Would that mean the $sumoLineTax should be changed as well?

Payphone line 606 and others. Seems like same case mistake everywhere sumofLineItems appears.

dbltoe:

Would that mean the $sumoLineTax should be changed as well?

Payphone line 606 and others. Seems like same case mistake everywhere sumofLineItems appears.

Just skimmed through this file myself - I think you are right on the money.

$sumofLineTax only appears once in the whole file, no reference in any other formula.

auto-spellchecker got me:shocking:

Payphone line 606 and others.shoulda been> shows up on line 1606 and other files.

stagebrace:

The following modification fixed the issue for me. I warn it may not fix it for others.

replace a line 1262 in file paypalwpp.php
if ($sumofLineItems == 0) {

with
if ($sumofLineItems === 0) {

There must be a difference between being Equal and Identical. Or the change may just shut down the equation altogether and bypass the needed logic. I don't know, not smart enough. I need the line items and am willing to take the chance at the moment.

Dennis
I noticed your use of the triple = instead of the more common double. Although this is true for solving strange problems within JS, is it also true for PHP?

I also noticed 'paypalwpp.php' has neither a closing ?> nor EOF. Any concern with that?

Rob,
Need to read up a few posts. I think the === was not required once the sumofLineItems was changed to sumOfLineItems.

Understood, but it is the specific use of === within PHP that I am curious about. I have only seen that used within JS.

Website Rob:

Understood, but it is the specific use of === within PHP that I am curious about. I have only seen that used within JS.

It's a perfectly valid operator in PHP when doing type-matching: http://php.net/manual/en/language.operators.comparison.php

And ... you're way off topic for this bug-fix thread :blush:

Website Rob:

I also noticed 'paypalwpp.php' has neither a closing ?> nor EOF. Any concern with that?That's been common practice now in Zen Cart for several years, starting in various files touched since v1.3.7.1: https://www.zen-cart.com/tutorials/index.php?article=313

NOTE: v1.3.9e has now been released and contains the fixes to the issue described by stagebrace initially. See the News & Announcements section of the forum for details.

$sumofLineTax is still at line 1264 of the paypalwpp.php:(

In the // Sanity Check> // Sanity Check of line-item subtotals

for ($j=0; $j<$k; $j++) {
  $itemAMT = $optionsLI["L_AMT$j"];
  $itemQTY = $optionsLI["L_QTY$j"];
  $itemTAX = (isset($optionsLI["L_TAXAMT$j"]) ? $optionsLI["L_TAXAMT$j"] : 0);
  $sumOfLineItems += ($itemQTY * $itemAMT);
  $sumOfLineTax += ($itemQTY * $itemTAX);
}
$sumOfLineItems = round($sumOfLineItems, 2);
$sumOfLineTax = round($sumOfLineTax, 2);

if ($sumOfLineItems == 0) {
  $sumofLineTax = 0;
  $optionsLI = array();
  $discountProblemsFlag = TRUE;
  if ($optionsST['SHIPPINGAMT'] == $optionsST['AMT']) {
    $optionsST['SHIPPINGAMT'] = 0;
  }
}

So it is. :(