Edit Orders v3.0 for ZC 1.3.9 [Support Thread]

I found a file that i thought would fix the email issue:

I downloaded the edit_orders_v3.03 the end of march and in the admin/includes/functions/extra functions folder common_orders_functions.php is slightly different from the file in the newest version in the download section.

replacing this did not solve my issue however.

athena:

I found a file that i thought would fix the email issue:

I downloaded the edit_orders_v3.03 the end of march and in the admin/includes/functions/extra functions folder common_orders_functions.php is slightly different from the file in the newest version in the download section.

replacing this did not solve my issue however.
I wish I could provide more insight.. I cannot reproduce this issue nor has anyone else reported it.. Makes it nearly impossible to troubleshoot..

i will try and isolate it, and post if i find it, but may just re do the entire cart

I'm merging a fresh orders.php file from 1.3.9h with Edit orders core edits using Winmerge.

I've read here that there are three edits to orders.php but I'm seeing a difference in the files and fear merging the change when it is not notated to be Edit orders specific is part of my problem with my install.

Here is the original orders.php section about line 550..and i did a search here for class="dataTableHeadingContent with no results.

<tr>
        <td class="main">
<table border="1" cellspacing="0" cellpadding="5">
          <tr>
            <td class="smallText" align="center"><strong><?php echo TABLE_HEADING_DATE_ADDED; ?></strong></td>
            <td class="smallText" align="center"><strong><?php echo TABLE_HEADING_CUSTOMER_NOTIFIED; ?></strong></td>

            <td class="smallText" align="center"><strong><?php echo TABLE_HEADING_STATUS; ?></strong></td>
            <td class="smallText" align="center"><strong><?php echo TABLE_HEADING_COMMENTS; ?></strong></td>
          </tr>

that same section in the edit orders version without any notation it is edit orders specific. Question: should this take the place of the above?:

<tr>
        <td class="main" valign="top">
	<table border="1" cellspacing="0" cellpadding="5" width="60%">
          <tr class="dataTableHeadingRow">
            <td class="dataTableHeadingContent smallText" valign="top"  width="21%"><strong><?php echo TABLE_HEADING_DATE_ADDED; ?></strong></td>
            <td class="dataTableHeadingContent smallText" align="center" valign="top" width="18%"><strong><?php echo TABLE_HEADING_CUSTOMER_NOTIFIED; 
?></strong></td>
            <td class="dataTableHeadingContent smallText" valign="top" width="17%"><strong><?php echo TABLE_HEADING_STATUS; ?></strong></td>
            <td class="dataTableHeadingContent smallText" valign="top" width="44%">
<strong><?php echo TABLE_HEADING_COMMENTS; ?></strong></td>
          </tr>

i meant to say there are three button edits to orders.php, one icon edit to orders.php and one edit to include the css for Edit Orders. There are other differences with the files, but I ignored those. moving on....

i can see some potential with winmerge to save as the wrong file into your site folder.

one thing i notice is that the email being sent to the customer on an updated order from edit_orders.php on my test site...live site still sending scrambled code...

is that the email template is not the email_template_order_status.html but email_template_default.html

their is a problem with the Detail Invoice: link. It does not not hide the url in the email.

I've spent some time going over these files and can not see any difference in how the url is handled except the difference in the email template used by orders.php vs edit_orders.php

athena:

one thing i notice is that the email being sent to the customer on an updated order from edit_orders.php on my test site...live site still sending scrambled code...This tells me that there is some difference between your live server and your test server which is the cause of the scrambled customer e-mails.. Can't say what.. but it does sound like the issue is related to your server's configuration..

Hi ....yes, they are on two different servers but the live sight has a lot of mods on it.

I stripped my test sight bare... and reloaded everything.

Is the edit orders supposed to use the default email template? It does not look as nice...does not say Dear So and so....and that link showing the full url. Does this sound like I've edited something wrong in merging the files?

athena:

Hi ....yes, they are on two different servers but the live sight has a lot of mods on it.

I stripped my test sight bare... and reloaded everything.

Is the edit orders supposed to use the default email template? It does not look as nice...does not say Dear So and so....and that link showing the full url. Does this sound like I've edited something wrong in merging the files?Edit Orders uses the same after order comments functions as found in the default orders.php. Like the default order comments, Edit Orders has NEVER had features which send out e-mails which look anything like the e-mails customer gets when the order is first placed..

When I first set up the new store a few weeks ago, I did merge my old email folder with the new. I went back and found that my style divs seemed to be causing an issue with edit_orders emails...so removed them and the weird code thing disappeared, but the full url to the invoice is still showing.

Reading the ZenCart manual on email formatting is priceless information...tend to forget I have this baby on the shelf.

So Edit Orders seems to be working as it should with Click and Ship ...Yeah!

Just a few tweaks to go...

You know, I wonder if someone who has orders.php inabled to work with edit orders, not hidden as is an option with super orders, could do a test to see if the email coming from edit_orders.php when you update from there is the email_template_default.

I've proven to myself that they are not sending the same email template.

I'm wondering if for some reason there is a by pass in place where if edit_orders.php doesn't like the email_template_order_status.html it goes to the default? Is that silly?

athena:

You know, I wonder if someone who has orders.php inabled to work with edit orders, not hidden as is an option with super orders, could do a test to see if the email coming from edit_orders.php when you update from there is the email_template_default.

I've proven to myself that they are not sending the same email template.

I'm wondering if for some reason there is a by pass in place where if edit_orders.php doesn't like the email_template_order_status.html it goes to the default? Is that silly?

No not silly, and you are correct that edit orders does send the email_template_default.

To correct this open admin/edit_orders.php and find the following line of code (around line 187)

              zen_mail($check_status->fields['customers_name'], $check_status->fields['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_NAME, STORE_OWNER_EMAIL_ADDRESS, $html_msg, NULL);

and replace it with this:

              zen_mail($check_status->fields['customers_name'], $check_status->fields['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_NAME, STORE_OWNER_EMAIL_ADDRESS, $html_msg, 'order_status');

You know, I wonder if someone who has orders.php inabled to work with edit orders, not hidden as is an option with super orders, could do a test to see if the email coming from edit_orders.php when you update from there is the email_template_default.

I am working with 1.3.9h Edit Orders WITHOUT Super Orders. When the same product was updated from orders.php and edit_order.php, respectively, it generated two emails which are clearly different...not by much, but just different. The problem for me is I have no idea how to find the template used for each respective email.

HTH.

JJ

deleted

Good good...thank you....i'm not alone.....we are on to something...

In the email folder:

your_shop > email

are all the templates that the site sends out.

In your Doc folder are instructions about how emails are used: 4.readme_html_email_templates.html

the order status email should have these fields:

Order Status Updates from Admin
$EMAIL_CUSTOMERS_NAME (extracted from Orders table -- combines first/last names based on what's in DB)
$EMAIL_STORE_NAME
$EMAIL_TEXT_ORDER_NUMBER (Order Number from database)
$EMAIL_TEXT_INVOICE_URL (URL to access "My Account History")
$EMAIL_TEXT_DATE_ORDERED (Order Date)
$EMAIL_TEXT_STATUS_UPDATED ("Has been updated to:")
$EMAIL_TEXT_STATUS_LABEL ("New Status:")
$EMAIL_TEXT_NEW_STATUS (actual status description and comments)
$EMAIL_TEXT_STATUS_PLEASE_REPLY ("Please reply to this address if you have questions")

but the default template only has these:

$EMAIL_SUBJECT
    $EMAIL_MESSAGE_HTML

oh, just saw this...thank you thank you...

there are two places where this code appears......change both or just the one?

oh i get it...one for text email the other for html

clydejones:

No not silly, and you are correct that edit orders does send the email_template_default.

To correct this open admin/edit_orders.php and find the following line of code (around line 187)

          zen_mail($check_status->fields['customers_name'], $check_status->fields['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_NAME, STORE_OWNER_EMAIL_ADDRESS, $html_msg, NULL);

> and replace it with this:
> 
> ```
              zen_mail($check_status->fields['customers_name'], $check_status->fields['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_NAME, STORE_OWNER_EMAIL_ADDRESS, $html_msg, 'order_status');

Nice catch Clyde!!:clap:

Honestly as someone just pointed out, the difference is so subtle I never noticed this.. Wasn't something we were looking for or targeting specifically when we submitted this version..

As you know ALL of this module is based on the Scott's original contribution.. Other than cleaning a few things up and adding a few new behaviors (to support Super Orders the way this mod has always worked with the default orders.php), this is still all the original contributions code..

I'll test myself, and if my time permits, make this minor change and resubmit it..

clydejones:

No not silly, and you are correct that edit orders does send the email_template_default.

To correct this open admin/edit_orders.php and find the following line of code (around line 187)

          zen_mail($check_status->fields['customers_name'], $check_status->fields['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_NAME, STORE_OWNER_EMAIL_ADDRESS, $html_msg, NULL);

> 
> ```
              zen_mail($check_status->fields['customers_name'], $check_status->fields['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_NAME, STORE_OWNER_EMAIL_ADDRESS, $html_msg, 'order_status');

that must be the code that also has the url problem....

no text link..just the full url after Detail Invoice:

I'm sorry to say that did not fix it. It sent the right email template but the fields are not filled out. :(

It also did not send the copy of email to that set in the email admin

DivaVocals:

Nice catch Clyde!!:clap:

Honestly as someone just pointed out, the difference is so subtle I never noticed this.. Wasn't something we were looking for or targeting specifically when we submitted this version..

As you know ALL of this module is based on the Scott's original contribution.. Other than cleaning a few things up and adding a few new behaviors (to support Super Orders the way this mod has always worked with the default orders.php), this is still all the original contributions code..

I'll test myself, and if my time permits, make this minor change and resubmit it..

I just double checked and there is another line of code (around line 765) that should be changed also.