Edit Orders v3.0 for ZC 1.3.9 [Support Thread]

did your order update email look ok?

When we tested Edit Orders we tested it's functionality for those who would be using Super Orders and for those who would NOT be using Super Orders. We recognized that not all shopowners will be using Super Orders (nor are they required to). So we had to test for both types of shop configurations..

Meaning??

We did the kind of testing you are asking about.. We tested Edit Orders, and viewed the results of the order changes made in the Edit Orders mod (order comments, totals, and product updates) in the default orders.php view and in super_orders.php view.

The results of these tests??

the default orders.php results MATCH the super_orders.php results. (As Super Orders is based on the default orders.php, and as the readme indicated Super Orders ADDS to the default features -- versus modifying default features -- so the results came as no surprise)

We had NO ISSUES in any of our testing (and there were three of us testing) with the comments functions in Edit Orders working as expected..

clydejones:

I just double checked and there is another line of code (around line 765) that should be changed also.I'll look at it this weekend.. But should this be the same change??

it is not working, guys...please let me know if your emails look the way they should. Mine order update email just had the fields...nothing filled out.

Dear $EMAIL_CUSTOMERS_NAME,

$EMAIL_TEXT_ORDER_NUMBER

$EMAIL_TEXT_INVOICE_URL

$EMAIL_TEXT_DATE_ORDERED

$EMAIL_TEXT_STATUS_COMMENTS

$EMAIL_TEXT_STATUS_UPDATED

$EMAIL_TEXT_STATUS_LABEL

$EMAIL_TEXT_STATUS_PLEASE_REPLY

at least it is the right template

The edit Clyde suggested should not cause a blank e-mail.. And Since the unmodified version of Edit Orders also did not send out blank e-mails, this only leaves the likelyhood that you've made other edits to the files which are causing the issues you are reporting..

You need to double check your edits..

athena:

it is not working, guys...please let me know if your emails look the way they should. Mine order update email just had the fields...nothing filled out.

Dear $EMAIL_CUSTOMERS_NAME,

$EMAIL_TEXT_ORDER_NUMBER

$EMAIL_TEXT_INVOICE_URL

$EMAIL_TEXT_DATE_ORDERED

$EMAIL_TEXT_STATUS_COMMENTS

$EMAIL_TEXT_STATUS_UPDATED

$EMAIL_TEXT_STATUS_LABEL

$EMAIL_TEXT_STATUS_PLEASE_REPLY

athena:

that must be the code that also has the url problem....

no text link..just the full url after Detail Invoice:

athena:

I'm sorry to say that did not fix it. It sent the right email template but the fields are not filled out. :(

It also did not send the copy of email to that set in the email admin

Did you check for a "plain text" email or are you only looking for an "html" email?

If you are looking for an "html" email then edit orders (as it is currently) does not have the necessary code in the sections that handle the email to provide that functionality.

likewise, the functionality to send a copy of the email is not included in the current version of edit orders.

The full URL after the detail invoice is the way the email section is coded. (<a href="' . zen_catalog_href_link(FILENAME_CATALOG_ACCOUNT_HISTORY_INFO, 'order_id=' . $oID, 'SSL') . '">' . zen_catalog_href_link(FILENAME_CATALOG_ACCOUNT_HISTORY_INFO, 'order_id=' . $oID, 'SSL') . "</a>)```

ok..clyde..thanks ...ws typing as you posted....

but does that mean you need to set your preferences to text for default?

athena:

ok..clyde..thanks ...ws typing as you posted....

but does that mean you need to set your preferences to text for default?

Are you talking about the customer or the admin side?

I'm looking at the emails that go the customer.....they have always been in html format for our store....I assume...yes i guess the customer can set a preference for text....have to check that...but what happens if they choose html...

I have mime set to true in admin > config > email

hmmmmm.....maybe I can disable the radio button for "notify customer" on the edit orders.php .....that seems messy

text emails look ok when i have the admin set for text only.....but why did it send the email_template_default with fields filled in. My only gripe with that at the time was the look of the email...it did get the message accross however.

tested by updating an order from a test customer with our email address on the edit_orders.php page.

athena:

text emails look ok when i have the admin set for text only.....but why did it send the email_template_default with fields filled in. My only gripe with that at the time was the look of the email...it did get the message accross however.

tested by updating an order from a test customer with our email address on the edit_orders.php page.

I have no idea as to why the email_template_default was being used. Thats the way the author of the mod created it. As Diva said, except for the tweaks to make it work with super orders, ALL of the code is from the original edit orders mod.

Here's a modified version of edit_orders.php that should send the emails using the "email_template_order_status.html", It should also send a copy of the email to admin.

Attachment #9109

Just unzip the package and upload the edit_orders.php file to your admin folder.

thank you for helping with this.

i did replace my admin > edit orders.php with the file in the zip and got a blank page...

I think I'll just sit tight until a formal update to this mod comes along.

I appreciate everyone's input...and just knowing how edit orders is meant to work so I don't have unreasonable expectations.

athena:

thank you for helping with this.

i did replace my admin > edit orders.php with the file in the zip and got a blank page...

I think I'll just sit tight until a formal update to this mod comes along.

I appreciate everyone's input...and just knowing how edit orders is meant to work so I don't have unreasonable expectations.

Try this:

Attachment #9110

athena:

thank you for helping with this.

i did replace my admin > edit orders.php with the file in the zip and got a blank page...

I think I'll just sit tight until a formal update to this mod comes along.

I appreciate everyone's input...and just knowing how edit orders is meant to work so I don't have unreasonable expectations.Well I suggest you don't do that.. I can only work on this in my SPARE time (this means no PAID client work and NO day job obligations)

It's MORE THAN likely that all I will do anyway is test, confirm, and submit Clyde's modifications posted above..

That said, one of the things I looked at doing one day when MY TIME permits, is to synchronize the Edit Orders comments code to look/act like the default orders.php. (for the record, this is ONE of the big changes we made that will be seen in the next Super Orders release -- AND BEFORE ANYONE ASKS -- when I get time to finalize it, I will release it -- I work on it a little bit at a time -- should be soon..)

It would be a CHALLENGE for me to do this since I am NOT really a coder, but I am not afraid!!!:laugh: This is also why it won't happen tomorrow, but it is on my "to-do" list (or should I say my "to-try list")..:laugh:

Hi clyde

ok..so this did send an email copy to spec address in admin > configuration > email options > send copy to admin order status etc.

but it was just this text:

Subject line: [ORDERS STATUS] Order Update #6817

This email address was given to us by you or by one of our customers. If you
feel that you have received this email in error, please send an email to
[email protected]
This e-mail is sent in accordance with the US CAN-SPAM Law in effect
01/01/2004. Removal requests can be sent to this address and will be honored
and respected.

The email that came to the customer had just "order update" in the subject line.

The email looked correct in every way and is email_template_order_status.html

but only the comments section was filled in.

then below that:

EMAIL_TEXT_STATUS_UPDATED
EMAIL_TEXT_STATUS_LABEL
Please reply to this email if you have any questions.

athena:

Hi clyde

ok..so this did send an email copy to spec address in admin > configuration > email options > send copy to admin order status etc.

but it was just this text:

The email that came to the customer had just "order update" in the subject line.

The email looked correct in every way and is email_template_order_status.html

but only the comments section was filled in.

then below that:

I'll check some more: looks like the language file may need to be updated as well.

here is the code that is not cooperating:

there is a blank line below the comments

$html_msg['EMAIL_TEXT_STATUS_UPDATED'] = str_replace('\n','', EMAIL_TEXT_STATUS_UPDATED);
            $html_msg['EMAIL_TEXT_STATUS_LABEL'] = str_replace('\n','', sprintf(EMAIL_TEXT_STATUS_LABEL, $orders_status_array[$status] ));
            $html_msg['EMAIL_TEXT_NEW_STATUS'] = $orders_status_array[$status];

complete email without header:

Dear Tommy Tester Tester,

Order Number: 6817

Detailed Invoice

Date Ordered: Friday 22 January, 2010

Comments:
testing if this will send copy email to me

EMAIL_TEXT_STATUS_UPDATED

EMAIL_TEXT_STATUS_LABEL

Please reply to this email if you have any questions.

My Shop

athena:

here is the code that is not cooperating:

there is a blank line below the comments

$html_msg['EMAIL_TEXT_STATUS_UPDATED'] = str_replace('\n','', EMAIL_TEXT_STATUS_UPDATED);
$html_msg['EMAIL_TEXT_STATUS_LABEL'] = str_replace('\n','', sprintf(EMAIL_TEXT_STATUS_LABEL, $orders_status_array[$status] ));
$html_msg['EMAIL_TEXT_NEW_STATUS'] = $orders_status_array[$status];

> 
> 
> complete email without header:
> 
> Dear Tommy Tester Tester,
> 
> Order Number: 6817
> 
> Detailed Invoice
> 
> Date Ordered: Friday 22 January, 2010
> 
> Comments:
> testing if this will send copy email to me
> 
> 
> 
> EMAIL_TEXT_STATUS_UPDATED
> 
> EMAIL_TEXT_STATUS_LABEL
> 
> Please reply to this email if you have any questions.
> 
> My Shop

Hope this solves it.

unzip the package - rename the YOUR_ADMIN folder to match the name of your admin folder - upload/FTP to your server.

Attachment #9111

and let me add this.. I'm still not sure this is an actual "issue".. Though I've sorta followed all of this, I lost track of what is wrong or being fixed.. Sorry -- with all of the back to back to back posts, there's now THREE pages of stuff to sort through on this one "issue". So it's been difficult to get a real sense of "what's really WRONG here"..

On a high level, I do understand what Clyde did, but until I look at it in detail, I'm not completely sure that there is an actual issue here to be "fixed"..

All that to say I will still take a look at what has been done, test and update if necessary.. (Clyde I hope you don't mind that I may poke at ya with a few questions when I can take a look at this in depth:smile:)

DivaVocals:

Well I suggest you don't do that.. I can only work on this in my SPARE time (this means no PAID client work and NO day job obligations)

It's MORE THAN likely that all I will do anyway is test, confirm, and submit Clyde's modifications posted above..

That said, one of the things I looked at doing one day when MY TIME permits, is to synchronize the Edit Orders comments code to look/act like the default orders.php. (for the record, this is ONE of the big changes we made that will be seen in the next Super Orders release -- AND BEFORE ANYONE ASKS -- when I get time to finalize it, I will release it -- I work on it a little bit at a time -- should be soon..)

It would be a CHALLENGE for me to do this since I am NOT really a coder, but I am not afraid!!!:laugh: This is also why it won't happen tomorrow, but it is on my "to-do" list (or should I say my "to-try list")..:laugh: