Zen Colorbox

g2ktcf:

Would it not be prudent to add Zen Colorbox to the IH4 readme by name and vice versa? I am not sure it would have helped me with my issue. But I am sure that I will not be the only one to miss this important connection.

Thanks
ChrisSure.. and if you look at the date Zen Colorbox was submitted, and the last IH4 update, you'd know that Zen Colorbox was submitted AFTER the last IH4 update..

Submitting an IH4 update JUST to add this to the readme wasn't IMHO a compelling reason to submit and update.. With the recent v1.5.4 release I will be submitting an IH4 update and I WILL update the readme to INCLUDE Zen Colorbox, and also to suggest that folks NOT install Fual Slimbox OR Zen Lightbox anymore in favor of this module..

DivaVocals:

Not part of the core code.. Images only.. There is a BETA version in the authors Github repo which is in response to this issue: https://github.com/daniel-hopkins/zen-colorbox/issues/9.

Be advised that the code is UNTESTED and INCOMPLETE, and there is NO SUPPORT for it here really. In order to have continuity across a shop using this module, the plan was to address ALL the popups in the list. 3 remain outstanding, and the author has been busy and has not been able to do any further work on this feature. ANYONE who wants this feature fully functioning to fork his repo and pick up where he left off on this feature would be a hero! SHARE IT with the community!:smile:

I will be submitting an update to Zen Colorbox soon. The updated code is in my Zen Colorbox Github fork of the Zen Colorbox repo.. I submitted a pull request with my modifications to the master repo, but because the author has been busy he has not yet approved and incorporated my changes into his master repo.. So just know that IF you decide to install this version with this code and you also want the LATEST and greatest version, there will be discrepancies between my fork and the author's repo so you will have to merge them together..

Thanks for the headsup. I will look into it over the next few days.

FWIW, I just downloaded the Colorbox repository and installed it on a Zen Cart v1.5.4 demo site without issue.

lat9:

FWIW, I just downloaded the Colorbox repository and installed it on a Zen Cart v1.5.4 demo site without issue.

Cool.. BUT there's a caveat.. Can you test some of the popups to make sure they work.. when I tested the code from the main repo, Daniel had started working on code to make the popups work inside a lightbox.. (See: https://github.com/daniel-hopkins/zen-colorbox/issues/9) It's not ALL popus, but the issue link I posted tells you which ones.. I tested it BRIEFLY, and got some errors (details of which escape me.. I just rolled back the popup code..) Let me know if the popups are working for you..

Is there a setting that causes the colorbox interface to be used. I'm not seeing the colorbox-type popup shopping-cart help.

lat9:

Is there a setting that causes the colorbox interface to be used. I'm not seeing the colorbox-type popup shopping-cart help.

Hmmmmmmmmmmmmmmmmmmm.. To be honest I don't remember.. :laugh: I didn't realize that Daniel had committed the popup code to the repo (Github did not notify me) until I went to grab the latest from his repo for my latest client install.. I installed tested, failed, and then rolled back..:laugh: Decided to go back at testing when I wasn't on a deadline..

Now I've got myself confused! I "think" that I downloaded the master from your fork rather than from the danielhopkins account.

Certainly looking at the danielhopkins account, there are changes for the shopping_cart page that aren't reflected in the version I downloaded. I'll get the danielhopkins "master" installed and let you know ...

lat9:

Now I've got myself confused! I "think" that I downloaded the master from your fork rather than from the danielhopkins account.

Certainly looking at the danielhopkins account, there are changes for the shopping_cart page that aren't reflected in the version I downloaded. I'll get the danielhopkins "master" installed and let you know ...

That's because I didn't include Daniel's popup changes in my fork.. I plan to submit my fork this weekend.. Daniel just accepted the changes from my pull request in his repo, and they will be included i nmy update.. I am submitting my fork because Daniels popup changes are incomplete (3 popups are not "done" yet) and untested..

Okie-dokie. I'll play with the additional pop-ups and report back. Meanwhile, I made the following changes to /includes/templates/YOUR_TEMPLATE/jscript/jscript_jquery_min.php to correct the HTML validation errors:

<?php
//Load jQuery ONLY if jQuery has not been loaded. This is to support versions of Zen Cart prior to v1.5.4 because jQuery was not part of core code
//Also want to prevent jQuery from loading again if bundled with a plugin or template package
?>
<script type="text/javascript">
if (typeof jQuery == 'undefined') {
    document.write(unescape('%3Cscript type="text/javascript" src="//code.jquery.com/jquery-1.11.1.min.js"%3E%3C/script%3E'));
}
</script>

Other than that, all looked good. Tested on a fresh ZC1.5.4 install, no IH4, PHP 5.4.35.

lat9:

Okie-dokie. I'll play with the additional pop-ups and report back. Meanwhile, I made the following changes to /includes/templates/YOUR_TEMPLATE/jscript/jscript_jquery_min.php to correct the HTML validation errors:

<?php //Load jQuery ONLY if jQuery has not been loaded. This is to support versions of Zen Cart prior to v1.5.4 because jQuery was not part of core code //Also want to prevent jQuery from loading again if bundled with a plugin or template package ?> <script type="text/javascript"> if (typeof jQuery == 'undefined') { document.write(unescape('%3Cscript type="text/javascript" src="//code.jquery.com/jquery-1.11.1.min.js"%3E%3C/script%3E')); } </script>

> Other than that, all looked good.  Tested on a fresh ZC1.5.4 install, no IH4, PHP 5.4.35.

Awesome.. Will include the validation change (thought I caught that) and submit this weekend..

You know that jQuery is getting called for already in ZC 1.5.4!

line 108 of /inculdes/templates/template_default/common/html_header.php

/** CDN for jQuery core **/ 
?> 
  <script>window.jQuery || document.write('<script src="//code.jquery.com/jquery-1.11.1.min.js"><\/script>');</script> 
  <script>window.jQuery || document.write('<script src="<?php echo $template->get_template_dir('.js',DIR_WS_TEMPLATE, $current_page_base,'jscript'); ?>/jquery.min.js"><\/script>');</script> 
 
<?php

of coruse if a custom template is not updated to 1.5.4, then it may be missing...

I've been doing popups using the standard popup and Jacks' iFrame method... finished setting up the contact us form using one of the responsive templates, but got side track so haven't finished setting up the others yet.

davewest:

You know that jQuery is getting called for already in ZC 1.5.4!

line 108 of /inculdes/templates/template_default/common/html_header.php

/** CDN for jQuery core **/
?>

<script>window.jQuery || document.write('<script src="//code.jquery.com/jquery-1.11.1.min.js"><\/script>');</script> <script>window.jQuery || document.write('<script src="<?php echo $template->get_template_dir('.js',DIR_WS_TEMPLATE, $current_page_base,'jscript'); ?>/jquery.min.js"><\/script>');</script> <?php ``` > > of coruse if a custom template is not updated to 1.5.4, then it may be missing... > > I've been doing popups using the standard popup and Jacks' iFrame method... finished setting up the contact us form using one of the responsive templates, but got side track so haven't finished setting up the others yet. > > That's one of the reasons for the che check to see if it is already installed . Another is that this code still supports versions before ZC 1.5.4, so either force everyone that uses it to upgrade to ensure up-to-date security or take minor action to continue support of older versions and potentially incorrectly installed jquery script...

lat9:

Okie-dokie. I'll play with the additional pop-ups and report back. Meanwhile, I made the following changes to /includes/templates/YOUR_TEMPLATE/jscript/jscript_jquery_min.php to correct the HTML validation errors:

<?php //Load jQuery ONLY if jQuery has not been loaded. This is to support versions of Zen Cart prior to v1.5.4 because jQuery was not part of core code //Also want to prevent jQuery from loading again if bundled with a plugin or template package ?> <script type="text/javascript"> if (typeof jQuery == 'undefined') { document.write(unescape('%3Cscript type="text/javascript" src="//code.jquery.com/jquery-1.11.1.min.js"%3E%3C/script%3E')); } </script>

> Other than that, all looked good.  Tested on a fresh ZC1.5.4 install, no IH4, PHP 5.4.35.

> **davewest:**
>
> You know that jQuery is getting called for already in ZC 1.5.4!
> 
> line 108 of /inculdes/templates/template_default/common/html_header.php
> ```
/** CDN for jQuery core **/ 
?> 
  <script>window.jQuery || document.write('<script src="//code.jquery.com/jquery-1.11.1.min.js"><\/script>');</script> 
  <script>window.jQuery || document.write('<script src="<?php echo $template->get_template_dir('.js',DIR_WS_TEMPLATE, $current_page_base,'jscript'); ?>/jquery.min.js"><\/script>');</script> 
 
<?php

of coruse if a custom template is not updated to 1.5.4, then it may be missing...

I've been doing popups using the standard popup and Jacks' iFrame method... finished setting up the contact us form using one of the responsive templates, but got side track so haven't finished setting up the others yet.
Very aware of the jQuery inclusion.. as mc12345678 pointed out, and as indicated by the code comment it is to support older v1.5 versions..

Regarding the popups, if you'd like to fork my repo and contribute lightbox popups that would be awesome..

DivaVocals:

Very aware of the jQuery inclusion.. as mc12345678 pointed out, and as indicated by the code comment it is to support older v1.5 versions..

Regarding the popups, if you'd like to fork my repo and contribute lightbox popups that would be awesome..

Ya... I kind of fugued you already knew... one thing I like about the ZC154 one, if your testing and not live, it looks to the template folder for one to load...

I was looking at both GitHubs, but didn't see any popups, so was wondering what method you was using. If the same, maybe save you some work..

davewest:

Ya... I kind of fugued you already knew... one thing I like about the ZC154 one, if your testing and not live, it looks to the template folder for one to load...Yep.. in fact the new version I'll being submitting even fixes the auto installer in versions prior to v.1.5.x so the admin menu part of the install doesn't error out..

davewest:

I was looking at both GitHubs, but didn't see any popups, so was wondering what method you was using. If the same, maybe save you some work..

Not my method at all.. WAYYYYYY over my head.. :laugh: The popups are in Daniels repo..

My repo (https://github.com/DivaVocals/zen-colorbox) is a fork of Daniel's (https://github.com/daniel-hopkins/zen-colorbox). My fork includes all the latest updates to support Zen Cart v1.5.4.. As Daniel recently merged my pull request with all of the Zen Cart v1.5.4 updates, now his fork contains the same updates.. Where our repo's DIFFER is the code Daniel included to support the popups. That code is in the includes/modules/pages folder (https://github.com/daniel-hopkins/zen-colorbox/tree/master/1_Installer_Files/includes/modules/pages)

If you have a complete/better/working method, then PLEASE contribute.. I've updated the issue log with the problems found in testing the code Daniel started working on..

Product image problem - - - ZC1.5.4 fresh - - Responsive Basic Blue - - - Zen_Colorbox -- browser, Chrome
Category listing problem page - http://www.gopopsshop.com/index.php?main_page=index&cPath=7_8
Product Listing page is OK - http://www.gopopsshop.com/index.php?main_page=product_info&cPath=7_8&products_id=7

My problem is related to Colorbox because pages were OK before Colorbox.

I am unable to find where the size of the images are controlled.
On the Categorys page, the pix are sized to 98 x 80 px - skinny and tall - wrong orientation
On the Products page, the pix are sized to 147 x 120 px - looks good

What is overriding the code on the Category page that causes the picture size to change so dramatically????

Looking forward to suggestions

duluthpopsshop:

Product image problem - - - ZC1.5.4 fresh - - Responsive Basic Blue - - - Zen_Colorbox -- browser, Chrome
Category listing problem page - http://www.gopopsshop.com/index.php?main_page=index&cPath=7_8
Product Listing page is OK - http://www.gopopsshop.com/index.php?main_page=product_info&cPath=7_8&products_id=7

My problem is related to Colorbox because pages were OK before Colorbox.

I am unable to find where the size of the images are controlled.
On the Categorys page, the pix are sized to 98 x 80 px - skinny and tall - wrong orientation
On the Products page, the pix are sized to 147 x 120 px - looks good

What is overriding the code on the Category page that causes the picture size to change so dramatically????

Looking forward to suggestions

I don't "see" the issue that you are referring to.. Will say this.. Colorbox doesn't set or modify image dimensions.. Sugget you look at your Configuration > Images settings..

DivaVocals:

I don't "see" the issue that you are referring to.. Will say this.. Colorbox doesn't set or modify image dimensions.. Sugget you look at your Configuration > Images settings..

My bad completely - have been so used to working with Google Chrome that I forgot to check the site with Firefox. After your post, I checked the site in Firefox and there are no problems. Will have to look into the Chrome issue. :blush:

Thanks for responding so quickly.

Fred

Was using Zen Lightbox before. It stopped working after upgrading to 1.5.4, so installed Zen Colorbox.

One feature that was nice in Zen Lightbox was the option to "Close on Image Click". It is possible to do this with Zen Colorbox?

Also, not sure if these are known bugs or just bugs pertaining to my specific installation, but setting "Display Image Counter" to false causes the Colorbox to stop working.

Almost forgot, the colorbox is resizing images to be smaller than they actually are. The point of a lightbox is to show images that are larger than being displayed on the page. What is the best way to go about making the images display as their actual size?