Super Orders v4.0 Support Thread for ZC v1.5.x

Trying to rename the subject of this thread to see if it helps vBulletin failures.

I have some PHP8 fixes for Super Orders that I will submit to JSWebSteve as soon as I can, hopefully mid December. They just need to get some more miles on them before release.

gothstone:

:frusty: I forked @strelitzia's github for this and was gonna make it work in zc1.5.8/php8.2 . Hours were spent, and progress was made. And then I discovered mom (my "customer") doesn't use it. At all. Not one piece. :censored:
So ya, it's not done, it doesn't work, and I won't do any more on it. But hopefully, it saves strelitzia or whoever touches it next a little time.

I might fork the project further. I'm like 90% sure I made more changes to fix it to PHP8.2. But if anyone is getting errors about

Creation of dynamic property purchaseorder::$sort_order is deprecated

You might want to make the following change:
Open /includes/modules/payment/purchaseorder.php

Find the line that reads

class purchaseorder {

and change it to read:

#[AllowDynamicProperties]
class purchaseorder {

This should remove the error. (This seems to be a band-aid patch however and I think it only applies to 8.2... I don't know of any other complications that may arise out of this.)

Just fix this issue properly by declaring $sort_order.

swguy:

Just fix this issue properly by declaring $sort_order.

I don't know why I thought that was going to be hard.

Editing in $sort_order, $email_footer to the var declaration fixed the problem too. Guess I'll make that change instead.

has anyone got this working on ZC V1.5.8? and if so have you a updated zip of the files?

I don't use this (so shut up then)...but no doubt different users want different aspects.

Progress would be more likely if the required aspects (that are missing in core ZC) were highlighted and could be worked on in smaller chunks.
For example I did a plugin to batch update orders yonks ago: https://github.com/torvista/Zen_Cart-Batch_Order_Update (probably needs some tlc now , which it won't get unless requested).

Maybe the functionality you want is in another dusty plugin that is easier to fix-up than the beast that is Super Orders.

1. Can I ask who this is to?
2. What it is in reply to?

Just a general comment, it seems a big job to get SO working with all its bells and whistles when maybe better to pension it off but work on it's functionality piecemeal.

Hence my interest in seeing what is the functionality that people want.

Hello,

Does someone already had this issue? I paid with Square webpay, the transaction passed without any issue, Square had charge the amount only once, but I find two payments records associated to my order, same amount, timestamp. (See the attachmen SO_PAYMENT) first record seem to be the right one, the second is the intruder. (Please ignore the "delete" status)

If I check inside Database tables, I found :

1x record inside square_payment
2 x record inside so_payment for the same order

If I do a payment through Paypal, I only found one payment, where is perfectly normal.

I already validate the issue with CarlWhat who give a great support on WebPay module, he suggest to me to ask my question to Super Order forum.

I'm using ZC 1.57d + Super Orders v5.0.0 + square-WebPay on PHP 7.33

Does someone have any clue ? sorry for the poor quality of the pictures.

Thanks

have you tried uninstalling super order and try a test order?

No, I haven't tried it, since Square is only configured in production and not on my test site and I don't want to break the whole "setup" in PROD, I prefer to ask if anyone already had a similar case.

I made a new test, I reinstalled new ZC 1.57d package + Square webpay without Super Order, I hadn't any double payments.
After, I add Super Order package and I made a new transaction with Webpay, got two payments again inside SO_PAYMENT .

Does someone had success installing these two packages together (Super-Orders-v5.0.Zen-Cart-1.5 + Square WebPa 1.0.3 ) on ZC 1.57d with PHP 7.3 ?

Finally find where the duplicated records come from: /include/classe/order.php (Line 732)

Need to comment $so->cc_line_item(); because $so = new super_order($insert_id); already create a first record inside the table so_payment.

// BEGIN Super Orders edit
// add CC data as a line item to SO payment system
if (zen_not_null($this->info['cc_type']) || zen_not_null($this->info['cc_owner']) || zen_not_null($this->info['cc_number'])) {
require(DIR_WS_CLASSES . 'super_order.php');
$so = new super_order($insert_id);
//$so->cc_line_item();
}
// END Super Orders edit

Thanks for the update Peter, commenting $so->cc_line_item(); resolved the issue with duplicate payments being applied to the same order.

@peter_pechesud would you please submit a PR to

https://github.com/JSWebSteve/Super-Orders-Zen-Cart-1.5.7

i installed on zen version 210
i do i fix this
--> PHP Fatal error: MySQL error 1292: Incorrect datetime value: '' for column c1JNSWOKIEE.so_payments.last_modified at row 1 :: INSERT INTO so_payments (orders_id, payment_number, payment_name, payment_amount, payment_type, date_posted, last_modified) VALUES ('11390', '11390-XXXXXX0015', 'James Warren', '107.2268', 'MasterCard', '2025-03-02 19:07:04', '') ==> (as called by) /includes/functions/database.php on line 134 <== in /includes/classes/db/mysql/query_factory.php on line 733.

jimmie:

i installed on zen version 210
i do i fix this
--> PHP Fatal error: MySQL error 1292: Incorrect datetime value: '' for column c1JNSWOKIEE.so_payments.last_modified at row 1 :: INSERT INTO so_payments (orders_id, payment_number, payment_name, payment_amount, payment_type, date_posted, last_modified) VALUES ('11390', '11390-XXXXXX0015', 'James Warren', '107.2268', 'MasterCard', '2025-03-02 19:07:04', '') ==> (as called by) /includes/functions/database.php on line 134 <== in /includes/classes/db/mysql/query_factory.php on line 733.

fixed
thanks to zenexpert
in includes/classes/super_order.php on line 735
from
$auto_payment['last_modified'] = $item['last_modified'];
to
$auto_payment['last_modified'] = 'now()';
working in zen 210

Hi Jimmie,

It would be great if you would share your code to get this plugin working in 2.1.0.

Thanks!!!

I was able to get Torvista's Batch Order Update to work with 2.1.0 if anyone is interested.