Edit Orders v4.0 Support Thread

kcallagmy:

Is it easy to go back to 1.5.4 from 1.5.5 ?

If you kept a backup before you upgraded, sure ... and if you don't mind losing any database records added since that backup, too.

Thanks for this mod.. we use it a lot.

Doing a fresh install of 1.5.4 for testing and am currently working on merging Edit Orders and Ty Tracker with admin/orders.php.

I can see where Ty Tracker has pretty clearly stated the BOF and EOF edits, but I can not make out the merging of the admin/orders.php file with EO.

So... FORGETTING Ty Tracker... and starting over and just working with the original admin/orders.php out of the box, still can not make sense of the merging of EO into orders.php. Compared it to our current 1.5.1 and must have been a genius back then, or miracle worker because it works for our 1.5.1 shop.

1st Question: Is blind faith an option with the 1.5.4 admin/orders.php where EO is concerned? Just drop it in?

2nd Question: Would anyone have a merged EO admin/orders.php from zen1.5.4 with Ty Tracker that works that I could see?

SBA is next... Omg...

The version of EO that is currently residing on GitHub (https://github.com/lat9/edit_orders/) has been pre-merged with the Zen Cart v1.5.4 orders.php (and I'm pretty sure that the TyPT changes are also included).

That version also has some changes for Zen Cart 1.5.5 and is waiting for the ZC 1.5.5a release for compatibility testing prior to its release as EO 4.1.4a.

Thanks... i was on my way there for SBA... cool...

I could swear the new sanitizers in 155a + latest Github EO are not playing well. Am I crazy?

swguy:

I could swear the new sanitizers in 155a + latest Github EO are not playing well. Am I crazy?
A little more information would certainly help; how are they not playing well?

I'll do an install on a clean system shortly and report back. Wasn't sure if anyone else had tried it and had bad results so I wanted to check first.

Update later: Dup'ed; see post below.

Does it make sense to pull the latest from https://github.com/lat9/edit_orders and call that the 1.5.4 version so we can get on with updating for 1.5.5? (last update to this plugin was 01/14 for 1.5.3.)

OK, I can repro the issue. What's happening is that on the 4th step (Add Now), on the default database with test products, I get correct attributes and options:

<input type='submit' value='Add now'><input type="hidden" name="id[3][value]" value="8"><input type="hidden" name="id[3][type]" value="0">

but on my database, these fields have been damaged:

<input type='submit' value='Add now'><input type="hidden" name="id[26]" value="Array"><input type="hidden" name="id[27]" value="Array">

(which creates empty values in orders_products_attributes.

So going back a step, on the default database in step 3, I get

<label class="attribsSelect" for="attrib-3">Model</label><select rel="dropdown" name="id[3][value]" id="attrib-3">

and on my database, I get

<label class="attribsSelect" for="attrib-27">Mounting Orientation:</label><select rel="dropdown" name="id[27][value]" id="attrib-27">

which looks the same to me.

Gets into init_sanitize fine, but goes from ./includes/classes/AdminRequestSanitizer.php into filterSimpleAlphanumPlus which clobbers the array (line 335).

It looks like on my side, the ParameterDefinitions array does not include the entry for MULTI_DIMENSIONAL.

One thing that looks interesting - why does admin/includes/extra_datafiles/eo_sanitization.php add an array entry for "update_products"
but not for add_prdct ? (I tried that and it didn't fix my issue but it's still curious.)

@swguy, you say you're using the demo products, but there's no option named "Mounting Options". If you could identify the specifics of the product and its attributes that you're trying to add to the order, I could probably help.

I'm also not sure what you mean by:

It looks like on my side, the ParameterDefinitions array does not include the entry for MULTI_DIMENSIONAL.

... although, in reviewing the sanitization array (in /ADMIN/includes/extra_datafiles/eo_sanitization.php) there's an entry for the update_order path, but not one for the add_prdct one.

OK, got one. Tried to add the "Big Linked" version of "A Bug's Life ..." entered all the attributes, clicked "Add" and came back to the same screen (with debug-logs generated). At this point, I've got something to work with and will report back when I've got a solution.

swguy:

OK, I can repro the issue. What's happening is that on the 4th step (Add Now), on the default database with test products, I get correct attributes and options:

<input type='submit' value='Add now'><input type="hidden" name="id[3][value]" value="8"><input type="hidden" name="id[3][type]" value="0">

but on my database, these fields have been damaged:

<input type='submit' value='Add now'><input type="hidden" name="id[26]" value="Array"><input type="hidden" name="id[27]" value="Array">

(which creates empty values in orders_products_attributes.

So going back a step, on the default database in step 3, I get

<label class="attribsSelect" for="attrib-3">Model</label><select rel="dropdown" name="id[3][value]" id="attrib-3">

and on my database, I get

<label class="attribsSelect" for="attrib-27">Mounting Orientation:</label><select rel="dropdown" name="id[27][value]" id="attrib-27">

which looks the same to me.

Gets into init_sanitize fine, but goes from ./includes/classes/AdminRequestSanitizer.php into filterSimpleAlphanumPlus which clobbers the array (line 335).

It looks like on my side, the ParameterDefinitions array does not include the entry for MULTI_DIMENSIONAL.

lat9:

@swguy, you say you're using the demo products, but there's no option named "Mounting Options". If you could identify the specifics of the product and its attributes that you're trying to add to the order, I could probably help.

Morning lat9. Looks like a comparison of operation is being performed between a default zc store and a "live" store, which is the "my database" version. Considering the timing of the discussion and issues, should also note that there appears to be something amiss with the products_attributes table or related with that database as a change to another plugin was required to address sort orders of attributes. That change required not using the sort order provided by routine query to the products_attributes table and instead to use the sort order provided by the products_options_values table. A suggestion was made to correct the issue with the products_attributes table, the status of which is unknown, but alternate software (for more than one reason) was sought.

Or perhaps it is something else as the issue can occur in the default database.

lat9:

OK, got one. Tried to add the "Big Linked" version of "A Bug's Life ..." entered all the attributes, clicked "Add" and came back to the same screen (with debug-logs generated). At this point, I've got something to work with and will report back when I've got a solution.

If you do a view source on the 4th step (with the Add button), do you get

name="id[1] value="Array"

instead of

name="id[1][value]" id="attrib-1"

Because that means you're seeing the issue.

lat9:

@swguy, you say you're using the demo products, but there's no option named "Mounting Options". If you could identify the specifics of the product and its attributes that you're trying to add to the order, I could probably help.

Mounting Options is something from my database (which exhibits the problem).

Reproduced using the demo products; see this posting.

@swguy, would you apply the following update to your ADMIN/includes/extra_datafiles/eo_sanitization.php to see if that corrects your issue (it corrected the issue with the demo product)?

<?php
// -----
// Part of the Edit Orders plugin, v4.1.5 or later.  This file defines the level of "sanitization" required by the adminSanitizer function,
// introduced in a patch-level of Zen Cart v1.5.5, so need to make sure that the "proper" version of the class is included.
//
if (defined ('PROJECT_VERSION_MAJOR') && version_compare (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR, '1.5.5', '>=') && class_exists ('AdminRequestSanitizer') && method_exists ('AdminRequestSanitizer', 'getInstance')) {
    $eo_sanitizer = AdminRequestSanitizer::getInstance();
    $eo_group = array (
        'update_products' => array (
            'sanitizerType' => 'MULTI_DIMENSIONAL',
            'method' => 'post',
            'pages' => array ('edit_orders'),
            'params' => array (
                'update_products' => array ('sanitizerType' => 'CONVERT_INT'),
                'qty' => array ('sanitizerType' => 'FLOAT_VALUE_REGEX'),
                'name' => array ('sanitizerType' => 'PRODUCT_DESC_REGEX'),
                'onetime_charges' => array ('sanitizerType' => 'FLOAT_VALUE_REGEX'),
                'attr' => array (
                    'sanitizerType' => 'MULTI_DIMENSIONAL',
                    'params' => array (
                        'attr' => array ('sanitizerType' => 'CONVERT_INT'),
                        'value' => array ('sanitizerType' => 'PRODUCT_DESC_REGEX'),
                        'type' => array ('sanitizerType' => 'CONVERT_INT')
                    )
                ),
                'model' => array ('sanitizerType' => 'WORDS_AND_SYMBOLS_REGEX'),
                'tax' => array ('sanitizerType' => 'FLOAT_VALUE_REGEX'),
                'final_price' => array ('sanitizerType' => 'FLOAT_VALUE_REGEX'),
            )
        )[B],
        'id' => array (
            'sanitizerType' => 'MULTI_DIMENSIONAL',
            'method' => 'post',
            'pages' => array ('edit_orders'),
            'params' => array (
                'id' => array ('sanitizerType' => 'CONVERT_INT'),
                'type' => array ('sanitizerType' => 'CONVERT_INT'),
                'value' => array ('sanitizerType' => 'PRODUCT_DESC_REGEX'),
            ),
            
        )[/B]
    );
    $eo_sanitizer->addComplexSanitization ($eo_group);
}

Will test as soon as I get home.

Never mind; that worked on my test setup (1.5.5+sanitizer updated from 4/12/2016) but fails using the sanitizer that's delivered as part of ZC1.5.5a.

ok -standing by.