Edit Orders v4.0 Support Thread

I encountered the following notice when deleting an order from the admin orders listing page:

PHP Notice: Undefined offset: 3 in ...admin/includes/classes/observers/EditOrdersAdminObserver.php on line 69

Also, should the edit order button appear in the delete order confirmation area after the delete button is clicked on the orders listing page? It seems out of place to me there.

Thanks for a great add-on!
Dave
zc257c, php 7.3.x, eo 4.6.0

Edit Orders 4.5.7 recalculates tax differently than store side. Specifically, the store side calculates tax on the product subtotal minus group discount (which is what I want), but edit orders calculates the tax on the product subtotal before the discount is applied. Please help. Log attached.
Dave
zc v155f, php 7.3.x

Dave224:

Edit Orders 4.5.7 recalculates tax differently than store side. Specifically, the store side calculates tax on the product subtotal minus group discount (which is what I want), but edit orders calculates the tax on the product subtotal before the discount is applied. Please help. Log attached.
Dave
zc v155f, php 7.3.x
Thanks for the log, it'll help to determine what's going on. I've created an issue (https://github.com/lat9/edit_orders/issues/207) in EO's GitHub repository to track the change needed.

Please note that my time is currently devoted to paid-clients' requests, but I'll try to work this in over the next weeks.

lat9:

Thanks for the log, it'll help to determine what's going on. I've created an issue (https://github.com/lat9/edit_orders/issues/207) in EO's GitHub repository to track the change needed.

Please note that my time is currently devoted to paid-clients' requests, but I'll try to work this in over the next weeks.
Please note that the issue appears to be the use of ot_quantity_discount (I thought you were referencing ot_group_pricing). You'll need to contact the author of that add-on order-total for resolution of the reported issue.

I have searched everywhere to find a solution for this request of a customer:

He wants the sort order of ordered items in the edit order page (and in printed packing slip etc') will be Alphabetically sorted.
How can I get this to happen?

eavinu:

I have searched everywhere to find a solution for this request of a customer:

He wants the sort order of ordered items in the edit order page (and in printed packing slip etc') will be Alphabetically sorted.
How can I get this to happen?
That sounds like a custom-coding effort, noting that the same changes would be needed for the base Zen Cart Customers :: Orders display, too. The products are listed in the order that the customer added them to their cart.

Edit Orders 4.5.7 recalculates tax differently than store side. Specifically, the store side calculates tax on the product subtotal minus group discount (which is what I want), but edit orders calculates the tax on the product subtotal before the discount is applied.

Turns out the problem was unrelated to Edit Orders but to a bad delivery state set for the in-store pickup shipping method. The state abbreviation was used instead of the state spelled out.
Dave

zc 1.56,1.57 php 7.4, edit orders 1.5

When editing Text Attributes, it appears that the length of the text allowed is being limited by the Size parameter of the option name. The Size parameter is the size of the input box. The text length should be limited by the Max parameter of the option name.

To re-create the issue, create a text option name with a Size of 10 and the Max of 20. When editing that option within an order, you can only enter 10 characters (Size) but in the catalog you can enter 20 chars (Max).

ChuckPhillips:

zc 1.56,1.57 php 7.4, edit orders 1.5

When editing Text Attributes, it appears that the length of the text allowed is being limited by the Size parameter of the option name. The Size parameter is the size of the input box. The text length should be limited by the Max parameter of the option name.

To re-create the issue, create a text option name with a Size of 10 and the Max of 20. When editing that option within an order, you can only enter 10 characters (Size) but in the catalog you can enter 20 chars (Max).
What is "edit orders 1.5"? I'll note that the current version is 4.6.0.

Sorry! Its the latest version, 4.6.0

ChuckPhillips:

Sorry! Its the latest version, 4.6.0
Thanks for the update. I'm in the middle of a couple of upgrades, but once completed, I'll attempt to reproduce (and ultimately correct) that issue.

ChuckPhillips:

zc 1.56,1.57 php 7.4, edit orders 1.5

When editing Text Attributes, it appears that the length of the text allowed is being limited by the Size parameter of the option name. The Size parameter is the size of the input box. The text length should be limited by the Max parameter of the option name.

To re-create the issue, create a text option name with a Size of 10 and the Max of 20. When editing that option within an order, you can only enter 10 characters (Size) but in the catalog you can enter 20 chars (Max).
GitHub tracking issue opened: https://github.com/lat9/edit_orders/issues/210

I sell in AUD$ and Admin | Home |display new order list displays new orders with a dollar sign and any international currency selected for display by the customer is also displayed inside brackets after the AUD value. eg "$37.20 (£19.95)".

If I select that order and select edit order for that order to get an idea on cost in AUD for customs purposes etc and cancel out of the editing, the values displayed on the home page are now all in the foreign currency eg "£37.20 (£19.95)".

The only way to clear this is to log out and log back in.

OldNGrey:

I sell in AUD$ and Admin | Home |display new order list displays new orders with a dollar sign and any international currency selected for display by the customer is also displayed inside brackets after the AUD value. eg "$37.20 (£19.95)".

If I select that order and select edit order for that order to get an idea on cost in AUD for customs purposes etc and cancel out of the editing, the values displayed on the home page are now all in the foreign currency eg "£37.20 (£19.95)".

The only way to clear this is to log out and log back in.
Is that custom code? I've got a client who sells in CA$ and US$ and I'm not seeing that for placed orders.

lat9:

Is that custom code? I've got a client who sells in CA$ and US$ and I'm not seeing that for placed orders.
Duh, it's that block on the home page ... I'll check that out.

lat9:

Duh, it's that block on the home page ... I'll check that out.
GitHub tracking issue: https://github.com/lat9/edit_orders/issues/211

I've just submitted v4.6.1 of Edit Orders for the Zen Cart moderators' review; I'll post back here when it's available for download.

This release contains changes associated with the following GitHub issues:

#203: Remove "Ty Package Tracker" and other duplicates from the language file.
#206: Add hidden field on order-update to include each ordered product's "products_id".
#208: Correct unwanted "Edit" button (and log) when an order-deletion is being confirmed.
#209: Ensure 'EO_DEBUG_ACTION_LEVEL' configuration setting is recorded; might not be for way-old versions when updating.
#210: On add/update, TEXT attributes' maximum-entry should be based on the option's 'length', not the 'size'.
#211: Correctly manage $_SESSION['currency'] for orders placed in a currency other than the site's default.

Additional thanks to @OldNGrey for helping to validate the change for issue#211.

lat9:

I've just submitted v4.6.1 of Edit Orders for the Zen Cart moderators' review; I'll post back here when it's available for download.

This release contains changes associated with the following GitHub issues:

#203: Remove "Ty Package Tracker" and other duplicates from the language file.
#206: Add hidden field on order-update to include each ordered product's "products_id".
#208: Correct unwanted "Edit" button (and log) when an order-deletion is being confirmed.
#209: Ensure 'EO_DEBUG_ACTION_LEVEL' configuration setting is recorded; might not be for way-old versions when updating.
#210: On add/update, TEXT attributes' maximum-entry should be based on the option's 'length', not the 'size'.
#211: Correctly manage $_SESSION['currency'] for orders placed in a currency other than the site's default.

Additional thanks to @OldNGrey for helping to validate the change for issue#211.
Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=1513

ZC 1.57c, template fluorspar

I've looked back over a year in the posts on this thread and don't see anyone else having this problem. So I'm not sure whether it's connected to my template or what. I can change an order with Edit Orders but when I save the change, the screen does not reload. If I refresh back to the admin home page, the changes are there and everything appears to be correct, but it's necessary to do that for every change you have to make. We don't often need to make a change, but this is still irritating. Any suggestions?

HeleneWallis:

ZC 1.57c, template fluorspar

I've looked back over a year in the posts on this thread and don't see anyone else having this problem. So I'm not sure whether it's connected to my template or what. I can change an order with Edit Orders but when I save the change, the screen does not reload. If I refresh back to the admin home page, the changes are there and everything appears to be correct, but it's necessary to do that for every change you have to make. We don't often need to make a change, but this is still irritating. Any suggestions?

Have you tried refreshing your browser cache?