Edit Orders v4.0 Support Thread

lhungil:

Found some other potential issues related to the tax calculations. As a temporary work around (until I can dig into the needed changes more extensively) you will also want to make sure DISPLAY_PRICE_WITH_TAX and DISPLAY_PRICE_WITH_TAX_ADMIN are both set to the same value ('True' or 'False').
Should I hold off on QA testing and wait for an update?? Also it would help if you could give me (at high level) the test case/scenario I should be running in order to confirm the fast and furious changes coming.. :laugh:

Also I am going to test a bug Ajeh reported to me a while back that I could NOT address because.. well because I am not a PHP developer that's why..:laugh:

If I discover that this old bug is still an issue, is NOW the time to raise/report this??

lhungil:

Found some other potential issues related to the tax calculations. As a temporary work around (until I can dig into the needed changes more extensively) you will also want to make sure DISPLAY_PRICE_WITH_TAX and DISPLAY_PRICE_WITH_TAX_ADMIN are both set to the same value ('True' or 'False').

Ah yes - I did notice that it uses the define for the front end, I wasn't sure whether that was by design or not. I have got the ADMIN set to true, and the front end one set to False, since that's the way I need it set up. It doesn't seem to cause any major issues though..

Gadgit:

Ah yes - I did notice that it uses the define for the front end, I wasn't sure whether that was by design or not. I have got the ADMIN set to true, and the front end one set to False, since that's the way I need it set up. It doesn't seem to cause any major issues though..
This is the reason your calculations was off for VAT and taxes. Certain functions in the admin are hard coded to use DISPLAY_PRICE_WITH_TAX_ADMIN and the order total code and modules (we call these to calculate totals) are hard coded to use DISPLAY_PRICE_WITH_TAX. So if both values are not the same, the calculations get off :P

I do not want to modify the Zen Cart functions directly as it will impact many other pages... So we will probably need to duplicate some of the code from the catalog side functions... And when the values are not the same on both sides add a warning to the top of the page in the admin to let users know calculations shown in Edit Orders are based upon the catalog side settings.

The "quick" fix for most people running EO 4.1 to address the calculations being off is make sure both these settings are the same.

ZC1.5.1
TY PACKAGE 3.1.3
EDIT ORDERS 4.4.1-B1
SUPER ORDERS 4.XXX (latest VERSION)
RECOVER CART SALES 1.5
UPS SHIPPING MOD

There are 3 problems with my super order batch form printing functions:

1. traditional menu printing invoices yield a http 500 Internal server error
   2 traditional menu printing packing slips yield a http 500 Internal server error
2. PDF Packing slip printing works but display a browser tab heading of "503 Service Temporary Un.....

Looking in my logs I find:

[22-May-2013 10:17:43] PHP Fatal error: Cannot redeclare class base in /htdocs/myzencart/includes/classes/class.base.php on line 17

[21-May-2013 16:07:50] PHP Warning: Invalid argument supplied for foreach() in /htdocs/myzencart/admin/super_batch_pages.php on line 37

What does this mean? Can anyone help?

DivaVocals:

Also I am going to test a bug Ajeh reported to me a while back ...
If I discover that this old bug is still an issue, is NOW the time to raise/report this??
Would be a good time. I'd like input on any "known bugs" so even if they are not fixed we can at least add them to the readme :)

twi:

...
There are 3 problems with my super order batch form printing functions:

1. traditional menu printing invoices yield a http 500 Internal server error
   2 traditional menu printing packing slips yield a http 500 Internal server error
2. PDF Packing slip printing works but display a browser tab heading of "503 Service Temporary Un.....

Looking in my logs I find:

[22-May-2013 10:17:43] PHP Fatal error: Cannot redeclare class base in /htdocs/myzencart/includes/classes/class.base.php on line 17

[21-May-2013 16:07:50] PHP Warning: Invalid argument supplied for foreach() in /htdocs/myzencart/admin/super_batch_pages.php on line 37
The 500's may be coming from the FATAL error... You can double check your webserver / php_error logs if your hosting provider has them enabled to double check.

I'd guess the first one is coming from code somewhere using include(class.base.php) or require(class.base.php) when the file already has been included (or required). Edit Orders does not manually call any includes for these... So you might check the Super Orders code...

The second is most likely caused by the variable being passed to the foreach on line 37 not being initialized or not being an iterable object.

@lhungil

there are no log in the hosting server logs. guess the host didn't enable them.

As far as coding goes, I am illiterate. Hope someone here can help.

thanks

Also posted the info at Super orders for help.

twi:

@lhungil

there are no log in the hosting server logs. guess the host didn't enable them.

As far as coding goes, I am illiterate. Hope someone here can help.

thanks

Double posting the SAME problem on two threads is generally frowned upon in this forum.. Not to mention your issue (as you reported it) is not with Edit Orders, but with SUPER ORDERS.. the fact that integration between these modules is possible doesn't mean that issues with one relate tothe other.. Super Orders, Ty Package Tracking and Edit Orders are still three distinct modules with different purposes/functions (Order Management, Shipping, and order Editing). So unless an issue is SPECIFIC to the integration of these modules, you should be reporting functional issues in the specific support thread for the module where the problem exists.. (in this case Super Orders batch printing is NOT in any way affected by Edit Orders)

problem is reported at super orders. happens to be on the wrong forum. Though it might have something to do with testing the edit order 4.1.1b1. that's why its here.

twi:

problem is reported at super orders. happens to be on the wrong forum. Though it might have something to do with testing the edit order 4.1.1b1. that's why its here.

Does not as there is no batch forms printing function with Edit Orders.. That said, are you saying you DID NOT get the error before installing the BETA version of Edit Orders??

BTW, if this is your LIVE store you SHOULD NOT be installing or testing a beta version of any add-on on your LIVE store..

Thank you for your info, over the weekend i did test install on another site, everything is working correctly files have been modified right, it when i import my Mysql database it gets broken, unfortunately editing the database is not my area of expertise, as far as my log file does not report any errors.

gromit1977:

Thank you for your info, over the weekend i did test install on another site, everything is working correctly files have been modified right, it when i import my Mysql database it gets broken, unfortunately editing the database is not my area of expertise, as far as my log file does not report any errors.
If everything worked before you imported your database (using Zen Cart's "test" data)... Sounds like something in the data you are importing may be causing some problems...

Things you can check:

• How was the data imported? phpMyAdmin restore? Database Backup Manager plugin? Easy Populate? Other?
• For the product option which is not working: What did you enter in the "options name manager" and "options values manager"?
• What is entered into the "attributes controller" for the product?
• You could add some debug code to "Step 3" of the code for adding a product (in edit_orders.php) to output the attributes / options data associated with the product (assigned to the variable $attrs).

Unfortunately without knowing what data you are using for the product (and what differs in your Zen Cart installation / data from a clean Zen Cart installation) it is going to be difficult to help you further. Specifically we would need an example product containing all the related data from within the following database tables: product, product_description, product_options, product_options_types, product_options_values, products_options_values_to_products_options, and products_attributes.

DivaVocals:

Does not as there is no batch forms printing function with Edit Orders.. That said, are you saying you DID NOT get the error before installing the BETA version of Edit Orders??

BTW, if this is your LIVE store you SHOULD NOT be installing or testing a beta version of any add-on on your LIVE store..

Does not as there is no batch forms printing function with Edit Orders.. That said, are you saying you DID NOT get the error before installing the BETA version of Edit Orders?? YES

solution: SO was simply reinstalled over EO beta & SO and TY. Now the problems mentioned in SO for batch forms works.

all is done on brand new site for upgrade. not live store.

ty for the reminder.

@lhungil and others- there's a small interoperability with Edit Orders and my discounting mods (Better Together, Quantity Discounts, etc.)

You'll get a white screen and an error log that looks like this:
[01-Jun-2013 06:53:00 UTC] PHP Fatal error: Call to undefined function zen_get_tax_rate_from_desc() in /var/www/html/demo_151/includes/modules/order_total/ot_giftwrap_checkout.php on line 184

The issue is that on the admin side, the function zen_get_tax_rate_from_desc() is not included. So a simple fix would be to pull this function (from includes/functions/functions_taxes) and put it into admin/includes/functions/extra_functions/edit_orders_functions.php.

The code you need is

// Get tax rate from tax description
 function zen_get_tax_rate_from_desc($tax_desc) {
    global $db;
    $tax_rate = 0.00;

    $tax_descriptions = explode(' + ', $tax_desc);
    foreach ($tax_descriptions as $tax_description) {
      $tax_query = "SELECT tax_rate
                    FROM " . TABLE_TAX_RATES . "
                    WHERE tax_description = :taxDescLookup";
      $tax_query = $db->bindVars($tax_query, ':taxDescLookup', $tax_description, 'string'); 

      $tax = $db->Execute($tax_query);

      $tax_rate += $tax->fields['tax_rate'];
    }

    return $tax_rate;
  }

swguy:

...
[01-Jun-2013 06:53:00 UTC] PHP Fatal error: Call to undefined function zen_get_tax_rate_from_desc() in /var/www/html/demo_151/includes/modules/order_total/ot_giftwrap_checkout.php on line 184
...
Thank You for reporting (and posting a quick solution). I'll include a copy of this function in the next release.

The first release candidate for Edit Orders 4.1.1 is now available.
A few of the changes present in the release candidate include: some bug fixes, interoperability changes, a shiny new install / upgrade / remove process, some feature requests, and new documentation. For a full list of changes please reference the readme included with Edit Orders 4.1.1 RC1.

Anyone who wishes to tryout the release candidate should send me a PM (private message).
I will not post Edit Orders 4.1.1 RC1 publicly (for various reasons). If you want to try the release candidate you must send me a PM or email.

lhungil:

The first release candidate for Edit Orders 4.1.1 is now available.
A few of the changes present in the release candidate include: some bug fixes, interoperability changes, a shiny new install / upgrade / remove process, some feature requests, and new documentation. For a full list of changes please reference the readme included with Edit Orders 4.1.1 RC1.

Anyone who wishes to tryout the release candidate should send me a PM (private message).
I will not post Edit Orders 4.1.1 RC1 publicly (for various reasons). If you want to try the release candidate you must send me a PM or email.
You know how to find me.. LOL

lhungil:

The first release candidate for Edit Orders 4.1.1 is now available.
A few of the changes present in the release candidate include: some bug fixes, interoperability changes, a shiny new install / upgrade / remove process, some feature requests, and new documentation. For a full list of changes please reference the readme included with Edit Orders 4.1.1 RC1.

Anyone who wishes to tryout the release candidate should send me a PM (private message).
I will not post Edit Orders 4.1.1 RC1 publicly (for various reasons). If you want to try the release candidate you must send me a PM or email.
and let me add this..
<rant>

Folks who are just looking to get their hands on what they think is the latest and greatest version of Edit Orders should simply just wait.. This is supposed to be a serious testing effort which will ultimately benefit the community.. It is not useful for the active maintainers of add-ons to ask for testers only to have folks "participating" who aren't REALLY participating in the testing effort..

Hello

I have edit orders 4.1 installed on Zen Cart 1.5.1,

I followed the installation in the exact order stated in the instructions file. I'm having a problem in the adding products.

When I add a product, or change qty. and click the update button the Sub-Total and Tota are changed to 0.00 after the page refreshes. Even the order in the client site is set to 0.