Zen Cart Logo
Forums / Addon Admin Tools / Edit Orders v4.0 Support Thread

Edit Orders v4.0 Support Thread

Views: 346,084

Results 1,841 to 1,860 of 1,927
16 Jan 2025, 8:46 PM
#1841
jimmie avatar

jimmie

Totally Zenned

Join Date:
Jan 2013
Location:
New Port Richey, Florida
Posts:
969
Plugin Contributions:
0

Edit Orders v4.0 Support Thread

[16-Jan-2025 20:43:31 UTC] Request URI: /Jimmies_Admin/index.php?cmd=plugin_manager&page=1&colKey=EditOrders&action=doInstall, IP address: 35.139.236.145, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php(158): trigger_error()
#2 /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php(16): ScriptedInstaller->nonEncapsulatedVersionPresent()
#3 /includes/classes/PluginSupport/ScriptedInstaller.php(64): ScriptedInstaller->executeInstall()
#4 /includes/classes/PluginSupport/Installer.php(94): Zencart\PluginSupport\ScriptedInstaller->doInstall()
#5 /includes/classes/PluginSupport/Installer.php(45): Zencart\PluginSupport\Installer->executeScriptedInstaller()
#6 /includes/classes/PluginSupport/BasePluginInstaller.php(29): Zencart\PluginSupport\Installer->executeInstallers()
#7 /includes/classes/ViewBuilders/PluginManagerController.php(145): Zencart\PluginSupport\BasePluginInstaller->processInstall()
#8 /includes/classes/ViewBuilders/BaseController.php(37): Zencart\ViewBuilders\PluginManagerController->processActionDoInstall()
#9 /Jimmies_Admin/plugin_manager.php(101): Zencart\ViewBuilders\BaseController->processRequest()
#10 /Jimmies_Admin/index.php(16): require('...')
--> PHP Notice: Non-encapsulated admin file (includes/classes/attributes.php) must be removed before this plugin can be installed. in /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php on line 158.
16 Jan 2025, 8:56 PM
#1842
jimmie avatar

jimmie

Totally Zenned

Join Date:
Jan 2013
Location:
New Port Richey, Florida
Posts:
969
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

jimmie:

[16-Jan-2025 20:43:31 UTC] Request URI: /Jimmies_Admin/index.php?cmd=plugin_manager&page=1&colKey=EditOrders&action=doInstall, IP address: 35.139.236.145, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php(158): trigger_error()
#2 /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php(16): ScriptedInstaller->nonEncapsulatedVersionPresent()
#3 /includes/classes/PluginSupport/ScriptedInstaller.php(64): ScriptedInstaller->executeInstall()
#4 /includes/classes/PluginSupport/Installer.php(94): Zencart\PluginSupport\ScriptedInstaller->doInstall()
#5 /includes/classes/PluginSupport/Installer.php(45): Zencart\PluginSupport\Installer->executeScriptedInstaller()
#6 /includes/classes/PluginSupport/BasePluginInstaller.php(29): Zencart\PluginSupport\Installer->executeInstallers()
#7 /includes/classes/ViewBuilders/PluginManagerController.php(145): Zencart\PluginSupport\BasePluginInstaller->processInstall()
#8 /includes/classes/ViewBuilders/BaseController.php(37): Zencart\ViewBuilders\PluginManagerController->processActionDoInstall()
#9 /Jimmies_Admin/plugin_manager.php(101): Zencart\ViewBuilders\BaseController->processRequest()
#10 /Jimmies_Admin/index.php(16): require('...')
--> PHP Notice: Non-encapsulated admin file (includes/classes/attributes.php) must be removed before this plugin can be installed. in /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php on line 158.


nevermind got it
17 Jan 2025, 4:51 AM
#1843
pilou2 avatar

pilou2

Zen Follower

Join Date:
Jun 2008
Location:
Japan
Posts:
366
Plugin Contributions:
6

Re: Edit Orders v4.0 Support Thread

lat9:

Please report EO-5 issues on GitHub and note that it's a beta version. https://github.com/lat9/edit_orders

Done!
I hope I could help more.

2 Feb 2025, 8:21 PM
#1844
wsworx avatar

wsworx

Zen Follower

Join Date:
Jun 2012
Location:
California
Posts:
260
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

ZC 2.1
PHP 8.3
Ty Package Tracker

Would the following be something in my system or a bug I need to report on GitHub?


[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(22): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 22.

[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(23): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 23.

2 Feb 2025, 8:33 PM
#1845
wsworx avatar

wsworx

Zen Follower

Join Date:
Jun 2012
Location:
California
Posts:
260
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

wsworx:

ZC 2.1
PHP 8.3
Ty Package Tracker

Would the following be something in my system or a bug I need to report on GitHub?


[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(22): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 22.

[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(23): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 23.

I ran a search in the developers toolkit and the only file it shows defining that constant is the 'public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php'

3 Feb 2025, 8:18 PM
#1846
wsworx avatar

wsworx

Zen Follower

Join Date:
Jun 2012
Location:
California
Posts:
260
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

wsworx:

I ran a search in the developers toolkit and the only file it shows defining that constant is the 'public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php'

Okay so I figured out that there were a batch of old files form an old version of Edit orders still in the 'includes/languages/english/modules/order_total/' folder. I deleted those and this issue went away but now I have a new issue that seems to be a bug in the ver 5 edit orders but I am not 100% sure.
When I try to add a 'Onetime Discount' I get the following debug log:


[03-Feb-2025 12:35:08 America/Boise] PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.


When I look in the file that defines the constants for EO 5, lang.ot_onetime_discount.php, I do not see that constant listed. Only the two following constants are listed:

$define = [
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE' => 'Onetime Discount',
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION' => 'Onetime Discount applied to the order',

I added the following to the file:

'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY' => 'Onetime Deduction Only',

this stopped the debug file from being created.

I also found that you must specify a negative amount for the discount or EO will not deduct the amount from the total but add it to the total.

3 Feb 2025, 8:47 PM
#1847
wsworx avatar

wsworx

Zen Follower

Join Date:
Jun 2012
Location:
California
Posts:
260
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

wsworx:

Okay so I figured out that there were a batch of old files form an old version of Edit orders still in the 'includes/languages/english/modules/order_total/' folder. I deleted those and this issue went away but now I have a new issue that seems to be a bug in the ver 5 edit orders but I am not 100% sure.
When I try to add a 'Onetime Discount' I get the following debug log:


[03-Feb-2025 12:35:08 America/Boise] PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.


When I look in the file that defines the constants for EO 5, lang.ot_onetime_discount.php, I do not see that constant listed. Only the two following constants are listed:

$define = [
'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE' => 'Onetime Discount',
'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION' => 'Onetime Discount applied to the order',

> 
> I added the following to the file:
> 
> ```
'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY' => 'Onetime Deduction Only',

this stopped the debug file from being created.

I also found that you must specify a negative amount for the discount or EO will not deduct the amount from the total but add it to the total.

I have added these along with several other issues to the github for editorders.

6 Feb 2025, 6:50 PM
#1848
clam_man avatar

clam_man

New Zenner

Join Date:
Jun 2019
Location:
Austin TX
Posts:
65
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

Whenever an order with sales tax is updated, the sales tax for the city and state no longer appear in the invoices or on the order's info, but it is calculated correctly in the total. I'm on 1.5.8a. What is the fix for this? I need the tax to appear on invoices after an order is edited instead of it just disappearing. I checked my logs and they aren't showing any issues with the page.

6 Feb 2025, 10:08 PM
#1849
clam_man avatar

clam_man

New Zenner

Join Date:
Jun 2019
Location:
Austin TX
Posts:
65
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

I messaged mcqueenycoins since I was having the exact same behavior as them, however our ot_tax.php is completely unchanged and is the same as the vanilla 1.5.8a ot_tax.php in includes/modules/order_total so I don't have a clue what would be causing that line to no longer show up after an order is edited with Edit Orders 4.7.1

6 Feb 2025, 10:28 PM
#1850
clam_man avatar

clam_man

New Zenner

Join Date:
Jun 2019
Location:
Austin TX
Posts:
65
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

Sorry for the third post, I didn't make the 7 minute limit for the edits. I did discover some more information. So it shows the correct total with tax included in 'Details' and 'Invoice' views but it isn't showing the line for the tax. I did discover that when the order was edited, it seems to have deleted the ot_tax entry in the orders_total table of the database. I can manually add this record back in, but why would editing an order delete an entry for ot_tax in the orders_total table?

7 Feb 2025, 1:39 PM
#1851
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,069
Plugin Contributions:
56

Re: Edit Orders v4.0 Support Thread

clam_man:

Sorry for the third post, I didn't make the 7 minute limit for the edits. I did discover some more information. So it shows the correct total with tax included in 'Details' and 'Invoice' views but it isn't showing the line for the tax. I did discover that when the order was edited, it seems to have deleted the ot_tax entry in the orders_total table of the database. I can manually add this record back in, but why would editing an order delete an entry for ot_tax in the orders_total table?
What order-total modules are in use on the site?

7 Feb 2025, 7:15 PM
#1852
clam_man avatar

clam_man

New Zenner

Join Date:
Jun 2019
Location:
Austin TX
Posts:
65
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

Currently just using:
ot_coupon, ot_group_pricing, ot_gv, ot_loworderfee, ot_shipping, ot_subtotal, ot_tax, ot_total

7 Feb 2025, 8:15 PM
#1853
wsworx avatar

wsworx

Zen Follower

Join Date:
Jun 2012
Location:
California
Posts:
260
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

jimmie:

zen 210 php 8.3 lots of mods when editing an order and you apply shipping to an order and you update the order, customers cant see the edits on the invoice or i cant see in orders, i see the amount was applied but does not show what the amount was applied to, or maybe im not doing something right.

Anyone using EO should not upgrade to 2.1 yet.
I have EO 4.7.1 working in 2.0.1.
EO 4.7.1 does not function correctly in Zen 2.1.
EO 5 is in beta mode currently and is not ready for prime time although lat9 is working hard at getting it ready. :clap:
Anyone who has loaded Zen 2.1 and EO5, test sites only DO NOT USE ON LIVE SITE you've been warned lol, and is finding issues are asked to report those issues on the GitHub site for EO 5: EO5 GitHub

20 Feb 2025, 12:16 AM
#1854
ideasgirl avatar

ideasgirl

Totally Zenned

Join Date:
Aug 2005
Location:
Trujillo Alto, Puerto Rico
Posts:
1,437
Plugin Contributions:
3

Re: Edit Orders v4.0 Support Thread

lhungil:

Older versions of Edit Orders (< 4.1) allowed the store owner to manually modify almost the entire order (including order total lines). It was not uncommon to find problems with math (as these needed to be done by the person editing the order) in stores using older versions of Edit Orders. If you look through the forums there are a number of other posts regarding issues caused by older versions of Edit Orders (including other math related items).

As of Edit Orders 4.1.x, end users are no longer allowed to manually "adjust" the subtotal (and certain other order total lines) within Edit Orders to avoid such issues. And instead of Edit Orders handling any math related to the order total modules, the order total modules are actually run (same as during checkout). This allows the order total modules to do their own calculations based upon the order contents.

As a result, under Edit Orders 4.1.x if the "subtotal" was off before editing, it will be off after editing (it is not recalculated, just loaded from the database as-is and adjusted up / down when products are added / edited / removed).

If you create a new order in the new store, then attempt to edit the order:

  • Are the order totals correct when the order is first loaded (no edits)?
  • Change the product price and then press "update". Are the order totals correct?
  • Add a product to the order and then press "update". Are the order totals correct?

I'll have to take a look at this. I think I know the cause, but want to verify the fix on a couple test sites.

If the database columns and tables were all set to use a CHARACTER SET of UTF8 previous to the upgrade, you are probably okay (you can check this in phpMyAdmin or similiar). This is rare because out of box Zen Cart < 1.5.0 always used iso-latin-1. When upgrading from Zen Cart < 1.5.0 if the 1.3.x database was iso-latin-1 you still need to manually address this (different store configurations need different massaging and conversions - especially multilingual stores, so this was not automated).

Ahhh, by default Zen Cart does not populate the "shipping" address when an order is completely virtual. If the shipping address contains an address with NO "country" (or a country not found in the Zen Cart database), this would be the cause of the message "Warning: One or more of the customer address fields contains a country name unknown to Zen Cart ("Locations / Taxes"->"Countries"). Taxes and some shipping modules may not function correctly until the issue has been resolved."

If all of the products are indeed virtual (and shipping will NEVER be used), you can disable the warning by making the following change in "/admin/edit_orders.php":

	if(!is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
		!is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country']) /*||
		!is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country'])*/) {
		$messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
	}
> 
> 
> 
> **NOTE:** Also make sure you apply all known bugfixes for Edit Orders 4.1.4. Some examples (there may be others, but these two come to mind): [bugfix when downloadable products are disabled](http://www.zen-cart.com/showthread.php?200407-Edit-Orders-v4-0-Support-Thread&p=1235066#post1235066) and [coupon validation functions are missing from the Zen Cart admin](https://www.zen-cart.com/showthread.php?200407-Edit-Orders-v4-0-Support-Thread&p=1242779#post1242779).

This issue is happening now to me after upgrading from 1.5.5 to 2.1. It was never an issue before. I don't pretend to edit the orders that are there but I can't make the suggested adjustments to the code because I manage both physical and digital products/services. Will this be an issue in the future when someone orders something that's digital? Will I be able to edit the orders? This will be useless then.
20 Feb 2025, 12:35 AM
#1855
ideasgirl avatar

ideasgirl

Totally Zenned

Join Date:
Aug 2005
Location:
Trujillo Alto, Puerto Rico
Posts:
1,437
Plugin Contributions:
3

Re: Edit Orders v4.0 Support Thread

Ok, so after my post I saw wsworx's post and I uninstalled it (v5 is what I had). When searching for answers I looked for "countries" or similar to my error. I didn't know that version was on beta; BUT, I am having a lot of language files warnings with 4.7.1 version (and I see the fix for those were posted, so I will fix them and continue).

Thanks!

9 Mar 2025, 7:16 PM
#1856
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,690
Plugin Contributions:
56

Re: Edit Orders v4.0 Support Thread

EO 4.7.1/ZC 2.0.0/ PHP 8.2

Customer edited an order and added a misc cost, which they renamed. The configuration for misc cost allows title changes.
Updated the order. Order shows correct new total, but does not show the line item for the misc cost. This seems to be a new behavior compared to 1.5.8.

Have you seen this before? Haven't tried to repro but they say it has happened multiple times.

12 Mar 2025, 3:25 PM
#1857
jimmie avatar

jimmie

Totally Zenned

Join Date:
Jan 2013
Location:
New Port Richey, Florida
Posts:
969
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

Zen version 210
When editing an order, adding a quantity to order, order does update with new quantity but customer details only line item still shows original quantity, but total is correct.
Also after editing an order how do I suppress all the extra info like the update info that goes into the comments?

12 Mar 2025, 4:01 PM
#1858
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,069
Plugin Contributions:
56

Re: Edit Orders v4.0 Support Thread

jimmie:

Zen version 210
When editing an order, adding a quantity to order, order does update with new quantity but customer details only line item still shows original quantity, but total is correct.
Also after editing an order how do I suppress all the extra info like the update info that goes into the comments?
What version of EO is in use?

If you're referring to the customer-hidden comments that EO-5 adds to identify the changes that an admin has made, that suppression is not supported.

13 Mar 2025, 1:03 AM
#1859
jimmie avatar

jimmie

Totally Zenned

Join Date:
Jan 2013
Location:
New Port Richey, Florida
Posts:
969
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

lat9:

What version of EO is in use?

If you're referring to the customer-hidden comments that EO-5 adds to identify the changes that an admin has made, that suppression is not supported.

Yes, eo5. My mistake on suppressing comments she's been printing from the admin, that's why she she's the comments, but that is the only area we can tell if a order has been changed, the order itself never changes quantity, but order total changes. If I log into customers account and look at edited ordered it shows them only 1 x some product = unit price 11.40 total 22.80

13 Mar 2025, 11:22 AM
#1860
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,069
Plugin Contributions:
56

Re: Edit Orders v4.0 Support Thread

jimmie:

Yes, eo5. My mistake on suppressing comments she's been printing from the admin, that's why she she's the comments, but that is the only area we can tell if a order has been changed, the order itself never changes quantity, but order total changes. If I log into customers account and look at edited ordered it shows them only 1 x some product = unit price 11.40 total 22.80
There have been a number of EO-5 pre-releases. I've tried to replicate your issue using EO5-rc1 and cannot. Please retry with that release-candidate.