Canada free local ship else flat rate

Just combed through it all again to ensure I hadn't made any mistakes.

FYI the test customer has an addressbook entry for Cornwall, Ottawa(nearby city within Ontario) and Montreal(out of province).

Code is there where you asked...Still doesn't work.

plc613:

To be clear, you're asking me to create a zone definition only and it will therefore show as zone defined but no tax rate?
Yes. To clarify, zones can be used for multiple things, could be for taxes, or shipping, or both, or even other things. Sometimes creating an extra zone definition for a specific purpose can help isolate issues.
Ajeh's suggestion of creating a new zone specific to this free shipping case allows the bulk of the normal code to isolate it to only Ontario as a whole. And then the custom code she offered is intended to check whether the city the customer entered specifically matches "cornwall" regardless of upper/lowercase, and to only activate when that combination occurs.

I had to clarify because that was one of the first things we did back in page 2. Are we 100% certain that code is right? ....I must be misunderstanding something.

Let's start with commenting out the code:

// bof: check for CORNWALL
if ($check_flag == true) {
  if (strtoupper($order->delivery['delivery_city']) != 'CORNWALL') {
[B]//[/B]    $check_flag = false;
  }
}
// eof: check for CORNWALL

the comment marks will let the Free Shipping Options freeoptions run for everywhere ...

With that commented out, does it show at the same time as Flat Rate flat?

If so, go to the Zone Definitions and go to the DETAILS ...

What is set on this Zone Definition DETAILS that you have been using for this Zone?

Do you see:
Country: Canada
Zone: Ontario

Next, uncomment the code in Free Shipping Options freeoptions ...

Now create a test customer with the right address ... what are you using for the address?

Ajeh:

Let's start with commenting out the code:

// bof: check for CORNWALL
if ($check_flag == true) {
if (strtoupper($order->delivery['delivery_city']) != 'CORNWALL') {
[B]//[/B] $check_flag = false;
}
}
// eof: check for CORNWALL

done.

> **Ajeh:**
>
> the comment marks will let the Free Shipping Options freeoptions run for everywhere ...
> 
> With that commented out, does it show at the same time as Flat Rate flat?
> 
> If so, go to the Zone Definitions and go to the DETAILS ...
> 
> What is set on this Zone Definition DETAILS that you have been using for this Zone?
> 
> Do you see:
> Country: Canada
> Zone: Ontario

Correct, yes.

> **Ajeh:**
>
> Next, uncomment the code in Free Shipping Options freeoptions ...
> 
> Now create a test customer with the right address ... what are you using for the address?

Getting Closer. I see both for all of Ontario not just Cornwall. If I choose an out of province address in the addressbook the free option disappears. So we're certainly closer but have not successfully isolated the city.

Eekks! How totally embarrassing ... :blush:

Could you try this code in Free Shipping Options freeoptions with the City addressed correctly ...

// bof: check for CORNWALL
if ($check_flag == true) {
  if (strtoupper([B]$order->delivery['city'][/B]) != 'CORNWALL') {
    $check_flag = false;
  }
}
// eof: check for CORNWALL

Talk about humbling moments ... :lookaroun

Not to worry...I've made my fair share of similar mistakes.

The correction didn't seem to change anything though. Free Shipping is still offered to all of Ontario and not just Cornwall.

Oh...Hold the phone!

The eagle has landed! Since there was a correction, I thought your initial instinct was probably correct and you were just second-guessing yourself in post #45:

// $check_flag = false;

So reenabling that now shows the free option solely to residents with a Cornwall address!

Yes! finally! silly coding issues ... :cool:

Thanks for the update that this is now working correctly for you ... :smile:

Thank you so much for your dedication in making this work. I appreciate it.

Remember the Zen Cart Team when you are rich and famous ... :cool:

Yeah I'm sure that'll happen real soon ;)

I forgot to ask, the freeoptions module doesn't support overrides does it?

No the modules do not have override files for the code ...

So should I add 'overrides to shipping modules' OR 'per city free shipping toggle in config' to the wish list?

Nope ... Payment, Shipping and Order Total modules do not get overrides ...

Fair enough. I imagine there's good reason for that. So it would need to be hardcoded as a variable that would be set via admin.

You could hardcode it as a constant if that is something that needs to be changed often, or just edit the file and change it ...

Well, I've git my fix but I'm just thinking if others want the same it would be a good feature to add to admin. Surely others have/will want this?

Always a possibility ...

If I were to make this an add-on, I would create a clone of Free Shipping Options freeoptions and add a new key to it for something such as clone it to be:
freeoptionscity.php

and add a new key to the module for:
MODULE_SHIPPING_FREEOPTIONSCITY_CITY

but then customize it to be able to have 1 to many cities, as some might want more than one city to have the Free Shipping ...

There are a lot of possibilities ...