Reward Points Full Suite v2.5 (for ZC v1.5x) Support Thread

Looks like it is the DPU Dynamic Price Updater mod causing my issue and there fixing next release.. :)

Hi CountryCharm,

i'm using this add on with edit order, old habits i know... :D, i've found an error while updating an edited orders, even if You don't touch the reward point it will put the symbols of the currencies in the text field.
Diva point out that there was a solution but i wasn't able to find it so I'm trying to solve it, but If You have any advice please tell.

Thanks

DivaVocals:

Okay so after thinking about this I think I know what solution I would prefer to implement to achieve the objective of showing the actual points earned (the results of the order_total table's "text" column) on the order detail page..

Been messing around with stuff, and I think what would work while still keeping the currency support is the following:

Show ALL order totals from the order_total table where the class is not = to "ot_reward_points_display" display the "title" and the "value" columns

BUT...

If there are order totals from the order_total table where the class is = to "ot_reward_points_display", show those totals JUST below the other orders totals, but display the values in the "title" and the "text" columns.

.....

Dunno if this could help, i'm still trying to figure it out, but Diva's mumbling made me mumble a lot :P.. so i found this kind of solution...

I modified the code:

<?php
    for ($i = 0, $n = sizeof($order->totals); $i < $n; $i++) {
      echo '              <tr>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Text">' . $order->totals[$i]['title'] . '</td>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Amount">' . $currencies->format($order->totals[$i]['value'], false) . '</td>' . "\n" .
           '              </tr>' . "\n";
    }
?>

With:

<?php
    for ($i = 0, $n = sizeof($order->totals); $i < $n; $i++) {
      if ($order_total['class'] = "ot_reward_points_display") {
      echo '              <tr>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Text">' . $order->totals[$i]['title'] . '</td>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Amount">' . $order->totals[$i]['text'] . '</td>' . "\n" .
           '              </tr>' . "\n";
       } else {
            echo '              <tr>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Text">' . $order->totals[$i]['title'] . '</td>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Amount">' . $currencies->format($order->totals[$i]['value'], false) . '</td>' . "\n" .
           '              </tr>' . "\n";
           }
    }
?>

It seem to work... still testing

izar74:

Dunno if this could help, i'm still trying to figure it out, but Diva's mumbling made me mumble a lot :P.. so i found this kind of solution...

I modified the code:

> 
> With:
> 
> ```php
<?php
    for ($i = 0, $n = sizeof($order->totals); $i < $n; $i++) {
      if ($order_total['class'] = "ot_reward_points_display") {
      echo '              <tr>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Text">' . $order->totals[$i]['title'] . '</td>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Amount">' . $order->totals[$i]['text'] . '</td>' . "\n" .
           '              </tr>' . "\n";
       } else {
            echo '              <tr>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Text">' . $order->totals[$i]['title'] . '</td>' . "\n" .
           '                <td align="right" class="'. str_replace('_', '-', $order->totals[$i]['class']) . '-Amount">' . $currencies->format($order->totals[$i]['value'], false) . '</td>' . "\n" .
           '              </tr>' . "\n";
           }
    }
?>

It seem to work... still testing
Ahhhh at last!! Something which appears to be the RIGHT solution.. as opposed to the bandaid solution that the current code contains.. and yes.. I'll admit that I was indeed grumbling about this.. :laugh: The "solution" that made it's way into the current Reward Points code IMHO should NEVER have been implemented as it solves one issue, while creating another..

So does this now show the Rewards Points WITHOUT a currency symbol while showing all other order totals WITH the currency symbol still in place??

DivaVocals:

So does this now show the Rewards Points WITHOUT a currency symbol while showing all other order totals WITH the currency symbol still in place??

I've not tested it very much but till now for all the order i've made Yes. It show all the total with currencies except the last line (in my case the Reward point module ot_reward_points_display has a sort order of 1000 so it's the last one) with the reward points.

Maybe this time is the right one :laugh:

izar74:

I've not tested it very much but till now for all the order i've made Yes. It show all the total with currencies except the last line (in my case the Reward point module ot_reward_points_display has a sort order of 1000 so it's the last one) with the reward points.

Maybe this time is the right one :laugh:

If it preserves the currency symbol for actual currency values, while displaying points as whole numbers.. then YEP.. this is the one.. Thanks for sharing.. Now THIS is the solution that should be included in the core of this module!!

DivaVocals:

If it preserves the currency symbol for actual currency values, while displaying points as whole numbers.. then YEP.. this is the one.. Thanks for sharing.. Now THIS is the solution that should be included in the core of this module!!

izar74
You can add this to the package or I will add it later this coming week sometime.
I have not tested it. I'm going on by what you said about it. I know it is a better way than before thank you

Hi countrycharm,

add it to the next release please :-), till now the modification works great, no error or problem so far. I'm glad to be of any help :P

Hi, I have what I hope is a simple question. I had this module previously and it worked great. Upgraded my store and had it reinstalled and it is basically working, but I can't get it to transfer points from pending to earned. i'm having to go in daily and manually transfer them. I'm sure it's some little box I don't have checked, but I can't figure out what it is. I've tried various configurations of where I think it needs changed, but it never works. Other than that, it is accumulating and redeeming just fine, but I'm tired of having to manually move them over.

loaner:

Hi, I have what I hope is a simple question. I had this module previously and it worked great. Upgraded my store and had it reinstalled and it is basically working, but I can't get it to transfer points from pending to earned. i'm having to go in daily and manually transfer them. I'm sure it's some little box I don't have checked, but I can't figure out what it is. I've tried various configurations of where I think it needs changed, but it never works. Other than that, it is accumulating and redeeming just fine, but I'm tired of having to manually move them over.

Try going to admin/configurations/Reward Points Config/ **Reward Point Status Track. **Change the simple to advance mode and set status items that will trigger a transfer of the reward points between pending and earned.

So right now I have them marked like this
Attachment #15190
and it isn't working. Should I have them marked in the other column? I think I've tried both and it didn't work for either one.

bumping this to see if I can get some help. It is still not working for me? See post above.

loaner:

So right now I have them marked like this
Attachment #15190
and it isn't working. Should I have them marked in the other column? I think I've tried both and it didn't work for either one.

On a stock zen cart 1.5.4 with reward points installed. This is how I have the reward points configuration setup.

Attachment #15202

The points transfer just fine from pending to earned when changing order status from processing or Delivered. Go back check your installation all I can tell you.

K, I changed to match yours. I'll see if that works. If not, I'll try installing it again myself and see if maybe he missed a file. Do you have any idea which file controls that so I can maybe just check that one?

Still not transferring for me. I downloaded the module again and checked all of the files that were installed back in February and it appears they are all there where they are supposed to be. I did notice this though. Do you think the one that is highlighted in blue may be causing a conflict? Can I delete it?
Attachment #15214

Hi again,

I've got this error:

[25-May-2015 15:22:01] PHP Fatal error:  1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '2') 
				OR (p.products_id=p2c.products_id AND prp.scope_id=p2c.categories_id A' at line 3 :: SELECT prp.point_ratio*p.products_price AS reward_points, prp.point_ratio, p.products_price, p.products_priced_by_attribute 
				FROM reward_master prp, products p, products_to_categories p2c
				WHERE p.products_id='101'"'
				AND p2c.products_id='101'"'
				AND ((prp.scope_id=p.products_id AND prp.scope='2') 
				OR (p.products_id=p2c.products_id AND prp.scope_id=p2c.categories_id AND prp.scope='1')
				OR (prp.scope='0'))
				ORDER BY prp.scope DESC LIMIT 1; ==> (as called by) /var/www/vhosts/.../httpdocs/includes/functions/extra_functions/reward_points_functions.php on line 62 <== in /var/www/vhosts/.../httpdocs/includes/classes/db/mysql/query_factory.php on line 155

Check the file but it seem all fine... the line 51 to 62 of reward_points_functions.php look like this:

if(zen_get_products_price_is_free($products_id)==false || REWARD_POINTS_ALLOW_ON_FREE=='1') // Allow RP on free items (Admin settable)
	{
		$sql = "SELECT prp.point_ratio*p.products_price AS reward_points, prp.point_ratio, p.products_price, p.products_priced_by_attribute 
				FROM ".TABLE_REWARD_MASTER." prp, ".TABLE_PRODUCTS." p, ".TABLE_PRODUCTS_TO_CATEGORIES." p2c 
				WHERE p.products_id='" . $products_id . "'
				AND p2c.products_id='" . $products_id . "'
				AND ((prp.scope_id=p.products_id AND prp.scope='".SCOPE_PRODUCT."') 
				OR (p.products_id=p2c.products_id AND prp.scope_id=p2c.categories_id AND prp.scope='".SCOPE_CATEGORY."')
				OR (prp.scope='".SCOPE_GLOBAL."'))
				ORDER BY prp.scope DESC LIMIT 1;";

		$result=$db->Execute($sql);

The specific of the server are:
Database: MySQL 5.1.73
Versione PHP: 5.3.3 (Zend: 2.3.0) PHP Memory Limit: 128M

I'm a little bit unsure of what that error could be... any guess would be helpful :smile:

I'm not sure if I'm blind but I cant find the installation directions for this mod. I love the mod and cant wait to install it.

I have reinstalled and made sure my screen matches yours on advanced and it is still not working. I'm still having to transfer points manually.

OK,

Tell me where i am going wrong here

Clean install of zen 1.5.4 with database imported from 1.39h which had reward points installed on it

Should i use the upgrade or the full version for this.

Because i looked in the upgrade version and there are only about 7 files, whereas in the new install version there are loads of files, Now as my zencart files are all new, there will be no reward point files already there, BUT as my database is imported from 1.39h it will still have the reward points data in it, which i don't want to lose.

So should i upload all files from "New install" versions and then run the "Upgrade SQL" or am i missing something, as i have read the instructions but they seem to be for either a completely new install or for an in place upgrade of an installed reward points module where the cart hasn't been upgraded since said module was installed

nigelt74:

OK,

Tell me where i am going wrong here

Clean install of zen 1.5.4 with database imported from 1.39h which had reward points installed on it

Should i use the upgrade or the full version for this.

Because i looked in the upgrade version and there are only about 7 files, whereas in the new install version there are loads of files, Now as my zencart files are all new, there will be no reward point files already there, BUT as my database is imported from 1.39h it will still have the reward points data in it, which i don't want to lose.

So should i upload all files from "New install" versions and then run the "Upgrade SQL" or am i missing something, as i have read the instructions but they seem to be for either a completely new install or for an in place upgrade of an installed reward points module where the cart hasn't been upgraded since said module was installed

Since you are not upgrading but doing a fresh install of all files and keeping your old database, use the New_Installation and use the Upgrade-to-2.5a.sql statement. That should be all you need to do.