Zen Cart Logo
Forums / Bug Reports / [Closed] FEEDBACK ON BETA of v1.5.5

[Closed] FEEDBACK ON BETA of v1.5.5

Locked

Views: 76,913

Results 241 to 260 of 461
This thread is locked. New replies are disabled.
2 Jan 2016, 6:45 PM
#241
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

[Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

Why would a PHP-driven user-tracking plugin need to fire a notifier at the template level? If the plugin is firing off some PHP code, then it could be triggered earlier and then there's no need to fire it at the end of template output generation. Now, if its sole purpose is to output some javascript then that's another issue.

Umm, early like first use of notifiers/observers and keeping the trigger point as it was by previous developers? :)

Okay, will look at a "sounder" trigger point for future revision as there is nothing external (template related)provided by the plugin, just picks up information. Thanks for the "code check".

2 Jan 2016, 6:51 PM
#242
wilt avatar

wilt

Oji-san

Join Date:
Jun 2003
Location:
Newcastle UK
Posts:
1,867
Plugin Contributions:
3

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Hi.

I don't want us to get fixated on ISO codes for zones, as you say there isn't anything official.

I guess my point is that the list you provided does not provide a proper list of county/zones for UK/GB

And if it doesn't do it for UK, can we trust it for other countries?

I don't want to discourage you, as what you are proposing is a good idea and really useful.

Maybe it's worth looking at what contributions we already have, that add country/zones, and think about updating those and adding them to core.

Dayo:

I don't believe there is a full set of official 2 digit ISO codes for every second level national subdivision in the world and outside the US, would be meaningless to most anyway. There isn't some 2 digit representation for Somerset or Newcastle in the UK for instance. Just doesn't exist. (There is a an obscure code for the two: GB-SOM/GB-NET) but I am sure Wilt, from Newcastle in the UK, probably never came across "GB-NET" before.

Basically, the abbreviations for the second tier subdivisions are not generally not significant outside the US and can be left blank in the database for most countries. Other Countries such as Australia which I believe do have some widespread use of 3 digit abbreviations for the subdivisions are probably already covered.

So my suggestion is to compile the list, exclude the countries already covered in the installation DB and leave the abbreviations empty for the new ones added.

2 Jan 2016, 7:02 PM
#243
dayo avatar

dayo

Zen Follower

Join Date:
Dec 2006
Posts:
187
Plugin Contributions:
1

Re: [Closed] FEEDBACK ON BETA of v1.5.5

wilt:

I guess my point is that the list you provided does not provide a proper list of county/zones for UK/GB

Difference of opinion as the list does identify the UK's Second Level Subdivisions, which are the Home Nations, correctly.
That the UK has a quirky set up where the second level (Home Nations) are not critical in some instances and the subdivisions of those (Counties) are instead, is a separate matter.

Anyway, if there is still time before release, I can put together an update to the SQL. I suppose that with all the recent additions from this thread, there must be significant pre-release testing to be re-done.

2 Jan 2016, 7:16 PM
#244
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Dayo:

Anyway, if there is still time before release, I can put together an update to the SQL.
Are you proposing just an updated set of countries only?
Or also more granularly adding "all zones" for all countries in the world?

I think what wilt's saying is he doesn't trust the source you quoted as being reliable for "all zones in all countries".

2 Jan 2016, 7:46 PM
#245
dayo avatar

dayo

Zen Follower

Join Date:
Dec 2006
Posts:
187
Plugin Contributions:
1

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

Are you proposing just an updated set of countries only?
Or also more granularly adding "all zones" for all countries in the world?

I think what wilt's saying is he doesn't trust the source you quoted as being reliable for "all zones in all countries".

Yeah, I got Wilt's point but my response was that this was not really valid as the list does correctly identify the UK's second level subdivisions (England, Scotland, Wales and Northern Ireland). That these are not what would be key in UK addresses is a separate and unique issue to the UK.

My intention was simply to granularly adding "all zones" for all countries in the world as already identified in the ZC setup. From your query about the updated set of countries, is it the case that the ZC list of countries/territories might need an update? Even if this was the case, I would think it would be best to maintain what is there already and leave such an update for a bigger dot point update.

That is, if a territory is one the zones list but not in the ZC list (New Territories), I'll leave it out and do the same for any in the ZC list but not in that list (Defunct Territories).

Alternative, is simply to supply the zones for Bahrain where I live and the nearby UAE although I think the "Full" proposal should be done and happy to do it if acceptable.

2 Jan 2016, 8:03 PM
#246
design75 avatar

design75

Totally Zenned

Join Date:
Dec 2009
Location:
Amersfoort, The Netherlands
Posts:
2,862
Plugin Contributions:
5

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Dayo:

Yeah, I got Wilt's point but my response was that this was not really valid as the list does correctly identify the UK's second level subdivisions (England, Scotland, Wales and Northern Ireland). That these are not what would be key in UK addresses is a separate and unique issue to the UK.

My intention was simply to granularly adding "all zones" for all countries in the world as already identified in the ZC setup. From your query about the updated set of countries, is it the case that the ZC list of countries/territories might need an update? Even if this was the case, I would think it would be best to maintain what is there already and leave such an update for a bigger dot point update.

That is, if a territory is one the zones list but not in the ZC list (New Territories), I'll leave it out and do the same for any in the ZC list but not in that list (Defunct Territories).

Alternative, is simply to supply the zones for Bahrain where I live and the nearby UAE although I think the "Full" proposal should be done and happy to do it if acceptable.
In my opinion it is of no use to add every zone of every country. For a lot of countries the zones are never used for shipping. Like in the Netherlands we only use the zip code, not the zone. I think it is better to add zones only when needed. This will prevent the database from becoming bloated.

2 Jan 2016, 8:16 PM
#247
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Dayo:

Alternative, is simply to supply the zones for Bahrain where I live and the nearby UAE although I think the "Full" proposal should be done and happy to do it if acceptable.
I'd recommend submitting 2 Pull Requests: one for Bahrain and UAE, and another with all the other updates you're proposing.

Either way, we'd have to review both before merging. And things that are smaller are definitely easier to review and do any corresponding additional research necessary.

While I realize you trust the single data source you quoted, it seems apparent to me that wilt doesn't trust it as its treatment of UK data is clinical and not practical (ie: while the 4 UK-related zones it contains are indeed accurate, they're not at all what anyone living in the UK actually uses day-to-day in relation to commerce or shipping).

Multiple data sources confirming the same information certainly help qualify validity of any proposal.
Please understand, that when something gets merged into core there is automatically a community-wide assumption that the core developers are assuming responsibility to maintain that information to be completely accurate for all future perpetuity ... and, while that's an unrealistic assumption it's still nonetheless part of the pressure considered when reviewing proposed changes. So, if a proposed change contains multiple verifiable sources that can be used for occasional future checking, it's more likely that we'll be willing to accept the proposal. Basically I'm talking about maintainability here.

That said, I'm glad you're offering to contribute. Many many thanks!

2 Jan 2016, 8:16 PM
#248
wilt avatar

wilt

Oji-san

Join Date:
Jun 2003
Location:
Newcastle UK
Posts:
1,867
Plugin Contributions:
3

Re: [Closed] FEEDBACK ON BETA of v1.5.5

But my point is valid. The second level entries in the list you provided are things that would never be used as a set of UK zones.
My point is, if the UK zones can't be trusted, why should I trust anything else.

That said.

If you have specific local experience for say Bahrain/UAE then sure, post details for this.

Dayo:

Yeah, I got Wilt's point but my response was that this was not really valid as the list does correctly identify the UK's second level subdivisions (England, Scotland, Wales and Northern Ireland). That these are not what would be key in UK addresses is a separate and unique issue to the UK.

2 Jan 2016, 8:21 PM
#249
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

Snap. Saw those and got distracted by something shiny probably :wow:
... or ... a squirrel! I don't see the changes in the GitHub repository, yet; will look again in the morning.

2 Jan 2016, 8:22 PM
#250
dayo avatar

dayo

Zen Follower

Join Date:
Dec 2006
Posts:
187
Plugin Contributions:
1

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Design75:

In my opinion it is of no use to add every zone of every country.

True that Post/Zip codes are unique identifiers and so, for countries that use them, you don't really need the zone for shipping. However, there can be tax and other things tied to zones.

Anyway, was just a thought. Would probably just do it for personal use.

2 Jan 2016, 8:29 PM
#251
dayo avatar

dayo

Zen Follower

Join Date:
Dec 2006
Posts:
187
Plugin Contributions:
1

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

... it seems apparent to me that Wilt doesn't trust it ...
Seems best to let things be ... especially since no one is complaining about missing zones.

2 Jan 2016, 8:40 PM
#252
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

... or ... a squirrel! I don't see the changes in the GitHub repository, yet; will look again in the morning.
They've just been merged :)

2 Jan 2016, 8:42 PM
#253
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Dayo:

True that Post/Zip codes are unique identifiers and so, for countries that use them, you don't really need the zone for shipping. However, there can be tax and other things tied to zones.

Anyway, was just a thought. Would probably just do it for personal use.

Dayo:

Seems best to let things be ... especially since no one is complaining about missing zones.
Fair enough. Still, thanks for engaging in the discussion and offering to contribute.

Perhaps preparing a plugin/addon that contains your proposed updates would be another option ... and we could get some community feedback, a crowd-sourced testing of sorts?

2 Jan 2016, 11:19 PM
#254
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

dw08gm:

Submit buttons readiness for cssButtons

If this has not already been done, can we have class="button" OR class="submitButton" AND/OR (perhaps) id="submit_Button" OR id="submit_Button" uniformly inserted within all <input type="submit"...> for cssButton readiness.

includes/modules/pages/checkout_success/header_php.php // class="submitButton" and id="submitbutton"
includes/modules/pages/payer_auth_auth/header_php.php
includes/modules/pages/payer_auth_verifier/header_php.php
includes/modules/payment/authorizenet/authorizenet_admin_notification.php
includes/templates/template_default/sideboxes/tpl_search.php
includes/templates/template_default/sideboxes/tpl_search_header.php

admin/banner_statistics.php
admin/categories.php
admin/coupon_restrict.php
admin/developers_tool_kit.php
admin/document_general.php
admin/document_product.php
admin/includes/modules/newsletters/product_notification.php
admin/login.php // class="button" and id="btn_submit"
admin/media_manager.php
admin/option_name.php
admin/option_values.php
admin/password_forgotten.php // class="button"
admin/product.php
admin/product_free_shipping.php
admin/product_music.php
admin/products_to_categories.php
Wherever zen_image_submit() is used, the CSS Buttons logic will output appropriate classes for that purpose. Catalog-side that's pretty much universal. Admin-side will get it with upcoming revisions.

3 Jan 2016, 1:22 AM
#255
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Was tryng to work on something related to attributes being displayed in the proper sequence and came across something I thought may be mysql server dependent, but on further testing does not appear to be so simple of a .

Discovery was in includes/modules/attributes.php and may be an issue in other files if in the same format.

When the sort order for option names is identified in product info as by sort order followed by name, then in the file, the sort order becomes: order by LPAD(popt.products_options_sort_order,11,"0")

But, when this is run perhaps the first time, then the data is presented as desired in sort order followed by option name order, but if that page is reloaded or the query performed again then the sort order is lost to return to being in the order of the options_id.. I thought that I had posted about this once before a long while back, and maybe the "solution" still stands that nothing need be done, but I thought I would bring it to light again.

This is fine if a sort order is applied to the option name, but when the sort order is 0 for all option names (or the same) the result is by option name id not by option name.

I then went to phpmyadmin and entered the exact query as created for the Execute, and got the same result, but the query was also slightly modified to add a space after each piece of information in the LPAD statement. When I then refed that query in, the result came back correctly sequenced (the first time)...

When I then went back to the attributes.php file and added the same space after each comma, then the attributes were presented in the correct sequence once correctly and then subsequent tries while on the same page were again presented incorrectly...

So yes it seems odd that it sorts properly one time but then subsequently incorrectly, but also the statement in admin is to sort by sort order and option name or to sort by option name. The sort provided to the query though only enforces either sort order or option name not both.

So my recommendation after all this is to change the LPAD statement here (and in other places entered the same) to be like:

  if (PRODUCTS_OPTIONS_SORT_ORDER == '0') {
                $options_order_by= ' order by LPAD(popt.products_options_sort_order, 11, "0"), popt.products_options_name';
  } else {
                $options_order_by= ' order by popt.products_options_name';
  }

Server OS: Linux 3.2.61-grsec-modsign
Database: MySQL 5.6.25-log
HTTP Server: Apache
PHP Version: 5.6.10 (Zend: 2.6.0)
PHP Memory Limit: 128M
PHP File Uploads: On **
Max Size:** 20M
PHP Safe Mode: Off
POST Max Size: 20M

Let me know if there is any specific or other data needed to reproduce this issue...

Even after accessing tools->Store Manager->Update All Products' Attribute Sort Orders
to match Option Value Default Sort Orders, the data still appears not in the sequence described by the admin option for sorting option names... Evidence also seen in the attributes controller.. Looks like either the admin description is incorrect, or the code at some point along the way is missing something to provide the response described... I found several other locations where the sort order of option_names was generated the same as provided in includes/modules/attributes.php Would be nice to have the full functionality described by adding the sort of products_options_name instead of removing the text of the option selection. :/

3 Jan 2016, 6:32 PM
#256
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Uh-oh! The admin-level configure.php file for ZC1.5.5 was reworked to discontinue the use of the ENABLE_SSL_ADMIN setting -- unfortunately, no one told

  1. admin/includes/functions/html_output.php (lines 21 and 44)
  2. admin/includes/init_includes/init_general_funcs.php (line 59)
  3. admin/includes/init_includes/init_sessions.php (line 23)

EDITED BY AJEH:
also referenced: /includes/functions/html_output.php

3 Jan 2016, 8:00 PM
#257
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

Uh-oh! The admin-level configure.php file for ZC1.5.5 was reworked to discontinue the use of the ENABLE_SSL_ADMIN setting -- unfortunately, no one told

  1. admin/includes/functions/html_output.php (lines 21 and 44)
  1. admin/includes/init_includes/init_general_funcs.php (line 59)
  1. admin/includes/init_includes/init_sessions.php (line 23)

EDITED BY AJEH:
also referenced: /includes/functions/html_output.php
In the interim, the defined_paths.php file defines HTTPS_SERVER so as to minimize the need to hack out a bunch of code. We've deferred the bigger change to v160 where lots of improvements are made to how those defines are used.

3 Jan 2016, 8:03 PM
#258
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,695
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Small suggestion: admin/customers.php lines 1245, 1265 - "pwreset" should be "pwdreset" to match "pwdresetconfirm" and TEXT_PWDRESET_INTRO (line 306 and 1247-1248).

5 Jan 2016, 3:32 PM
#259
brittainmark avatar

brittainmark

Totally Zenned

Join Date:
Apr 2009
Posts:
507
Plugin Contributions:
1

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Hi Finally had a bit of time to start looking at the new version. Sorry if any of these are duplicated I have tried to read through the previous messages.

On a brand new install I have a few issues/ suggestions

  1. "Main /includes/configure.php file does not exist (isn't readable) or is not writeable" error is clickable but no extra help provided. Same for admin (do you want empty files in place?)
  2. if you copy over the config template file from zc_install errormessage appears "Probems with database connection based on the entries in your current configure.php
    2005:Unknown MySQL server host '%%DB_SERVER%%' (2)" this links to itself again.
    3)Database setup. Should you add note to this page to say that you need to create a database before completing the fields. (I know that you should know this but is it better to cover all bases). the errormessage if you don't is "There are some problems. Problems with Database Connection 1049:Unknown database 'zencart'.

Also you recommend not using root but do not test for its use.

Hope this is useful if duplicated please ignore.

5 Jan 2016, 9:29 PM
#260
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

brittainmark:

Hi Finally had a bit of time to start looking at the new version.Thanks!

brittainmark:

  1. "Main /includes/configure.php file does not exist (isn't readable) or is not writeable" error is clickable but no extra help provided. Same for admin (do you want empty files in place?)Will look into the help text for that.
    brittainmark:

  2. if you copy over the config template file from zc_install errormessage appears "Probems with database connection based on the entries in your current configure.phpThe correct "source" to copy from is the /includes/dist-configure.php file ... which is why it's in that folder.
    Will mention that further in the help text.
    brittainmark:

3)Database setup. Should you add note to this page to say that you need to create a database before completing the fields. Good point.

These are all mentioned in the /docs/Implementation_Guide-v155.pdf file, but we all know nobody reads written docs despite the time it takes to write them. The on-screen help text can use some updates. Thanks for pointing these out!

brittainmark:

Also you recommend not using root but do not test for its use.Correct. On live production sites, root should not be used. But on offline localhost dev sites sometimes it's quite desirable, hence we're not preventing that.