Zen Cart Logo
Forums / Bug Reports / [Closed] FEEDBACK ON BETA of v1.5.5

[Closed] FEEDBACK ON BETA of v1.5.5

Locked

Views: 76,913

Results 201 to 220 of 461
This thread is locked. New replies are disabled.
31 Dec 2015, 7:25 PM
#201
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

[Closed] FEEDBACK ON BETA of v1.5.5

bn17311:

but doesn't matter if on or off the boxes seem to resize

bn
Just to be clear, you're talking about the light-grey vs the dark-grey boxes being not-exactly-sitting-perfectly-aligned-on-each-other at all resolutions?
Is this "on specific devices" ... or is it because you're resizing a desktop browser and noticing a progressive change?
I just want to be sure we're talking about the same thing.

31 Dec 2015, 7:43 PM
#202
bn17311 avatar

bn17311

Zen Follower

Join Date:
Apr 2010
Posts:
319
Plugin Contributions:
0

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

Just to be clear, you're talking about the light-grey vs the dark-grey boxes being not-exactly-sitting-perfectly-aligned-on-each-other at all resolutions?
Is this "on specific devices" ... or is it because you're resizing a desktop browser and noticing a progressive change?
I just want to be sure we're talking about the same thing.

iPad doesn't line up and desktop noticable when resizing window, maybe because everything else seems to sit well it catches your eye

only posting hoping its being helpful as i do think its looking good.

bn

31 Dec 2015, 8:47 PM
#203
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Just FYI ... while we'd hoped to release v1.5.5 sometime in the past 3 days, in some of our testing today we ran into some bugs that will cause SQL query errors in the latest MySQL versions ... and there are still a few mobile-related CSS things we want to tidy up.

We'd rather not release it with known bugs like that, so we'll try again for tomorrow and thru the weekend.

It'll be released as soon as we can.

In the meantime, we want to wish you all a Happy New Year!

1 Jan 2016, 3:39 AM
#204
kobra avatar

kobra

Black Belt

Join Date:
Aug 2005
Location:
Arizona
Posts:
31,500
Plugin Contributions:
4

Re: [Closed] FEEDBACK ON BETA of v1.5.5

picaflor-azul:

The easiest way to find any errors is to run the page through the w3c html validator
I have just installed from a fresh download and ran it through the validator
As you can see there are several errors that are template related and these also seem to be standard with most of your templates

1.5.5 install
https://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fwww.kobrawd.com%2Fdemo155%2Findex.php&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

1.5.4 with the westminster_new template
https://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fwww.kobrawd.com%2Fdemo154%2Findex.php&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

Are these to be addressed at the developer level or left to the community to fix for each install

1 Jan 2016, 1:30 PM
#205
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

Just FYI ... while we'd hoped to release v1.5.5 sometime in the past 3 days, in some of our testing today we ran into some bugs that will cause SQL query errors in the latest MySQL versions ... and there are still a few mobile-related CSS things we want to tidy up.

We'd rather not release it with known bugs like that, so we'll try again for tomorrow and thru the weekend.

It'll be released as soon as we can.

In the meantime, we want to wish you all a Happy New Year!
Happy New Year ... back at you! Since I've got the chance, I figured that I'd request just a few::P more notifiers:

/includes/classes/order.php:

  function create_add_products($zf_insert_id, $zf_mode = false) {
    global $db, $currencies, $order_total_modules, $order_totals;

    // initialized for the email confirmation
    $this->products_ordered = '';
    $this->products_ordered_html = '';
    $this->subtotal = 0;
    $this->total_tax = 0;

    // lowstock email report
    $this->email_low_stock='';

    for ($i=0, $n=sizeof($this->products); $i<$n; $i++) {
      $custom_insertable_text = '';
      [B]$this->notify ('NOTIFY_ORDER_CREATE_ADD_PRODUCTS_BEGIN', array ( 'i' => $i));[/B]  //-products_options_stock-lat9  *** 1 of 2 ***
      $this->doStockDecrement = (STOCK_LIMITED == 'true');
      $this->notify('NOTIFY_ORDER_PROCESSING_STOCK_DECREMENT_INIT', array(), $this->products[$i], $i);
      // Stock Update - Joao Correia
      if ($this->doStockDecrement) {
      $this->notify('NOTIFY_ORDER_PROCESSING_STOCK_DECREMENT_END', $i);

      $sql_data_array = array('orders_id' => $zf_insert_id,
                              'products_id' => zen_get_prid($this->products[$i]['id']),
                              'products_model' => $this->products[$i]['model'],
                              'products_name' => $this->products[$i]['name'],
                              'products_price' => $this->products[$i]['price'],
                              'final_price' => $this->products[$i]['final_price'],
                              'onetime_charges' => $this->products[$i]['onetime_charges'],
                              'products_tax' => $this->products[$i]['tax'],
                              'products_quantity' => $this->products[$i]['qty'],
                              'products_priced_by_attribute' => $this->products[$i]['products_priced_by_attribute'],
                              'product_is_free' => $this->products[$i]['product_is_free'],
                              'products_discount_type' => $this->products[$i]['products_discount_type'],
                              'products_discount_type_from' => $this->products[$i]['products_discount_type_from'],
                              'products_prid' => $this->products[$i]['id']);
      zen_db_perform(TABLE_ORDERS_PRODUCTS, $sql_data_array);

      $order_products_id = $db->Insert_ID();

      $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_PRODUCT_LINE_ITEM', array_merge(array('orders_products_id' => $order_products_id[B], 'i' => $i[/B]), $sql_data_array), $order_products_id);  //-products_options_stock-lat9  *** 2 of 2 ***

      $this->notify('NOTIFY_ORDER_PROCESSING_CREDIT_ACCOUNT_UPDATE_BEGIN');
      $order_total_modules->update_credit_account($i);//ICW ADDED FOR CREDIT CLASS SYSTEM
    //comments area
    if ($this->info['comments']) {
      $email_order .= zen_db_output($this->info['comments']) . "\n\n";
      $html_msg['ORDER_COMMENTS'] = nl2br(zen_db_output($this->info['comments']));
    } else {
      $html_msg['ORDER_COMMENTS'] = '';
    }

//-bof-multiship-lat9 *** 1 of 2 ***   
    [B]$this->notify('NOTIFY_ORDER_EMAIL_BEFORE_PRODUCTS', array(), $email_order, $html_msg);[/B]
//-eof-multiship-lat9 *** 1 of 2 ***

    //products area
    $email_order .= EMAIL_TEXT_PRODUCTS . "\n" .
    EMAIL_SEPARATOR . "\n" .
    $this->products_ordered .
    $html_msg['EMAIL_FIRST_NAME'] = $this->customer['firstname'];
    $html_msg['EMAIL_LAST_NAME'] = $this->customer['lastname'];
    //  $html_msg['EMAIL_TEXT_HEADER'] = EMAIL_TEXT_HEADER;
    $html_msg['EXTRA_INFO'] = '';
    $this->notify('NOTIFY_ORDER_INVOICE_CONTENT_READY_TO_SEND', array('zf_insert_id' => $zf_insert_id, 'text_email' => $email_order, 'html_email' => $html_msg), $email_order, $html_msg);
//-bof-multiship-lat9 *** 2 of 2 ***
    [B]$this->notify('NOTIFY_ORDER_INVOICE_CONTENT_READY_TO_SEND2', array('zf_insert_id' => $zf_insert_id), $email_order, $html_msg);[/B]
//-eof-multiship-lat9 *** 2 of 2 ***

/includes/modules/attributes.php:

                $tmp_attributes_image = '';
                $tmp_attributes_image_row = 0;
                $show_attributes_qty_prices_icon = 'false';
                
//-bof-attribute_image_swatch-lat9  *** 1 of 4 ***
                [B]$zco_notifier->notify('NOTIFY_ATTRIBUTES_MODULE_START_OPTION', $products_options_names->fields);[/B]
//-eof-attribute_image_swatch-lat9  *** 1 of 4 ***

                while (!$products_options->EOF) {
                  // reset
                  $products_options_display_price='';
                  $new_attributes_price= '';
                  $price_onetime = '';

                  $products_options_array[] = array('id' => $products_options->fields['products_options_values_id'],
                  'text' => $products_options->fields['products_options_values_name']);

//-bof-posm_price_weight-lat9  *** 1 of 1 ***
                  [B]$zco_notifier->notify ('NOTIFY_ATTRIBUTES_MODULE_START_OPTIONS_LOOP', array (), $products_options->fields);[/B]
//-eof-posm_price_weight-lat9  *** 1 of 1 ***
                    }
                    $tmp_html .= $products_options_details;
                  }

//-bof-attribute_image_swatch-lat9  *** 2 of 4 ***
                  [B]$zco_notifier->notify('NOTIFY_ATTRIBUTES_MODULE_FORMAT_VALUE', $products_options->fields);[/B]
//-eof-attribute_image_swatch-lat9  *** 2 of 4 ***

                  // collect attribute image if it exists and to be drawn in table below
                  if ($products_options_names->fields['products_options_images_style'] == '0' or ($products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_FILE or $products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_TEXT or $products_options_names->fields['products_options_type'] == '0') ) {
                    if ($products_options->fields['attributes_image'] != '') {
                  }
                  $options_html_id[] = 'drp-attrib-' . $products_options_names->fields['products_options_id'];
                  $options_menu[] = zen_draw_radio_field('id[' . $products_options_names->fields['products_options_id'] . ']', $products_options_value_id, 'selected', 'id="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '-' . $products_options_value_id . '"') . '<label class="attribsRadioButton" for="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '-' . $products_options_value_id . '">' . $products_options_details . '</label>' . "\n";
                  $options_comment[] = $products_options_names->fields['products_options_comment'];
                  $options_comment_position[] = ($products_options_names->fields['products_options_comment_position'] == '1' ? '1' : '0');
                  break;
                  
//-bof-attribute_image_swatch-lat9  *** 3 of 4 ***
                  [B]case ($products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_SELECT):[/B]  // Was default:
//-eof-attribute_image_swatch-lat9  *** 3 of 4 ***
                  // normal dropdown menu display
                  if (isset($_SESSION['cart']->contents[$prod_id]['attributes'][$products_options_names->fields['products_options_id']])) {
                  $options_html_id[] = 'drp-attrib-' . $products_options_names->fields['products_options_id'];
                  $options_menu[] = zen_draw_pull_down_menu('id[' . $products_options_names->fields['products_options_id'] . ']', $products_options_array, $selected_attribute, 'id="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '"') . "\n";
                  $options_comment[] = $products_options_names->fields['products_options_comment'];
                  $options_comment_position[] = ($products_options_names->fields['products_options_comment_position'] == '1' ? '1' : '0');
                  break;
                  
//-bof-attribute_image_swatch-lat9  *** 4 of 4 ***
                  [B]default:
                  $zco_notifier->notify('NOTIFY_ATTRIBUTES_MODULE_DEFAULT_SWITCH', $products_options_names->fields, $options_name, $options_menu, $options_comment, $options_comment_position, $options_html_id);
                  break;[/B]
//-eof-attribute_image_swatch-lat9  *** 4 of 4 ***

[B]/YOUR_ADMIN/attributes_controller.php

[/B]
      case 'delete_attribute':
        // demo active test
        if (zen_admin_demo()) {
          $_GET['action']= '';
          $messageStack->add_session(ERROR_ADMIN_DEMO, 'caution');
          zen_redirect(zen_href_link(FILENAME_ATTRIBUTES_CONTROLLER, $_SESSION['page_info'] . '&current_category_id=' . $_POST['current_category_id']));
        }
        if (isset($_POST['delete_attribute_id']))
        {
          $attribute_id = zen_db_prepare_input($_POST['delete_attribute_id']);
          
//-bof-options_stock-lat9  *** 1 of 3 ***
          [B]$zco_notifier->notify ('NOTIFY_ATTRIBUTE_CONTROLLER_DELETE_ATTRIBUTE', array ( 'attribute_id' => $attribute_id));[/B]
//-eof-options_stock-lat9  *** 1 of 3 ***

          $db->Execute("delete from " . TABLE_PRODUCTS_ATTRIBUTES . "
                      where products_attributes_id = '" . (int)$attribute_id . "'");

// added for DOWNLOAD_ENABLED. Always try to remove attributes, even if downloads are no longer enabled
          $db->Execute("delete from " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . "
                      where products_attributes_id = '" . (int)$attribute_id . "'");

        // reset products_price_sorter for searches etc.
          zen_update_products_price_sorter($products_filter);

          zen_redirect(zen_href_link(FILENAME_ATTRIBUTES_CONTROLLER, $_SESSION['page_info'] . '&current_category_id=' . $_POST['current_category_id']));
        }
        break;
// delete all attributes
      case 'delete_all_attributes':
      
//-bof-options_stock-lat9  *** 2 of 3 ***
        [B]$zco_notifier->notify ('NOTIFY_ATTRIBUTE_CONTROLLER_DELETE_ALL', array ( 'pID' => $_POST['products_filter']));[/B]
//-eof-options_stock-lat9  *** 2 of 3 ***

        zen_delete_products_attributes($_POST['products_filter']);
        $messageStack->add_session(SUCCESS_ATTRIBUTES_DELETED . ' ID#' . $products_filter, 'success');
        $action='';
        $products_filter = (int)$_POST['products_filter'];

        // reset products_price_sorter for searches etc.
        zen_update_products_price_sorter($products_filter);

        zen_redirect(zen_href_link(FILENAME_ATTRIBUTES_CONTROLLER, 'products_filter=' . $products_filter . '&current_category_id=' . $_POST['current_category_id']));
        break;

      case 'delete_option_name_values':
//-bof-options_stock-lat9  *** 3 of 3 ***
        [B]$zco_notifier->notify ('NOTIFY_ATTRIBUTE_CONTROLLER_DELETE_OPTION_NAME_VALUES', array ( 'pID' => $_POST['products_filter'], 'options_id' => $_POST['products_options_id_all'] ));[/B]
//-eof-options_stock-lat9  *** 3 of 3 ***

        $delete_attributes_options_id = $db->Execute("select * from " . TABLE_PRODUCTS_ATTRIBUTES . " where products_id='" . $_POST['products_filter'] . "' and options_id='" . $_POST['products_options_id_all'] . "'");
        while (!$delete_attributes_options_id->EOF) {
// remove any attached downloads
          $remove_downloads = $db->Execute("delete from " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " where products_attributes_id= '" . $delete_attributes_options_id->fields['products_attributes_id'] . "'");
// remove all option values

/YOUR_ADMIN/options_values_manager.php

      case 'delete_value':
        // demo active test
        if (zen_admin_demo()) {
          $_GET['action']= '';
          $messageStack->add_session(ERROR_ADMIN_DEMO, 'caution');
          zen_redirect(zen_href_link(FILENAME_OPTIONS_VALUES_MANAGER, $_SESSION['page_info']));
        }
        $value_id = zen_db_prepare_input($_GET['value_id']);
        
//-bof-options_stock-lat9  *** 1 of 1 ***
        [B]$zco_notifier->notify ('OPTIONS_VALUES_MANAGER_DELETE_VALUE', array ( 'value_id' => $value_id ));[/B]
//-eof-options_stock-lat9  *** 1 of 1 ***

/YOUR_ADMIN/includes/classes/order.php

  class order [B]extends base[/B] {  //-products_options_stock-lat9 (Added 'extends base')  *** 1 of 2 *** 
    var $info, $totals, $products, $customer, $delivery;

and, at the very end of the file:

 
//-bof-products_options_stock-lat9  *** 2 of 2 ***
      [B]$this->notify ('ORDER_QUERY_ADMIN_COMPLETE', array ('orders_id' => $order_id));[/B]
//-eof-products_options_stock-lat9  *** 2 of 2 ***

    }
  }
1 Jan 2016, 2:22 PM
#206
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

Bulletin-board notifier support. Needs a change to /includes/modules/pages/account_edit/header_php.php to be able to distinguish between an email-address check for the current customer vs. an overall check for the email address, changing:

// check external hook for duplicate email address, so we can reject the change if duplicates aren't allowed externally
  // (the observers should set any messageStack output as needed)
  $nick_error = false;
  $zco_notifier->notify('NOTIFY_NICK_CHECK_FOR_EXISTING_EMAIL', $email_address, $nick_error);

to

// check external hook for duplicate email address, so we can reject the change if duplicates aren't allowed externally
  // (the observers should set any messageStack output as needed)
  $nick_error = false;
  $zco_notifier->notify('NOTIFY_NICK_CHECK_FOR_EXISTING_EMAIL', $email_address, $nick_error[B], $nick[/B]);

Otherwise, a customer with a bulletin-board account can't change their password because the (unchanged) email address already associated with the nickname is going to come back as "already used".

1 Jan 2016, 2:56 PM
#207
picaflor_azul avatar

picaflor_azul

Totally Zenned

Join Date:
Jul 2009
Location:
picaflor-azul.com
Posts:
6,940
Plugin Contributions:
28

Re: [Closed] FEEDBACK ON BETA of v1.5.5

kobra:

I have just installed from a fresh download and ran it through the validator
As you can see there are several errors that are template related and these also seem to be standard with most of your templates

1.5.5 install
https://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fwww.kobrawd.com%2Fdemo155%2Findex.php&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

1.5.4 with the westminster_new template
https://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fwww.kobrawd.com%2Fdemo154%2Findex.php&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

Are these to be addressed at the developer level or left to the community to fix for each install

These are all related to the font awesome stylesheet. See this:

https://github.com/FortAwesome/Font-Awesome/issues/6489

Thanks,

Anne

1 Jan 2016, 3:02 PM
#208
kobra avatar

kobra

Black Belt

Join Date:
Aug 2005
Location:
Arizona
Posts:
31,500
Plugin Contributions:
4

Re: [Closed] FEEDBACK ON BETA of v1.5.5

picaflor-azul:

These are all related to the font awesome stylesheet
There are also several "unknown vendor extension" errors

1 Jan 2016, 3:32 PM
#209
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

Bulletin-board notifier support. Needs a change to /includes/modules/pages/account_edit/header_php.php to be able to distinguish between an email-address check for the current customer vs. an overall check for the email address, changing:

// check external hook for duplicate email address, so we can reject the change if duplicates aren't allowed externally
// (the observers should set any messageStack output as needed)
$nick_error = false;
$zco_notifier->notify('NOTIFY_NICK_CHECK_FOR_EXISTING_EMAIL', $email_address, $nick_error);

> to
> ```
// check external hook for duplicate email address, so we can reject the change if duplicates aren't allowed externally
  // (the observers should set any messageStack output as needed)
  $nick_error = false;
  $zco_notifier->notify('NOTIFY_NICK_CHECK_FOR_EXISTING_EMAIL', $email_address, $nick_error[B], $nick[/B]);

Otherwise, a customer with a bulletin-board account can't change their password because the (unchanged) email address already associated with the nickname is going to come back as "already used".
OK, I obviously needed some more coffee before I wrote that. The existing code-block reads:

// check external hook for duplicate email address, so we can reject the change if duplicates aren't allowed externally
  // (the observers should set any messageStack output as needed)
  $nick_error = false;
  $zco_notifier->notify('NOTIFY_NICK_CHECK_FOR_EXISTING_EMAIL', $email_address, $nick_error);
  if ($nick_error) $error = true;
  [B]$zco_notifier->notify('NOTIFY_NICK_CHECK_FOR_DUPLICATE', $nick, $nick_error);
  if ($nick_error) $error = true;[/B]

and the highlighted lines need to be removed. Note that the $nick input still needs to be sent on the first notifier!

1 Jan 2016, 4:29 PM
#210
picaflor_azul avatar

picaflor_azul

Totally Zenned

Join Date:
Jul 2009
Location:
picaflor-azul.com
Posts:
6,940
Plugin Contributions:
28

Re: [Closed] FEEDBACK ON BETA of v1.5.5

kobra:

There are also several "unknown vendor extension" errors

These will show as errors or warnings depending on how you have the validator settings. It is true that vendor-specific extensions are invalid CSS. They help support browser compatibility. The vendor extensions are proprietary code and will always be invalid. Is there a way to make them validate?

http://stackoverflow.com/questions/1889724/how-to-validate-vendor-prefixes-in-css-like-webkit-and-moz

Thanks,

Anne

1 Jan 2016, 4:33 PM
#211
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

Happy New Year ... back at you! Since I've got the chance, I figured that I'd request just a few::P more notifiers:lol

A few questions ...

  1. Is there a reason why you want to add NOTIFY_ORDER_CREATE_ADD_PRODUCTS_BEGIN when NOTIFY_ORDER_PROCESSING_STOCK_DECREMENT_INIT already provides that info?

  2. What's the purpose of the duplication provided by NOTIFY_ORDER_INVOICE_CONTENT_READY_TO_SEND2?

3 ... more after I review the attributes proposals

1 Jan 2016, 4:43 PM
#212
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

lol

A few questions ...

  1. Is there a reason why you want to add NOTIFY_ORDER_CREATE_ADD_PRODUCTS_BEGIN when NOTIFY_ORDER_PROCESSING_STOCK_DECREMENT_INIT already provides that info?
    Er, because I wasn't paying attention?:blush:

  2. What's the purpose of the duplication provided by NOTIFY_ORDER_INVOICE_CONTENT_READY_TO_SEND2?
    Because NOTIFY_ORDER_INVOICE_CONTENT_READY_TO_SEND doesn't allow the observer to change the contents of the email information blocks.

3 ... more after I review the attributes proposals
See replies embedded above.

1 Jan 2016, 5:14 PM
#213
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

OK, I obviously needed some more coffee before I wrote that. The existing code-block reads:

// check external hook for duplicate email address, so we can reject the change if duplicates aren't allowed externally
// (the observers should set any messageStack output as needed)
$nick_error = false;
$zco_notifier->notify('NOTIFY_NICK_CHECK_FOR_EXISTING_EMAIL', $email_address, $nick_error);
if ($nick_error) $error = true;
[B]$zco_notifier->notify('NOTIFY_NICK_CHECK_FOR_DUPLICATE', $nick, $nick_error);
if ($nick_error) $error = true;
[/B]

> and the highlighted lines need to be removed.  Note that the $nick input still needs to be sent on the first notifier!

What about the create_account.php file too?
1 Jan 2016, 5:16 PM
#214
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

Because NOTIFY_ORDER_INVOICE_CONTENT_READY_TO_SEND doesn't allow the observer to change the contents of the email information blocks.
Any objection to us just fixing that?

1 Jan 2016, 5:17 PM
#215
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

Because NOTIFY_ORDER_INVOICE_CONTENT_READY_TO_SEND doesn't allow the observer to change the contents of the email information blocks.
Er, um, in v1.5.5 it does already allow changing them.

1 Jan 2016, 5:22 PM
#216
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

What about the create_account.php file too?
Nope, in the create-account process you want to ensure that the nickname chosen is unique; in the account-edit process, the nickname's already chosen (and not modifiable).

1 Jan 2016, 5:23 PM
#217
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

Er, um, in v1.5.5 it does already allow changing them.
Where's that coffee ... you're correct, of course. I'll be making some changes in my plugins.

1 Jan 2016, 5:27 PM
#218
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

//-bof-attribute_image_swatch-lat9 *** 3 of 4 ***
[B]case ($products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_SELECT):[/B] // Was default:
//-eof-attribute_image_swatch-lat9 *** 3 of 4 ***
// normal dropdown menu display
if (isset($_SESSION['cart']->contents[$prod_id]['attributes'][$products_options_names->fields['products_options_id']])) {

> 
> ```
                  $options_html_id[] = 'drp-attrib-' . $products_options_names->fields['products_options_id'];
                  $options_menu[] = zen_draw_pull_down_menu('id[' . $products_options_names->fields['products_options_id'] . ']', $products_options_array, $selected_attribute, 'id="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '"') . "\n";
                  $options_comment[] = $products_options_names->fields['products_options_comment'];
                  $options_comment_position[] = ($products_options_names->fields['products_options_comment_position'] == '1' ? '1' : '0');
                  break;
                  
//-bof-attribute_image_swatch-lat9  *** 4 of 4 ***
                  [B]default:
                  $zco_notifier->notify('NOTIFY_ATTRIBUTES_MODULE_DEFAULT_SWITCH', $products_options_names->fields, $options_name, $options_menu, $options_comment, $options_comment_position, $options_html_id);
                  break;[/B]
//-eof-attribute_image_swatch-lat9  *** 4 of 4 ***
```Can you talk a bit about the sort of testing you've done, and logic considered, to ensure there are no ill side-effects of changing this default?
I know Ajeh's probably grinding fingernails on the blackboard trying to anticipate potential problems with this...
1 Jan 2016, 5:27 PM
#219
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,086
Plugin Contributions:
56

Re: [Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

Any objection to us just fixing that?
The reason that I'd created another notifier to add those fields (that it turns out isn't needed!) is that I didn't want to introduce version-specific notifiers! The last thing that I, as a plugin developer, want is to have to know which version of Zen Cart is being used for my plugin to determine how to handle a specific notifier.

1 Jan 2016, 5:30 PM
#220
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Closed] FEEDBACK ON BETA of v1.5.5

lat9:

The reason that I'd created another notifier to add those fields (that it turns out isn't needed!) is that I didn't want to introduce version-specific notifiers! The last thing that I, as a plugin developer, want is to have to know which version of Zen Cart is being used for my plugin to determine how to handle a specific notifier.
Yes, I fully appreciate that challenge. But it's a necessary evil. We do try to defer "big" changes to "big" versions, but I'm a believer in progressive change especially since some people delay upgrading terribly long but try to use new plugins against old code so having new hooks or improvements integrated sooner than later tends to be better. Fortunately there are a few ways to handle version control, including just testing whether a certain thing has been passed or not, etc.