[Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

Fixed:

• observers folder is now searched
• the overrides for modules and sidebox templates are now searched
• previous search terms are repopulated (into the same search that was last used)
  Is the admin/includes/classes/observers folder also searched?

psst ... sure he did what are you reading? :lookaroun

oops I didn't ... there isn't one in the /admin/classes

Ajeh:

That would be a bad plan ... try adding it to the end of United States on countries and make an order ...

Notice the terrible mess on TEXT emails and the Account History page that it makes ... :lookaroun
Good point. It's sounding like a store with an existing latin1 database that's looking to upgrade is going to be :censored:.

Not that I'm against going to all-utf8-all-the-time (especially given that most of the payment providers are sending utf8 datastreams that don't record nicely in a latin1 database) ... I'm about to formalize this for any upgrades that I'm asked to do.

lat9:

Good point. It's sounding like a store with an existing latin1 database that's looking to upgrade is going to be :censored:.

Not that I'm against going to all-utf8-all-the-time (especially given that most of the payment providers are sending utf8 datastreams that don't record nicely in a latin1 database) ... I'm about to formalize this for any upgrades that I'm asked to do.

Sounds good to me ... wish everyone would! :cool:

Done

https://github.com/zencart/zencart/commit/935af515a85799234a1524a9ca11d3dc5f50df12

balihr:

Don't want to be a pain in the a**, but was there any reason why this was ignored? IMHO, an important fix

I am probably jumping the gun here (so what else is new? lol) but is it ok to start doing some testing on mods in the plugins section to see if they are going to work with 1.5.5? Or should I wait until 1.5.5 is officially released?

stellarweb:

I am probably jumping the gun here (so what else is new? lol) but is it ok to start doing some testing on mods in the plugins section to see if they are going to work with 1.5.5? Or should I wait until 1.5.5 is officially released?
Nothing wrong with testing them!

The most notable potential compatibility issues are with plugins which change core function files like html_output.php and functions_general.php or functions_lookups.php ... and of course any other files that need merging of changes.

bn17311:

in mobile template if you click contact us link it takes to you part way down page missing out the store name etc

you wouldnt naturally think to scroll up for store name phone no etc

Hmmm ... The focus is automatically set to the first field in the form ... which results in partially scrolling the page downward so that the field is visible. It's a bit of a chicken-vs-egg thing ... as it's impossible to know whether the visitor went to the contact-us page to merely see address/phone info vs with the intention of using the contact-us form. Those are kinda difficult stats to collect ... or, at least, I've not seen any to suggest which "default" is the best for most sites.

This functionality has existed in ZC since v1.3 ... and is driven by the brief javascript in /includes/modules/pages/contact_us/on_load_main.js
I suppose one could alter that javascript to behave differently on mobile devices.
Removing the javascript and using the HTML "autofocus" attribute also causes the same "scroll" effect.

Cool - Thanks Chris. I am on it as soon as I get done with this site I am working on. I will also see what I can do about submitting any of them that need to be updated as well.

DrByte:

Nothing wrong with testing them!

The most notable potential compatibility issues are with plugins which change core function files like html_output.php and functions_general.php or functions_lookups.php ... and of course any other files that need merging of changes.

Anne - I am having a problem identifying why the buttons on the login page are being distorted.... see attached

Can you help me figure it out? I have looked in stylesheets as well as the tpl_login_default.php to see if there is coding in there that is magnifying them and I just can't find anything.

THANKS!

bn17311:

on desktop template with right column switched off

sample data - category big linked and mixed product types the add button is hidden slightly

bn
Fixed .

DrByte:

Fixed the missing $options_html_id stuff.
https://github.com/zencart/zencart/commit/e217333bc2d34508b171f978aa9f8835a1aa32da

Its purpose is to allow for javascript targeting of specific CSS IDs on the page, to allow dynamic update stuff.

Looking at the includes/modules/attributes.php changes identified in the above commit, didn't see the "special" case of a dropdown with a single value that results in a radio button instead of a dropdown... Not having tried to use those features, I don't have a suggestion for addressing it, but would certainly want to be sure that one or the other side recognized/addressed that.

mc12345678:

Looking at the includes/modules/attributes.php changes identified in the above commit, didn't see the "special" case of a dropdown with a single value that results in a radio button instead of a dropdown... Not having tried to use those features, I don't have a suggestion for addressing it, but would certainly want to be sure that one or the other side recognized/addressed that.

That is covered too ...

small thing, enabling and disabling products

while browsing categories products you click on red / green button this is what its called

but when in product i think you could be confused into thinking you are switching product to out of stock or instock rather than enable / disable

unless there is a reason for this. if they do the same job call them the same

bn

Ajeh:

That is covered too ...

Well, I guess I meant there is no "unique" consideration for that condition...

$options_html_id[] = 'drp-attrib-' . $products_options_names->fields['products_options_id'];
                    $options_menu[] = zen_draw_radio_field('id[' . $products_options_names->fields['products_options_id'] . ']', $products_options_value_id, 'selected', 'id="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '-' . $products_options_value_id . '"') . '<label class="attribsRadioButton" for="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '-' . $products_options_value_id . '">' . $products_options_details . '</label>' . "\n";

Maybe a drprad setting? Therefore the "handler" can determine which way to go with it? Treat it as a radio button or treat it as a dropdown?

Oh and sorry for any # symbols in the above code. Happens typically when I copy on cell phone from github to post. I doubt I can get them all out once posted and then tryng to edit.

minor thing in **configuration maximum values **most items have a better description for title except these

Products on Special
New Products Module
Upcoming Products

bn

bn17311:

small thing, enabling and disabling products

while browsing categories products you click on red / green button this is what its called

but when in product i think you could be confused into thinking you are switching product to out of stock or instock rather than enable / disable

unless there is a reason for this. if they do the same job call them the same

bn

If the product listings screen for the in-stock/out-of-stock message is changed, I believe it would also have to be changed on each of the product type data entry screens... In otherwords currently these sets of words match the other respective use/location areas.

stellarweb:

Anne - I am having a problem identifying why the buttons on the login page are being distorted.... see attached

Can you help me figure it out? I have looked in stylesheets as well as the tpl_login_default.php to see if there is coding in there that is magnifying them and I just can't find anything.

THANKS!

What is the link to the page?

Thanks,

Anne

mc12345678:

If the product listings screen for the in-stock/out-of-stock message is changed, I believe it would also have to be changed on each of the product type data entry screens... In otherwords currently these sets of words match the other respective use/location areas.

you lost me there ...

but when editing a product it says in stock or out of stock, but if you click either it enables or disables

if thats the way its meant to be thats ok, but for me i have plenty of products on my site out of stock but don't want them switched off

bn

picaflor-azul:

What is the link to the page?

Thanks,

Anne
Anne, I think that the issue appears whenever someone chooses to use image-buttons instead of CSS buttons on the responsive template.