[Closed] FEEDBACK ON BETA of v1.5.5

DrByte:

I know what you're referring to.
I added another dummy language so that the box would show, and it shows up just fine:

I'll admit, I did a "selective" (i.e. copying files) mini-upgrade from a previous download of 155 rather than go through the whole install process. I'll give the full process a go, but an puzzled as to why the difference exists.

DrByte:

I know what you're referring to.
I added another dummy language so that the box would show, and it shows up just fine:

I can confirm, I have the same issue as Lat9

DrByte:

Lol ... those came directly from the Edit Orders mod.

Will have to look at those separately.
The coloring comes from the default color values provided by both the CSS3 Buttons and CSS3 Admin Buttons plugins, not the EO plugin itself.

DrByte:

This should help with that: https://github.com/zencart/zencart/pull/847

Unfortunately security analysts would call it a flaw, not a feature.

Trying to find the balance ...
That change (at least) doesn't kill the overall styling. I can see how adding a <script> tag could be a-bad-thing, but basic styling like a <span>, <em>, <br> or <strong>? Really?

lat9:

That change (at least) doesn't kill the overall styling. I can see how adding a <script> tag could be a-bad-thing, but basic styling like a <span>, <em>, <br> or <strong>? Really?
It's not mangling the <span>. It was mangling the =" part (ie: in style=" ).

Anyway, you have the fix.

Install using demo products; Catalog->Products Expected date display issue. All dates display as 11/30/2036; the products_date_available values in the database are 0000-00-00 00:00:00.

lat9:

Install using demo products; Catalog->Products Expected date display issue. All dates display as 11/30/2036; the products_date_available values in the database are 0000-00-00 00:00:00.
What version of PHP and MySQL, and operating system on that server?

I haven't seen it mangle the dates to be zeros on any Ubuntu or Mac server, using PHP 5.2, 5.3, 5.4, 5.5, 5.6, or 7.0, or MySQL 5.5 or 5.6. And latest cPanel.

Need to know a lot more details about the specific server you encountered that on.

DrByte:

What version of PHP and MySQL, and operating system on that server?

I haven't seen it mangle the dates to be zeros on any Ubuntu or Mac server, using PHP 5.2, 5.3, 5.4, 5.5, 5.6, or 7.0, or MySQL 5.5 or 5.6. And latest cPanel.

Need to know a lot more details about the specific server you encountered that on.
It's an XAMPP installation (PHP 5.4.27, mySQL 5.5.36) running Windows 8.1. I'll retry the installation (from fresh) to see if it replicates. This installation started with the very first 1.5.5 beta and has been incrementally updated from there, so it's a bit suspect.

I can't replicate the Products Expected issue on a fresh install of the 155 branch contents downloaded a couple of minutes ago.

There is a small bug in /admin/includes/init_includes/init_errors.php

line 165 is php if (file_exists($check_path) && is__[/COLOR]writeable($check_path)) { and should be ```php
if (file_exists($check_path) && is_writeable($check_path)) {

ciao from Italy
enzo

There is a mistyping in the preceding message.
Below how it had to be.

enzo-ita:

There is a small bug in /admin/includes/init_includes/init_errors.php

line 165 is php if (file_exists($check_path) && is__writeable($check_path)) { and should be ```php
if (file_exists($check_path) && is_writeable($check_path)) {

> 
> ciao from Italy
> enzo

enzo-ita:

There is a mistyping in the preceding message.
Below how it had to be.

Also, the line number is off... On github this is currently line 52 not 165 for ZC 1.5.5.

Also there is a ZC function with that name in the filesystem so not necessarily an error.

mc12345678:

Also, the line number is off... On github this is currently line 52 not 165 for ZC 1.5.5.

Also there is a ZC function with that name in the filesystem so not necessarily an error.

Okay.. Sorry, I looked at several wrong versions of the file... Anyways, there is a function is__writeable that has been added at least to the admin side in includes/functions/general.php which means that the code should work. Not sure how/when line 165 existed to have that content (personally not going to search for that), but the current version does have the function (two underscores) as well as that usage in that file.

enzo-ita:

There is a small bug in /admin/includes/init_includes/init_errors.php

line 165 is php if (file_exists($check_path) && is__[/COLOR]writeable($check_path)) { and should be ```php
if (file_exists($check_path) && is_writeable($check_path)) {

> 
> ciao from Italy
> enzo
Thanks. Good eye to spot that. However, it is intentional.  
We might rename it to zen_is_writable in 2.0 or something, but for now the double-underscore is intentional.

Fresh new install on a Wamp server. localhost/morrisgiftshop/zc_install/index.php is this an upgrade or new install?

ERROR:
500

DrByte:

Thanks. Good eye to spot that. However, it is intentional.
We might rename it to zen_is_writable in 2.0 or something, but for now the double-underscore is intentional.
Well, it is not a matter of good eye. I do not remember what caused it and I can not reproduce this but I got an log file saying that a call was made to a non exsisting function is_writable and I found that that function was written is__writable.
Now you tell me that i__writable is intentional so I think I need to correct that back. Right?
Ciao from Italy
enzo

mc12345678:

Okay.. Sorry, I looked at several wrong versions of the file... Anyways, there is a function is__writeable that has been added at least to the admin side in includes/functions/general.php which means that the code should work. Not sure how/when line 165 existed to have that content (personally not going to search for that), but the current version does have the function (two underscores) as well as that usage in that file.

About the line number, I noticed that a weird problem happens to me. I use notepad++ for editing files. Some files when dwld with livezilla for editing gets added empty lines. If I delete the empty lines then the file becomes unusable. Probably I indicated line 165 becaus of that reason.
ciao from Italy

mtechama:

Fresh new install on a Wamp server. localhost/morrisgiftshop/zc_install/index.php is this an upgrade or new install?

ERROR:
500
A 500 error is often hard to track down, and typically means a security problem has happened on the server, or PHP has encountered a fatal error.
If it's a PHP problem, you may find it explained in the /logs/ folder. The logs for zc_install are named zcInstall_xxxxxxxxx.log and if they're reporting a PHP error, they're zcInstall-DEBUG-xxxxxx.log

lat9:

The language-changer in the header's upper-left corner. It's only visible when multiple languages are defined in the store/admin.
Found and fixed the CSS for this.

lat9:

I can't replicate the Products Expected issue on a fresh install of the 155 branch contents downloaded a couple of minutes ago.
Thanks for the update.