Some observations while doing the spanish language pack.
ADMIN
english.php
define('WARNING_SESSION_AUTO_START', 'Warning: session.auto_start is enabled - please disable this PHP feature in php.ini and restart the web server.');
Misleading. True I must restart my local server to apply php changes, but it's not necessary to restart my hosting's web server, nor can I do that.
Suggest
define('WARNING_SESSION_AUTO_START', 'Warning: session.auto_start is enabled - please disable this PHP feature in php.ini. It may be necessary to restart the web server to apply this change.');
admin_activity.php
- the "Interpretation of the log data" section is one paragraph with a child ul which is not valid html:
https://developers.whatwg.org/grouping-content.html#the-p-element
2)Nested ul missing closing li
<li><strong>WARNING</strong> is assigned to CRITICAL things such as removal of payment modules or deletion of admin users. These are activities which might suggest pending trouble if not caught quickly. These should be reviewed very frequently; recommended daily.</li>
</ul></li><!-- steve added /li-->
suggest
define('TEXT_INTERPRETING_LOG_DATA', '<p><strong>Interpretation of the log data</strong></p><ul>
<li><strong>Severity</strong> - The standards for logging generally describe severities as follows:<ul>
<li><strong>INFO</strong> refers to general activity. This may or may not contain remarkable details.</li>
<li><strong>NOTICE</strong> refers to activity which indicates higher privilege was used, and may include things like creating new admin users or adding new payment modules. It also highlights when any data submitted on the web page includes potentially risky content such as script tags or embedded iframes, where malicious content is being added to your products/categories/pages by unhappy employees or an intruder on your site. These should be reviewed regularly for any anomalies such as unauthorized activity.</li>
<li><strong>WARNING</strong> is assigned to CRITICAL things such as removal of payment modules or deletion of admin users. These are activities which might suggest pending trouble if not caught quickly. These should be reviewed very frequently; recommended daily.</li>
</ul></li>
<li><strong>admin_user</strong> - This will show the admin user ID number followed by their admin username. If not logged in, it will show 0.</li>
<li><strong>page_accessed</strong> - This will indicate the name of the page visited, thus giving hints to the kind of activity taking place.</li>
<li><strong>parameters</strong> - This is the rest of the URI of the page visited, and gives further indication of the kind of activity being attempted by the visitor.</li>
<li><strong>flagged</strong> - If this is set to 1, that indicates that you should inspect the content recorded in the "postdata" field for unauthorized entry of script or iframe or other potentially dangerous content. An explanation of suspicious content will be listed in the "attention" field.</li>
<li><strong>attention</strong> - This will contain suggestions related to the kind of suspicious activity which should be reviewed in the "postdata" field if flagged. </li>
<li><strong>logmessage</strong> - This contains any messages recorded by the system about the activity taking place, such as installation of a certain module.</li>
<li><strong>postdata</strong> - This contains the raw POST data (with some sensitive information scrubbed) for easy review in case malicious activity is suspected.</li>
</ul>');
attributes_controller.php
define('TABLE_TEXT_MAX_DAYS', 'Expiry days: (0 = unlimited)');
colon should be at end of text
define('TABLE_TEXT_MAX_DAYS', 'Expiry days (0 = unlimited):');
coupon_restrict.php
are these extra spaces necessary?
define('TEXT_INFO_ADD_DENY_ALL', '<strong>For Add all Category Products, only Products not already set for restrictions will be added.<br />
For Delete all Category Products, only Products that are specified Deny or Allow will be removed.</strong>');
modules.php
define('WARNING_MODULES_MISSING_KEYS', '<span class="alert">Missing keys - Save, Remove, Install and Reconfigure</span>');
I assume this means database entries are missing. "Save" would be pointless/misleading as "Remove" will remove whatever has been saved.
Suggest "Note down any configuration values and Remove, Install and reconfigure the module.".
email
email_template_coupon.html
email_template_direct_email.html
email_template_gv_mail.html
email_template_gv_queue.html
email_template_newsletters.html
email_template_order_status.html
email_template_product_notification.html
have hard-coded "Dear" in the templates
CATALOG
includes\languages\english\responsive_classic\button_names.php
missing new constant
define('BUTTON_VIEW_ALL_ALT', 'View All');
\includes\languages\english\shopping_cart.php
define('TEXT_INFORMATION', 'You may proceed with your purchase by clicking the Checkout button below. Shipping and Taxes and Discounts will be handled on subsequent pages.');
Suggest
define('TEXT_INFORMATION', 'You may proceed with your purchase by clicking the "' . BUTTON_CHECKOUT_ALT . '" button below. Shipping and Taxes and Discounts will be handled on subsequent pages.');
