One-Page Checkout [Support Thread]

DivaVocals:

Figured out the mistake..I want to move the country field up.. Not having good luck figuring out how to do that.. :(

Wow, welcome back! :P

/includes/templates/template_default/tpl_modules_opc_address_block.php

rbarbour:

Wow, welcome back! :P

/includes/templates/template_default/tpl_modules_opc_address_block.php
Amen to that welcome back!

Hello,

I am unable to change and save an address on the checkout page being a full registered customer, guest checkout is off and I am logged in before checkout page.

I am using a Fresh install of zencart 1.55f with the responsive class template and opc 2.0.1. No changes have been made to either the zen install or opc mod. PHP 7.0.27 MySQL 5.5.5. Tested in Chrome and Firefox.

Changing the street address line, the Add to Address Book checkbox and the cancel and save changes buttons appear. Checking the add to address book and clicking save, the page reloads and the changes are not saved in either the address book or here on this checkout page.

Not saving it to the address book works and it reloads correctly with the change.

@getaped, I'm pretty sure that that issue was corrected in either v2.0.2 or v2.0.3 (now available from the plugins' download).

lat9:

@getaped, I'm pretty sure that that issue was corrected in either v2.0.2 or v2.0.3 (now available from the plugins' download).

Ok, I've upgraded to 2.0.3 and it still does not work.

@getaped, I'm unable to reproduce your issue running OPC 2.0.3 on zc1.5.5f on PHP 7.1.4.

I logged in as a full-up registered user, changed the billing address, ticked "Save to Address Book" and the "Save" button. That address was recorded for the order and saved in the address-book.

I then changed the shipping address (in the same manner) and that updated shipping address was now associated with the order and saved in the address-book.

You should check to see that all the OPC classes (in /includes/classes, /includes/classes/ajax and /includes/classes/observers) are at the v2.0.3 version. Also verify that any template-override versions of the OPC's templates (they're distributed in the /includes/templates/template_default directory) have also been updated.

lat9:

@getaped, I'm unable to reproduce your issue running OPC 2.0.3 on zc1.5.5f on PHP 7.1.4.

I logged in as a full-up registered user, changed the billing address, ticked "Save to Address Book" and the "Save" button. That address was recorded for the order and saved in the address-book.

I then changed the shipping address (in the same manner) and that updated shipping address was now associated with the order and saved in the address-book.

You should check to see that all the OPC classes (in /includes/classes, /includes/classes/ajax and /includes/classes/observers) are at the v2.0.3 version. Also verify that any template-override versions of the OPC's templates (they're distributed in the /includes/templates/template_default directory) have also been updated.

Hello,

Yes, everything is new. This is the 3th fresh install I have done and it does not work. They are fresh downloads and installs of zen and opc. No plugins added except opc and whatever defaults with zencart.

• downloaded and installed zencart 1.5.5f with demo data
• created a customer account
• changed 5 template names and admin name on opc install and installed it
• enabled opc
• test order by adding apt 100 in the address line 2 box, clicked add to address box and saved. failed to save, no error message.

You can see the apt 100 in the suburb field, but it doesn't get validated and saved.

2018-06-27 12:54:18 OnePageCheckout: validateAndSaveAJaxPostedAddress(bill, ..), POST: array (
  'securityToken' => 'cb75bcdd6657ee466c50d716852e54e2',
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => 'apt 100',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
  'shipping_billing' => 'true',
  'add_address' => 'true',
)
2018-06-27 12:54:18 OnePageCheckout: Start validateUpdatedAddress, which = bill:array (
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => 'apt 100',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
)
2018-06-27 12:54:18 OnePageCheckout: Exiting validateUpdatedAddress.array (
)array (
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => '',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
  'country' => '223',
  'zone_id' => '31',
  'zone_name' => 'Maryland',
  'error_state_input' => false,
  'country_has_zones' => true,
  'show_pulldown_states' => false,
  'error' => false,
  'validated' => true,
  'selected_country' => '223',
  'state_field_label' => 'State/Province:',
)
2018-06-27 12:54:18 OnePageCheckout: saveCustomerAddress(bill, 1), shipping=billing array (
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => '',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
  'country' => '223',
  'zone_id' => '31',
  'zone_name' => 'Maryland',
  'error_state_input' => false,
  'country_has_zones' => true,
  'show_pulldown_states' => false,
  'error' => false,
  'validated' => true,
  'selected_country' => '223',
  'state_field_label' => 'State/Province:',
)
2018-06-27 12:54:18 OnePageCheckout: findAddressBookEntry, returning (2) for 'testuser123mainstreetanytown20772'array (
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => '',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
  'country' => '223',
  'zone_id' => '31',
  'zone_name' => 'Maryland',
  'error_state_input' => false,
  'country_has_zones' => true,
  'show_pulldown_states' => false,
  'error' => false,
  'validated' => true,
  'selected_country' => '223',
  'state_field_label' => 'State/Province:',
)
2018-06-27 12:54:18 index: validateAddressValues, returning:array (
  'status' => 'ok',
  'errorMessage' => '',
  'messages' => 
  array (
  ),
)OnePageCheckout::__set_state(array(
   'isGuestCheckoutEnabled' => false,
   'registeredAccounts' => false,
   'guestIsActive' => false,
   'isEnabled' => true,
   'tempAddressValues' => 
  array (
    'ship' => 
    array (
      'gender' => '',
      'company' => '',
      'firstname' => '',
      'lastname' => '',
      'street_address' => '',
      'suburb' => '',
      'city' => '',
      'postcode' => '',
      'state' => 'Maryland',
      'country' => 223,
      'zone_id' => 31,
      'zone_name' => 'Maryland',
      'address_book_id' => 0,
      'selected_country' => 223,
      'country_has_zones' => true,
      'state_field_label' => 'State/Province:',
      'show_pulldown_states' => false,
      'error' => false,
      'error_state_input' => false,
      'validated' => false,
    ),
    'bill' => 
    array (
      'gender' => '',
      'company' => '',
      'firstname' => '',
      'lastname' => '',
      'street_address' => '',
      'suburb' => '',
      'city' => '',
      'postcode' => '',
      'state' => 'Maryland',
      'country' => 223,
      'zone_id' => 31,
      'zone_name' => 'Maryland',
      'address_book_id' => 0,
      'selected_country' => 223,
      'country_has_zones' => true,
      'state_field_label' => 'State/Province:',
      'show_pulldown_states' => false,
      'error' => false,
      'error_state_input' => false,
      'validated' => false,
    ),
  ),
   'guestCustomerInfo' => NULL,
   'guestCustomerId' => 3,
   'tempBilltoAddressBookId' => 3,
   'tempSendtoAddressBookId' => 4,
   'dbStringType' => 'stringIgnoreNull',
   'customerInfoOk' => NULL,
   'billtoTempAddrOk' => true,
   'sendtoTempAddrOk' => NULL,
   'isVirtualOrder' => false,
   'billtoAddressChangeable' => true,
   'shiptoAddressChangeable' => NULL,
   'sendtoAddressChangeable' => true,
))
2018-06-27 12:54:18 checkout_one: CHECKOUT_ONE_ENTRY, version (2.0.3 (2018-06-21)), Zen Cart version (1.5.5f), template (responsive_classic)
2018-06-27 12:54:18 OnePageCheckout: startGuestOnePageCheckout, exit: sendto: 2, billto: 2OnePageCheckout::__set_state(array(
   'isGuestCheckoutEnabled' => false,
   'registeredAccounts' => false,
   'guestIsActive' => false,
   'isEnabled' => true,
   'tempAddressValues' => 
  array (
    'ship' => 
    array (
      'gender' => '',
      'company' => '',
      'firstname' => '',
      'lastname' => '',
      'street_address' => '',
      'suburb' => '',
      'city' => '',
      'postcode' => '',
      'state' => 'Maryland',
      'country' => 223,
      'zone_id' => 31,
      'zone_name' => 'Maryland',
      'address_book_id' => 0,
      'selected_country' => 223,
      'country_has_zones' => true,
      'state_field_label' => 'State/Province:',
      'show_pulldown_states' => false,
      'error' => false,
      'error_state_input' => false,
      'validated' => false,
    ),
    'bill' => 
    array (
      'gender' => '',
      'company' => '',
      'firstname' => '',
      'lastname' => '',
      'street_address' => '',
      'suburb' => '',
      'city' => '',
      'postcode' => '',
      'state' => 'Maryland',
      'country' => 223,
      'zone_id' => 31,
      'zone_name' => 'Maryland',
      'address_book_id' => 0,
      'selected_country' => 223,
      'country_has_zones' => true,
      'state_field_label' => 'State/Province:',
      'show_pulldown_states' => false,
      'error' => false,
      'error_state_input' => false,
      'validated' => false,
    ),
  ),
   'guestCustomerInfo' => NULL,
   'guestCustomerId' => 3,
   'tempBilltoAddressBookId' => 3,
   'tempSendtoAddressBookId' => 4,
   'dbStringType' => 'stringIgnoreNull',
   'customerInfoOk' => NULL,
   'billtoTempAddrOk' => true,
   'sendtoTempAddrOk' => NULL,
   'isVirtualOrder' => false,
   'billtoAddressChangeable' => true,
   'shiptoAddressChangeable' => NULL,
   'sendtoAddressChangeable' => true,
))

Ah, that's a different issue than a general "address not saving". I've replicated the issue where the suburb is not being kept and have created a GitHub issue (https://github.com/lat9/one_page_checkout/issues/143) to track the associated changes.

lat9:

Ah, that's a different issue than a general "address not saving". I've replicated the issue where the suburb is not being kept and have created a GitHub issue (https://github.com/lat9/one_page_checkout/issues/143) to track the associated changes.
I've got that corrected on GitHub, with an update to /includes/classes/OnePageCheckout.php's *validateUpdatedAddress *method. Find the following code fragment within that method:

        $street_address = zen_db_prepare_input($address_values['street_address']);
        if (strlen($street_address) < ENTRY_STREET_ADDRESS_MIN_LENGTH) {
            $error = true;
            $messages['street_address'] = $message_prefix . ENTRY_STREET_ADDRESS_ERROR;
        }
        
        $city = zen_db_prepare_input($address_values['city']);
        if (strlen($city) < ENTRY_CITY_MIN_LENGTH) {
            $error = true;
            $messages['city'] = $message_prefix . ENTRY_CITY_ERROR;
        }

and insert the highlighted section to provide the correction:

        $street_address = zen_db_prepare_input($address_values['street_address']);
        if (strlen($street_address) < ENTRY_STREET_ADDRESS_MIN_LENGTH) {
            $error = true;
            $messages['street_address'] = $message_prefix . ENTRY_STREET_ADDRESS_ERROR;
        }
[B]        
        if (ACCOUNT_SUBURB == 'true') {
            $suburb = zen_db_prepare_input($_POST['suburb']);
        }
        [/B]
        $city = zen_db_prepare_input($address_values['city']);
        if (strlen($city) < ENTRY_CITY_MIN_LENGTH) {
            $error = true;
            $messages['city'] = $message_prefix . ENTRY_CITY_ERROR;
        }

lat9:

I've got that corrected on GitHub, with an update to /includes/classes/OnePageCheckout.php's *validateUpdatedAddress *method. Find the following code fragment within that method:

......

Great, that worked. The company name field also needs to be fixed.

getaped:

Great, that worked. The company name field also needs to be fixed.
:oops: I'll get that corrected next ...

So I recently changed Internet gateways, and figured out that this plugin doesn't work.

First, we weren't getting ANY error, it was just refreshing the page.

Then we updated we started getting the invalid card error which we see was an error going back to late last year.

This was an issue in both test & live mode & even with my own credit card.

So we had to disable it :( & then the transaction worked.

rapidfinancia1:

So I recently changed Internet gateways, and figured out that this plugin doesn't work.

First, we weren't getting ANY error, it was just refreshing the page.

Then we updated we started getting the invalid card error which we see was an error going back to late last year.

This was an issue in both test & live mode & even with my own credit card.

So we had to disable it :( & then the transaction worked.
I'm sorry to hear that something in your configuration didn't work, but you haven't given me enough information to understand what the root-cause of your issue is.

When you say you "changed Internet gateways", I'm assuming that this is for your payment method (which you don't mention). What payment method are you using? What "Internet gateway"? What shipping modules?

lat9:

:oops: I'll get that corrected next ...
I've got the update to correctly gather/store any company entry in the addresses available on GitHub. There are three added sections (see this commit for details) that are required for this process correction. It'll be part of the forth-coming v2.0.4 release.

lat9:

I'm sorry to hear that something in your configuration didn't work, but you haven't given me enough information to understand what the root-cause of your issue is.

When you say you "changed Internet gateways", I'm assuming that this is for your payment method (which you don't mention). What payment method are you using? What "Internet gateway"? What shipping modules?

Hi,

The procesor doesn't matter as it has nothing to do with this plugin.

The gateway is NMI. I'm sorry that I assumed people know what an Internet gateway is. :)

The shipping modules are:

FedEx (fedexwebservices) and "FREE SHIPPING!" (freeshipper).

Thanks a ton

Is that NMI gateway used by the authorize.net payment method?

lat9:

Amen to that welcome back!
rbarbour:

Wow, welcome back! :p

/includes/templates/template_default/tpl_modules_opc_address_block.php
hahaha. Yeah it's been a LOOOOONG time no see for me. I miss hanging out here.. :) I got a job with an AMAZING org as a technical project manager for a mobile app project that SAVES LIVES. (Look up Guardian Connect - Android & iOS) That gig and the ones that followed required me to sorta step back on some of my side ventures. I've retained my long time clients, but had to stop accepting new work.. While I'd like to think I'm every woman, apparently I'm not!! lol

Anyway.. @rbarbour I did indeed edit that file, but the entire country field disappeared. So I'm sure my editing is off.. What I want to do is to move the country field just below the name fields. I want the country placed before entering the address as some of the state/regional fields are dependent on the country selection. Our usability testers are asking suggesting we make this change. HELP por favor?? :)

DivaVocals:

hahaha. Yeah it's been a LOOOOONG time no see for me. I miss hanging out here.. :) I got a job with an AMAZING org as a technical project manager for a mobile app project that SAVES LIVES. (Look up Guardian Connect - Android & iOS) That gig and the ones that followed required me to sorta step back on some of my side ventures. I've retained my long time clients, but had to stop accepting new work.. While I'd like to think I'm every woman, apparently I'm not!! lol

Anyway.. @rbarbour I did indeed edit that file, but the entire country field disappeared. So I'm sure my editing is off.. What I want to do is to move the country field just below the name fields. I want the country placed before entering the address as some of the state/regional fields are dependent on the country selection. Our usability testers are asking suggesting we make this change. HELP por favor?? :)

Crystal,

I hope doing all that work for for Android & iOS apps hasn't blurred your memory that much. :laugh:, I'm glad you are doing well! I still have that $200 bottle of Vodka and visiting Vegas in Oct. :D

anywhoooooo, my lines may be off here and look different but here goes.

line 98, find:

$field_name = "zone_country_id[$which]";
$field_id = "country-$which";
?>
      <label class="inputLabel" for="country-bill"><?php echo ENTRY_COUNTRY; ?><?php if (zen_not_null(ENTRY_COUNTRY_TEXT)) echo '<span class="alert">' . ENTRY_COUNTRY_TEXT . '</span>';?></label>
      <?php echo zen_get_country_list($field_name, $address['country'], "id=\"$field_id\""); ?>
      <div class="p-2"></div>

copy and replace with:

?>

paste the copied php on line 64, after

ENTRY_COMPANY_MIN_LENGTH, ENTRY_COMPANY_TEXT);
}

then add:

   <?php 

directly afer so the pasted code looks like:

$field_name = "zone_country_id[$which]";
$field_id = "country-$which";
?>
      <label class="inputLabel" for="country-bill"><?php echo ENTRY_COUNTRY; ?><?php if (zen_not_null(ENTRY_COUNTRY_TEXT)) echo '<span class="alert">' . ENTRY_COUNTRY_TEXT . '</span>';?></label>
      <?php echo zen_get_country_list($field_name, $address['country'], "id=\"$field_id\""); ?>
      <div class="p-2"></div>
      
   <?php 

Hope that helps!!!

Hello Cindy - doing a total site rebuild on a new fresh install version 1.5.5f - OPC version 2.0.1 - site is https://www.treeoflifejewellery.com.au/testsite/ which has PayPal express checkout and PayPal Pro activated - Guest Checkout is enabled as 'true' -

as a Guest (not logged in) at checkout OPC worked fine when selecting method of payment as PayPal (did a transaction through to completion/confirm order and it went through OK) - however selecting credit card I am getting the following pop up dialogue box message;

Please make the following corrections:

* The credit card number must be at least 10 characters.
* The 3 or 4 digit CVV number must be entered from the back of the credit card.

the credit card is a Visa so has the required number of characters - seems to me that it is not recognizing that characters are being added to the respective lines even though they appear OK when typed in. I have tried a few times with the same result.(after cache cleared and system reboot)

myDEBUG has about 4400+ lines and contains personal data so I won't post it in here - I didn't see any references to 'errors' in it though, but I'm not sure what I would be looking at anyway. I cannot confirm that it works on the original site as it is version 1.5.1 and I don't have OPC working on it.

I am not sure what other information I can offer at present - if you need more information please ask.

cheers,
Mike

Mike, make sure that you're using OPC v2.0.3 (a couple of important bugfixes since 2.0.1) ... but there hasn't been change since v2.0.1 that would have bearing on your issue.

I'll send you a PM with my direct email address so you can send over that OPC debug information.

Update: Your PM inbox is full ...