Tabbed Products ''LITE'' version - Delimiter based

bhuntsman:

As for the Add to Cart box appearing both above and below tabs...I did that intentionally.
I can see the advantages of that. Just an idea, if product descriptions are to appear on a tab you might want to put the bottom Add to Cart box on the tab under the lengthy descriptions.

bhuntsman:

The title cap for x-sell tab shows the title text wrapping to second line...again, this was intentional
Sorry I wasn't clear... was not referring to the titles ON the actual tabs, I was referring to the title bar headings within the tab containers. e.g. the "We Also Recommend" container title bar (which is included in the Future Zen template). Looks like you already adjusted by changing the define to "Related Products" or by shortening the text and adding an ellipsis to end of define. So all is well with that now.

Look forward to hearing the solutions you implemented to solve your previously reported issues.

Woodymon:

It is my experience you have to insert a minimum of one tag in your product description for the "globals" to work (or for instance, to make the x-sell items display in the "We Also Recommend" tab and not below the tabs as you are experincing.

The mod works great but some logic issues remain with default globals and requiring one soft tag (as I reported recently).

I do not understand the reasoning (logic) behind this requirement but suspecting there is some good reason that qhome configured the mod to behave this way ;-)

Woody

ideasgirl:

In my experience this is only need for the image setting. They all will appear automatically if you have any thing to show.

What ideasgirl says should be the way it works.. at least thats how it was designed and appears to work on my demo examples.

I'm back from my vacation now and I've only read this one page so maybe there is more I missed. I will try to read more of what I missed tomorrow.. im tired after a long day of travelling and going to bed for now :)

Here's my situation:

Running Zen Cart 1.3.0.2 with latest version of Tabbed Lite and X-sell installed.

Below are Tabbed Lite Settings in tpl_product_info_display.php

$bGblMainImageOnTabs = true;
$bGblAddToCart = true;
$bGblAdditionalImages = true;
$bGblCustomersAlsoPurchased = true;

$bCrossSell_Exists = true;
$bGblCrossSell_Tab = true;

$bShowHeaders = true;
$bShowHeadersNoJavascript = true;

$addtocart_tab_name = 'Add to Cart';
$add_images_tab_name = 'Additional Images';
$cust_also_purchased_tab_name = 'Customers Also Purchased';
$cross_sell_tab_name = 'We Also Recommend';
For the results below I have only generic text in Products Description. No tags.

RESULT: The Main Image renders above the tabs. (this would be expected based on your note "adds Main image to tabs only if you have at least one custom tab", but I don't understand the logic of why with global on, the image does not appear on tab instead of above the tab).

RESULT: Cross sell tab containing "We Also Recommend" text within tab is displayed but no "container" for the tab is rendered (just a horzonatal line where the top of the container should be). And then of course no cross sell items render on the product info page.

However if I change $bGblCrossSell_Tab = false;
then the Xsell items appear below tabs on the product info page as expected (by default).

Later I will post some observations of unexpected strangeness when the tag <!--%Product Description%--> is inserted at beginning of "products Description" and I then change some of the above settings in tpl_product_info_display.php

Woodymon:

For the results below I have only generic text in Products Description. No tags.

RESULT: The Main Image renders above the tabs. (this would be expected based on your note "adds Main image to tabs only if you have at least one custom tab", but I don't understand the logic of why with global on, the image does not appear on tab instead of above the tab).

This is because I haven't yet added the "$GblProdDescAsTab" feature yet. Remember I was working on it and had it almost working but there was some tough logic to work out and there were other issues I wanted to work out first. It is at the bottom of the readme in the ToDo list. When that is implemented, then it will also have that option to have the image on the tab instead of above the tab so I can see if I can see any problems.

Woodymon:

RESULT: Cross sell tab containing "We Also Recommend" text within tab is displayed but no "container" for the tab is rendered (just a horzonatal line where the top of the container should be). And then of course no cross sell items render on the product info page.

However if I change $bGblCrossSell_Tab = false;
then the Xsell items appear below tabs on the product info page as expected (by default).

This was something I remember seeing as well and was fixed in 3.1 final. I haven't tested tabbed lite with 1.3.0.2 yet tho, I will be upgrading this week. Still.. I dont think a simple sql query should cause this problem. You are sure you have the latest version of Tabbed Lite? And you uploaded the jscript, and tpl files? Do any of your image files begin with numbers?... and finally.. could you send your modified tpl file to the email in the readme file. Or at least do a 'view source' on your browser on that page and copy/paste it for me and send to my email.

bhuntsman:

Finally, after 3 long days of frustration, hair pulling, etc., my site's product page layout not only looks the way I want it to, but all the tabs also work. Here's an example page http://www.learningbydvd.com/newstore/index.php?main_page=product_info&products_id=918. I would appreciate any comments, feedback or criticism.

And to everyone who contributed their thoughts and suggestions, I give you my thanks. Take care everyone. Long live ZenCart!!!

can you share what fixed the tabs for you? this seems to be a similar problem that woody is seeing with having the cross sell tab showing the tab but no products underneath.

Also after reading back a few pages it looks like I've confused a few things with not adding the Global Products Description.. i will work on that this week.. I think most of the current code is decently stable, just a few anomalies that seem to be working themselves out. So I will build the GblProdDesc on this latest version.

IntelCos:

Few issues I've noticed...

One was that if you created a product but do not use tabs yet globals set on a java error is generated. Once you inset at least one tab, then the java error is gone.

Be sure to upload the latest jscript file in 3.11 too. That should fix it.

IntelCos:

Second, trying to set the borders to use images and cannot seem to get this to work.

example border-top-image:url(../images/bordertop.gif); which is standard css entry and fails to show the image. Yet if I set the border to a pixel def only a border works. I tried to set the border as well to "wave" to see and that fails as well. Dots or solid lines work...So not sure whats up there either or what I'm doing wrong???
border-top-image and especially wavy and dots IIRC is slated for CSS3 ... CSS2.x is the current standard and CSS3 hasn't been released yet. see more here: http://www.w3.org/TR/2002/WD-css3-border-20021107/ (correct me if I'm wrong tho, I just remember having this problem a few month back when I tried it for another site of mine)

haven't tested tabbed lite with 1.3.0.2 yet tho
I'm running 1.3.0.2 and is working perfectly.

qhome:

This is because I haven't yet added the "$GblProdDescAsTab" feature yet. Remember I was working on it and had it almost working but there was some tough logic to work out and there were other issues I wanted to work out first. It is at the bottom of the readme in the ToDo list. When that is implemented, then it will also have that option to have the image on the tab instead of above the tab so I can see if I can see any problems.
Apologies Q. I missed that info. Thanks for the reminder.

qhome:

This was something I remember seeing as well and was fixed in 3.1 final.
What's strange is the xsell items were displaying on the tabs fine before the last Tabbed Lite upgrade (I've been testing on ZC 1302 all along.

qhome:

I haven't tested tabbed lite with 1.3.0.2 yet tho, I will be upgrading this week. Still.. I dont think a simple sql query should cause this problem. You are sure you have the latest version of Tabbed Lite? And you uploaded the jscript, and tpl files?
Yes. And I reuploaded all files and did compares just in case.

qhome:

Do any of your image files begin with numbers?...
Yes. Both test product image filenames begin with a numeric. Was not aware of this as an issue.

qhome:

could you send your modified tpl file to the email in the readme file. Or at least do a 'view source' on your browser on that page and copy/paste it for me and send to my email.
I'll change my product image filenames first, and see if that helps.

Can you point me to a document/resource that explains not to use numerics at the beginning of image filenames? I read the docs diligently before requesting support and posting my issues. That particular guideline slipped by me somehow. Does it apply to Zen Cart in general or just when using the Tabbed Lite mod (I've been using numbers at beginning of product images filenames for some time now without issues).

P.S. I have ImageHandler2 installed if that makes any diff.

Thanks for the follow-up!

Woody

Woodymon:

Yes. Both test product image filenames begin with a numeric. Was not aware of this as an issue.
I'll change my product image filenames first, and see if that helps.

Can you point me to a document/resource that explains not to use numerics at the beginning of image filenames? I read the docs diligently before requesting support and posting my issues. That particular guideline slipped by me somehow. Does it apply to Zen Cart in general or just when using the Tabbed Lite mod (I've been using numbers at beginning of product images filenames for some time now without issues).

P.S. I have ImageHandler2 installed if that makes any diff.

Thanks for the follow-up!

Woody

Well I didnt know about this either until when i was trying to set up my demo site and started naming files like this:

1.jpg
1_1.jpg
2.jpg
2_1.jpg
.
.
.
11.jpg

in this case, it would show 2.jpg and 2_1.jpg for product 2 properly,

but 1.jpg, 1_1.jpg, 11.jpg and 2_1.jpg for product 1. Or something hokey like that. I was doin some indepth variable echoing to see what zc saw and its basically just confusing the zc additional images code up when the file name is only a number. I think it should be fine as long as there is at least one letter or word in the name after the number. But if you had the files working with numbers in your filename in the previous version then it's probably not a problem.

Have you tried getting Xsell to work before modifying any files first just to see if it works? Ill rescan the code again. I am trying to remember back to when I was seeing this problem. I can't remember what the solution was but it took me nearly half a day to figure it out... so I'll see if I can remember.

Try using words for image names and words in the model number just to see if that does anything for you. I seem to recall that being related however I can't remember if that was it or not.

I'm just trying the process of elimination but so far it seems to work for me both ways.

Good News!!

I must have slept well last night.. Fighting with this Global Product Description Tab had initially been a logic nightmare the last time I tried it, and then again most of last night. Finally this morning my brain opened up! Instead of trying to fake the tab, and having to add more logic checks and chase variables all over the place and make a whole new coding abortion, I simply made a few line change and it works perfectly!

Instead of me forcing the data to be a hardcoded tab, I simply prefix a variable I set the product description to with the global product description tags on the fly and let the existing code work as normal. If only my genius moments weren't so brief and occured more often :P

Anyways, There was very little to change after I started over from scratch so I will drop the beta version here for you guys to test and since it was so simple I even included a simple 4-step guide to let you make the changes easily to your current modified version of 3.11 so you don't have to make heavy modifications to a whole new file.

Also, the code is smart enough to check if you already have a custom Product Description tab, it will not auto-create another one, it will just load that one as normal. Remember my code is genius :P

Give it a whirl!

Ok one guinea pig stepping right up :)
I followed your steps in your readme and got the following... see subtle screenshot :wink2:
I left the relevant part in English for the screenshot for you Q as I guess your Japanese isnt great.
I was wondering if its poss to put a line feed in under the title in the cross sell tab so its the same as the also purchased module, ive been staring at that part of the code and its the same as the other tabs... I dont get it :blink:

edited to say, I removed the <br> in the tab name and its now fine....
Answers on a postcard....

Reesy:

Ok one guinea pig stepping right up :)
I followed your steps in your readme and got the following... see subtle screenshot :wink2:
I left the relevant part in English for the screenshot for you Q as I guess your Japanese isnt great.

heh yea its a tough call for me to decide how I should leave the defaults. Even tho most people I've seen tend to use the non-wrapped style, I tend to like all my tabs on one line and IMO it looks neater that way if you have a lot of tabs so I tend to default to including the word wrap. But Im glad it is easy enough to figure out. I had toyed with the idea of making it a language file for all of them.. but then thats more files to maintain and more for you guys to edit if needed. So Im still on the fence about that.

Reesy:

I was wondering if its poss to put a line feed in under the title in the cross sell tab so its the same as the also purchased module, ive been staring at that part of the code and its the same as the other tabs... I dont get it :blink:

Ah yes, I was wondering if anyone else was going to notice this. This is actually a Cross Sell issue, unrelated to the tabs. You can open up templates_default/templates/tpl_modules_also_purchased_products.php and compare it to templates_default/templates/tpl_modules_xsell_products.php

The Xsell module adds the header name to the template file, the customers also purchased module adds it from modules/also_purchased_products.php. Perhaps because the require is outside of the template load in the also purchased products, but inside the template loading of the xsell module.. You might be able to add <br /> tags after the </h2> tag in the xsell module to get it to look the same. or move the Cross sell header name to the modules file to be more like the rest.

@Reesy, just to try it, I moved the title tag to the xsell module file to make it look more like the also purchased module, but had no luck, it just removed the title all together. So instead I added the <br /> under the </h2> tag in the xsell template file and it worked fine there. Its a hack, but it looks fine when rendered.

Hi Q!
Kewl, that hack works fine. Thanks for helping out there.
In the screenshot above you will notice that when the tab name was on 2 lines it didnt render correctly and there was a small gap under the tab. ie the tabs were not all sitting on the same line.
I made a language file for mine, as its only 1 tiny extra file.
:smile:

Also, the code is smart enough to check if you already have a custom Product Description tab, it will not auto-create another one, it will just load that one as normal. Remember my code is genius
Sure it is. :smartass: Works perfectly.

Reesy:

Hi Q!
Kewl, that hack works fine. Thanks for helping out there.
Good to hear :)

ideasgirl:

Sure it is. :smartass: Works perfectly.
:)

Well no bug reports so far :) Looks like its good for release. I'll add it to the Downloads area.

So here's some ideas that have been going through my head. The use of AJAX to pull tab data on the fly, instead of loading it all at page load.

The idea would be to have things like Additional Images, Customers Also Purchased, and Cross Sell tab data. Also.. for new tabs planned like the Reviews, Ask a Question, and Tell a friend forms right inside the tabs instead of a link to the form also might be good candidates for AJAX style instead of loading it all at once.

Any thoughts?

I know I also said I'd look into porting it across to the other product types like music and freeshipping. I was waiting for all the ideas and bugs to be worked out of this version first before doing that. So it's still in the plans.

I know I also said I'd look into porting it across to the other product types like music and freeshipping.
I did the freeshipping type, if you want to add it to your files, let me know.

kelvyn:

I just noticed css right column weirdness in IE 6. I use Firefox and hadn't noticed this until a customer told me:
http://www.bowak.co.uk/jangro/jangro-hydromist-compact-carpet-extractor-p-2113.html
Fine in firefox, broken in IE.

Any ideas? Thanks!

Hmm.. not sure. I dont see that on any of my sites using tabs. Have you made any modifications to the code or css? Also I would recommend removing the <br /> tags in the "We Also Recommend" in the template file so its all on one line to match your other custom tabs.