DivaVocals:
So I am back with more issue regarding product images and product reviews.. I think the issue I reported previously regarding the images and reviews may not be related to TPP at all.. I think the issues with having reviews on the tabs in TPP is caused because of an overall issue with how Colorbox (and Zen Lightbox) display/deal with reviews and product images together in general.
I reported this new find in the Zen Lightbox thread, but I'm reporting here too since I am seeing the SAME issue with both Colorbox and Zen Lightbox.
Not sure why, but the Lightbox and Colorbox add-ons are generating some weird/invalid HTML on the product reviews pages. You will see the model number appear in what appears to be some weird link to the left of the product image. Using Zen Lightbox, you can see what I am speaking of on this page:
http://clientlaserdiscvault**(dot)overthehillweb(dot)**com/index.php?main_page=product_reviews&products_id=8909
I found the EXACT same issue with the beta version of the Colorbox add-on as well. You can see the same issue using the Colorbox add-on on this page:
http://clienthairisle**(dot)overthehillweb(dot)**com/Hair-Extensions/Economy-Collection/Economy-Unprocessed/Indian-Remy-Micro-Thin-Machine-Weft-Virgin-Curly-Texture-3-Oz/reviews?number_of_uploads=0&
This weird link goes away when I turn off Lightbox or Colorbox.
Without Lightbox turned on this is the HTML created:
<div id="productReviewsDefaultProductImage" class="centeredContent back">
<div id="productMainImage" class="centeredContent back">
<script language="javascript" type="text/javascript">
<!-- document.write('<a href="javascript:popupWindow(\'http://myclient.com/index.php?main_page=popup_image&pID=8909\')"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " width="349" height="350" />
<br /><span class="imgLink">larger image</span></a>'); //-->
</script>
<noscript>
<a href="http://myclient.com/index.php?main_page=popup_image&pID=8909" target="_blank"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " width="349" height="350" /><br /><span class="imgLink">larger image</span></a>
</noscript>
</div></div>
```
>
> With Lightbox turned off this is the HTML created (note the mis-behaving HTML created is in red):
> ```
<div id="productReviewsDefaultProductImage" class="centeredContent back">
<div id="productMainImage" class="centeredContent back">
<script language="javascript" type="text/javascript">
<!-- document.write('<a href="images/dasPic_24141.jpg" rel="lightbox-g" title="National Geographic - Secrets of the Titanic<br /><span class=\"smallText\">[G52000]</span>"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " width="349" height="350" /><br /><span class="imgLink">larger image</span></a>'); //-->
</script>
[B]
<a href="images/dasPic_24141.jpg" rel="lightbox-g" title="National Geographic - Secrets of the Titanic<br /><span class=" smalltext"="">[G52000]"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " height="350" width="349"><br><span class="imgLink">larger image</span></a> [/B]
<noscript>
<a href="http://myclient.com/index.php?main_page=popup_image&pID=8909" target="_blank"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " width="349" height="350" /><br /><span class="imgLink">larger image</span></a>
</noscript>
</div></div>
```
>
> Using either Colorbox or Zen Lightbox, the issue goes away when I turn off these add-ons. It seems clear that there is something with how both of these add-ons deal with product images and reviews that goes awry.
>
> Any thoughts??
Found a better solution to this issue than what I posted previously..
Issue:
If you have both Tabbed Products Pro, and Zen Lightbox installed AND your products have model numbers defined, the problem outlined above will manifest itself.
To fix this in the includes/modules/pages/product_reviews/header_php.php file replace this:
if (zen_not_null($review->fields['products_model'])) {
$products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields['products_model'] . ']</span>';
} else {
$products_name = $review->fields['products_name'];
}
with this:
if (TPP_GLOBAL_ENABLE_TABS == '1') {
if (zen_not_null($review->fields['products_model'])) {
$products_name = $review->fields['products_name'];
}
} else {
if (zen_not_null($review->fields['products_model'])) {
$products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields['products_model'] . ']</span>';
} else {
$products_name = $review->fields['products_name'];
}
}
**What this change does:
**If you have Tabbed Products Pro and Zen Lightbox installed, the model number field will NOT display on the product reviews page.
I realize this is pretty much a bandaid solution, but coming up with a solution that allows the product model field to display when both TPP and Zen Lightbox are installed and active is over my paygrade to execute. I don't know if the issue is in the TPP code, or the ZenLight box code or if a change needs to be made in both. Again, someone smarter than me will need to figure this out. So I am sharing a down and dirty solution that works.
