Zen Lightbox addon [Support Thread]

pewe:

I haven't fully tested it, but it appears to work - it is attached if you'd like to compare it to yours and for anyone else to test for issues.

Are the following values=100 from includes\classes\zen_lightbox\slimbox.php expressed in percentages?

				initialWidth: 100, //1024
				initialHeight: 100, //768

Thanks in advance.

niestudio:

pewe,
I merged in your updates and submitted a new version.
I have also created a github repo to make collaboration easier (if anyone else here uses github).

daniel

:thumbsup: just forked and submitted a small change

Design75:

:thumbsup: just forked and submitted a small change
What was the small change - did you find a problem somewhere?
(Github shows all the files as being last changed 2 days ago.)

dw08gm:

Are the following values=100 from includes\classes\zen_lightbox\slimbox.php expressed in percentages?

			initialWidth: 100, //1024
			initialHeight: 100, //768

> 
> Thanks in advance.

I, for one, don't know - but maybe one of the other guys will have the answer.

pewe:

What was the small change - did you find a problem somewhere?
(Github shows all the files as being last changed 2 days ago.)

Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.

mc12345678:

Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.

That's the one :)

mc12345678:

Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.

Forgive me - am I missing something.
The files on the Github link posted by @niestudio are still showing as posted 2 days ago, and the file there (slimbox.php) still appears to contain the same code as the one I have.

So is there a different link to the re-submitted file??

pewe:

Forgive me - am I missing something.
The files on the Github link posted by @niestudio are still showing as posted 2 days ago, and the file there (slimbox.php) still appears to contain the same code as the one I have.

So is there a different link to the re-submitted file??

This really isn't the place to discuss how github works. If that type of assistance is needed a separate thread should be begun, possibly on an entirely different website. More can be seen at:
https://github.com/Zen4All/zen_lightbox/commit/78470a3f7afbcaf7072140d81bf66243b95c709c

mc12345678:

This really isn't the place to discuss how github works. If that type of assistance is needed a separate thread should be begun, possibly on an entirely different website. More can be seen at:
https://github.com/Zen4All/zen_lightbox/commit/78470a3f7afbcaf7072140d81bf66243b95c709c

In which case - with all due respect - if someone makes a change to an zen cart plugin (particularly one already hosted on the zen cart plugins section) surely the changes should be uploaded to the Plugin repository where zen cart users would expect to find it (as niestudio kindly did) - or at least post details of the changes in the relevant plugin support thread so others could see them without visiting a third party hosting service.

pewe:

In which case - with all due respect - if someone makes a change to an zen cart plugin (particularly one already hosted on the zen cart plugins section) surely the changes should be uploaded to the Plugin repository where zen cart users would expect to find it (as niestudio kindly did) - or at least post details of the changes in the relevant plugin support thread so others could see them without visiting a third party hosting service.

No disrespect observed, thank you for the concern. The issue(s) are this: the Zen Cart forum and plugin areas, do not as openly support a collaboration/testing of a product to be made available/acceptable to all that will use it. Generally speaking, github is an open source location (when not paying to have a private space) where yes collaboration can occur. In this case, one meber of the community posted the code and in essence is in control of that code. Another member of the community has provided their input (including a statement of such here as wellas performing the actions to notify the original poster.) That individual could go through the submission of an "updated" plug-in, or could allow the community to incorporate the suggestion or perhaps the change is not beneficial to the masses. Whatever the case, other than our coonversation on this portion of the topic, I don't see that Design75 nor niestudio have done anything wrong. At this point it is basically up to niestudio to accept the change that Design75 has suggested in order for that revision to appear in the final package of the github link. This is also how multiple versions of a product end up existing. One developer heads down a path, another picks up part way and goes another direction and the two do not get merged together offering multiple programs that essentially do the same thing but have different ways of getting there or slightly different features.

mc12345678:

Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.

Without seeing this change, this sounds like the same change I made to the Colorbox module.. I removed the echo statement that calls the jQuery CDN and instead made this call to the CDN via a file in the jscript folder (plus I updated it to call the latest version of jQuery as well).. I did this for a number of reasons. The biggest reason is so that shopowners who have templates or other modules which ALSO include jQuery do not end up with jQuery loaded twice (they can remove the duplicates or not load them at all). Otherwise novice shopowners will end up being unable to trace WHERE the other jQuery call is.

pewe:

In which case - with all due respect - if someone makes a change to an zen cart plugin (particularly one already hosted on the zen cart plugins section) surely the changes should be uploaded to the Plugin repository where zen cart users would expect to find it (as niestudio kindly did) - or at least post details of the changes in the relevant plugin support thread so others could see them without visiting a third party hosting service.

mc12345678:

No disrespect observed, thank you for the concern. The issue(s) are this: the Zen Cart forum and plugin areas, do not as openly support a collaboration/testing of a product to be made available/acceptable to all that will use it. Generally speaking, github is an open source location (when not paying to have a private space) where yes collaboration can occur. In this case, one meber of the community posted the code and in essence is in control of that code. Another member of the community has provided their input (including a statement of such here as wellas performing the actions to notify the original poster.) That individual could go through the submission of an "updated" plug-in, or could allow the community to incorporate the suggestion or perhaps the change is not beneficial to the masses. Whatever the case, other than our coonversation on this portion of the topic, I don't see that Design75 nor niestudio have done anything wrong. At this point it is basically up to niestudio to accept the change that Design75 has suggested in order for that revision to appear in the final package of the github link. This is also how multiple versions of a product end up existing. One developer heads down a path, another picks up part way and goes another direction and the two do not get merged together offering multiple programs that essentially do the same thing but have different ways of getting there or slightly different features.

and to piggyback on this, this is EXACTLY where/how updates to the Zen Cart framework are conducted.. Zen Cart maintains an ACTIVE github repository. All niestudio did was to do the SAME THING with Zen Lightbox when he created the gibhub repository for this module.. and Design75 did what good community members do.. CONTRIBUTE/COLLABORATE..

mc12345678 is right.. No one is doing anything wrong.. In fact this is the RIGHT way to do it so that Zen Lightbox doesn't go the way of modules like Stock by Attributes which now has SO MANY forks/variants/versions (with various degrees of suitability/stability) that were created and submitted by well meaning community members NOT based on community needs, but the need of the individual authors. These well meaning authors fork this module to HELL without any regard for how these variations could cause more harm than good down the road. (multiple modules where a feature works on one, but not on another version, etc)

Thank you for the explanations and taking the time to write them Guys.

Much appreciated.

If I may, could I clarify -

Would I be right to assume that updates such as the latter one will end up in the plugins section (as was the case with the one niestudio did)?
and if so, is there any built in update notifier for those who use it, or is it up to the individual to periodically check for changes??

pewe:

Thank you for the explanations and taking the time to write them Guys.

Much appreciated.

If I may, could I clarify -

Would I be right to assume that updates such as the latter one will end up in the plugins section (as was the case with the one niestudio did)?
and if so, is there any built in update notifier for those who use it, or is it up to the individual to periodically check for changes??

Welcome with whatever little I may have helped. Typically those that submit an update will post something in the forum thread (which if monitored and one stays "up-to-date" with) will be notified. But I can't say that I have seen a notifier for plug-in updates otherwise. And yes as such the shop owner(s) should periodically check for updates and then evaluate whether it should eventually be incorporated into the active site.

pewe:

Thank you for the explanations and taking the time to write them Guys.

Much appreciated.

If I may, could I clarify -

Would I be right to assume that updates such as the latter one will end up in the plugins section (as was the case with the one niestudio did)?
and if so, is there any built in update notifier for those who use it, or is it up to the individual to periodically check for changes??

Of course they will.. and while I don't exactly know how to submit changes to github:blush:, I do undestand how it works.. gihub isn't a place to HOST modules, and the forum rules frown up supporting modules that are not available for download on this site (commercial or not)..

As for notification, IF this thread is updated with such a notification and IF you are subscribed to this thread, that is ALL the notification that any module gets round here..

DivaVocals:

and while I don't exactly know how to submit changes to github:blush:, I do undestand how it works..

and just that quick I think I figured it out.. (would love someone to grade my homework though) I created a fork and submitted a change as follows:

Replace jQuery with the latest jQuery version.

Pulls latest jQuery from CDN.

DivaVocals:

and just that quick I think I figured it out.. (would love someone to grade my homework though) I created a fork and submitted a change as follows:

So, looks like you successfully have updated github to reflect the changes that you have made, which went a step further than provided by Design75 by deleting what looks like the contents of the the jquery file (haven't downloaded the applicable files to see if actually the file itself and associated folders were deleted or just the contents of the file), but then kept a reference to the internet version of the jscript_jquery file. So couple of comments based on a review and I wouldn't call myself a grading teacher:
Don't see a pull request from niestudio's version (so, yes forked, but no notification back to the main project to request merging).
It looks like the project was forked from niestudio's version which does not yet include Design75's changes.
The changes made in both forks are different, as well as similar, this would result in niestudio having to decide/determine a "best" path forward as to which to incorporate and will likely require a manual merge, but that is the way of working in/with github.
Next homework assignment is to provide a new commit to your own branch, create two branches off of yours, make a modification in each branch that is in two different areas, merge the two branches, submit a pull request for your changes, let's see what else? :)

mc12345678:

Next homework assignment is to provide a new commit to your own branch, create two branches off of yours, make a modification in each branch that is in two different areas, merge the two branches, submit a pull request for your changes, let's see what else? :):laugh: I'll have to read and try and digest this all after I eat.. I already submitted the pull request for my changes.. (figured out that I missed this all on my own..:smile: just need someone to tell me if I did it "right":smile:)

mc12345678:

So, looks like you successfully have updated github to reflect the changes that you have made, which went a step further than provided by Design75 by deleting what looks like the contents of the the jquery file (haven't downloaded the applicable files to see if actually the file itself and associated folders were deleted or just the contents of the file), but then kept a reference to the internet version of the jscript_jquery file. So couple of comments based on a review and I wouldn't call myself a grading teacher:
Don't see a pull request from niestudio's version (so, yes forked, but no notification back to the main project to request merging).
It looks like the project was forked from niestudio's version which does not yet include Design75's changes.
The changes made in both forks are different, as well as similar, this would result in niestudio having to decide/determine a "best" path forward as to which to incorporate and will likely require a manual merge, but that is the way of working in/with github.
In summary my changes included deleting the outdated v1.4.1 jQuery file that is included with Zen Lightbox in it's entirety, and replacing it with a NEW file that instead pulls the latest version of jQuery from a CDN.. (I followed the same pattern that Picaflor follows in her templates)

Now going forward should I have simply worked from Design75's repo or niestudios's original repo versus creating my own fork???.. As I said I know what gihub is for, but have never used it in practice.. So I simply followed Design75's lead and created my own fork.. If this was the wrong path, then I would appreciate some tips on best practices here..

mc12345678:

So, looks like you successfully have updated github to reflect the changes that you have made, which went a step further than provided by Design75 by deleting what looks like the contents of the the jquery file (haven't downloaded the applicable files to see if actually the file itself and associated folders were deleted or just the contents of the file), but then kept a reference to the internet version of the jscript_jquery file. So couple of comments based on a review and I wouldn't call myself a grading teacher:
Don't see a pull request from niestudio's version (so, yes forked, but no notification back to the main project to request merging).
It looks like the project was forked from niestudio's version which does not yet include Design75's changes.
The changes made in both forks are different, as well as similar, this would result in niestudio having to decide/determine a "best" path forward as to which to incorporate and will likely require a manual merge, but that is the way of working in/with github.
Next homework assignment is to provide a new commit to your own branch, create two branches off of yours, make a modification in each branch that is in two different areas, merge the two branches, submit a pull request for your changes, let's see what else? :)

I like that "cliff's notes" version of github collaboration. :)

While I do agree that jQuery probably doesn't need to be loaded in the way that it has with this plugin since the beginning.
With these new proposals, my concern with pulling latest jQuery from the cdn is that ZLB is based on slimbox which is not really actively developed anymore. There was an update in May (that has not been applied to ZLB) to address jQuery 1.9 compatibility, but the previous one was 3+yrs prior.
So, had we been pulling latest jQuery from CDN all this time, it may have broken everyones ZLB until there was an update to slimbox.

Also, shouldn't we have a fallback to check if !jQuery {load jquery} incase the user has not used a template or other plugin that already has jQuery?

any thoughts on this?

niestudio:

I like that "cliff's notes" version of github collaboration. :)

While I do agree that jQuery probably doesn't need to be loaded in the way that it has with this plugin since the beginning.
With these new proposals, my concern with pulling latest jQuery from the cdn is that ZLB is based on slimbox which is not really actively developed anymore. There was an update in May (that has not been applied to ZLB) to address jQuery 1.9 compatibility, but the previous one was 3+yrs prior.
So, had we been pulling latest jQuery from CDN all this time, it may have broken everyones ZLB until there was an update to slimbox.

Also, shouldn't we have a fallback to check if !jQuery {load jquery} incase the user has not used a template or other plugin that already has jQuery?

any thoughts on this?

The fallback option was a thought that I had, as well as the concerns of always loading/forcing the latest. Yes programs should always seek to use the latest, and if everything else is kept up-to-date, going out and calling the latest is probably a great way to go. I did at one time (2 years ago) collaborate on a project where they were calling the latest from the internet, and the resulting delay was actually causing trouble as compared to simply loading it locally, but at the same time can understand the reasons for not loading it again, and again, and again.... (almost worse if all of them are using different versions).