Zen Lightbox addon [Support Thread]

niestudio:

I like that "cliff's notes" version of github collaboration. :)

While I do agree that jQuery probably doesn't need to be loaded in the way that it has with this plugin since the beginning.
With these new proposals, my concern with pulling latest jQuery from the cdn is that ZLB is based on slimbox which is not really actively developed anymore. There was an update in May (that has not been applied to ZLB) to address jQuery 1.9 compatibility, but the previous one was 3+yrs prior.
So, had we been pulling latest jQuery from CDN all this time, it may have broken everyones ZLB until there was an update to slimbox.

Also, shouldn't we have a fallback to check if !jQuery {load jquery} incase the user has not used a template or other plugin that already has jQuery?

any thoughts on this?
I agree with the fallback code.. it's a BIG problem with sooooo many modules and templates using jQuery and shopowners unwittingly having MULTIPLE versions of jQuery running in their shops.. (which was the inspiration for my contribution)

Couldn't backwards compatibility be mitigated with the jQuery Migrate script??

<script src="http://code.jquery.com/jquery-migrate-1.2.1.js"></script>

DivaVocals:

:laugh: I'll have to read and try and digest this all after I eat.. I already submitted the pull request for my changes.. (figured out that I missed this all on my own..:smile: just need someone to tell me if I did it "right":smile:)

In summary my changes included deleting the outdated v1.4.1 jQuery file that is included with Zen Lightbox in it's entirety, and replacing it with a NEW file that instead pulls the latest version of jQuery from a CDN.. (I followed the same pattern that Picaflor follows in her templates)

Now going forward should I have simply worked from Design75's repo or niestudios's original repo versus creating my own fork???.. As I said I know what gihub is for, but have never used it in practice.. So I simply followed Design75's lead and created my own fork.. If this was the wrong path, then I would appreciate some tips on best practices here..

If you and Design75 are working on the same "goal" then probably better to repo/fork off of Design75's version so that the changes made by the two of you could be merged together by one of you and then brought into niestudio's master. If you each are working on something different, like each working on a different feature, or "black box", then repo'ing off of a functional path would be best/easiest. In short, the collaborative effort actually requires collaboration, not just at the software level (which allows "checking out" each other's work), but also in the communication of what is being done to minimize rework and duplication of effort.

Also, by forking off the master, the master can be changed, including building more functionality, and eventually the or one of the forks can be merged with the master (possibly to even create a new branch) to verify downstream/future compatibility, and then could be rewound also to find in which commit caused a conflict.

I personally thought it was great to see you run off and give it a shot. Unfortunately you and one other basically did the same thing, so the result didn't give you the best first experience. :)

In short, usually best to pick a "known" point that is good/works (which you can do before actually forking the project) and then work from that point. When others provide input, always possible to provide comment associated with what they have shared with github/the thread "runner". (That person also can add others to help manage the master thread.) Also, there are ways/places to provide input about the mod as part of pushing each commit, and depending on your interface software this may be "clearer" than with others, but generally the title will wrap around to the body of the statement(s), also things pushed to github, well... are out there and can not really be taken back. There are several readme files in github that are informative. Perhaps niestudio may have other hints/tips?

DivaVocals:

I agree with the fallback code.. it's a BIG problem with sooooo many modules and templates using jQuery and shopowners unwittingly having MULTIPLE versions of jQuery running in their shops.. (which was the inspiration for my contribution)

Couldn't backwards compatibility be mitigated with the jQuery Migrate script??

Have you ever suggested that ZC roll a latest jQuery call into the ZC default template?

Hmm, I've never come across this before. Sounds interesting but would not have worked for this since it only supports jQuery 1.6.4 and later.
Going forward it could be good though.

niestudio:

Have you ever suggested that ZC roll a latest jQuery call into the ZC default template?

I believe that v1.6 (though I haven't looked at the gibhub lately) is going to do JUST THAT.. Then there would be no NEED for plugin authors to have to include jQuery files which would also eliminate the issue with multiple jQuery versions being loaded on a shop..

It's a path WordPress also took in recent versions so that plugin developers wouldn't have to include jQuery in their plugins. Eliminates the number of plugin clashes due to conflicting versions of jQuery loading at once on a site..

niestudio:

Hmm, I've never come across this before. Sounds interesting but would not have worked for this since it only supports jQuery 1.6.4 and later.
Going forward it could be good though.
Well I've used it with Zen Lightbox with no issues.. let me find the site and post the URL.. Here's the gihub for the jQuery Migrate script: https://github.com/jquery/jquery-migrate/#readme

Edited to add: http://laserdiscvault(dot)com/
CDN calls for jQuery and the jQuery Migrate script.. This is both the changes Design75 and I submitted to github with the addition of the jQuery Migrate script.. Lightbox works with no issues..

haha , you make one little change in code and get almost 2,5 pages of reading in return :laugh:.

The reason I did not change the jquery version, is because I wanted to make this first change as easy as possible. I know ZLB runs fine on JQ 1.8.4 , and probably later versions. My knowledge of Jquery is only limited. I wanted to integrate the latest version of slimbox, but since I do not have enough knowledge of Jquery, and a limited amount of time, I choose to only remove the echo command and rename the script-name to start with jscript_ .

Design75:

haha , you make one little change in code and get almost 2,5 pages of reading in return :laugh:.

The reason I did not change the jquery version, is because I wanted to make this first change as easy as possible. I know ZLB runs fine on JQ 1.8.4 , and probably later versions. My knowledge of Jquery is only limited. I wanted to integrate the latest version of slimbox, but since I do not have enough knowledge of Jquery, and a limited amount of time, I choose to only remove the echo command and rename the script-name to start with jscript_ .

has happened this way a lot over the years.

I'll go ahead and update to Slimbox 2.05 then we can safely load jQuery latest.

DivaVocals:

Edited to add: http://laserdiscvault(dot)com/
CDN calls for jQuery and the jQuery Migrate script.. This is both the changes Design75 and I submitted to github with the addition of the jQuery Migrate script.. Lightbox works with no issues..

I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4

niestudio:

I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4
I'm sure I read elsewhere it will work with older versions too.. That's something I can EASILY and quickly test..

Design75:

haha , you make one little change in code and get almost 2,5 pages of reading in return :laugh:.

should we move this part of the discussion to github instead since this is not helpful for someone lookin for basic ZLB help?

niestudio:

I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4

DivaVocals:

I'm sure I read elsewhere it will work with older versions too.. That's something I can EASILY and quickly test..

Done.. take a look now.. Update the jQuery and jQuery Migrate versions.. Lightbox still works like a champ..

niestudio:

should we move this part of the discussion to github instead since this is not helpful for someone lookin for basic ZLB help?

I would agree with this move..

DivaVocals:

I would agree with this move..

I would also agree

Hello, I am very new to zen cart. I have tried to install the lightbox addon (version: 1.6.4b_1.5). However, it was not successful. I have the following questions. in the installation file:
4.Rename the following folders to match your template folder name.

includes\languages\english\extra_definitions\YOUR-TEMPLATE-FOLDER
includes\modules\YOUR-TEMPLATE-FOLDER
includes\templates\YOUR-TEMPLATE-FOLDER

I am wondering the "YOUR-TEMPLATE-FOLDER" is it the folder at Admin-->Tools-->Template Selection. In my case, it is theme377. Please help.

DivaVocals:

Done.. take a look now.. Update the jQuery and jQuery Migrate versions.. Lightbox still works like a champ..

I would agree with this move..

Off topic I know but must ask before you guys working on the ZLB update slip away into the ether.

Is there a zencart forum page, existing or coming any time soon, providing instructions on how to load/use jQuery Migrate with zencart.

Thanks

aszybdean:

Hello, I am very new to zen cart. I have tried to install the lightbox addon (version: 1.6.4b_1.5). However, it was not successful. I have the following questions. in the installation file:
4.Rename the following folders to match your template folder name.

includes\languages\english\extra_definitions\YOUR-TEMPLATE-FOLDER
includes\modules\YOUR-TEMPLATE-FOLDER
includes\templates\YOUR-TEMPLATE-FOLDER

I am wondering the "YOUR-TEMPLATE-FOLDER" is it the folder at Admin-->Tools-->Template Selection. In my case, it is theme377. Please help.

Welcome to ZenCart (ZC). Pretty decent start with your first post. Please in the future identify what "didn't work". But, to answer your question, yes it will be a directory that is theme377 or named very close to that. One way to tell what the name should be is to try to follow that path (substituting the desired (typically active) template name) and see what it leads you to. When you get there, if you see a file that is named like what you want to put there, you probably will need to merge the two or at least should make sure you won't lose something important with the new file.

Use the tools you have and you'll get through: a good ftp program, a head on your shoulders, knowing where your various logs are, a good merge program, backup, backup, backup, help where you can and give detailed information when asking for help, should get there.

dw08gm:

Off topic I know but must ask before you guys working on the ZLB update slip away into the ether.

Is there a zencart forum page, existing or coming any time soon, providing instructions on how to load/use jQuery Migrate with zencart.

Thanks

Nothing really different than the last two pages. :P I think/thought there was something about instructions at the following post. http://www.zen-cart.com/showthread.php?45314-Zen-Lightbox-addon-Support-Thread&p=1226003#post1226003

I could be wrong.

mc12345678:

Nothing really different than the last two pages. :P I think/thought there was something about instructions at the following post. http://www.zen-cart.com/showthread.php?45314-Zen-Lightbox-addon-Support-Thread&p=1226003#post1226003

I could be wrong.

Yes Seeing that is what prompted my query. I had visited and quickly scanned the GH page, and also downloaded the zip. However, for the likes of me such wonders are cursed with "many a slip between cup and lip".

Are the files on GH the updated and newest files?

If so, their seems to be allot of unnecessary code copied from the slimbox.php file from google groups that is not needed and may cause issues.

That file is generic and the custom options may/may not override options.php (ADMIN Configurations).

rbarbour:

Are the files on GH the updated and newest files?

If so, their seems to be allot of unnecessary code copied from the slimbox.php file from google groups that is not needed and may cause issues.

That file is generic and the custom options may/may not override options.php (ADMIN Configurations).

I thought the discussion of GH and Zen LightBox got moved to elsewhere. My understanding is that one person setup GH, another had posted the update here on ZC, so not sure (without comparing the two filesets) if they are/were the same. That said, the GH files are there for mod/continued improvement if an issue has/will be identified. Please feel free to evaluate for the issues of concern and contribute back the changes/suggestions.

rbarbour:

Are the files on GH the updated and newest files?

If so, their seems to be allot of unnecessary code copied from the slimbox.php file from google groups that is not needed and may cause issues.

That file is generic and the custom options may/may not override options.php (ADMIN Configurations).

I have used this lightbox for a very long time and the only real problems that have been written about are when the user accidently installs both lightbox and slimbox together, they do not play nice so only one is needed for the store.

Aside from that and the occasional corrupt file or missing file I have not had any problems with this mod at all...in my own store or the ones I have installed it on.

DarkAngel:

I have used this lightbox for a very long time and the only real problems that have been written about are when the user accidently installs both lightbox and slimbox together, they do not play nice so only one is needed for the store.

Aside from that and the occasional corrupt file or missing file I have not had any problems with this mod at all...in my own store or the ones I have installed it on.

Darkangel, if I understand correctly, you are indicating that the Zen LightBox as provided here in ZC has been good; however, in the last couple of days, a "solution" for it working better on mobile devices was proposed. The result of incorporating that appears to have been the incorporation (in full?) of a file into the package. What rbarbour was indicating was that perhaps the included file contains more code than necessary, and may (or may not) be fully compatible with options.php. That is something still to be determined, unless those that proposed the change(s) have already addressed that issue.

Btw, where's that other thread to discuss things like this further?