MSRP contrib

In trying the MSRP display, the file at
includes/functions/functions_price.php

is showing an error, and the page is empty

the logs show that it's an Unexpected end of file error

I'm not sure what the issue is, and if anyone has a working copy of that file I'd love to take a look at it...

the file I downloaded has an error someplace.... I'll keep looking... thanks for any help

zen cart version 1.5.1 latest version of MSRP display mod

jonkip:

In trying the MSRP display, the file at
includes/functions/functions_price.php

is showing an error, and the page is empty

the logs show that it's an Unexpected end of file error

I'm not sure what the issue is, and if anyone has a working copy of that file I'd love to take a look at it...

the file I downloaded has an error someplace.... I'll keep looking... thanks for any help

zen cart version 1.5.1 latest version of MSRP display mod

same here...anyone know what the issue is?

log says:

[29-Jan-2015 15:01:31 America/Chicago] PHP Parse error: syntax error, unexpected end of file in /root/includes/functions/functions_prices.php on line 1408

Jonathan Grant:

same here...anyone know what the issue is?

log says:

[29-Jan-2015 15:01:31 America/Chicago] PHP Parse error: syntax error, unexpected end of file in /root/includes/functions/functions_prices.php on line 1408

I think I found the error. There is a closing bracket missing.
find

 }}else{
 $final_display_price = $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount;
 }
 }
 
 // end modifications =================

and add a "}"

 }}else{
 $final_display_price = $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount;
 }
 }
  }
 // end modifications =================

Design75 is right. Same thing was reported and a fix posted just a couple posts earlier: http://www.zen-cart.com/showthread.php?54857-MSRP-contrib&p=1243869#post1243869

I posted an updated version in the downloads

Design75:

I posted an updated version in the downloads

Hi, the latest update is missing the following just before the closing bracket in functions_prices.php around line 330.

    return $final_display_price . $free_tag . $call_tag;

Without the "Return" call no prices are being displayed. Could you please update the contribution accordingly and re-upload.

BTW, thank you for making this available to the community and for your time and effort in maintaining this plugin.

I have noticed another issue with this plugin which has to do with the pricing display.

If your store is setup to show prices with VAT (tax) included the plugin will display the saving incorrectly:

Retail Price: R3,990.00
You save: R526.32 (15%)
Our Price: R3,390.00

The store is setup to add a standard 14% VAT to all prices and the 526.32 is the saving excluding the 14% VAT.

This should read:

Retail Price: R3,990.00
You save: R600.00 (15%)
Our Price: R3,390.00

Anybody else having the same issue?

Sorry folks, I tried to edit the previous post but was too late.

I made the following changes and it seems to work for my specific requirements. Hope this is useful to someone else as well.

In functions_prices.php find

        $final_display_price = '<span class="smalltext1"><s>' . TEXT_PRODUCT_MSRP . $currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s></span><br><span class="save">' . TEXT_PRODUCT_SAVE . $currencies->display_price($save, '') . '  (' . number_format((($display_msrp_price - $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)' . '</span><br><span class="norm">' . TEXT_PRODUCT_OUR . $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount . '</span>';

and replace with

        $final_display_price = '<span class="smalltext1"><s>' . TEXT_PRODUCT_MSRP . $currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s></span><br><span class="save">' . TEXT_PRODUCT_SAVE . $currencies->display_price($save, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '  (' . number_format((($display_msrp_price - $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)' . '</span><br><span class="norm">' . TEXT_PRODUCT_OUR . $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount . '</span>';

The discount is now displaying with the VAT included.

I have submitted an updated version for ZC 1.5.4 - it should be available for download in a few days.

frank18:

Thanks for the heads up and the contribution. I will be looking for it!

Silver

frank18:

I have submitted an updated version for ZC 1.5.4 - it should be available for download in a few days.

Just noted that the bug which was posted by Louis (post #346) is not incorporated in the previous (Design75) and my latest upload.

So, in includes/functions/functions_prices.php find

    }
  }
}

// end modifications for MSRP =================

and replace with:

    }
  }
 return $final_display_price . $free_tag . $call_tag;
}

// end modifications for MSRP =================

Sorry folks.

Hi Guys

I am just about to give up all hope... I have installed everything step by step but as soon as I put the "functions_prices.php" file into includes/functions/ the front end of the site still works but I cannot access the admin side. Just a great big blank page. I am desperately trying to get this pricing functionality to work on Zen Cart 1.5.4 can anybody please help me out with this?

Thank you in advance I really appreciate any assistance I can get

Regards

Erwin

ErwinSk8:

...... Just a great big blank page.....

What output do you find in your logs folder? Also see https://www.zen-cart.com/content.php?124-blank-page

Hi Frank

Thank you so much for dropping some knowledge on a noob, I really appreciate it. The only problem is I don't really know how to read this... or what to do to correct it as I am literally learning as I go along. This is what I found in the latest site log:

[09-Oct-2015 15:04:30 UTC] PHP Fatal error: Cannot redeclare zen_update_products_price_sorter() (previously declared in /home/erwintheoutlaw/public_html/thecontrolroom.co.za/marsadmin/includes/functions/general.php:2769) in /home/erwintheoutlaw/public_html/thecontrolroom.co.za/marsadmin/includes/functions/functions_prices.php on line 1375

but really have no idea what it means... if you don't mind, would you consider giving me a little crash course on how this error log works and how to repair it?

I will attached the two files that seem to be the cause of all the issues as per the log.

I really appreciate your assistance, I only hope that one day I will be good enough at this to be able to help someone else.

Regards

Erwin

ErwinSk8:

Hi Frank

Thank you so much for dropping some knowledge on a noob, I really appreciate it. The only problem is I don't really know how to read this... or what to do to correct it as I am literally learning as I go along. This is what I found in the latest site log:

[09-Oct-2015 15:04:30 UTC] PHP Fatal error: Cannot redeclare zen_update_products_price_sorter() (previously declared in /home/erwintheoutlaw/public_html/thecontrolroom.co.za/marsadmin/includes/functions/general.php:2769) in /home/erwintheoutlaw/public_html/thecontrolroom.co.za/marsadmin/includes/functions/functions_prices.php on line 1375

but really have no idea what it means... if you don't mind, would you consider giving me a little crash course on how this error log works and how to repair it?

I will attached the two files that seem to be the cause of all the issues as per the log.

I really appreciate your assistance, I only hope that one day I will be good enough at this to be able to help someone else.

Regards

Erwin
We all started small at some stage, it is a learning curve.

You copied the file functions_prices.php into the admin/includes/functions folder instead of the /includes/functions folder.

Firstly replace the file admin/includes/functions/functions_prices.php with the original file from your backup and see if you can get into admin without a blank page.

Next check that the files in the module have been correctly merged and placed into the correct folders.

One basic rule when stating file paths here in the forums is to never reveal the real name of your admin folder. That is an invitation for hackers! Always call it MY_ADMIN or ADMIN_FOLDER or similar when posting file paths! So, quickly rename your admin folder to something else.

BTW, there is nothing to 'repair' in the logs folder, that folder only records errors in the system. Ideally that folder should be empty but for the .htaccess file.

Hi Frank

You are a Life Saver!! 100% a True Legend! I do have one rather pressing issue. I think this is due to me working within the confines of a purchased template. for some reason the price, discount and MSRP price are scattered as per the image I have attached. I don't know if the problem can be solved within the line of css? I would really like them to be under one another... then perhaps also have the ability to change their colors and so on? Could you maybe give me a hand with this? I really appriciate it and can't believe I mad such a rookie mistake...

.atrib2 {
  padding: 10px 15px;
  margin-top: 15px;
  color: #fff;
  -webkit-border-radius: 4px 0 4px 0;
  -moz-border-radius: 4px 0 4px 0;
  border-radius: 4px 0 4px 0;
}
.atrib2 #productAttributes .wrapperAttribsOptions {
  overflow: hidden;
  border-bottom: 1px solid #d1d1d1;
  padding-bottom: 15px;
  color: #555;
}
.atrib2 #productAttributes .wrapperAttribsOptions h4 {
  font-size: 16px;
  text-transform: uppercase;
  margin: 10px 0 10px 0;
  color: #777;
  font-family: "Open Sans", sans-serif;
}
.atrib2 #productAttributes .wrapperAttribsOptions .option {
  width: 33.33%;
  color: #000;
  float: left;
}
.atrib2 #productAttributes .wrapperAttribsOptions .option label {
  margin: 0 0 0 5px;
  font-family: "Open Sans", sans-serif;
}
.atrib2 #productAttributes .wrapperAttribsOptions .two {
  width: 50%;
  padding-bottom: 5px;
}
.atrib2 .add_to_cart_block #prod-price span {
  float: right;
  margin-top: 10px;
  margin-left: 10px;
  padding: 10px 10px;
  background: #ce1b22;
  -webkit-border-radius: 0 4px 0 4px;
  -moz-border-radius: 0 4px 0 4px;
  border-radius: 0 4px 0 4px;
}
.atrib2 .add_to_cart_block .price-text {
  font: 400 19px/34px "Open Sans", sans-serif;
  color: #fff;
}
.atrib2 .add_to_cart_block .productSalePrice,
.atrib2 .add_to_cart_block .productSpecialPrice {
  font-size: 20px;
  line-height: 54px;
}
.atrib2 .add_to_cart_block .normalprice {
  font-size: 20px;
  line-height: 55px;
}
.atrib2 .add_to_cart_block .productPriceDiscount {
  font-size: 17px;
  margin-top: 0px;
}

.wrapper.atrib2 {
  padding: 0;
}

Thank you so much, I really appreciate the assistance and time you are spending on helping out noobs :-)

ErwinSk8:

Hi Frank

You are a Life Saver!! 100% a True Legend! I do have one rather pressing issue. I think this is due to me working within the confines of a purchased template. for some reason the price, discount and MSRP price are scattered as per the image I have attached. I don't know if the problem can be solved within the line of css? I would really like them to be under one another... then perhaps also have the ability to change their colors and so on? Could you maybe give me a hand with this? I really appriciate it and can't believe I mad such a rookie mistake...

No problem, glad you got that fixed.

Since your layout is not related to MSRP you should open another thread.

Hi Frank

I managed to get the layout sorted out but I sit with one last issue... I even contacted templatetuners and was told they do not support third party modules and that I should contact the developer. The only problem I now have is that the first price you see on the product listing page is the "Retail Price" with the strike through it but rather the "Our Price" which is what we would like the client to see. I was told that the issue is not one of CSS rather that of the module or something in that area so as to retain the sites responsiveness.

if you visit https://www.thecontrolroom.co.za you will see the product, NOVATION UltraNova but it is showing the Retail Price rather than the "Our Price" (The actual price we are selling the product price) you will see if you visit the actual product URL: http://www.thecontrolroom.co.za/index.php?main_page=product_info&cPath=157_191&products_id=1170 that everything is perfect but I need "Our Price: R10,850.00" to be the price the client sees in searches and then when they land on the product page they see exactly what it is currently.

I really appreciate any help you can throw at this Noob.

Regards

Erwin

Hi there all you Zen Cart Legends! Can anybody help me with this issue? I would really appreciate any assistance.

ErwinSk8:

Hi there all you Zen Cart Legends! Can anybody help me with this issue? I would really appreciate any assistance.

Just checked your site - looks like you got that sorted.