Event Calendar v3

Diva

Sidebox issue: Sounds to me like the tpl_main_page edits were not completed.
Catalog/Products issue: I believe post #242 was to address this issue, but so far I have failed to make sense of it.

Rus

Re your post #242, I struggled to match the contents with your ec4_alpha_rus - confused by the line numbers you gave and not sure which code is to be replaced. If you could post the two modified files in their entirety (color coding not required in this instance), I will be able to directly compare with your originals.

Thanks

LaCamus:

Just thinking though...hold up...

...did you add the required code to includes/templates/your_template/common/tpl_main_page.php?

The following is required at the beginning of the file:

> 
> and this is required at the end of the file:
> ```
<?php
}
?>

You would need to do this for all of your templates that use the event calendar.

If you added this and it still isn't working please send me a copy of the above file so I can see if some other variable is being used (or possibly none at all).

RusThere was a posted fix in this support thread for the sidebox, and that I suspected that this fix was NOT included in the add-on?? So I went back last night and found the posts and added the code at the beginning of my includes/templates/your_template/common/tpl_main_page.php the result was blank pages.. I looked at my Zen Cart error logs, and wasn't sure what the issue was because there was no error log file (strange).. Anyway what was missing in those posts was this part:

<?php
}
?>

So I just added the right code at the beginning and end of my includes/templates/your_template/common/tpl_main_page.php file and NOW the sidebox works.. Thank you!!!

Now the question is this.. Is an iframe REALLY the best/only way to render this sidebox???

dw08gm:

Diva

Sidebox issue: Sounds to me like the tpl_main_page edits were not completed.The instruction in the the readme wasn't really clear.. and perhaps it's because it's in a text file and the formatting made the instruction unclear.. These edits should not be a line item in the instructions.. they really should be part of the add-on files.. The add-on should simply include the tpl_main_page with the proper edits in place.

dw08gm:

Catalog/Products issue: I believe post #242 was to address this issue, but so far I have failed to make sense of it.

Rus

Re your post #242, I struggled to match the contents with your ec4_alpha_rus - confused by the line numbers you gave and not sure which code is to be replaced. If you could post the two modified files in their entirety (color coding not required in this instance), I will be able to directly compare with your originals.

Thanks
I am using Rus' files with all of his edits in place.. I use Beyond Compare for file comparison which makes it SUPER easy to see his changes. That coupled with the fact that next to the venerable niccol, Rus, is VERY thorough and anal about commenting his code.. his changes light up like a CHRISTMAS TREE in Beyond Compare..:laugh:

Still unable to add categories/products to an event..

DivaVocals:

The instruction in the the readme wasn't really clear.. and perhaps it's because it's in a text file and the formatting made the instruction unclear.. These edits should not be a line item in the instructions.. they really should be part of the add-on files.. The add-on should simply include the tpl_main_page with the proper edits in place.

I am using Rus' files with all of his edits in place.. I use Beyond Compare for file comparison which makes it SUPER easy to see his changes. That coupled with the fact that next to the venerable niccol, Rus, is VERY thorough and anal about commenting his code.. his changes light up like a CHRISTMAS TREE in Beyond Compare..:laugh:

Still unable to add categories/products to an event..

Let me be clear..

After viewing Rus' changes in Beyond Compare I simply replace 4 of dw08gm's alpha version files with Rus' 4 modified files in their entirety.. I didn't attempt to MERGE the changes between the files since it was obvious to see after looking at the changes that Rus' files were meant to replace dw08gm's.. so that's what I did..

DivaVocals:

Let me be clear..

After viewing Rus' changes in Beyond Compare I simply replace 4 of dw08gm's alpha version files with Rus' 4 modified files in their entirety.. I didn't attempt to MERGE the changes between the files since it was obvious to see after looking at the changes that Rus' files were meant to replace dw08gm's.. so that's what I did..

I'm uploading, for those interested, the file set I used to install Event Calendar. It includes all of Rus' additions to the codebase and I've included the tpl_main_page edits as part of the fileset to make it easier for folks and to follow standards other add-ons use for these kinds of changes.. (include ALL file modifications as a part of the add-on and not rely on instructions on how to make those changes being included in user docs)

I've made it easy to see where the core code changes are by putting all the core code changes in one set of folders and the base add-on files in another set of folders.. I didn't touch the readme except to remove the instruction to edit the tpl_main_page since this file is now included as part of the installation package fileset.

Diva

Those written instructions in the readme have been a key part of installation ever since the mod was introduced in zencart 138a days and, as they are already quite clear and explicit, should not be removed.

As you could be classed as an old hand with this mod, and a staunch advocate of the "Read the Instructions" brigade, the required edits should have been familiar to you.

I fail to see how removing the written instructions in favour of adding the necessary changes to the TemplateDefault/common/tpl_main_page.php works any better for those, like myself, who have overridden and drastically altered their tpl_main_page.

cheers

dw08gm:

Diva

Those written instructions in the readme have been a key part of installation ever since the mod was introduced in zencart 138a days and, as they are already quite clear and explicit, should not be removed.

As you could be classed as an old hand with this mod, and a staunch advocate of the "Read the Instructions" brigade, the required edits should have been familiar to you.

I fail to see how removing the written instructions in favour of adding the necessary changes to the TemplateDefault/common/tpl_main_page.php works any better for those, like myself, who have overridden and drastically altered their tpl_main_page.

cheers
I admit I overlooked the readme file that was included in the alpha files (wasn't expecting to find a completed readme file in a set of files being put forward for testing).

AND as you put it being "a staunch advocate of the "Read the Instructions" brigade" when I had issues with the sidebox, **the VERY first place **I went to WAS the readme file.. Then I went to the support thread becasue I KNEW the issue and solution was posted.. However, I looked at the text readme from the v1.1 files and that readme is a TXT file (the one in the alpha zip is an RTF file). IMHO, the instructions from the text version of the readme were not clear.. even to me, and upon looking at that text file again this morning I realized that the way the instructions were formatted probably made them a tad unclear.. I saw that this was cleaned up in the RTF readme included in the alpha zip files, but if the properly modified file is included, then the instruction is no longer needed.. Hence why I removed it..

That said, I fail to see why including the file already modified IS an issue.. I am looking at things through the eyes of the NOVICE shopowner, and looking at the practices in use by more seasoned Zen Cart mod author vets.. MANY other Zen Cart modules where there are changes to core files simply include the files with the modifications already done so that it makes it easier for shopowners to see where the changes should go.. Having an example of what core modifications should look like IMHO is far easier than relying on written instructions alone to make those changes.. I would go an additional step of commenting those changes so that it is VERY easy for shopowners to identify where the changes are -- much like Rus' comments in the 4 files he modified.

Merging those changes into the existing core files can be achieved using a file merging program like WinMerge and Beyond Compare.. Again, there are a TON of add-ons by some Zen Cart powerhouses that already follow this same model and they all provide guidelines for shopowners so that they know how to merge these changes into their own stores particularly when they've got other mods in those same files..

dw08gm:

I fail to see how removing the written instructions in favour of adding the necessary changes to the TemplateDefault/common/tpl_main_page.php works any better for those, like myself, who have overridden and drastically altered their tpl_main_page.One more thing to add here.. When I compare the file I included in the file set to the HEAVILY modified **YOUR_TEMPLATE/common/tpl_main_page.php **file used in the test site I posted earlier, the changes are QUITE easy to see and implement. I don't see this as a BIG issue, but I think that adding some clarifying comments around the changes so that it's REALLY clear that these changes are coming from the Event Calendar mod will help folks see the changes related to this mod and can very easily see how to merge them into their own modified **YOUR_TEMPLATE/common/tpl_main_page.php **file.

Now the thing I'd like to see resolved is the issue as to why you cannot attach products or categories to events.. For me it's the ONE thing I need resolved to finally be able to use this add-on.. Attaching maufacturers to an event works just fine.. products and categories?? Not so much..:no:

I'll have to go look at past posts (particularly my post where I summarized all the known issues with this add-on), but has attaching products/categories to events EVER worked??

dw08gm:

I believe the problem of image size will be largely limited to those who blindly adopt other's images without a thought to tailoring same for their website. In this day and age, store owners/developers should know better.

LaCamus:

When the store owner took a photo of one of his products (he does not adopt other's images) and uploaded it in admin, then refreshed the store side page and the image took over the screen, at the time, he did not know better. He does now. Even with his list of image dimensions posted on the wall next to the monitor it doesn't mean it won't happen again, it probably will. But wasn't the reason we humans created these hunks of electronic parts controlled by 1's and 0's to make our lives easier and limit the mistakes? To err is human after all.

Perhaps I should have been a little more clear...

The images we are talking about are event images, not product images, which could be in any of the prescribed graphical forms, and not limited to scenic photos or scans. The main type of image I envisage most shopowners uploading for their event image is an informational flyer or poster, mostly containing text but which could also include a map, corporate logo and other graphics, including photos. If the shopowner drafts the flyer themselves, and have already been through the process of size editing their product images, then they should already be familiar with many of the layout constraints of zencart sufficient to determine an appropriate size of their event image.

If, however, the shopowner is participating in an event organised by or under the direction of others, such as operating a stall at a sporting, artistic or cultural event, then the shopowner may be required to use an event image supplied by the organisers, which could come in any format. The particular instance I was referring to is where a shopowner downloads or otherwise acquires a graphic from another source and then simply inserts that graphic directly into the shopowners website.

The code supplied in tpl_events_calendar_default will handle all sizes of event image (up to 2048kb IIRC) and reduce the image only so far as to fit it into the events page and without physically altering the size of the image. This I consider a good thing, as the graphic is not altered to fit the page but delivered to suit the customer. If the customer then saves the event page, the event image as supplied will also be saved at its intended size, which then allows a customer to view the event image offline and print or otherwise use it at their discretion.

I hope you can see there is more to event images than may first meet the eye.

cheers

Diva

I really do appreciate your comments and criticisms and hope that I am not responding in too harsh a fashion as to drive you away.

Sunday, when I am back on my main pc, I hope to properly address all of these issues, but for the moment I am using a win8 laptop that drives me half-crazy with the things it makes me endure.

Cheers

DivaVocals:

Now the thing I'd like to see resolved is the issue as to why you cannot attach products or categories to events.. For me it's the ONE thing I need resolved to finally be able to use this add-on.. Attaching maufacturers to an event works just fine.. products and categories?? Not so much..:no:

I'll have to go look at past posts (particularly my post where I summarized all the known issues with this add-on), but has attaching products/categories to events EVER worked??

It works to my satisfaction in the ec4_alpha version, in that it only provides a link in event manager and the event page. I am still a little unclear as to what Rus was trying to achieve with this.

cheers

dw08gm:

The images we are talking about are event images, not product images, which could be in any of the prescribed graphical forms, and not limited to scenic photos or scans. The main type of image I envisage most shopowners uploading for their event image is an informational flyer or poster, mostly containing text but which could also include a map, corporate logo and other graphics, including photos.I think that everyone participating inthis conversation understands that we are not talking about product images.. So yes we are indeed all on the same page..

dw08gm:

If the shopowner drafts the flyer themselves, and have already been through the process of size editing their product images, then they should already be familiar with many of the layout constraints of zencart sufficient to determine an appropriate size of their event image.You cannot make this assumption.. Not every shopowner will be drafting their own flyers or even understand FULLY the constraints of Zen Cart. YOU may understand this, but I can assure you from my years of experience working with end users is that I would NEVER make this assumption. I do believe that Rus will concurr with my thoughts here since he and I have worked in the same line of work outside this forum (he as a developer and I as a Business Analyst)..

dw08gm:

If, however, the shopowner is participating in an event organised by or under the direction of others, such as operating a stall at a sporting, artistic or cultural event, then the shopowner may be required to use an event image supplied by the organisers, which could come in any format. The particular instance I was referring to is where a shopowner downloads or otherwise acquires a graphic from another source and then simply inserts that graphic directly into the shopowners website.
Understood.. But to Rus' point we see shopowners who upload their OWN images from digital cameras. This is NOT a good thing.. and NO you cannot assume they will or even know how to edit these images..

dw08gm:

The code supplied in tpl_events_calendar_default will handle all sizes of event image (up to 2048kb IIRC) and reduce the image only so far as to fit it into the events page and without physically altering the size of the image. This I consider a good thing, as the graphic is not altered to fit the page but delivered to suit the customer. If the customer then saves the event page, the event image as supplied will also be saved at its intended size, which then allows a customer to view the event image offline and print or otherwise use it at their discretion.This statement right here says that there are two different images in use

1. the image that is displayed on the event page
2. the image that is saved/downloaded (flyer) by an event participant.

The display and print image cannot be one and the same image file as the requirements for displaying an image on a page and downloading an image for print are different. The code supplied in the Events Calendar uses poor practices for displaying the images, and keeping this improper display code in place just for the sake of having a print sized image is not the right way to deliver a print sized image.

We also don't want to use artificial means of displaying event images.. Down and dirty why it's not a good practice to use height and width tags to artificially re-size images..

While it is advisable to specify actual image height and width via these tags, it's not advisable to use these tags to change the image display size for a few reasons.

2. You're forcing your viewers to download larger files then they need. Cropping your photos before putting them on your Web page will result in smaller files and less download time.

3. Browsers don't do a very good job of resizing images. The images are going to look either blurry or blocky if you resize them via the browser. GIF images are the worst. Never resize GIF images via the browser; they'll look awful!

4. Resizing in the browser requires more time to render the page and uses more of your viewer's system resources and RAM.

IF the image should be available for printing at dimensions meant for print, then there really should be a function that explictly calls the print sized image and delivers it to the printer. (or for download)

AND..

That code will STILL need some admin configurable parameters to ensure that 2500 x 2500 images are not uploaded and delivered as print images.

dw08gm:

I hope you can see there is more to event images than may first meet the eye.
I do, but I hope you can also see that the code in this module doesn't fully satisfy the requirements for images without some modifications..

dw08gm:

Diva

I really do appreciate your comments and criticisms and hope that I am not responding in too harsh a fashion as to drive you away.

Sunday, when I am back on my main pc, I hope to properly address all of these issues, but for the moment I am using a win8 laptop that drives me half-crazy with the things it makes me endure.

CheersNo worries.. Just trying to add something useful to the conversation. Hope you don't mind.. At the end this will make things better right??

dw08gm:

It works to my satisfaction in the ec4_alpha version, in that it only provides a link in event manager and the event page. I am still a little unclear as to what Rus was trying to achieve with this.

cheersAnd I'm going to work with Rus to figure out why it doesn't work on my test store since he reports it works on his.. So I'm sure it's a completely resolvable issue..

I did suggest a few posts back that we can make this exist in both worlds....

I am going to reinstall the original alpha and test the link creation again, I don't remember it ever working right for me...I think it was because when you went back to edit an event the default manufacturer kept overwriting the original link.

I can add a checkbox to not resize....I can even put this in the review page after we know the dimensions and whether it even possibly should be resized. Then say something like, "whoah! grandma, what a big image you have, want me to resize it for you?" and if so "what size?" What a nice feature to have. I can make this happen for only certain types of images and then open the uploads up to things like PDF's, doc's, etc. But we don't want to leave the upload open ended...for things like .exe's/.php's/etc. That's risky, 'specially since there is a link to it in a permanent web page telling the outside world it's there. Just give me a list of the extensions you want to allow. If what they upload is not an image (say a doc/pdf) then we should have a default image (or something) that says "click to view".

Let's work together on this to make it usable by many, not just a few. An events calendar like this should be one of the most popular downloads on Zen-Carts.

Ya know!?

...and don't worry about "bloat" on the admin side, that's what most of data entry and configuration programming is all about...error checking and ease of use. We use overkill in admin (input) so we can make sure what's delivered (output) is error free and resource efficient.

We all have different skill sets, let's put them to good use. Even rock stars (with their rock star egos) come together on special occasions to do great things.

I'm just a traveler who's crossed your path, let's trade our wares and move on.

Rus

LaCamus:

I did suggest a few posts back that we can make this exist in both worlds....

I am going to reinstall the original alpha and test the link creation again, I don't remember it ever working right for me...I think it was because when you went back to edit an event the default manufacturer kept overwriting the original link.

I can add a checkbox to not resize....I can even put this in the review page after we know the dimensions and whether it even possibly should be resized. Then say something like, "whoah! grandma, what a big image you have, want me to resize it for you?" and if so "what size?" What a nice feature to have. I can make this happen for only certain types of images and then open the uploads up to things like PDF's, doc's, etc. But we don't want to leave the upload open ended...for things like .exe's/.php's/etc. That's risky, 'specially since there is a link to it in a permanent web page telling the outside world it's there. Just give me a list of the extensions you want to allow. If what they upload is not an image (say a doc/pdf) then we should have a default image (or something) that says "click to view".

**Let's work together on this to make it usable by many, not just a few. An events calendar like this should be one of the most popular downloads on Zen-Carts.

Ya know!?

...and don't worry about "bloat" on the admin side, that's what most of data entry and configuration programming is all about...error checking and ease of use. We use overkill in admin (input) so we can make sure what's delivered (output) is error free and resource efficient.

**We all have different skill sets, let's put them to good use. Even rock stars (with their rock star egos) come together on special occasions to do great things.

I'm just a traveler who's crossed your path, let's trade our wares and move on.

RusNods in agreement with ALL of this!!!:yes: (especially the part in red)

Rus clarify for me, are you also unable to add products/categories?? I am not getting error logs either when it fails.. So I'm stumped as to what is happening..

DivaVocals:

Rus clarify for me, are you also unable to add products/categories?? I am not getting error logs either when it fails.. So I'm stumped as to what is happening..

I can add anything and everything and delete the link. If you could, please, got to admin and edit an event, then right click the page, view source, copy that and send it to me. I want to make sure my changes made it to your output.

LaCamus:

I can add anything and everything and delete the link. If you could, please, got to admin and edit an event, then right click the page, view source, copy that and send it to me. I want to make sure my changes made it to your output.

plus the link doesn't get deleted/overwritten when editing an event unless you choose "No Manufacturer".

I think to simplify things I should just put a check box to delete the link.

LaCamus:

I can add anything and everything and delete the link. If you could, please, got to admin and edit an event, then right click the page, view source, copy that and send it to me. I want to make sure my changes made it to your output.

Will do that.. I uploaded the files I have installed on my test stores (local and live).. See a few posts back from today.. Will that help??

deleted

LaCamus:

plus the link doesn't get deleted/overwritten when editing an event unless you choose "No Manufacturer".

I think to simplify things I should just put a check box to delete the link.This is certainly the simpliest solution form the UI perspective..