Event Calendar v3

LaCamus:

OK, this is a test release of the mods I've been working on. I don't have a readme for it yet, but it is really a cleaner version of the previous mods.

I made a few more changes:

Defaulting the second date (end) to the 1st (start) when you forget to put it in. Also will copy other date if empty (1st to 2nd, 2nd to 1st), onblur.

All the link build select drop downs should stay highlighted now. Only 1 drop down will have a highlight...the one the link is built from. If there is no link (or you delete it) then all drop downs go to the top (blank).

Link build section has delete radio button and lets you know that it was deleted (or updated) now. Will also keep the value when moving back and forth from preview and edit.

Can upload (and view in store front) images and docs now...for images it only supports png, jpg, and gif, if someone needs another type let me know and I will make the change. When you upload a doc type it shows a default image...you can change the image (just use the same file name) I have there now if you don't like my generic one.

Don't forget to update the image manipulator under your_admin/includes/classes, a made a few changes to it.

Had to change the .htaccess file in the events image directory...of course that's for apache (there is a copy in the zip), if you are serving from windows those doc types below are probably already good to go.

Resizing on images is on the preview page now, works pretty good, gives warning if over max(s) (now supports a height max too), then you can click to change, allows you to go above the max parameters, they are just used as a guide for the admin user. You can go back and resize the image even after you've saved an event (update mode).

You can turn off the image resizing (see defines below) if you want. Leaving the maxes set and turning EVENTS_FILE_RESIZE off (false) takes out the file resizing fields but will resize the image in the IMG tag only...only on the admin side, I left the image resizing up to you (I know you were planning some css changes on the front).

---

DEFINE vars are currently in:
(admin side) your_admin\includes\languages\english\extra_definitions\events_manager.php
define(EVENTS_FILE_MAX_WIDTH, '800'); //** rus.02: for max image width in px, check on uploads, change on review
define(EVENTS_FILE_MAX_HEIGHT,'600'); //** rus.02: for max image height in px, check on uploads, change on review
define(EVENTS_FILE_RESIZE, true); //** rus.02: for image resizing, set to false to do/show no resizing
define(EVENTS_IMAGE_EXTS, '.jpg .jpeg .png .gif'); //** rus.02: image types allowed
define(EVENTS_OTHER_EXTS, '.doc .docx .pdf .rtf .txt'); //** rus.02: other file types allowed

(store side) includes\languages\english\extra_definitions\your_template\events_calendar_include_defines.php
define(EVENTS_IMAGE_EXTS, '.jpg .jpeg .png .gif'); //** rus.02: image types allowed
define(EVENTS_OTHER_EXTS, '.doc .docx .pdf .rtf .txt'); //** rus.02: other file types allowed

Question: Why are defines separate? One set for front one set for back...did I miss something? Is there a shared define file between the two?

---

Things I still need to do:

I would like to get the 2nd date to auto fill after spiffy calendar, it is an old script and doesn't make it easy to piggy back onchange/onblur functions...I can do it but it will be tricky, something for a later date.

Would like to move above defines into admin/configure menu (thinking I can have that done this week).

Have to move some of my text into the language define files (this week).

I made some other changes, I just can't remember right now (tired)...if I made a change, it is REMarked.

Should be able to make that other change for you...straight to single events on given date (this week).

---

The functionality should be all there, just cosmetics, testing from others would be greatly appreciated.

Thanks everyone,
Rus

Wow Rus.. You are a rock star!! :yes:

will test when I get home from work tonight.. I'm not coder, but I DO know how to move those defines up to the admin (I have a template I am working on with a BUNCH of admin options), and when I'm testing tonight I'll take a slash at doing that and share the results here (if you don't have it done between now and then)

Thanks, none of what I did happens without the hard work of so many of you before.

One note: my version needs to be installed on top of dw08gm's ec_4_alpha.zip.

Download at: http://www.zen-cart.com/showthread.php?76804-Event-Calendar&p=1193493#post1193493

Rus

dw08gm:

...I am wondering if its not too much to ask whether you could look into this:

When a particular calendar date has only one event, clicking that date in calendar will take you directly to that event, rather than to the event list for that date. ...

Done...

in:
----includes/languages/english/extra_definitions/your_template/events_calendar_include_defines.php
added a define:

// when query returns only 1 event, jump over the event list (false=always show list on single day click)
define(EVENTS_SINGLE_JUMP, true);

in:
----includes/templates/your_template/templates/tpl_events_calendar_default.php
(around line 35) easier to just go ahead and replace everything inside of the if statement (in green):

    $month_= $month;
    $year_= $year;
}
if($_GET['_day'])
{
    $_day=$_GET['_day'];$_month=$_GET['_month'];$_year=$_GET['_year'];
    $ev = $db->Execute("select event_id from ".TABLE_EVENTS_CALENDAR." where DAYOFMONTH(start_date)= '" . $_day . "' and MONTH(start_date) = '" . $_month . "' and YEAR(start_date) = '" . $_year . "' AND language_id = '" . $_SESSION['languages_id'] . "'");
    if(EVENTS_SINGLE_JUMP && $ev->RecordCount() == 1) {
        $single_event = true;
        $select_event = $ev->fields['event_id'];
        $_GET['select_event']=$select_event;
    }
}?>
<div class="centerColumn">
  <h1 class="center"><?php echo HEADING_TITLE ?></h1>
```

That should do it,
Rus

LaCamus:

Done...

Great news. :clap: I am so looking forward to testing.

Just one thing that caught my attention though, and I hope I am not jumping the gun:

define(EVENTS_FILE_MAX_WIDTH, '800'); //** rus.02: for max image width in px, check on uploads, change on review
define(EVENTS_FILE_MAX_HEIGHT,'600'); //** rus.02: for max image height in px, check on uploads, change on review

For fluid and flexible, I usually set only a width or a height, but not both, for particular instances. For events calendar, I am only interested in setting a max width, whereby I would be inclined to set:

define(EVENTS_FILE_MAX_HEIGHT,'');

and expect proportionality to be preserved.

My only concern, however, if both happen to be set, is whether an image will be resized to fit within both bounds simultaneously, whilst also preserving proportionality.

Cheers

LaCamus:

One note: my version needs to be installed on top of dw08gm's ec_4_alpha.zip.

Download at: http://www.zen-cart.com/showthread.php?76804-Event-Calendar&p=1193493#post1193493

This can also be installed on top of Diva's last upload.

This install does not alter any of the core Zen Cart programs. The files can be copied right on top of the old ones. The only acception may be the .htaccess file, if you created a specialized version of your own in the images/events_images folder you may want to compare the two.

Rus

dw08gm:

For fluid and flexible, I usually set only a width or a height, but not both, for particular instances. For events calendar, I am only interested in setting a max width, whereby I would be inclined to set:

define(EVENTS_FILE_MAX_HEIGHT,'');

> 
> and expect proportionality to be preserved.
> 
> My only concern, however, if both happen to be set, is whether an image will be resized to fit within both bounds simultaneously, whilst also preserving proportionality.
> 
> Cheers

Proportionality should be maintained with one, both,  or none.  It is done with a checkbox and is up to the individual (default is always on).  The reason (mainly) for adding the max height is so an error can be detected if they go too big.  Remember I don't force a max anything, they are used as guidelines only to warn the admin who uploaded them.  If the file is detected as being over one of the maxes, the program will show an warning on the preview screen and default the values in the resize boxes to the suggested setting (proportional).  If they want to use these suggested settings they would just click the "resize now" radio button, or they could change them and click the button, or just leave the image oversized.

The only time an image is forced to the max sizes is on the admin side and only in the IMG html tag (not to the file itself)...and it is proportional.  This is done in case the user accidently uploaded an image too large...just so they can view it neatly while adding an event and not have it stretched out causing the bottom browser slide to appear.  No resizing is done on the store side, if they choose not to resize the image it will be shown as it is on disk on the front store.

Think of it like this...they are only guidelines used for viewability and as a warning.  You can remove max width and height (set them to 0) and still allow a resize, just no warning will ever show and the original image will show as written to the disk on the admin side.

I know it sounds confusing, but it should work in every possible scenario anyone would need.

Rus

dw08gm:

...I would be inclined to set:

define(EVENTS_FILE_MAX_HEIGHT,'');

> 
> and expect proportionality to be preserved.
> 
> My only concern, however, if both happen to be set, is whether an image will be resized to fit within both bounds simultaneously, whilst also preserving proportionality.

One more note:  When the auto resizing is used for viewing (and for calculating a suggested size during review) the program looks at the width, if defined max is not 0 and the image is greater than max width then the new width (suggested) becomes max and new height (suggested) is adjusted proportionately.  Then height (after the previous adjustment is made) is checked, if defined max is not 0 and height is greater than max height then new height becomes max and a new width is adjusted proportionately.  This gives me in the end a height and width that are both less than or equal to their maxes while both being proportionate to each other.  All this happens on the admin side only.

So I'm still testing.. so far so good.. there's some layout stuff in the admin I'm working through.. and all these daggone nested tables are a NIGHTMARE to wade through.. Really quickly I changed all the places where the table width was hardcoded to 1080px to simply 100%.. I removed the table border on the preview page.. What I cannot seem to get to work properly is how to widen the preview table so that the image resizing section doesn't wrap the way it does..

Gotta go to work.. will be doing more testing tonight when I get home.. So far so good though.. The IMMEDIATE issues I was having with linking products and categories is GONE!!!!

DivaVocals:

... What I cannot seem to get to work properly is how to widen the preview table so that the image resizing section doesn't wrap the way it does..

Gotta go to work.. will be doing more testing tonight when I get home.. So far so good though.. The IMMEDIATE issues I was having with linking products and categories is GONE!!!!

I don't have any wrapping...not even on my laptop. I see something I have to change...quirk under IE9, shows different in firefox.

LaCamus:

I don't have any wrapping...not even on my laptop. I see something I have to change...quirk under IE9, shows different in firefox.

Yep in Firefox the preview is wrapping the text on the image resizing section. I removed the border because the image was extending outside the table border in the preview..

However looking at this in IE8, (yeah that's what the job has on our desktops) like Firefox, the table on the preview is a little narrow thing BUT it cuts the image off.. and the text doesn't wrap but the display is not right in IE either..

The image preview needs to be set at 85% of the screen width... Not this little narrow thing it is now.. and the rest of the layout needs to just behave..:laugh: I attached a screenprint of what I am seeing and a prototype of my suggestion for the preview layout..

Personally I'd like to see all these tables replaced with divs, but that's my own personal hangup.. :laugh:

My version looks nothing like this, it stretches across the page. The colorful rainbow is the div's for reporting success/warning/info. In firefox when text is empty they are hidden, easy fix.

What I think's going on is you have some default widths for tables or td's that I don't have. Could be coming any of the css's in your package. I will give the tables and their child elements a class and that "should" fix the issue.

LaCamus:

My version looks nothing like this, it stretches across the page. The colorful rainbow is the div's for reporting success/warning/info. In firefox when text is empty they are hidden, easy fix.

What I think's going on is you have some default widths for tables or td's that I don't have. Could be coming any of the css's in your package. I will give the tables and their child elements a class and that "should" fix the issue.

The only thing in my admin stylesheet that is different is this:

/* BOF Added so that the configuration settings displayed will wrap correctly */
   table {border-collapse:collapse; table-layout:fixed;}
   table td {word-wrap:break-word;vertical-align:top;}
/* EOF Added so that the configuration settings displayed will wrap correctly */

This was added for a custom template that I am using.. The template has some configuration settings in Configuration > Layout Settings that were not wrapping correctly so they mucked up the settings display.. so I added this to fix the issue..

DivaVocals:

The only thing in my admin stylesheet that is different is this:

/* BOF Added so that the configuration settings displayed will wrap correctly /
table {border-collapse:collapse; table-layout:fixed;}
table td {word-wrap:break-word;vertical-align:top;}
/ EOF Added so that the configuration settings displayed will wrap correctly */

> 
> This was added for a custom template that I am using.. The template has some configuration settings in Configuration > Layout Settings that were not wrapping correctly so they mucked up the settings display.. so I added this to fix the issue..

It may be the collapse setting, you could try removing both lines temporarily just to test it.  Those settings, the way they are written will apply to all tables and td's that don't have those attributes set.

Now if you remove them and it works I then know and can go in and create those attributes in a class for the tables/td's in the events manager which then will override yours.

fyi: i started taking css out of events manager and putting it in a separate file, same for javascript...this should make the code a little easier to read through.  Being able to flip back and forth between the 3 languages using multiple editor windows really helps speed up the coding process.

LaCamus:

It may be the collapse setting, you could try removing both lines temporarily just to test it. Those settings, the way they are written will apply to all tables and td's that don't have those attributes set.

Now if you remove them and it works I then know and can go in and create those attributes in a class for the tables/td's in the events manager which then will override yours.

fyi: i started taking css out of events manager and putting it in a separate file, same for javascript...this should make the code a little easier to read through. Being able to flip back and forth between the 3 languages using multiple editor windows really helps speed up the coding process.
THAT was going to be my next suggestion.. What's that they say about great minds.. :laugh:

Rus

Re Version 2, I encountered a few problems, all but one relatively minor.

1. Upon resizing a gif or png containing transparent sections, usually outside the margins of non-rectangular shapes, the transparent sections are turned black. For me this is no big deal, as I would normally resize these images prior to uploading, and having onscreen controls to adjust width/height makes this optimisation easy. However, for stores with colorful backgrounds, the blackening affect could look unsavoury.

2. However, the removal of <img class="c1" in tpl_events_calendar_default.php breaks my fluid and flexible design approach, as images are no longer reduced further to fit their enclosing divs. I cannot accept this change as is.

3. In admin\includes\languages\english\events_manager.php, I applied the following changes. :

define('TEXT_EVENT_IMAGE', 'Event Image Info:'); // Event Info File:
define('TEXT_EVENT_NO_IMAGE', 'Unselect Image:'); // remove info file:

The checkbox for TEXT_EVENT_NO_IMAGE does not physically move or delete an image, but only deletes the link in the database. FWIW I like the fact that I can tick this checkbox to unselect an existing image and at the same time upload a replacement image.

4. In tpl_events_calendar_default.php, I added the following snippets in case storeowners wish to prepend the event start and end dates with the weekday ie Thursday April 11, 2013 as opposed to April 11, 2013. This is useful when viewing events beyond the current month, as the sidebox only shows the current calendar month in event view, and could force a customer the look elsewhere for the weekday of the event. To activate, simply rem the upper line and unrem the lower line of each snippet respectively.

          $date_start = date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year));
//          $date_start = zen_date_long($events->fields['start_date']);

            $date_end = date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end));
//            $date_end = zen_date_long($events->fields['end_date']);

Cheers

dw08gm:

4. In tpl_events_calendar_default.php, I added the following snippets in case storeowners wish to prepend the event start and end dates with the weekday ie Thursday April 11, 2013 as opposed to April 11, 2013. This is useful when viewing events beyond the current month, as the sidebox only shows the current calendar month in event view, and could force a customer the look elsewhere for the weekday of the event. To activate, simply rem the upper line and unrem the lower line of each snippet respectively.

      $date_start = date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year));

// $date_start = zen_date_long($events->fields['start_date']);

> 
> 
> ```
            $date_end = date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end));
//            $date_end = zen_date_long($events->fields['end_date']);

Cheers
My suggestion is to turn this into an admin configuration item.. It keeps novice shopowners "out of the code", and ensures that install errors from an errant edit won't happen.. The easiest way to do that is to wrap this code in a conditional statement..

dw08gm:

Rus

Re Version 2, I encountered a few problems, all but one relatively minor.

1. Upon resizing a gif or png containing transparent sections, usually outside the margins of non-rectangular shapes, the transparent sections are turned black. For me this is no big deal, as I would normally resize these images prior to uploading, and having onscreen controls to adjust width/height makes this optimisation easy. However, for stores with colorful backgrounds, the blackening affect could look unsavoury.
   Just researched...others have had issues with this, looks like there is a way to do it from what I am reading. Give me a few days. This is happening to GIF's? or just to PNG's?

2. However, the removal of <img class="c1" in tpl_events_calendar_default.php breaks my fluid and flexible design approach, as images are no longer reduced further to fit their enclosing divs. I cannot accept this change as is.

I meant to talk with you about this...the code as written was:

<!-- Note: closing ' />' for <img> is located in function zen_image -->
      [B]<img class="c1"[/B] <?php echo zen_image(DIR_WS_IMAGES .'events_images/' . $event_array['image'], '', '', 'hspace="0" vspace="0"');?>

What that did was create a reference with 2 open brackets ( <img class="c1" <img ). The zen_image function actually has support for additional parameters. It (probably) should have been written like this:

      <?php echo zen_image(DIR_WS_IMAGES .'events_images/' . $event_array['image'], '', '', '[B]class="c1"[/B] hspace="0" vspace="0"');?>

My new function also supports extra parameters...the existing code as is can be changed to:

echo event_flink_small($event_array['image'], $event_array['title'], '[B]class="c1"[/B] hspace="0" vspace="0"');

3. In admin\includes\languages\english\events_manager.php, I applied the following changes. :

define('TEXT_EVENT_IMAGE', 'Event Image Info:'); // Event Info File:
define('TEXT_EVENT_NO_IMAGE', 'Unselect Image:'); // remove info file:

> 
> The checkbox for TEXT_EVENT_NO_IMAGE does not physically move or delete an image, but only deletes the link in the database. FWIW I like the fact that I can tick this checkbox to unselect an existing image and at the same time upload a replacement image.

Yeah, it is really up to the individual, that's why it is in with the language defines.  I had "Event Info File" because those terms applied to both docs and images.  For the 2nd one, yeah, you are right the way the program works it deselects the file by just deleting the reference in the db.  I don't think the program ever did delete the files.  We could add another option to "delete physical file", it would only work if the deselect was checked...your call.

> 4. In tpl_events_calendar_default.php, I added the following snippets in case storeowners wish to prepend the event start and end dates with the weekday ie Thursday April 11, 2013 as opposed to April 11, 2013. This is useful when viewing events beyond the current month, as the sidebox only shows the current calendar month in event view, and could force a customer the look elsewhere for the weekday of the event. To activate, simply rem the upper line and unrem the lower line of each snippet respectively.
> 
> ```
          $date_start = date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year));
//          $date_start = zen_date_long($events->fields['start_date']);

        $date_end = date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end));

// $date_end = zen_date_long($events->fields['end_date']);

> 
> Cheers
I like that one, good idea:  On my end I made it a dynamic option via the defines file...

[I][B]in /includes/languages/english/extra_definitions/your_template/events_calendar_include_defines.php
added:[/B][/I]
// use long dates (includes day of week) when displaying events
define(EVENTS_LONG_DATES, true);

[I][B]on the two lines above I changed them to:[/B][/I]
$date_start = ( EVENTS_LONG_DATES ? zen_date_long($events->fields['start_date'])
: date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year)) );

        $date_end = ( EVENTS_LONG_DATES ? zen_date_long($events->fields['end_date'])
                                        : date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end)) );

Rus

DivaVocals:

My suggestion is to turn this into an admin configuration item.. It keeps novice shopowners "out of the code", and ensures that install errors from an errant edit won't happen.. The easiest way to do that is to wrap this code in a conditional statement..

Dude! You jumped in front of me...again, you're reading my mind.

LaCamus:

Dude! You jumped in front of me...again, you're reading my mind.

LOL:laugh:

Okay I need to go to bed.. will post my findings from today's adventure with this tomorrow..

LaCamus:

Just researched...others have had issues with this, looks like there is a way to do it from what I am reading. Give me a few days. This is happening to GIF's? or just to PNG's?

Both gif's and png's. Had no trouble with other types, although did not test for docx as I had none at hand.

LaCamus:

My new function also supports extra parameters...the existing code as is can be changed to:

echo event_flink_small($event_array['image'], $event_array['title'], '[B]class="c1"[/B] hspace="0" vspace="0"');

Hopefully this will work. 

> **LaCamus:**
>
> We could add another option to "delete physical file", it would only work if the deselect was checked...your call.

Happy to leave out "delete physical file", as I prefer to do such tasks manually and always after creating a backup.


> **LaCamus:**
>
> I like that one, good idea:  On my end I made it a dynamic option via the defines file...
> ```
[I][B]in /includes/languages/english/extra_definitions/your_template/events_calendar_include_defines.php
added:[/B][/I]
// use long dates (includes day of week) when displaying events
define(EVENTS_LONG_DATES, true);

[I][B]on the two lines above I changed them to:[/B][/I]
          $date_start = ( EVENTS_LONG_DATES ? zen_date_long($events->fields['start_date']) 
                                            : date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year)) );

            $date_end = ( EVENTS_LONG_DATES ? zen_date_long($events->fields['end_date'])
                                            : date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end)) );
```
> 
> Rus

Excellent - will try. 

Re: stripping css and js from events manager.
I largely agree, although I am not adverse to inline css. I can handle the css but am a bit green with js. Should js be shoved into a function file? 

Re: developer attributions
Since you have done so much work upon certain files, I believe it more than fair to give yourself credit as in events_manager_drop_dns.php

Generally, I am standing in awe at your rapid responses and prompt solutions, and feel I should almost check myself for experiencing so much pleasure in our dealings. I have been at this for years and have never gained so much in so short a time.

Cheers