I've attached all the files I've been using in my testing.. I haven't touched the readme because until this is stable, I want to hold off on the readme updates just yet..:smile:
this includes the changes Rus posted to stop the internal manufacturer/categories/products links form opening inside a new page.
Once dw08gm confirms that the fix I posted last night addresses his concerns with the CSS image scaling, this admin setting can be removed:
(NULL, 'Include the IMG tag height and width', 'EVENTS_DISPLAY_IMAGE_WIDTH_HEIGHT', 'true', 'If this option is set to true, the module will include the image\'s native height and width in the IMG tag. This is required to support other user agents (e.g. a speech browser) which should have this information in order to relate it to the user.<br /><br />If you do not wish to include the image\'s native height and width in the IMG tag, set this to false.<br /><br />Default is true.', @t4, 10, NOW(), NULL, 'zen_cfg_select_option(array(\'true\', \'false\'),'),
and this code in includes/templates/custom_template/templates/tpl_events_calendar_default.php:
<!-- **rus.02:start -->
<?php if (EVENTS_DISPLAY_IMAGE_WIDTH_HEIGHT == 'true') { ?>
<?php echo event_flink_small($event_array['image'], $event_array['title'], 'class="event_calendar_image"', true); ?>
<?php } else { ?>
<?php echo event_flink_small($event_array['image'], $event_array['title'], 'class="event_calendar_image"'); ?>
<?php } ?>
<!-- **rus.02:stop -->
can be modified to this:
<!-- **rus.02:start -->
<?php echo event_flink_small($event_array['image'], $event_array['title'], 'class="event_calendar_image"', true); ?>
<!-- **rus.02:stop -->
I've seperated the sidebox stylesheet from the page stylesheet, and named the page stylesheet so that it only loads when on the events page. I've also added additional defines for the short month dropdowns to seperate the page dropdowns from the sidebox dropdowns to includes/languages/english/extra_definitions/events_calendar_include_defines.php as follows:
define('EVENTS_MONTHS_SHORT_SIDEBOX_DROPDOWNS', 'JAN,FEB,MAR,APR,MAY,JUN,JUL,AUG,SEP,OCT,NOV,DEC');
//define('EVENTS_MONTHS_SHORT_SIDEBOX_DROPDOWNS', 'Jan,Feb,Mar,Apr,May,Jun,Jul,Aug,Sep,Oct,Nov,Dec');
define('EVENTS_MONTHS_SHORT_PAGE_DROPDOWNS', 'Jan,Feb,Mar,Apr,May,Jun,Jul,Aug,Sep,Oct,Nov,Dec');
//define('EVENTS_MONTHS_SHORT_PAGE_DROPDOWNS', 'JAN,FEB,MAR,APR,MAY,JUN,JUL,AUG,SEP,OCT,NOV,DEC');
I included BOTH set of options for both so that all a shopowner has to do is uncomment/comment the ones they want to use.. The defaut for the events page as you can see is the titlecase defines, while the sidebox default is the uppercase defines.
to support using these new defines I modified: includes/templates/custom_template/templates/tpl_events_calendar_default.php and includes/templates/custom_template/templates/tpl_events_calendar_include_default.php
DivaVocals:
Okay... despite the fact that I think image scaling can be a performance Achilles heel for a site (which is why I'll personally never use the technique without at LEAST resizing-optimizing images :laugh:), I think I figured out how you can have your cake AND eat it too.. The key is to use height:auto to override any height or width attribute already present on the image.
I modified the following in the stylesheet..
img.event_calendar_image {max-width:100%; margin:0em auto; height: auto;}
>
>
> Now with the IMG height and width, the images still scale correctly on my test site.. (http://zentestcart(dot)overthehillweb(dot)com/index.php?main_page=events_calendar&_day=23&_month=04&_year=2013) I've tested it with the latest versions of IE, Opera, Safari, Firefox, and Chrome. I know that there may still be issues with IE8 and IE7, but I cannot confirm as I cannot test in either of these browsers..
I believe this addresses all concerns raised.. I do have one more thing on resizing, but I'll put that in a separate post..
