Event Calendar v3

dw08gm:

I hope you noticed the image I inserted was square. The displayed result was rectangular shown in portrait.

Is there no other way to provide for accessibility?Haven't seen your site.. so no I didn't notice the image shape..
:smile:

as far as accesibility is concerned, NO there is no other way to do this.. Page readers read the textual code, and the only way to communicate image height and width is via the IMG tag with the height and width. I get what you are trying to do, but you can't use the method you use to do it AND maintain accessibility as you remove the code the readers depend on. (on an aside this is why I used a javascript solution in my template to scale images proportionaly depending on screen size while maintaining acessibility for readers)

[QUOTE=dw08gm;1199720But changing the define to short month changes the sidebox also. I wish to keep the sidebox as short months all in capitals.[/QUOTE]

The only way of doing this is by adding another set of defines for the page dropdowns versus the sidebox dropdowns.. Unless Rus has another idea.. I also wonder if this couldn't be managed via CSS as well.. (I gave that a thought, but never tried it)

DivaVocals:

But isn't the module using the additional links code for files linked to the event?? These files are all internal links..
The code you showed above is for the extra link that you can add to an event. The files (docs & images) are after that. When I wrote the function to serve those docs I used a variable set by Zen Carts that does not use a full url, just the reference to the images directory so http and https will not come into play on these...they will automatically get the same prefix as the page they exist on.

dw08gm:

I hope you noticed the image I inserted was square. The displayed result was rectangular shown in portrait.

Is there no other way to provide for accessibility?I don't know, I've never had to research this. If you can find a way and it takes some code changes (non css) let me know and I'll do whatever you need.

But changing the define to short month changes the sidebox also. I wish to keep the sidebox as short months all in capitals.
I'll let you two hash this out, just let me know what you decide.

DivaVocals:

The only way of doing this is by adding another set of defines for the page dropdowns versus the sidebox dropdowns.. Unless Rus has another idea.. I also wonder if this couldn't be managed via CSS as well.. (I gave that a thought, but never tried it)Take a look at http://php.net/manual/en/function.date.php. We could just use this function and make the date look however you want, make the format string a config variable and the owner can make it whatever they want. Let me know it you want to add the config variable and I'll make the code changes.

LaCamus:

I don't know, I've never had to research this. If you can find a way and it takes some code changes (non css) let me know and I'll do whatever you need.Okay using these configuration settings
**Images
**Image - Use Proportional Images on Products and Categories - 1

**Event Manager
**Automatically re-size event images? - false
Include the IMG tag height and width - false

The images will be resized proportionally exclusively using the CSS settings for the container.

The resulting HTML looks like this:

<!-- **rus.02:start -->
<img src="images/events_images/Chrysanthemum.jpg" alt="de Finibus Bonorum et Malorum" title=" de Finibus Bonorum et Malorum " class="event_calendar_image" /><!-- **rus.02:stop -->

If I use these settings:

**Images
**Image - Use Proportional Images on Products and Categories - 1

**Event Manager
**Automatically re-size event images? - false
Include the IMG tag height and width - true

Then while the images are not overlapping the edges of the inner and outer containers, they are displayed disproportionally

The resulting HTML looks like this:

 
<!-- **rus.02:start -->
 <img src="images/events_images/Chrysanthemum.jpg" alt="de Finibus Bonorum et Malorum" title=" de Finibus Bonorum et Malorum " width="1024" height="768" class="event_calendar_image" /><!-- **rus.02:stop -->

In either case it doesn't matter what my height and width settings are (I left the default settings). It also doesn't matter whether I choose to resize images or not. Since re-sizing happens on upload I also expected this. In either case the Images configuration settings has no effect on the image display within an event (which is what I expected). The ONLY setting that affects the image display is the "Include the IMG tag height and width" setting..

LaCamus:

I'll let you two hash this out, just let me know what you decide.
Well at the risk of being brash, there's isn't a LOT to work out..:laugh: I think there is a pretty simple solution that can be had here.. Allow the page dropdown definitions to be defined differently from the ones in the sidebox dropdown.. this provides shopowners with more flexibility.. Then this module will be like Burger King.. Everyone will be able to have it their way!:laugh:

There's no reason to code this feature just "one way" based on the individual preferences of the participants here.. This module should allow ALL shopowners to set things up the way they prefer. There's no reason to NOT make this flexible for all.. What I want will not be the same as what someone else will want (and I'm thinking from the perspective that all of my clients are not going all want the SAME thing). If we can make this flexible, then it should be flexible.. If this is done with defines, then it can be an additional admin configuration option..

So here's the user requirements (I realize some of these are done, I just want to put it all in context:

1. The module shall include functions to support the display of long OR short month displays in the page and sidebox dropdowns
2. The module shall support the ability for the page dropdown to use a month display different than the sidebox dropdown month display
   (ie: the page dropdown can be set to use the long months whereas the sidebox can be set to use the short months display)
3. The module shall support the ability for variations of the short month display which can be applied to EITHER the page dropdowns or the sidebox dropdowns.
   (ie: BOTH page and sidebox dropdowns are set to use short month displays. However the page dropdown will display the month in all caps [ie: "APR"] and the sidebox dropdown displays the months using title case [ie: "Apr"] )
   This should cover everything and allow everybody to set this up the way they want.. just like at Burger King, you can have it your way!:laugh:

Is there a way to hide the Start and/or End dates?

Fourpaws:

Is there a way to hide the Start and/or End dates?Not without modifying the page file that contains the start and end dates.. The dates appear not only on the events list, but also on the event detail page. Hiding the dates would take a significant amount of editing to accomplish this.. Since this is a events calendar module, the dates are a KEY part of this module. So when you say you want to hide the dates, HOW they are hidden would depend on what dates you are referring to.

Not sure which version you are trying to use, but if you are trying to use the beta version (compatible with Zen Cart v1.5 ONLY) that's been attached to the posts/discussion currently taking place, that version is NOT recommended to be put in use for a live site just yet. If you have read through this support thread you will see we are still testing/tweaking that version..

[QUOTE=DivaVocals;1199792]However the page dropdown will display the month in all caps [ie: "APR"] and the sidebox dropdown displays the months using title case [ie: "Apr"] )[/QUOTE}

Actually I was seeking the dropdowns to display thus
Sidebox = APR, since it is standalone
Page = Apr, since the appended event title text is predominately in lowercase.

However, allowing for all variants is the way to go.

cheers

DivaVocals:

Okay using these configuration settings
**Images
**Image - Use Proportional Images on Products and Categories - 1

**Event Manager
**Automatically re-size event images? - false
Include the IMG tag height and width - false

The images will be resized proportionally exclusively using the CSS settings for the container.

The resulting HTML looks like this:

<img src="images/events_images/Chrysanthemum.jpg" alt="de Finibus Bonorum et Malorum" title=" de Finibus Bonorum et Malorum " class="event_calendar_image" /><!-- **rus.02:stop -->

> 
> 
> If I use these settings:
> 
> **Images
> **Image - Use Proportional Images on Products and Categories - 1 
> 
> **Event Manager
> **Automatically re-size event images? - false 
> Include the IMG tag height and width - true
> 
> Then while the images are not overlapping the edges of the inner and outer containers, they are displayed disproportionally
> 
> The resulting HTML looks like this:
> ```
 
<!-- **rus.02:start -->
 <img src="images/events_images/Chrysanthemum.jpg" alt="de Finibus Bonorum et Malorum" title=" de Finibus Bonorum et Malorum " width="1024" height="768" class="event_calendar_image" /><!-- **rus.02:stop -->

In either case it doesn't matter what my height and width settings are (I left the default settings). It also doesn't matter whether I choose to resize images or not. Since re-sizing happens on upload I also expected this. In either case the Images configuration settings has no effect on the image display within an event (which is what I expected). The ONLY setting that affects the image display is the "Include the IMG tag height and width" setting..

I am really struggling to explain with this phenomena....

The original code, before the introduction of the image manipulation code and before I inadvertantly did the double <img> thing, returned the actual image width and height in px (as listed in view source and as stored in the events_images folder) and, even though the image as displayed on the event page may have been smaller than the actual image size, the proportions were maintained.

This should still be the case after image manipulation, but somehow some function (zen_image, zen_image_OLD or whatever) is distorting this process. My limited understanding of coding prevents from seeing how the image width and height values as collected should not be maintained in whatever code does the proportioning for the display.

Does/can event_flink_small do any proportioning, or is the proportioning entirely dependent upon zen_image/zen_image_OLD?

DivaVocals:

In either case it doesn't matter what my height and width settings are (I left the default settings). It also doesn't matter whether I choose to resize images or not. Since re-sizing happens on upload I also expected this. In either case the Images configuration settings has no effect on the image display within an event (which is what I expected). The ONLY setting that affects the image display is the "Include the IMG tag height and width" setting..

If resizing only happens upon upload, then this needs to be written into the Readme. I am sure, however, that earlier I was able to resize images, both up and down, that were already in the events_images folder, which may or may not have been done when delinking one image for another.

dw08gm:

If resizing only happens upon upload, then this needs to be written into the Readme. I am sure, however, that earlier I was able to resize images, both up and down, that were already in the events_images folder, which may or may not have been done when delinking one image for another.
You CAN re-size images if you edit the event and then choose the re-sizing radio button. Otherwise the size of the image is unaffected by merely changing the settings.. I will adjust the readme and the admin setting explanation to make this clearer.. I still want to make an attempt at adding an auto-installer to eliminate the need for an external SQL file..

dw08gm:

Actually I was seeking the dropdowns to display thus
Sidebox = APR, since it is standalone
Page = Apr, since the appended event title text is predominately in lowercase.

However, allowing for all variants is the way to go.

cheersRight and that works for YOUR situation..:smile: but other shopowners may not want this exact same layout, and in fact may be okay with the way the current settings work. So some flexibility has to be included so everyone can modify this as they wish. Plus, since both dropdowns share the same set of defines, this would require that the page and sidebox would each need a different set of defines so they could be setup differently. barring I can't find a CSS solution.. (not sure that this can be done using ONLY CSS)

dw08gm:

I am really struggling to explain with this phenomena....

The original code, before the introduction of the image manipulation code and before I inadvertantly did the double <img> thing, returned the actual image width and height in px (as listed in view source and as stored in the events_images folder) and, even though the image as displayed on the event page may have been smaller than the actual image size, the proportions were maintained.

This should still be the case after image manipulation, but somehow some function (zen_image, zen_image_OLD or whatever) is distorting this process. My limited understanding of coding prevents from seeing how the image width and height values as collected should not be maintained in whatever code does the proportioning for the display.

Does/can event_flink_small do any proportioning, or is the proportioning entirely dependent upon zen_image/zen_image_OLD?Using the IMG height and width tells the BROWSER what size to display the image. If you use that with the CSS settings that are meant to re-size the image to the container, and the image is larger or smaller than those settings, the images will distort.

If you want the CSS to control the image display size
and
you are NOT going to use the resizing features (the full sized image will be uploaded and left as is)
and
the image is larger (or smaller) than the dimensions of the page container

then you need to remove the height and width from the IMG tag so that the image will not distort, and so the CSS will properly display the image in the correct proportions.

You indicated that you wanted to maintain the ability to upload the full image size and let the CSS do the proportioning and resizing the image display versus explicitly resizing the image upon upload and then telling the browser what those image dimensions are. Rus provided the code to achieve this, and also provided the code for those who were okay with using the resizing features.. If you go back to the posts where Rus introduced this code you will see that this is what he said, and you confirmed that this code worked.. All I did was add a conditional statement so that BOTH options could be used.

DivaVocals:

Using the IMG height and width tells the BROWSER what size to display the image. If you use that with the CSS settings that are meant to re-size the image to the container, and the image is larger or smaller than those settings, the images will distort.

If you want the CSS to control the image display size
and
you are NOT going to use the resizing features (the full sized image will be uploaded and left as is)
and
the image is larger (or smaller) than the dimensions of the page container

then you need to remove the height and width from the IMG tag so that the image will not distort, and so the CSS will properly display the image in the correct proportions.

You indicated that you wanted to maintain the ability to upload the full image size and let the CSS do the proportioning and resizing the image display versus explicitly resizing the image upon upload and then telling the browser what those image dimensions are. Rus provided the code to achieve this, and also provided the code for those who were okay with using the resizing features.. If you go back to the posts where Rus introduced this code you will see that this is what he said, and you confirmed that this code worked.. All I did was add a conditional statement so that BOTH options could be used.

Yes I understood as much, but this is not what I am getting at.

The html image tag <img> puts the actual width and height values on the page, presumably in that order. My code does not change those values, but preserves the actual values on screen, even though the image is resized by css, while proportion is maintained.

Both zen_image and zen_image_OLD utilise <img> and both also use CONFIG_CALCULATE_IMAGE_SIZE to determine image size. But zen_image says if PROPORTIONAL_IMAGES_STATUS = 0, then use zen_image_OLD, otherwise stay with zen_image. But my site needs PROPORTIONAL_IMAGES_STATUS = 1 to correctly proportion product images, so theoretically we should be using zen_image. However, using zen_image and PROPORTIONAL_IMAGES_STATUS = 1 causes the event images to distort, while forcing zen_image_OLD and setting PROPORTIONAL_IMAGES_STATUS = 1, the event images are displayed in proportion. That is, until the call to display width and height values is made, whereupon the event image is once again distorted. But using zen_image with PROPORTIONAL_IMAGES_STATUS = 1 and displaying width and height values distorts the events images

Enough to drive one mad. This is why I suspect something in this arrangement is a-about.

Maybe the answer is to do away with zen_image and zen_image_OLD altogether in events calendar and just use the <img> tag, which could also dispense with the need for an admin switch to display the width and height.

Does this makes sense.

dw08gm:

Yes I understood as much, but this is not what I am getting at.

The html image tag <img> puts the actual width and height values on the page, presumably in that order. My code does not change those values, but preserves the actual values on screen, even though the image is resized by css, while proportion is maintained.

Both zen_image and zen_image_OLD utilise <img> and both also use CONFIG_CALCULATE_IMAGE_SIZE to determine image size. But zen_image says if PROPORTIONAL_IMAGES_STATUS = 0, then use zen_image_OLD, otherwise stay with zen_image. But my site needs PROPORTIONAL_IMAGES_STATUS = 1 to correctly proportion product images, so theoretically we should be using zen_image. However, using zen_image and PROPORTIONAL_IMAGES_STATUS = 1 causes the event images to distort, while forcing zen_image_OLD and setting PROPORTIONAL_IMAGES_STATUS = 1, the event images are displayed in proportion. That is, until the call to display width and height values is made, whereupon the event image is once again distorted. But using zen_image with PROPORTIONAL_IMAGES_STATUS = 1 and displaying width and height values distorts the events images

Enough to drive one mad. This is why I suspect something in this arrangement is a-about.

Maybe the answer is to do away with zen_image and zen_image_OLD altogether in events calendar and just use the <img> tag, which could also dispense with the need for an admin switch to display the width and height.

Does this makes sense.

Sorry no.. :laugh:

If I upload animage and choose NOT to resize it

AND

I leave the PROPORTIONAL_IMAGES_STATUS = 1

AND

I simply turn on the call for the IMG height/width

then the images distort..

If I turn off the call for the IMG height/width then the images DO NOT distort and disply correctly..

Honestly speaking, I'm not clear what it is you think is wrong as it seems to do what you have been suggesing (upload the full sized image and NOT use the resizing, and then let the CSS drive the image proportions) Perhaps if we understood this we can get towards a solution.. I do not think that we should do away with zen_image.. I think we need to figure out what it is you are trying to achieve here.. The current settings appear to do that, but clearly you don't think so.. Getting down to WHY you think this is will help get towards a solution that is flexible for ALL..

One other thing I noticed.. the includes/templates/custom_template/css/stylesheet_events_calendar.css loads on EVERY page. This should probably be a page specific CSS file so that it ONLY loads on the events calendar pages.. So I suggest that this file be renamed includes/templates/custom_template/css/events_calendar.css so it only loads on the events calendar pages.

DivaVocals:

Sorry no.. :laugh:

If I upload animage and choose NOT to resize it

AND

I leave the PROPORTIONAL_IMAGES_STATUS = 1

AND

I simply turn on the call for the IMG height/width

then the images distort..

If I turn off the call for the IMG height/width then the images DO NOT distort and disply correctly..

Honestly speaking, I'm not clear what it is you think is wrong as it seems to do what you have been suggesing (upload the full sized image and NOT use the resizing, and then let the CSS drive the image proportions) Perhaps if we understood this we can get towards a solution.. I do not think that we should do away with zen_image.. I think we need to figure out what it is you are trying to achieve here.. The current settings appear to do that, but clearly you don't think so.. Getting down to WHY you think this is will help get towards a solution that is flexible for ALL..

Resizing is an admin event_manager function and is completely separate to the display of event images in event calendar.

DivaVocals:

One other thing I noticed.. the includes/templates/custom_template/css/stylesheet_events_calendar.css loads on EVERY page. This should probably be a page specific CSS file so that it ONLY loads on the events calendar pages.. So I suggest that this file be renamed includes/templates/custom_template/css/events_calendar.css so it only loads on the events calendar pages.

Interesting thought, will try.

stylesheet_events_calendar.css was inherited from the very first version 1.01, presumedly so-named because it also contains sidebox setting that load on every page.

dw08gm:

Interesting thought, will try.

stylesheet_events_calendar.css was inherited from the very first version 1.01, presumedly so-named because it also contains sidebox setting that load on every page.

Ahhhhhh okay.. forgot about the sidebox.. So we COULD consider seperating the sidebox stylesheet from the page stylesheet..