Event Calendar v3

I apologize for the additional post.. My last one expired..

Small change I made the the fileset structure:

I moved this file:
/includes/languages/english/extra_definitions/YOUR_TEMPLATE/events_calendar_include_defines.php

to here:
/includes/languages/english/extra_definitions/events_calendar_include_defines.php

There's no need for an override for this file since this is NOT a default Zen Cart file. Any shopowner who makes changes to this file certainly SHOULD create an override for it, but the Events Calendar fileset doesn't need to put it in a template override folder..

Hi just checking in.. still doing some cleanup before I post up the fileset I've been testing off of..

• Removing all of the deprecated and comment out code
• Removing the closing "?>" from files where appropriate (there's a Zen Cart FAQ that explains why this is okay)
• I'm cleaning up the top section of the files to line up with other Zen Cart files and to appropriately credit modifiers of the files (specifically to add Rus and myself where appropriate)

Once I finish all of this, I will run through all of my test cases again to be sure that I didn't break anything in my file cleanup. Then I will post the fileset I'm testing from for the group to throw darts at..:laugh:

I'm at a stopping point in this effort. (I'm off to a Mustang open house where I'll be showing off my 600HP Supercharged baby!). I will wrap this up and post my files later tonight.. (dw08gm will be in bed by then:laugh:)

Yes I did see this which is why I modified the dropdown define that appears on the Events page. The admin setting for the long/short months dropdown implies it applies to ALL dropdowns. So to make the results of this setting consistent in the UI, I changed the define being used on the Events page dropdown.. Otherwise we would need to add a THIRD define for the Events page dropdown to separate it from the sidebox month dropdown. (see the images I attached)Here's the problem...that setting affects the year calendar titles as well. Let's do this....we can go ahead and make these changes:

1. Put the line you changed back to use the ...TITLES flag.
2. setup a new array for the drop down.
   ...the code at the top of tpl_events_calendar_default.php will look like this:

$cal = new Calendar;
$cal->setMonthNames(explode(",", ([B]EVENTS_LONG_MONTHS_TITLES[/B] ? EVENTS_MONTHS_LONG : EVENTS_MONTHS_SHORT)));  //**rus: via diva: add
$cal->setDayNames(explode(",", EVENTS_WEEKDAY_FIRST_CHARS));   //**rus:add
[B]$dd_months = explode(",", (EVENTS_LONG_MONTHS_DROPDOWNS ? EVENTS_MONTHS_LONG : EVENTS_MONTHS_SHORT));       //**rus: new[/B]
$cal->setStartDay(FIRST_DAY_OF_WEEK);
```3) now use the new array in the drop down (around line 84):```
      while (!$q_events->EOF) {
	    $year = $q_events->fields['year'];
        $month = $q_events->fields['month'];
        $day = $q_events->fields['day'];
        $event_array[] = array('id' => $q_events->fields['event_id'], 'text' => [B]$dd_months[$month - 1][/B] . ' ' . $day . ' - ' . $q_events->fields['title']);  //**rus:changed
        $q_events->MoveNext();
      }

Now for the bug...that query around line 74, change "date('Y-m-d H:i:s')" to "date('Y-m-d')". This is the same issue we had with the query I changed when I first joined. The start_date in the db doesn't use a time so we shouldn't compare it to the current date & time (just the date). ```
$q_events = $db->Execute("select *, DAYOFMONTH(start_date) AS day, MONTH(start_date) AS month, YEAR(start_date) AS year"
. " from ".TABLE_EVENTS_CALENDAR." where start_date >= '" .[B] date('Y-m-d')[/B] . "' and language_id = '" . $_SESSION['languages_id'] . "'"
. " order by start_date");

Thanks,
Rus

DivaVocals:

Small change I made the the fileset structure:

I moved this file:
/includes/languages/english/extra_definitions/YOUR_TEMPLATE/events_calendar_include_defines.php

to here:
/includes/languages/english/extra_definitions/events_calendar_include_defines.php

There's no need for an override for this file since this is NOT a default Zen Cart file. Any shopowner who makes changes to this file certainly SHOULD create an override for it, but the Events Calendar fileset doesn't need to put it in a template override folder..

Nod...in truth everything that has a unique filename should be moved out of "your_template" and into the default directories. "Your_template" overrides are set aside for when someone wants to change what we release as the default module...that includes the tpl files.

LaCamus:

Here's the problem...that setting affects the year calendar titles as well. Let's do this....we can go ahead and make these changes:

1. Put the line you changed back to use the ...TITLES flag.
2. setup a new array for the drop down.
   ...the code at the top of tpl_events_calendar_default.php will look like this:

$cal = new Calendar;
$cal->setMonthNames(explode(",", ([B]EVENTS_LONG_MONTHS_TITLES[/B] ? EVENTS_MONTHS_LONG : EVENTS_MONTHS_SHORT))); //**rus: via diva: add
$cal->setDayNames(explode(",", EVENTS_WEEKDAY_FIRST_CHARS)); //**rus:add
[B]$dd_months = explode(",", (EVENTS_LONG_MONTHS_DROPDOWNS ? EVENTS_MONTHS_LONG : EVENTS_MONTHS_SHORT)); //**rus: new[/B]
$cal->setStartDay(FIRST_DAY_OF_WEEK);
3) now use the new array in the drop down (around line 84):
while (!$q_events->EOF) {
$year = $q_events->fields['year'];
$month = $q_events->fields['month'];
$day = $q_events->fields['day'];
$event_array[] = array('id' => $q_events->fields['event_id'], 'text' => [B]$dd_months[$month - 1][/B] . ' ' . $day . ' - ' . $q_events->fields['title']); //**rus:changed
$q_events->MoveNext();
}

> 
> Now for the bug...that query around line 74, change "date('Y-m-d H:i:s')" to "date('Y-m-d')".  This is the same issue we had with the query I changed when I first joined.  The start_date in the db doesn't use a time so we shouldn't compare it to the current date & time (just the date). ```
    $q_events = $db->Execute("select *, DAYOFMONTH(start_date) AS day, MONTH(start_date) AS month, YEAR(start_date) AS year"
    . " from ".TABLE_EVENTS_CALENDAR." where start_date >= '" .[B] date('Y-m-d')[/B] . "' and language_id = '" . $_SESSION['languages_id'] . "'"
    . " order by start_date");

Thanks,
Rus

Yep.. All of this did the trick.. Fixed the bug.. fixed the dropdowns so they are consistent on the Events page and sidebox..

Returned about an hour ago (10pm) and found no-one here - home alone. :(.

Re: iFrame
IIRC this is only required to update the display of the sidebox calendar month without having to update entire page. However, clicking any other link in the sidebox will require the main column to also be updated. As is, the iframe does not present any siginificant problems to me ATM, especially as core zencart utilises iFrames in other areas, and with Rus improving the loading/buffering, this may be all that is needed to serve well into the future.

Re: Supercharged baby.
I regularly dream of 3D-printing a candy-colored, tangerine-flaked, multi-mini-jet-powered streamlined baby with metal-storm cannons, and tonight may be no exception.

Cheers

dw08gm:

Returned about an hour ago (10pm) and found no-one here - home alone. :(.

Re: iFrame
IIRC this is only required to update the display of the sidebox calendar month without having to update entire page. However, clicking any other link in the sidebox will require the main column to also be updated. As is, the iframe does not present any siginificant problems to me ATM, especially as core zencart utilises iFrames in other areas, and with Rus improving the loading/buffering, this may be all that is needed to serve well into the future.Awwwwwww... we didn't leave you alone on purpose..:hug: We left snacks in the fridge though if that helps..:laugh:

My concern is not the iframe itself, but the fact that in the background it is loading the entire page and then hiding the headers and such.. THAT alone could present a performance issue for some servers.. Plus all those extra calls to display and hide content seems somewhat unnecessary.. If that alone could be improved that can't be a bad thing right??:smile:

dw08gm:

Re: Supercharged baby.
I regularly dream of 3D-printing a candy-colored, tangerine-flaked, multi-mini-jet-powered streamlined baby with metal-storm cannons, and tonight may be no exception.

CheersWell my baby was the queen of the ball yesterday.. She was one of the SHOWCASE vehicles at the open house.. Made her mama proud!:laugh:

I have to head off to a client meeting this morning.. Just wanted to let ya'll know I'm still testing & cleaning up stuff.. I found a few more defines that need to be added to the setting script.. So I will need to run my test scripts again against these new changes.. Hoping to be able to get my files submitted for the review of the group later tonight..

Update:
Removed the following define from includes/languages/english/events_calendar.php

define('MAX_DISPLAY_PAGE_LINKS', 5);

**Reason: **This is a duplicate of a an existing default Zen Cart admin configuration setting and this define is used ALL OVER Zen Cart. There is no reason to keep this define setting as it is already controlled in the admin settings. I suspect this is leftovers from this modules Zen Cart 1.3.7 roots that never got pulled out as it should have been.

Removed the following define from includes/languages/english/events_calendar.php

define('TEXT_DISPLAY_NUMBER_OF_EVENTS', 'Displaying event nB0 <b>%d</b><b>%_</b> of <b>%d</b>');

**Reason: **This define is not being used ANYWHERE in the Events Calendar module. Again, I suspect this is leftovers from this modules Zen Cart 1.3.7 roots that never got pulled out as it should have been.

I modified the following from includes/languages/english/events_calendar.php

define('TEXT_DISPLAY_NUMBER_OF_PAGES', 'Displaying <b>%d</b> to <b>%d</b> (of <b>%d</b> events) ');

to read

define('TEXT_DISPLAY_NUMBER_OF_EVENTS', 'Displaying <b>%d</b> to <b>%d</b> (of <b>%d</b> events) ');

**Reason: **The TEXT_DISPLAY_NUMBER_OF_PAGES define is a duplicate of another existing Zen Cart define for the EZ Pages. (YOUR_ADMIN/includes/languages/english/ezpages.php) Though this doesn't appear to be problematic, to avoid ANY possible issues, it makes sense that the Events Calendar module should use it's OWN unique define.

In support of this I edited: includes/modules/events_calendar_listing.php and replaced all instances of TEXT_DISPLAY_NUMBER_OF_PAGES with TEXT_DISPLAY_NUMBER_OF_EVENTS

I'm making on more pass through all the language defines to make sure that I've moved out all of the defines that should be in the admin settings menu, and still doing more regression testing.. But I think we are really nearly here..

I do have one question.. Did we NOT want a start and end TIME for events???

More tweaks:

Modified: YOUR_ADMIN/includes/languages/english/extra_definitions/events_manager.php
changed this:

    define('FILENAME_EVENTS_MANAGER', 'events_manager.php');

to this:

    define('FILENAME_EVENTS_MANAGER', 'events_manager');

**Reason: **Whenever a user profile other than super-user tries to access "Events Manager" under the "Extras" menu, the system will display this message:

Sorry, your security clearance does not allow you to access this resource.
Please contact your site administrator if you believe this to be incorrect.
Sorry for any inconvenience.

Now taking a pass at cleaning up inline styles and tweaking/cleaning up the shop-side CSS file. Where appropriate I have moved inline styles to the stylesheet (where they should be housed).

• I seperated the event single view description class from the events list description class. This will give shopowers a ton more flexibility Since the labels/headings on these two views already had seperate classes this made sense to include.
• I have removed ALL of the CSS that looks specific to the person or persons who updated this module in the past (font colors, background, etc). Individual shop owners have PLENTY of freedom to modify the look/feel of the single event or event listings views using the CSS file that comes with this module. In my own testing many of these "default" CSS rules were in direct conflict with my store's own template, and I can imagine that this too will be an issue for others.. This of course doesn't preclude a shopowner from modifying the look and feel of the Events Calendar pages. The Events Calendar stylesheet should be where they do it.
• the "xbackground" etc rules have all been removed - This is something people do instead of using css comments to nullify a rule when testing or building pages. It is surely not good practice and just results in invalid css, and it looks ike many of these invalid rules were left in the CSS file.

Gotta go start Sunday dinner.. Will be back at this in a few hours..

DivaVocals:

I do have one question.. Did we NOT want a start and end TIME for events???

Start/End times are OK for single day events, but when there are long breaks say for lunch, or a signle event comprises a series of progressive events (eg dinner party), or an event runs over two or more days with different start/end times each day, it becomes problematic. To resolve this, I use a mini-table (one prepared earlier) that can be simply copy/pasted into and edited in the description section. I also do a similar thing with certain event posters setup as proformas.

However, I am not saying it cannot be done, but that attempting such may extend the current development of this mod somewhat. At this stage, it maybe better to leave it for a latter upgrade.

Cheers

dw08gm:

Start/End times are OK for single day events, but when there are long breaks say for lunch, or a signle event comprises a series of progressive events (eg dinner party), or an event runs over two or more days with different start/end times each day, it becomes problematic. To resolve this, I use a mini-table (one prepared earlier) that can be simply copy/pasted into and edited in the description section. I also do a similar thing with certain event posters setup as proformas.

However, I am not saying it cannot be done, but that attempting such may extend the current development of this mod somewhat. At this stage, it maybe better to leave it for a latter upgrade.

Cheers

I understand that I can use the description to add this information, but it would be nice if there were simple start and end time fields (ie: Starts at 8am and Ends at 5pm).. I wasn't suggesting it for NOW.. I was simply inquiring why it's never been included..

The mechanism this module now uses for creating recurring events wouldn't make this at all problematic since all it really does is create multiple events based on specific parameters and because of this it's easy enough to edit the start and end times for an event that spans over several days where the hours for one or more days of a multi-day event may be different from other days of the multi-day event... I'm not concerned about adding lunch breaks etc because other apps in this class (events managers) do not typically include this when you enter start and end times. Breaks and stuff could be specified by including an itinerary in the event description.

For my own personal use I will probably take a stab at adding simple text fields with a start and end time..

DivaVocals:

More tweaks:

The mod inherited lots of deliquent things and needs someone way above my paygrade to fix.

Cheers

DivaVocals:

The mechanism this module now uses for creating recurring events wouldn't make this at all problematic since all it really does is create multiple events based on specific parameters and because of this it's easy enough to edit the start and end times for an event that spans over several days where the hours for one or more days of a multi-day event may be different from other days of the multi-day event... I'm not concerned about adding lunch breaks etc because other apps in this class (events managers) do not typically include this when you enter start and end times. Breaks and stuff could be specified by including an itinerary in the event description.

Yes, which ultimately would allow vendors to sell tickets and other products for each part or various stages of an event. However, for the inital promotion of a multi-staged event, the public would still like to see one overview of the entire event, eg for booking travel/accommodation months in advance, and could get cheesed if the event information was spread out too much and they happened to miss part of the main event because the details were listed elsewhere. The additional link(s) can provide details for each part or various stages of an event.

Cheers

dw08gm:

Yes, which ultimately would allow vendors to sell tickets and other products for each part or various stages of an event. However, for the inital promotion of a multi-staged event, the public would still like to see one overview of the entire event, eg for booking travel/accommodation months in advance, and could get cheesed if the event information was spread out too much and they happened to miss part of the main event because the details were listed elsewhere. The additional link(s) can provide details for each part or various stages of an event.

CheersThough Rus has added some nice features, enhanced others and fixed existing ones, this module isn't really setup for creating a TRUE multiple day event. Now the recurring event feature Rus created can be used to create something which resembles a multi-day event, but in reality it really only creates multiple single events.

For that reason one would need to include an itinerary in the description.

That this add-on cannot show the itinerary of a multi-day event has nothing to do with adding start and end times to this add-on.

For other apps in this same class of apps they do not include time fields for things like breaks etc.. they include simple start and end times for each day of a multi-day event. So when you create an events that span multiples days, one would simply include the start/end time that particular day's activities. Adding start and end time fields in this add-on for an event has nothing really to do with showing a full schedule for a multi-day event as this add-on doesn't truly support multiple day events.. Adding start/end times is one thing adding full support for multi-day events (like showing the itinerary) is a different beast..

Okay here's the (mostly) cleaned scrubbed tested to death version that includes all of Rus' recent changes and mine as well..

The readme file has been created and is also included..

One last bug I found that is kinda a showstopper IMHO..

The product/manufacturer/categories links open inside a new window/tab which is silly. Internal links should simply open in the current window.. I've gone though every file that had target="_blank" and target=_blank and no dice.. I can't get this to stop happening and I can't figure out why.. See this page to see what I mean..
http://zentestcart(dot)overthehillweb(dot)com/index.php?main_page=events_calendar&select_event=1

Times, like location/directions/maps, available amenities, pre-requisites and such, are at a level of detail below the inital function of promoting "dates" in calendar format.

The recurring event feature was never intended to break up events into smaller components, but only to make it easier to input mulitple events of similar character.

As currently developed, the calendar is sufficiently flexible to provide for all manner of details, while not requiring vendors to input levels of detail they may or may not wish to provide.

Cheers

DivaVocals:

Okay here's the (mostly) cleaned scrubbed tested to death version that includes all of Rus' recent changes and mine as well..

The readme file has been created and is also included..

I have been so looking forward to this moment. Immense thanks.

DivaVocals:

One last bug I found that is kinda a showstopper IMHO..

The product/manufacturer/categories links open inside a new window/tab which is silly. Internal links should simply open in the current window.. I've gone though every file that had target="_blank" and target=_blank and no dice.. I can't get this to stop happening and I can't figure out why.. See this page to see what I mean..
http://zentestcart(dot)overthehillweb(dot)com/index.php?main_page=events_calendar&select_event=1

I never really liked forced target_blanks, since I prefered to do same with my right-mouse-button. Now that the month/year sidebox dropdown selection has been retained, target_blanks could be removed altogether without a worry. Will look into this problem though.

One thing I noticed with my recent upgrade to FF20 is that FF has added such a myriad of additional links to the right-mouse-button that the options now exceed the height of my screen, and which makes selecting "open in new window/tab" a veritable pain to find. This could be peculiar to my PC, but it annoys me no end.

Cheers

dw08gm:

As currently developed, the calendar is sufficiently flexible to provide for all manner of details, while not requiring vendors to input levels of detail they may or may not wish to provide.

Cheers

To provide some examples of flexibility:

i) public holidays theoretically extend from midnight to midnight, but for most really extend from close of business the day before to opening of business the day after. Although not controlled by a particular shopowner (although some churches may be exceptions), a shopowner can still seek to sell certain products catering to that event.

ii)likewise, with that meteor expected to come close to Earth in November 2013, the exact date and time may not be accurately known at this point in time, but this does not preclude a shopowner from trying to sell certain products ahead of that event.

cheers