Further to my reply I can tell I've added Image Handler, Mailbeez, gift wrapping, Light box, COWOA, facebook_like_button, jscroller_sidebox etc.
Kim
Printable View
Further to my reply I can tell I've added Image Handler, Mailbeez, gift wrapping, Light box, COWOA, facebook_like_button, jscroller_sidebox etc.
Kim
Hi all,
I'm currently starting up a new business where I'd like to have a Discount Coupons for new prospect customers.
The idea is to print 250-500 Coupon-ID's on 85x54mm vcards and distribute them on fairs, clinics, etc....
So my question is:
Is there a simple way to generate 250 codes in a row and were all coupons have the same properties? (1 € discount per coupon for example).
Thanks a lot for all ideas
Best regards,
Michael
Hi
I have created a discount coupon called "summer specials" which I uploaded when I created the discount coupon in the admin. But when I email it to the customers the discount coupon that I uploaded does not appear in the email. The customer only gets the discount coupon code and other details but not the actual coupon ie the coupon image does not display. How can I do this? I appreciate your help.
estore
After lots of hunting and not finding the answer, I'm hoping someone can tell me if I'm doing something wrong, or if what I want to do isn't possible.
Situation: We give away complementary tickets, and would like to do so by giving a coupon code so the recipient can pick which show they go to.
I've set up a coupon code with top level deny, a category allow, and several products in that category to deny (so the coupon can only be used against certain shows, not the sell-out shows).
In testing, I've found that:
Fixed value of $40 for four tickets: user could buy one ticket and a sweatshirt and the coupon would apply to both
Percentage value of 100%: coupon only applies to the specified product, but not limited to quantity of four.
Am I missing something, or is this something I need to code up?
Also, I see the SQL records in the coupons table for restrict_to_products and restrict_to_categories. Are these used, or reserved for future use?
Thanks
@carlvt88, you can restrict your coupon to certain products if that's what you want to do. Use the "Restrictions" button after going to admin->gift certificate->coupon admin and selecting your coupon. It's on the right hand side on the second row of buttons.
That's what I'm trying to do, but it doesn't seem to be working. I've set the top category to deny, the allow the evening shows, except for Friday 10/19 at 8pm:
Attachment 11197
But when I place an order, the coupon (fixed value) appears to apply to all products in the cart:
Attachment 11198
This is with version 1.5.0
Am I looking at this wrong?
Thanks,
Carl
Just tested, works fine in a clean copy of 1.5.0. Check your copy of includes/modules/order_total/ot_coupon.php.
Sorry, I missed the fact that it was a fixed value coupon. I see what you're trying to do but you can't do that with coupons.
Another option would be a certain percent off the evening shows with a minimum order.
Scott, thanks for taking a look at this.
I can fix this, that is, make it do what I want by adding a line in ot_coupon.php line 421:
But, I don't know if this is a bug, or if this is intended operation and I just happen to want something unusual. Any idea on this? Why would it apply the entire coupon against products that are restricted?Code:case 'F':
$od_amount['total'] = zen_round($coupon->fields['coupon_amount'] * ($orderTotalDetails['orderTotal']>0), $currencyDecimalPlaces);
$od_amount['type'] = $coupon->fields['coupon_type']; // amount off 'F' or amount off and free shipping 'O'
if ($od_amount['total'] > $orderTotalDetails['orderTotal']) $od_amount['total'] = $orderTotalDetails['orderTotal'];
Also, I'm guessing that there's a typo in functions_general.php line 830 - should say '===' instead of '==' in the first if ($allow_for_category) statement
No. In the case of string comparisons such as against the string 'none', the use of == and === are synonymous. In the context of this present discussion, it's moot. Unrelated.Quote:
Originally Posted by carlvt88
Hi Guys. I need some help with this.
Is there anyway to have one or the other on the discount codes / gift vouchers.
To explain what I mean, for example:
A customer places a £30 order. She has a £6 gift certificate and also a 20% off code.
Is there anyway to allow ONE of the ways. Not both.
Thanks.
You'd have to customize it to work this way; nothing is built in.
Ok Thanks SWGuy! Do you know what files I would have to change?
Thanks.
Is this still the issue, or has this been reconsidered in an update since? I have a coupon code that I use weekly and accidently deleted it. If the case is that you cannot reactivate, nor completely delete, nor create another coupon with same code, what files would I go into to remove the information of the coupon code so that I may create another one exactly the same? Basically tricking the cart into thinking there was never that code and completely removing it.Quote:
Originally Posted by Ajeh
Please let me know.
Thanks!
If you look at the Inactive Coupons, does it show?
If so ... is the only thing that happened to the Discount Coupon that you accidentally marked it Inactive?
Or ... did you delete it from the database in another manner such as through phpMyAdmin?
hi guys. i can't seem to find answer to this scenario.
we are trying to give one certain item discounted for the full amount of the product price (say $25.00), if someone uses a coupon and spends $50. this doesn't seem to be working.
i restricted all categories, and allowed only that certain product in coupon restriction. and in coupon i set up coupon amount 25.00 and minimum order $50. Now when i fill my cart up to $100 including this item, it shows that you must spend $50.00 and rejects the coupon.
coupon works only if i set coupon minimum amount to $25.00 and discounted amount to $25.00 with same restrictions above.
is there a workaround?
using zen-cart 1.5.0
thanks.
You could try this ot_coupon.php and see if it accomplishes what you are looking for ...
Ajeh, you are incredible!, thank you!
I do have my moments ... :smile:
Remember the Zen Cart Team when you are rich and famous!
Site is Zen Cart v1.5.0. No other issues.. Site has been running smoothly for MONTHS and this is something newly discovered.. Is this a bug or the sign of another issue???
It isn't a bug so much as most want Discount Coupons with restrictions and minimums to be based on what is allowed ...
Some, however, want the minimum based on the whole order while the restrictions are on the Products allowed ...
The changes I posted make it that minimums on Discount Coupons are based on the whole order total rather than the restricted products total only ...
Thanks for being Johnny on the spot as usual Linda!!:hug:Quote:
Originally Posted by Ajeh
I apologize for being a PITA here.. I'm on a mobile browser via a smartphone and the interface makes searching the thread a tad challenging to say the least.. Can you guide me to the changes you speak of..
and just so that I'm clear if the coupon is ONLY for free shipping for the WHOLE order (no other restrictions nor other discounts), will these changes you refer to allow my client to see the free shipping coupons when they view the "Active Coupons" filter?? (right now the only way to see these "shipping only" coupons is by changing the filer to "All Coupons")
I am not following on why your Free Shipping Discount Coupons, if active, do not show in the Active Coupons setting ...
What settings are you using on the Discount Coupon?
Unless a Discount Coupon is marked as not being active, then it should show ... otherwise, you would need to find it under Inactive Coupons or All Coupons ...
I'm not sure why these particular coupons are not showing up either Linda.. But for this client any coupons which are ONLY free shipping coupons do not show up in the "Active Coupons" display.. These coupons are configured with no other discounts included in these coupons, only the free shipping checkbox is checked. We can only see them in the "All Coupons" display.. They are not expired (it was the first thing I checked when the client reported this last night), and customers are able to use the coupon code with no issues there either.. We just can't see these coupons in the "Active Coupons" list in the admin..Quote:
Originally Posted by Ajeh
Could you post the settings used for one of these Free Shipping Discount Coupons so that I can try to make one?
Yep.. I've asked my client to send those to me.. In the meantime I was trying to recreate the issu on a test site and found a coupon showing in the "Active Coupons" listing that should NOT be there..Quote:
Originally Posted by Ajeh
Why would this one appear as an active coupon?? It has LONG since expired..Quote:
Coupon Name :: LDVPRICE
Coupon Amount :: 10.0000%
Start Date :: 05/07/2012
End Date :: 05/14/2012
Uses per Coupon :: Unlimited
Uses per Customer :: Unlimited
Valid Product List :: --none--
Valid Categories List :: --none--
Date Created :: 05/07/2012
Date Modified :: 05/07/2012
While the dates are expired and they will prevent them from being used ...
Discount Coupons are not deactivated unless the Admin deactivates them as this allows the Admin to readily see those out of date and decide to delete (deactivate) them or save for later use ...
Got it.. So it's considered ACTIVE for the filter based on the coupon status not the date.. So is it the dates or status (or BOTH) that prevents customers from using a coupon..Quote:
Originally Posted by Ajeh
The date and status will control if a Discount Coupon is available for use ...
Next, there are the number of uses per coupon and number of uses per customer ...
Then, qualifiers on category/product restrictions and zones ...
Understood.. As soon as my client sends me those settings (Can get them from the tiny mobile device) I will post them for your analysis..:smile:Quote:
Originally Posted by Ajeh
Thanks .. I have not been able to duplicate this yet, but I will fool with it some more ... :lookaroun
I don't know if this has been covered but it's probably worth mentioning again since it just took me a couple hours to figure it out. If you don't have the Master Category set (i.e. "Invalid Master Category") on any of your products the Top = Deny restriction for coupons doesn't work for them!
This really shows up if you set up a % discount coupon. It will be applied to *everything* in the cart without a Master Category ID, not just the "approved" items! This can really kill your profit margin if you don't notice it. Fair warning!
Regards,
Scott
www.bumboatonline.com
All Products need a master_categories_id or things are not going to work right ...
Are you importing your Products?
If so, are you using any Linked Products?
Hi! Yes and yes. When you import your items (via EP) the MCID isn't set. So I had to use the Multi-category Link Mgr to set Master Cat for every sub-category in my store. A pain but it only took about 45 minutes. (Yeah, I have a LOT of categories)Quote:
Originally Posted by Ajeh
After setting the master_categories_id you might also want to run from the Tools ... Store Manager ... the setting for:
NOTE: while there is a setting also for updating the master_categories_id on the Store Manager, that may or may not work for you due to the Linked Products that you are using, so you would need to experiment with it to see if it is a help or a hinderence ...Quote:
Update ALL Products Price Sorter
to be able to sort by displayed prices:
I would like to offer to newly registered people a coupon code on facebook, that they can add during the registration into Referred box and to be able to use the code on their first time purchase. When i do it the way default is set (Admin/customers details/Customer referral status-2, Admin/GV Coupons/Set New signup discount coupon ID #) and then test it as a not first timer (a person that already had several orders before) i am able to add the coupon code at the end, and it gives me a discount. But not first time customer should not be able to get the discount that is offered for new registered people. How i can exclude customers with purchase to use this particular coupon? thanks.
zen-cart 1.5.1
You might check this thread and adapt as needed for what you are trying to do ...
http://www.zen-cart.com/showthread.p...t=Coupon+order
I haven't peeked at the Easy Populate code just yet... is there a reason it's not producing master category ID's?Quote:
Originally Posted by scottj
Hello,
I have a coupon code created that I currently use to get customers to use my live chat option, I have a small banner in my sidebox just below my live chat button telling them that they can request the code just by clicking the live chat button and that if I'm offline, they can just request it by leaving a message. This part works fine as far as the discount code goes, those that have asked and received the code have used it successfully.
My question is, this discount code is not showing up in the new account email that goes out, have I missed something or is there something I need to turn on for it to be included in the new account email?
Thanks for any info.
Jim
Check your setting in the Configuration ... GV Coupons ...
Do you have the Discount Coupon set there for new accounts?Quote:
New Signup Discount Coupon ID#
Select the coupon
Got it now, missed that one.Quote:
Originally Posted by Ajeh
Thanks
I did all the configurations related to Discount Coupon module but Coupon Code Box is not showing up anywhere to enter the code. Please help.
Please help.
I see the Discount Coupon in your checkout on the checkout_payment page ... I am assuming this is for your site at: krutikraft.com
Thanks for your reply.
Actually its coming in the checkout payment page after a user creates a login. If user wants to go for Paypal Express checkout without signing up, I am not getting any placeholder for the coupon code. Also in case a user logs in and enters coupon code its not getting applied on the total amount.
Please let me know if I have missed any steps.
The Discount Coupon code is applied on the checkout_payment ...
On your PayPal settings you would need to set:
The Discount Coupon would not show to the customer until that code is entered on the checkout_payment page ...Quote:
Express Checkout: Skip Payment Page
No
You could turn off the PayPal button on the shopping_cart page with:
Quote:
Express Checkout Shortcut Button
Off
I did this setting.
Express Checkout: Skip Payment Page
No
but its not working as when I click on express checkout button its taking me directly on Paypal and not showing Payment Page where I can enter Coupon Code.
When the PayPal button is clicked on the shopping_cart page, PayPal receives nothing about the Discount Coupon, this is why turning off that button is suggested ...
Only from the checkout_payment page can the Discount Coupon be added to the Order ...
Ok.. so that means in paypal express checkout, we can not have coupon code. Thanks for your answer.
So now I am facing another issue that when I enter coupon code, a message shows that coupon is redeemed but from the total value, discount is not deducting. Total amount remains same. To apply the discount in total order value, do I need to have any other setting.
What version of Zen Cart are you running?
What are the settings on your Discount Coupon?
Do you have any restrictions set?
1.5.1. I have not set any restrictions yet. I want to apply a 30% discount on all my products.
What products_id are in your cart that you are testing the Discount Coupon?
Could you PM me the Discount Coupon code so that I can test this and try to see what is happening with it?
I want to apply on all my products. Basically its a site-wide 30% off discount. So what should be the setting for restrictions?
If the Discount Coupon is for all Products, then you want no restrictions ...
Any plans in a future release to give this feature the flexibility to offer a discount AND free shipping????????Quote:
Originally Posted by Ajeh
Honestly this always struck me as a business rule that the Zen Cart code sets whether it's the rule for your business or not.. Are there ANY plans in a future release to put this decision back in the hands of the shop owner so they don't have to use myPHPAdmin to reactivate a coupon??Quote:
Originally Posted by Ajeh
Crap.. I should have LOOKED before I asked.. I found this post,Quote:
Originally Posted by DivaVocals
but I don't see this code included in the latest version of Zen Cart (or am I missing something??)Quote:
Originally Posted by Ajeh
You appear to be missing something, as this is in v1.5.4 ...
What isn't working for you on a Discount Coupon?
Honestly I hadn't tried it yet.. I compared the code from the thread you were asking folks to test the new functionality to the current v1.5.4 code, and it wasn't the same, so it was unclear to me if this made it's way in or not.. PLUS, the on-screen "helper" text still indicates that the interface still doesn't support the ability to have a coupon with a discount (dollar or percentage) AND free shipping.. the "helper" text STILL indicates it's one or the other.. and YEP this is a fresh v1.5.4 install..Quote:
Originally Posted by Ajeh
To be CRYSTAL clear.. Are you saying that in v1.5.4, I can create a coupon with a discount AND free shipping??Code:define('COUPON_FREE_SHIP_HELP', 'The coupon gives free shipping on an order. Note. This overrides the coupon_amount figure but respects the minimum order value');
What about reactivating coupons?? is that STILL not a supported admin feature, and still requires updating the DB directly???
Well wasn't *that* help text misleading ... :blink:
It is better in v1.6.0 language file:
Code:define('COUPON_FREE_SHIP_HELP', 'The coupon gives free shipping on an order.');
And yes, you can have Discount Coupons for:
Amount
Percentage
Free Shipping
Amount and Free Shipping
Percentage and Free Shipping
No, you cannot reactivate a Discount Coupon that has been Deleted/Inactivated ... for that you would have to cheat and hack the database ...
No it wasn't.. had me koo koo for Cocopuffs!:laugh:Quote:
Originally Posted by Ajeh
I'll make the change..
One more question.. I have a client who is on my schedule to upgrade later in Feb.. But she is running v1.5.1 and wants this functionality NOW.. can I safely upload the new coupon files to her v1.5.1 site?? If so can you guide me as to which files I need to upload..
Grrrr.. So I guess I'll have to look into how to add this to the front end.. Are there STILL no plans to make this an option?? I spent last night looking at how other open source e-commerce CMS's do this, and it appears that OpenCart and PrestCart support reactivating coupons.. (haven't looked at Magento..) Is there a REASON why this isn't at least a OPTION that the shopowner gets to decide for themselves whether to turn on/off..Quote:
Originally Posted by Ajeh
If the Store Owner marks the Discount Coupon as Inactive by deleting it, then it is flagged deleted ...
If it just expires, that is not being marked as Deleted, just as not being usable ... if the Store Owner changes the expiration date, then the Discount Coupon is valid ... to this is purely a Store Owner choice to mark the Discount Coupon as Deleted ...
Once the Store Owner marks the Discount Coupon as Deleted, there is NOT an option to Un-delete the Discount Coupon by the Store Owner. This is when the database would need to be hacked ...
Yes I do understand how this works.. What I am asking is are there plans for future releases to modify this?? For one thing, the "Delete" button label is an example of the action taken not matching the UI label (there are other examples of this in the current codebase as well). Teh coupon is not in fact DELETED but DISABLED/INACTIVATED. Having to hack the DB to reactivate a coupon is an unnecessary set of steps IMHO.Quote:
Originally Posted by Ajeh
The premise behind the current functionality dates back to the BEGINNING of Zen Cart, (and I believe even back to osCommerce from whence Zen Cart came) The logic behind preventing shopowners form reactivating a coupon seems a tad out of step with other similar systems.. Also the functionality as it sits doesn't give shopowners the FREEDOM to determine their OWN business policies..
The Deleted/Inactive Discount Coupon can be Restored in Zen Cart v1.6.0 ...
Cool!!! thanks.. Regarding my other question and the v1.5.4 coupon changes..Quote:
Originally Posted by Ajeh
Quote:
One more question.. I have a client who is on my schedule to upgrade later in Feb.. But she is running v1.5.1 and wants this functionality NOW.. can I safely upload the new coupon files to her v1.5.1 site?? If so can you guide me as to which files I need to upload..
That code is already in v1.5.4 for the Discount Coupon, test it and see ...
Sure.. My concern is I just want to give her this part now.. her v1.5.4 migration is scheduled for later in Feb.. but okay.. I'll test and see..Quote:
Originally Posted by Ajeh
Is it possible to allow all categories (top), and deny, say, one category, or will the allow all override the 'deny'?
Also, if I allow a category, will all products in sub-categories of that category be allowed, or do those sub-categories have to be each specifically allowed?
To Deny just one Category, you only have to mark the one Category as Deny, you do not need to mark Top Allow ...
To mark Top Deny and mark 1 Top Category as Allow is to allow all sub-categories in that Top Category as allowed ...
Thanks so much for the clarification. I proceed with confidence.
You are most welcome glad that this helped ... :smile:
Sorry - another question: I have a minimum spend specified, and two categories excluded. In testing, when I buy something from an excluded category, a message appears in the checkout process referring to the need to meet the minimum spend. Should I be expecting a message about not being able to get a discount from the excluded category?
Many issues were fixed in v1.5.4 ... what version are you using?
What is the exact message that you are seeing?
What are the exact settings on the Discount Coupon and the Restrictions?
You could customize the code for the message and use the code in RED:
/includes/modules/order_ttotal/ot_coupon.php
around the line 192:
and see if having the popup to explain what the Discount Coupon is about helps ...Code:// $messageStack->add_session('redemptions', sprintf(TEXT_INVALID_REDEEM_COUPON_MINIMUM, $currencies->format($coupon_result->fields['coupon_minimum_order'])),'caution');
$dc_check = $_POST['dc_redeem_code'];
$dc_link = ' <a href="javascript:couponpopupWindow(\'' . zen_href_link(FILENAME_POPUP_COUPON_HELP, 'cID=' . $coupon_result->fields['coupon_id']) . '\')">' . $dc_check . '</a>';
$messageStack->add_session('redemptions', sprintf(TEXT_INVALID_REDEEM_COUPON_MINIMUM, $currencies->format($coupon_result->fields['coupon_minimum_order'])) . $dc_link, 'caution');
You could also change the define in the language file(s) for:
TEXT_INVALID_REDEEM_COUPON_MINIMUM
Using 1.5.1.
There is actually no need for a minimum spend message in the particular situation, so what I need in essence is a message which indicates why someone who has chosen from an excluded category why they haven't got a discount. Are you suggesting I simply hijack the min_spend message in the language file? That would work for me...
If I have an excluded category item and an OK category item in the cart, the order will process. Obviously because it is over min_spend - but there is no warning re: the excluded product. If I have only an excluded category item, the min_spend message is displayed:
'You must spend at least $100.00 to redeem this coupon'
Ah. No, wait, that is all OK. If I complete the order, the discount is not applied to the sale item! So I can just change the TEXT_INVALID_REDEEM_COUPON_MINIMUM. Should be OK. Because if only an excluded product is in the cart and processed, there is no issue because it is over the min_spend, but no discount is applied.
I have a question about coupons ...
I designed a banner where I am advertising a $5 discount only for international users ... This banner is linked to an EZ page where I will advertise the coupon code.
So my question is how can I limit the coupon CODE just to non-US customers?
I want to give a different discount to US clients! So I need to prevent them from trying to redeem this code.
Well I am using Zen Cart 1.5.3 and found the answer to this myself ... however I am not sure if I created the restrictions right ...:blink:Quote:
Originally Posted by icecold
What I did was to Top Deny and Allow Product Category and specific product in that order ...
Discount Coupons Product/Category Restrictions
Category Restrictions
Coupon ID Coupon Name Category ID Category Name Allow Deny Remove
2 -1 All Categories Deny Allow Remove
Displaying 1 to 1 (of 1 categories) Page 1 of 1
Category Name Add
Product Restrictions
Coupon ID Coupon Name Product ID Product Name Allow Deny Remove
2 CODEW 147 Armani Code by Giorgio Armani for Women Eau De Parfum Spray 2.5 oz
Category: Women's Perfumes
Manufacturer: Giorgio Armani Allow Allow Remove
Hi Linda,Quote:
Originally Posted by Ajeh
Because I needed to be able to reactivate discount coupons from admin, I made a few simple changes to do the job.
In ZC1.5.4 admin/coupon_admin.php around line 112:
Now the delete button will toggle the status. Need to make some changes to the button texts and add some language defines etc., but it works.PHP Code://jpda: bof toggle coupon_active instead of setting to 'N' always
// get current status
$ca_sql = $db->Execute("select coupon_active from " .TABLE_COUPONS . " where coupon_id = '" . $_GET['cid'] . "'");
$new_coupon_active = ($ca_sql->fields['coupon_active'] == 'N') ? '"Y"' : '"N"';
// $messageStack->add_session('$ca_sql=' . $ca_sql->fields['coupon_active'], 'caution');
[COLOR="#FF0000"] $db->Execute("update " . TABLE_COUPONS . "
set coupon_active = $new_coupon_active
where coupon_id='".$_GET['cid']."'");
[/COLOR] $messageStack->add_session(($new_coupon_active == '"N"') ? SUCCESS_COUPON_DISABLED : 'Success! Discount Coupon was set to Active ...!', 'success');
// replacing
// $db->Execute("update " . TABLE_COUPONS . "
// set coupon_active = 'N'
// where coupon_id='".$_GET['cid']."'");
// $messageStack->add_session(SUCCESS_COUPON_DISABLED, 'success');
// replacing
//jpda: eof toggle coupon_active instead of setting to 'N' always
Questions:
Is this acceptable?
Could the code at $ca_sql be done easier?
On the side, not really related to the subject, the selection character '*' to display all discount coupons does not work, I replaced it by 'A'. The '*' is still present in the ZC1.5.5 version.
Background:
A client of mine is using the Autoresponder+ mod, which sends emails to customers, asking them to write a review. The email contains an active discount coupon. Thus, the customer might use the coupon and forget all about the review.
I change the mod to send an inactive discount coupon, my client needs to be able to reactivate the coupon when the review arrives.
Thanks in advance,
jpda
The code has been updated in v1.6, for the ALL Discount Coupons ...Quote:
Originally Posted by jpda
I have not had time to checkout your code changes ...
Thank you for replying quickly! :-)
jpda
Is there a way to set up a discount coupon that does NOT apply the discount to the shipping cost of the order? In other words, a discount that is applied to the items in the cart - the subtotal amount - before shipping is added?
Quick question. I'm using ZC 1.5.4x. I've created a discount coupon which I am printing on business cards to hand out to potentially new customers. I want the discount code to only work for first-time purchasers! I don't care if they already have an account, but they must not have had any previous purchases.
Is there a way to do this?
Thanks :smile:
Hi Everyone :)
I've just made an adjustment to my Discount Coupons and see that there is no option to extend them past Dec 31, 2018. These are an ongoing thing for me and so I would like them to be available for many years to come. Is there an easy way to extend them past 2018?
I'm using V1.5.4.
Thanks in advance :blink:
Debbie
Known bug in ZC 1.5.4 and earlier, corrected in ZC 1.5.5. See this GitHub commit by DrByte that corrects the issue.Quote:
Originally Posted by Debbiew4960
Thank you so much lat9! I'm on it :blush:
I'm currently chasing a zc157c issue with ot_coupon on a site that uses multiple tax rates and has the ot_coupon settings Include tax = 'true' and Re-calculate Tax set to 'None'.
That leads me to the question: How are those ot_coupon tax settings supposed to work? What is the expected difference using the above settings and when Re-calculate Tax is set to 'Standard'?
i hate coupons.Quote:
Originally Posted by lat9
looking at this outstanding PR here:
https://github.com/zencart/zencart/pull/4324
i wanted the coupon amount to be included into the order info array.
this amount would then be used in any of your various ot tax modules to reduce said tax by that rate * the coupon amount.
i am not sure if that helps with your question, as i am not in a position to answer how it is 'supposed to work' nor what are the 'expected differences'.
best.
ReCalculate Tax = None vs Standard
For Standard, it goes through the products list and for taxable products, computes the updated tax based on the discount provided by the coupon.
Finally, the tax line(s) are updated based on the new computation.
They're not my favorite, either.Quote:
Originally Posted by carlwhat
I got that, I'm looking for the processing difference between the "None" and "Standard" settings since "None" is how the client's got their coupons currently set up.Quote:
Originally Posted by swguy
I'll note that the coupon calculations are off using the "Standard" setting as well when a site's products have multiple, additive tax rates that apply.
Here's another "How is it supposed to work?" question:
The base ot_coupon configuration contains a setting: Include shipping (true or false). Coupons can (since zc152) be defined to include free shipping and I'm wondering if this setting was created for pre-zc152 coupons.
Does anyone have a clue as to what processing is expected when "Include shipping" is set to true?
Include shipping just means the amount that a percent off coupon will apply to is grossed up by the shipping cost. (Without this, it's just the cost of all items which are valid for this coupon.)
I saw that, but what's the setting's "business" purpose? You can create individual coupons that do/don't include shipping.Quote:
Originally Posted by swguy
I think it's vestigial code. :)
If that's the case, shouldn't it be removed (before it becomes cancerous)?Quote:
Originally Posted by swguy
I think it still works and serves a purpose - you are right, there are now other ways of doing this but the old way also works.
I'm questioning 'works' ...Quote:
Originally Posted by swguy