If the issue is in SBA (and you are going to address this on the SBA support thread), but will affect Edit Orders, could you share your findings here as well..Quote:
Originally Posted by RodG
Printable View
If the issue is in SBA (and you are going to address this on the SBA support thread), but will affect Edit Orders, could you share your findings here as well..Quote:
Originally Posted by RodG
Quote:
Originally Posted by RodG
Yup this is how it works (and why we added a message to tell people). Why? Because ot_coupon stores the coupon name and code as the "title" for the order total. So basically the title needs to be formatted to match what ot_coupon expects ;)Quote:
Originally Posted by DivaVocals
I'm still chasing this rabbit down the hole. .. and after following many threads it once again appears to be an Edit Orders issue and not directly related to the SBA mod.Quote:
Originally Posted by DivaVocals
Here's where I'm currently at:
ile: /admin/edit_orders.php
------------------ Updated to avoid the need for the strange syntax current required (my clients have a bit of a problem following the instructions, and would prefer to just enter the coupon code_
----------------- Original code ----------------------------------------
case 'ot_coupon':
preg_match('/([^:]+):([^:]+):/', $order_total['title'], $matches);
//DEBUG echo '<div>Coupon Matches</div><pre>'; var_dump($matches); echo '</pre>';
if(count($matches) > 2) {
$order_total['title'] = trim($matches[1]);
$cc_id = $db->Execute(
'SELECT coupon_id FROM `' . TABLE_COUPONS . '` ' .
'WHERE coupon_code=\'' . trim($matches[2]) . '\''
);
if(!$cc_id->EOF) $_SESSION['cc_id'] = $cc_id->fields['coupon_id'];
else {
$messageStack->add_session(WARNING_ORDER_COUPON_BAD, 'warning');
$order_total['title'] = '';
$order_total['value'] = 0;
}
}
else {
$messageStack->add_session(WARNING_ORDER_COUPON_BAD_FORMAT, 'warning');
$order_total['title'] = '';
$order_total['value'] = 0;
}
break;
------------ Replacement code ----------------------------------------------
case 'ot_coupon':
$order_total['title'] = "Discount Coupon:" . $order_total['title'] .":" ;
preg_match('/([^:]+):([^:]+):/', $order_total['title'], $matches);
//DEBUG echo '<div>Coupon Matches</div><pre>'; var_dump($matches); echo '</pre>'; die ;
$order_total['title'] = trim($matches[1]);
$cc_id = $db->Execute(
'SELECT coupon_id FROM `' . TABLE_COUPONS . '` ' .
'WHERE coupon_code=\'' . trim($matches[2]) . '\''
);
if(!$cc_id->EOF) $_SESSION['cc_id'] = $cc_id->fields['coupon_id'];
else {
$messageStack->add_session(WARNING_ORDER_COUPON_BAD, 'warning');
$order_total['title'] = '';
$order_total['value'] = 0;
}
break;
-------------------------------------------------------------------------------------
This same file /admin/edit_orders.php has a
switch($optionInfo['type']) block, with case references to:
PRODUCTS_OPTIONS_TYPE_RADIO
PRODUCTS_OPTIONS_TYPE_SELECT
PRODUCTS_OPTIONS_TYPE_TEXT
PRODUCTS_OPTIONS_TYPE_FILE
PRODUCTS_OPTIONS_TYPE_READONLY
PRODUCTS_OPTIONS_TYPE_CHECKBOX
These don't appear to be defined anywhere, so nothing matches. (bug?)
I've 'fixed' this problem by making the following edits to
/admin/includes/classes/attributes.php
(I thought this was from the SBA mod, but I've since found it to be from the Edit orders mod)
Added these defines at the beginning of the file
------------------------------------------------------------
define('PRODUCTS_OPTIONS_TYPE_RADIO', 'Radio') ;
define('PRODUCTS_OPTIONS_TYPE_SELECT', 'Dropdown');
define('PRODUCTS_OPTIONS_TYPE_TEXT', 'Text') ;
define('PRODUCTS_OPTIONS_TYPE_FILE', 'File') ;
define('PRODUCTS_OPTIONS_TYPE_READONLY', 'Read Only') ;
define('PRODUCTS_OPTIONS_TYPE_CHECKBOX', 'Checkbox') ; // is this a valid option? It doesn't appear in the database as such?
-------------------------------------------------------------
These are probably best suited in another datafile, or at the very least, add a check to ensure they don't try to get redefined.
---- replaced the get_attributes_options with this ---------------
function get_attributes_options($zf_product_id, $readonly = false) {
global $db;
$query = 'SELECT attr.products_attributes_id, attr.products_id, attr.options_id, opt.products_options_name,
type.products_options_types_name, type.products_options_types_id,
val.products_options_values_name, opt.products_options_type,
products_options_size, opt.products_options_rows ' .
'FROM ' . TABLE_PRODUCTS_ATTRIBUTES . ' AS attr ' .
'LEFT JOIN ' . TABLE_PRODUCTS_OPTIONS .
' AS opt ON attr.options_id = opt.products_options_id ' .
'LEFT JOIN ' . TABLE_PRODUCTS_OPTIONS_VALUES .
' AS val ON attr.options_values_id = val.products_options_values_id ' .
'LEFT JOIN ' . TABLE_PRODUCTS_OPTIONS_TYPES .
' AS type ON type.products_options_types_id = opt.products_options_type ' .
'WHERE attr.products_id = \'' . (int)$zf_product_id . '\' ' .
'AND val.language_id = \'' . (int)$_SESSION['languages_id'] . '\' ' .
'AND val.language_id = opt.language_id ';
// Don't include READONLY attributes if product can be added to cart without them
if(PRODUCTS_OPTIONS_TYPE_READONLY_IGNORED == '1' && $readonly === false) {
$query .= 'AND opt.products_options_type != \'' . PRODUCTS_OPTIONS_TYPE_READONLY . '\' ';
}
$query .= 'ORDER BY `opt`.`products_options_sort_order`, `attr`.`options_id`';
if($this->cache_time == 0) $queryResult = $db->Execute($query);
else $queryResult = $db->Execute($query, false, true, $this->cache_time);
$retval = array();
while (!$queryResult->EOF) {
$retval[$queryResult->fields['products_attributes_id']] = array(
'id' => $queryResult->fields['options_id'],
'name' => $queryResult->fields['products_options_name'],
'value' => $queryResult->fields['products_options_values_name'],
// 'type' => $queryResult->fields['products_options_type'],
'type' => $queryResult->fields['products_options_types_name'],
'length' => $queryResult->fields['products_options_length'],
'size' => $queryResult->fields['products_options_size'],
'rows' => $queryResult->fields['products_options_rows']
);
$queryResult->MoveNext();
}
return $retval;
}
---------------------------------------------------------------------------------------------------------
These changes seems to cure most of the problems I was having with the site I'm working on.
Cheers
Rod
Oh no! Don't do that!:no: Those constants are defined in the database and provide a mapping to the products_options_types table row associated with that option name.Quote:
Originally Posted by RodG
They're NOT defined in the database of the clients site that I'm working on.Quote:
Originally Posted by lat9
They ARE defined in the configuration database of my own test site though (not associated with the clients site).
(That's why I suggested they should probably be checked to prevent a possible redefine).
I've not figured out how or where they got defined on my site, or more importantly, why they *didn't* get defined on the clients site during whatever upgrade performed this function.
Time to follow this lead to see where it takes me. It'll probably avoid the need for those other changes I made :)
.... Other than the case 'ot_coupon' changes (which was for a different issue). If you can foresee any potential problems with that could you please let me know?
Thanks
RodG
They've been part of the Zen Cart "standard" database install since at least v1.3.8a (I've got a client that started with v1.3.7 and the constants are in that database). What Zen Cart version did your client start out with?Quote:
Originally Posted by RodG
Honestly Rod, the discount coupon thing aside (which is a functional issue not a "bug"), I'm starting to wonder if the "bugs" you are finding are UNIQUE to the client site you are working on.. Otherwise it would stand to reason that others would have reported the same issues you are having..Quote:
Originally Posted by RodG
The correct stored format is "<module_title>: <coupon_code>".Quote:
Originally Posted by RodG
Just a couple warnings about your code:
- The module title is not static (and may vary depending upon store language and / or modifications).
- Indexes on an array are not checked to verify they exist before using them (PHP 5.4+ potential issue).
- It will break when the correct full title is passed (such as a order created by the checkout process).
Most users have not had any problems understanding the warning which is printed on the top of the screen by Edit Orders and taking the appropriate action. On the other hand, I do like the idea of allowing the entry of just the coupon code. With the upcoming 4.1.3 release, I have been focusing on usability, compatibility, and automatically finding / fixing certain common database issues (caused by errant code in OTHER modules).
I'll add the updating the handling of ot_coupon to the list for Edit Orders 4.1.3. :o)
Not a bug. These are core database entries relating to attributes in the Zen Cart database. Means the store you are working on has some serious database damage... You should re-add the appropriate entries to the database (and verify the SBA code is not incorrectly removing these).Quote:
Originally Posted by RodG
Not needed if you fix the core database entries relating to attributes. Also why did you change the code to use the "product's option's type" name instead of id? What happens if in the future the names are in a localized language? Or someone changes the name?Quote:
Originally Posted by RodG
Other Thoughts
Sounds like your client's store has a large number of modifications (both to the database and files) including damage to some of the core Zen Cart database entries relating to attributes... I cannot say what introduced these "changes", but I would make sure it was not the SBA module you are using...
You will probably want to correct the current issues in the specific store you are working on instead of modifying the "Edit Orders" code (to work around the issues specific to the client's site). Applying bandages instead of stopping the root cause could cause problems down the road (such as when a new version of Zen Cart or Edit Orders is released).
NOTES: If the SBA module includes something to indicate it's presence (like EO_VERSION identifies Edit Orders is installed and which version)... And the SBA module does not break existing Zen Cart core attribute handling... I'm more than willing to add some additional code / code blocks to help "support" the SBA module... So if you do find what exactly is changed by the SBA module during the product selection and checkout process... Contributions are welcome (but expect them to be looked at to ensure they do not introduce unnecessary risks). :o)
Thanks.Quote:
Originally Posted by lhungil
I find your 3rd point the most disconcerting. I'll need to check this before the client discovers this before I've taken steps to mitigate it :)Quote:
Originally Posted by lhungil
I could dispute this and suggest that most users simply haven't reported or commented about the issue, or that most users have probably never even attempted to use the discount coupons when editing an order. :)Quote:
Originally Posted by lhungil
This is partially why I provided the info about how I 'solved' the problem and asked about the possible repercussions :)Quote:
Originally Posted by lhungil
I kinda figured that my solution was a little *too* easy.
You're not wrong there. This site has been a major headache since the 1st day I started working on the upgrade.Quote:
Originally Posted by lhungil
In hindsight if I were to do this one again I would have started with a fresh install of V1.5.1 and basically rebuilt it from scratch.
I can normally do such upgrade in a matter of hours. This one has had me going around in circles for weeks. (Thankfully the client has been very understanding and quite generous).
I cannot say what introduced these "changes", but I would make sure it was not the SBA module you are using...
I agree 100%. I thought I *had* fixed all the 'current issues' (without any code patches) until this reported problem (which on first inspection appeared to be a simple bug in the code).Quote:
Originally Posted by lhungil
Thanks to you guys I now have another lead to follow up on. :)
FWIW, in regards to the missing CONSTANTS in the DB configuration table, I had a *very quick* look at this before calling it quits last night, and discovered that these entries are created (re-created?) when I went to the attributes controller and created some new entries. Alas, there still seems to be an issue (using unmodified code), so there is still a little more to the puzzle. I hope to get back onto it further later today. I suspect it is probably related to the fact that the current entries still have missing or incorrect data somewhere. At least now I have a means of comparison. :)
I seriously don't like the idea of adding bandaids/patches, especially with code modules that I'm unfamiliar with.
Cheers
Rod
Wonder no more. It is most certainly unique to this clients site.Quote:
Originally Posted by DivaVocals
Until this thread I really wasn't sure (and arguably, could still be in doubt), because this is the 1st store in which I've had the combination of
-----------------------------------
ZenCart V1.5.1
Edit Orders 4.1.2
Super Orders 4.0.7
Stock by Attribute 1.5.1.2
-----------------------------------
Although I'm now pretty much convinced the problem(s) pertain to the store/data itself, can you (or anyone) be 100% sure that there *isn't* a bug with this specific combination of inter related modules?
Again, I will stress that I'm now of the opinion that when I find what else is amiss with the data in this store that these versions of these modules will almost certainly behave as expected. Without reporting the 'bugs' and what I've needed to do to 'fix' them I don't think I could have gotten the feedback I needed to put me back on the right track. :)
Cheers
Rod
I had problems installing Edit Order on a vanilla install of ZC. The solution / workaround is shown below.
The resulting error is:
"PHP Fatal error: 1366:Incorrect integer value: '' for column 'configuration_group_id' at row 1 :: INSERT INTO `zen_configuration_group` VALUES ('', 'Edit Orders', 'Settings for Edit Orders', '36', '1') in E:\web\zc151\includes\classes\db\mysql\query_factory.php on line 120
"
I have tracked it down to
admin\includes\auto_loaders\config.eo_onetime.php
--> admin\includes\init_includes\init_eo_install.php
--> admin\includes\classes\eo_plugin.php
--> admin\includes\classes\plugin.php
LINE 435
// Create configuration group
$db->Execute(
'INSERT INTO `' . TABLE_CONFIGURATION_GROUP . '` ' .
'VALUES (\'\', \'' . $this->getUniqueName() . '\', ' .
'\''. $this->getDescription() . '\', \'' . $max_sort . '\', \'1\')'
);]
The solution that works on my environment is to change to the value of configuration_group_id from '' to NULL
$db->Execute(
'INSERT INTO `' . TABLE_CONFIGURATION_GROUP . '` ' .
'VALUES (NULL, \'' . $this->getUniqueName() . '\', ' .
'\''. $this->getDescription() . '\', \'' . $max_sort . '\', \'1\')'
);
This can be replicated on a fresh database and Zen Cart demo installation
Configuration
PHP 5.3.8
Apache 2.2.21
MySQL 5.1
Windows 7 (test server)
I have posted the problem and the workaround here for future reference.
I have persevered with this as I have been using Edit Order on many version of ZC and simply find it difficult to admin a ZC site without it.
Thank You for reporting back, if you see / saw any database pieces you feel could be "commonly" damaged, feel free to send me a PM / email with the information. If nothing else an installation check might be in order :)Quote:
Originally Posted by RodG
Thank You for catching this, reporting the issue, and providing a workaround / solution!Quote:
Originally Posted by OldNGrey
For the next release (of both Edit Orders and the Plugin module), I'll be replacing most UPDATE and INSERT statements with the "zen_db_perform" function.
I'm curious as to why you "Changed the "local_sales_tax" line to no longer be editable (automatically generated based upon the order)" when "Not all order total modules are fully supported"???
As this is the case for my site (I'm running the Better Together addon), and I have to update the database directly with the correct sales tax (AND the total) as Edit Orders is not taking this discount into consideration when calculating the tax. I'd much rather be able to update it directly on the order edit page.
Thank,
Leslie
Because the "Local Sales Tax" module IS supported by Edit Orders with the noted changes in the readme. "Local Sales Tax" reads the product list from the order (not the cart) and works when loaded during checkout or from the administrative interface.Quote:
Originally Posted by lunabug
An Order Total module can be treated as "automatically" calculating or "editable" (not both) within "Edit Orders". Currently there are no plans to add an extra checkbox to each order total line to allow selecting the mode... Mostly because what a customer sees when they place an order via the checkout process should match what is shown when an administrative user edits / creates an order.
The calculations are NOT done by Edit Orders in version 4.1+ The calculations are done by the Order Total modules.Quote:
Originally Posted by lunabug
I sympathize with the issues you are experiencing, but they are not caused directly by "Edit Orders".
- "Better Together" and "Local Sales Tax" are not friendly towards each other. Specifically, "Local Sales Tax" calculates tax separate from Zen Cart's tax tables and reads the products from the order. "Better Together" is not aware of the "Local Sales Tax" module and only calculates tax using Zen Cart's tax tables and does not modify the price of products in the order.
- "Better Together" does currently support being loaded from the administrative interface. "Better Together" depends on access to the shopping cart (and does not make use of $order->products). "Edit Orders 4.1+" currently only populates $order as there is no shopping cart once an order has been placed.
If you must use an unsupported Order Total module (or have multiple Order Total modules which do not work well together), you may wish to uninstall "Edit Orders 4.1+" and go back to using "Edit Orders 4.0". Edit Orders 4.0 relied upon manual price adjustments vs. ones calculated by the Zen Cart Order Total modules.
Otherwise, continue reading for some of the things involved (not all) if you want to use "Edit Orders 4.1+", "Better Together", and "Local Sales Tax" together.
To address the first issue:
Modify "Better Together" and / or "Local Sales Tax" to play well together. I believe some of the other tax lookup modules have similar problems with discount modules which do not alter the price of the product directly... But I could be wrong...
To address the second issue:
Modify "Better Together" to use the order information (when available, instead of just the cart) -- or -- Modify "Edit Orders" to populate a "dummy" cart. This would allow automatic calculation for "Better Together" (and if item #1 is corrected tax rates should be calculated correctly).
You may also run into some issues with the automatic calculation of the stock Zen Cart taxes via ot_taxes without this compatibility issue being addressed. As "Better Together" does not see products in the shopping cart, it does not apply any corrections (including tax corrections).
I've got a question regarding what should be expected regarding Edit Orders' handling of orders that contain deleted products.
The scenario: The website that uses Edit Orders extensively has one class of products that are one-off. Once they're sold, they're no longer available. The store owner, in performing "routine" maintenance, has gone through and specifically deleted (not disabled) the one-off products that have been sold (including product ID#234).
The customer who has purchased product #234 calls the store owner and requests that an additional product be added to their order. Store owner adds product ID 456 to the order. Upon updating the order, the orders_products table entry for the deleted product #234 has been updated with the products_id and products_prid both set to 0 and the products_price set to 0.00 (interestingly, the products_final_price value is unchanged).
What I expected was for Edit Orders to use the product-related information from the orders_products table (i.e. the products_id, products_prid and products_price fields should not have been changed for product #234) unless a new product was added to the order, in which case the products table would need to be interrogated for that newly-added product.
During an update, all products are removed from the order and re-added. The information about the product is first looked up from the database, then merged with the product information shown on the edit orders page...
I'll have to take another look at the code (out of town). I THINK the reason was to ensure the product info is fully populated for the order totals... Suspect I can add a workaround (although tax may be off without being able to pull the product's tax class and description)... Again will need to look back over the code.
Thank you for being patient and mentioning!
MagZ, You are a blessing. Was scared of not having edit orders and needing to completely reinstall many contributions. Thanks for all for having these forums, and participating with your knowledge and energy.
After getting edit orders functioning again, I am noticing I do not have a dropdown on adding additional orders for priced by attributes items. The first is a pulldown for product, but no pulldown for attributes like size, color etc. Is there something I must amend?
1.5.1
superorders4
editorders4.1.2
TyTracker etc
There are no other items I know of affecting this, but would appreciate any advice.
Attachment 13596
when i send Po using (POs - Send for Unknown Customer) Its's did't save to database history. how can save iT to my database please help
The most common cause of the attribute selection dropdown not appearing is pre-existing damage to your Zen Cart installation (in particular some of the settings for attributes). See this post for more details.Quote:
Originally Posted by Trademagic
Edit Orders 4.1.3
Focus areas for version 4.1.3: additional safety checks, automated repair of common database issues, logging of relevant information to aid troubleshooting, improved attribute and order total line handling, and easing the general use of Edit Orders.
What's New?
Please refer to the readme included in the distribution zip archive for the full list of changes. Some notable changes include: automatic repair of damaged configuration entries related to attributes, better handling of deleted products, an (optional) Order Total Module allowing administrative users to discount an order, retention of "uploaded file" attributes when updating an order, a "mock" shopping cart to ease the use of Order Total modules ignorant of the $order variable, following the configured Zen Cart "stock" rules for incrementing and decrementing product stock levels, and support for Zen Cart 1.5.2 RC2.
Firstly many thanks to both of you DivaVocals & lhungil for this very useful plugin. You have done a great job!Quote:
Originally Posted by lhungil
I had toyed with the idea of installing this tool for a while and finally found the time to do it on the weekend. It came to immediate use when one of my suppliers could not provide the full quantity I had ordered. EO to the rescue: update the qty and issue a new invoice - no probs at all.
As for EO v4.1.3, has been submitted yet?
Cheers / Frank
Thank You for the kind words. It's nowhere near perfect, but glad you found it useful.Quote:
Originally Posted by frank18
And a great big thank you to all the contributors and beta test team!
Without these individuals Edit Orders would not function half as well as it does. They volunteer their valuable time to throw this module at different environments with different modifications... And see if it sticks (or just shatters into many pieces). Their contributions, testing, and debugging contributes directly to the quality of Edit Orders.
All the credit really goes to lhungil.. I am just the comedy relief around here.. :laugh:Quote:
Originally Posted by frank18
frank18 suggested I post my question in the "Edit Orders" thread, I hope this is the right one. :) If not please point me in another direction.
My original post:
Quote:
Originally Posted by ifss
Basically I have 2 admins that run the store, but I'm also looking at creating a superuser to run support enquiries (lost orders through Paymate is one of the reasons for this), I want to make sure that the user has their login name attached to the order update. It doesn't have to show to the customer, I just want to be able to see who edited the order. :)
Cheers ...
While not against the thought of consolidating information, isn't the change affected by the logged in admin individual captured in the admin activity log?Quote:
Originally Posted by ifss
You could check out this post (http://www.zen-cart.com/showthread.p..._history-table) where I've got such an interface proposed. I use that interface in a couple of the plugins I've submitted, like SNAP Affiliates.Quote:
Originally Posted by ifss
If you only want the "Updated by" feature, you could download SNAP and just use the files that start with "osh_" and the update to the admin /orders.php.
Thank you lat9, that sounds exactly what I need. :)
Being able to see who did what to an order is important to me.
I will take my questions over to that thread when I've had a chance to read more on it.
In the meantime, if I add your option to my store and use the Edit Orders plugin, when I create an order using Edit Orders, will that reflect in the order_status update? Are these 2 plugins compatible for data sharing? It would be good to see that an Admin created the order using the Edit Orders, so it can be followed up if a customer has an issue.
Cheers :D
There's a code-merge required for Edit Orders to make use of the "updated by" field. I'm pretty sure that I've got that merge somewhere for the most recent version of edit orders ...Quote:
Originally Posted by ifss
keep in mind by default the order history table is only updated when an admin user actually adds a comment or changes the status.
You will probably want to "coach" your users on always adding relevant comments when editting an order - they can use the "private" flag to have comments not vivble to the customer if needed.
This was going to be my suggestion.. Besides that from a purely administrative process POV, you would want this information anyway so that you have a complete order history.. Suggest that the admin comments entry should be part of your order editing process..Quote:
Originally Posted by lhungil
If you have that information to hand that would be terrific, thank you :)Quote:
Originally Posted by lat9
Quote:
Originally Posted by lhungil
Completely agree, I make a habit of it and make sure I "stamp" my comments, but when you're modding 10+ orders a time, or you've got someone new doing it the process can get away from you. I think it makes perfect sense that the system come with that sort of "stamp" already programmed, on all of the programs and systems I've worked on there has always been a user stamp when something is changed. Whilst we're only small, and not big like the Companies I have worked for, I still think it immensely important that these records are kept up correctly, including a user stamp.Quote:
Originally Posted by DivaVocals
Attached is a merger of the "Orders Status History - Updated By" files and the edit_orders.php and orders.php (both in the /YOUR_ADMIN directory) files from the Edit Orders plugin's v4.1.3 release.Quote:
Originally Posted by ifss
Attachment 13713
Edit Orders 4.1.4
This release includes updated installation code to better operate in some server configurations and with some 3rd party alterations to the Zen Cart admin interface. Updated core files from "Plugin Manager" 0.5 RC2 have been included.
The specific item addressed: when configuring Edit Order options, the dropdown menu's may not appear. While this is the only change from version 4.1.3, it is recommended to update to the latest version to mitigate any potential problems in the future when upgrading to a new version of Zen Cart.
Is there a list of core files to update or do I need to do a full install if upgrading from a previous version. I'm asking because if there are core files that were not updated in this newer version I would like not to spend time comparing them. I have a ton of modifications and combing through each one becomes tedious. The readme didn't really give any useful information on upgrades that I saw.
It's a minor change..Quote:
Originally Posted by lhungil
Easiest way to identify what files changed is to compare the v4.1.3 to v4.1.4 filesets.. the list of changed files will be very obvious.. A comparison tool like Beyond Compare does folder or zip file comparisons which will allow you to see at a glance what changed between the two versions.. WinMerge has a similar folder comparison feature (http://manual.winmerge.org/Compare_dirs.html)Quote:
Originally Posted by southshorepizza
While waiting for the reply. I used beyond compare to check the core files against mine. I have fast easy checkout installed. So I left anything that said cowoa alone. I think there was only 5 lines or so. Then used filezilla to upload to site. I was able to click edit order and view the edit order page. However if I changed anything and clicked update I would get the following page your_admin/edit_orders.php?origin=index&page=1&oID=18905&action=update_order
WARNING: An Error occurred, please refresh the page and try again.
So I looked in my logs file and my last entry was on January 9th.
So I deleted my admin folder and uploaded my backup via filezilla. Old edit order worked fine again. So I filezilla all the files up as they came no modifications and I get the same error. So I went into my cpanel and manually uploaded the original files one at a time. I still get the same error. At this point I have uploaded each file through my cpanel 3 times. Each file prompts me to overwrite the previous version. So they are all there and in the correct place.
Any ideas how to hunt this down or if fast easy checkout is the culprit? From what I can see they only share the order.php file. So if there is a merge issue it would be there. However my knowledge of merging is very limited.
Thank you to anyone who can help. The new version looks awesome. Just wish I could get it working!
Usually this means either:Quote:
Originally Posted by southshorepizza
1) Something was not installed correctly (missed file or merge).
2) You have a 3rd party Order Total module not supporting being loaded from the admin.
What version of Zen Cart is installed?
What was the previously installed version of Edit Orders?
What version of Edit Orders are you trying to install (4.1.4 had not been approved yet)?
What messages did you receive during installation?
What is in the Zen Cart debug logs (and php / server error logs)?
Can you enable TRACE debug in the Edit Orders configuration menu and attach the log?
Yes, every single file in the folder "1_modified_core_files". This is answered in the readme.Quote:
Originally Posted by southshorepizza
Depending on what version you are coming from the answer will be different. As mentioned the best way to find out is to compare the files from the version you previously had installed with the ones from the version you are trying to install.Quote:
Originally Posted by southshorepizza
But in the long run it is usually easier to just do a comparison directly between the files in "1_modified_core_files" and your installation. The "/admin/orders.php" file includes lines which indicate where changes were made specifically for "Edit Orders".
The readme has an entire section on how to install / upgrade this module. Edit Orders 4.1.x includes code to upgrade an existing 4.x installation when running the installation. There are no "special" instructions because there is nothing "special" one needs to do differently. Just the usual merge files, upload files, run the installer.Quote:
Originally Posted by southshorepizza
What version of Zen Cart is installed? 1.5.1
What was the previously installed version of Edit Orders? V3.0
What version of Edit Orders are you trying to install (4.1.4 had not been approved yet)? 4.1.3
What messages did you receive during installation? Didn't see any messages However none of the links in the readme did anything so there really were no installation instructions. I just downloaded V4.0.3 and saw detailed instructions stating I should be logged into admin or I will miss it.
What is in the Zen Cart debug logs (and php / server error logs)? Zen Cart logs don't show anything from January 10th to current time. php/server logs in my cpanel not showing any errors
Can you enable TRACE debug in the Edit Orders configuration menu and attach the log? I did and it didn't generate any logs.
The only plug in I have that changes the core files is fast easy checkout. It changes my_admin/orders.php So that is the only one I have to merge.
I can say that after looking at the install for 4.0.3 I did upload that one overwriting the files for 4.1.3. I still get the same error message, no log files generated.
Perhaps I will check with hostgator and ask them if they have any error logs that are not shown in my cpanel error logs.
I am attaching my_admin/orders.php file that I attempted to merge with FEC. Attachment 13720
Thank you for taking the time to help me!
The tabbed links in the readme WON'T work if you are attempting to view it from INSIDE the zip file.. You do need to UNZIP the file and extract the readme file to SEE it..Quote:
Originally Posted by southshorepizza
I downloaded it on a mac. So it went into my download file as a folder and in my trash was a zip. So I assumed it was unzipped. Anyway I downloaded this morning on a pc unzipped and it looks completely different. Actually it looks very similar to V4.0.3 did on my mac last night. Perhaps the 4.1.3 didn't get zipped correctly or my mac didn't unzip it the same.
Anyway that still doesn't get me to the what didn't go right during the install. So I guess I will restore backup and try reinstalling again?
The instructions for 4.1.x are slightly different from 4.0.x. Please extract the Edit Orders 4.1.x distribution zip file to your hard drive and open /readme/index.html from the location you extracted the files. The readme is a webpage and links to other files / resources included in the distribution zip file.Quote:
Originally Posted by southshorepizza
I'd recommend after reading through the installation steps, performing each step - one at a time - to do a full re-install. During step 3 of the install, messages will be generated and displayed on the top of the admin interface.
Please verify your configured Zen Cart "log" folder is writable.Quote:
Originally Posted by southshorepizza
If Edit Orders is completely installed (not just the files) and TRACE is enabled... Each and every access to "edit_orders" will create a log file. This includes just viewing the page. The log file will be found inside the Zen Cart log file location in a folder labeled "edit_orders" (/logs/edit_orders/).
Note: If Edit Orders 4.1.3+ is not fully installed or PHP (or the webserver) does not have access to write / create files and folders in the Zen Cart logs folder, enabling debug logging in Edit Orders will do nothing. Debug logging for Edit Orders should not be enabled unless one is actively troubleshooting an issue as it will cause a large number of log files to be created.
So I reinstalled 4.1.3 following the instructions I see on my pc. Clicked on admin home as recommended.
Received the message:
Found previous version installed. Upgrading (or re-installing) Edit Orders (old 4.1.3 => new 4.1.3).
Edit Orders installation / upgrade completed!
Clicked on the last order. Choose edit. Tried to change from one shipping method to another in the drop down box. Clicked update and I get
WARNING: An Error occurred, please refresh the page and try again.
Clicking refresh gives me the same page.
Today I have success in generating three logs from the edit order folder:
============================================================
= Edit Orders (4.1.3) Action Log
============================================================
Order ID: 18908
Action Requested: edit
Enabled Order Totals: ot_subtotal;ot_shipping;ot_coupon;ot_group_pricing;ot_quantity_discount;ot_tax;o t_loworderfee;ot_gv;ot_reward_points;ot_cod_fee;ot_tip;ot_total;ot_reward_points _display
============================================================
= Edit Orders (4.1.3) Action Log
============================================================
Order ID: 18908
Action Requested: update_order
Enabled Order Totals: ot_subtotal;ot_shipping;ot_coupon;ot_group_pricing;ot_quantity_discount;ot_tax;o t_loworderfee;ot_gv;ot_reward_points;ot_cod_fee;ot_tip;ot_total;ot_reward_points _display
Requested Products:
array (
37930 =>
array (
'qty' => '1',
'name' => 'Hawaiian pizza',
'onetime_charges' => '0.0000',
'attr' =>
array (
37 =>
array (
'value' => '4698',
'type' => '0',
),
15 =>
array (
'value' => '1379',
'type' => '0',
),
14 =>
array (
'type' => '3',
),
22 =>
array (
'value' => '3454',
'type' => '0',
),
6 =>
array (
'type' => '3',
),
7 =>
array (
'type' => '3',
),
8 =>
array (
'type' => '3',
),
23 =>
array (
'value' => '',
'type' => '1',
),
),
'model' => '',
'tax' => '7',
'final_price' => '12.49',
),
)
============================================================
= Processing Requested Updates to Products
============================================================
============================================================
= Edit Orders (4.1.3) Action Log
============================================================
Order ID: 18908
Action Requested: update_order
Enabled Order Totals: ot_subtotal;ot_shipping;ot_coupon;ot_group_pricing;ot_quantity_discount;ot_tax;o t_loworderfee;ot_gv;ot_reward_points;ot_cod_fee;ot_tip;ot_total;ot_reward_points _display
Requested Products:
array (
37930 =>
array (
'qty' => '1',
'name' => 'Hawaiian pizza',
'onetime_charges' => '0.0000',
'attr' =>
array (
37 =>
array (
'value' => '4698',
'type' => '0',
),
15 =>
array (
'value' => '1379',
'type' => '0',
),
14 =>
array (
'type' => '3',
),
22 =>
array (
'value' => '3454',
'type' => '0',
),
6 =>
array (
'type' => '3',
),
7 =>
array (
'type' => '3',
),
8 =>
array (
'type' => '3',
),
23 =>
array (
'value' => '',
'type' => '1',
),
),
'model' => '',
'tax' => '7',
'final_price' => '12.49',
),
)
============================================================
= Processing Requested Updates to Products
============================================================
From my regular log file:
[29-Jan-2014 11:07:44] PHP Fatal error: 1054:Unknown column 'p.products_quantity' in 'field list' :: SELECT `p`.`products_quantity` FROM `zen_products` WHERE `p`.`products_id` = '34' in /home4/w57dsjmm/public_html/d132s/includes/classes/db/mysql/query_factory.php on line 120
[29-Jan-2014 11:08:43] PHP Fatal error: 1054:Unknown column 'p.products_quantity' in 'field list' :: SELECT `p`.`products_quantity` FROM `zen_products` WHERE `p`.`products_id` = '34' in /home4/w57dsjmm/public_html/d132s/includes/classes/db/mysql/query_factory.php on line 120
It looks like the second was generated when I clicked refresh.
Product id=34 was the Hawaiian pizza. However the only thing I updated was the shipping module.
Verified Bug.Quote:
Originally Posted by southshorepizza
Edit "/admin/includes/functions/extra_functions/edit_orders_functions.php". Around line 1025 change:
to read:Code:$check = $db->Execute(
'SELECT `p`.`products_quantity` FROM `' . TABLE_PRODUCTS . '` ' .
'WHERE `p`.`products_id` = \'' . (int)$query->fields['products_id'] . '\''
);
Please let me know if this solves the problem.Code:$check = $db->Execute(
'SELECT `p`.`products_quantity` FROM `' . TABLE_PRODUCTS . '` AS `p` ' .
'WHERE `p`.`products_id` = \'' . (int)$query->fields['products_id'] . '\''
);
In /public_html/d132s/admin_folder/includes/functions/extra_functions/edit_orders_functions.php
I searched for your text. There was one result found. I changed it to read
Saved then tried to edit order. I clicked update and just got a completely blank page.Code:$check = $db->Execute(
'SELECT `p`.`products_quantity` FROM `' . TABLE_PRODUCTS . '` AS `P` ' .
'WHERE `p`.`products_id` = \'' . (int)$query->fields['products_id'] . '\''
);
I now have this in my log file:
[29-Jan-2014 12:16:20] PHP Fatal error: 1054:Unknown column 'p.products_quantity' in 'field list' :: SELECT `p`.`products_quantity` FROM `zen_products` AS `P` WHERE `p`.`products_id` = '164' in /home4/w57dsjmm/public_html/d132s/includes/classes/db/mysql/query_factory.php on line 120
Case sensitivity matters. The `P` needs to be `p` (lowercase).Quote:
Originally Posted by southshorepizza
Code now looks like
I still get a blank page and log states.Code:else {
$check = $db->Execute(
'SELECT `p`.`products_quantity` FROM `' . TABLE_PRODUCTS . '` AS `p` ' .
'WHERE `p`.`products_id` = \'' . (int)$query->fields['products_id'] . '\''
);
}
[29-Jan-2014 12:59:41] PHP Fatal error: Call to undefined function getrewardpoints() in /home4/w57dsjmm/public_html/d132s/includes/modules/order_total/ot_reward_points_display.php on line 40
This is caused by another "add-on" you have installed. A quick search of the "Edit Orders" thread and the Zen Cart forums reveals: Bugfix for "Reward Points Module" to allow the reward points order total modules to be loaded from the admin side of Zen Cart.Quote:
Originally Posted by southshorepizza
So i loaded that and then did the same test.
Again a blank page with
[29-Jan-2014 14:00:27] PHP Fatal error: Call to undefined function getrewardpoints() in /home4/w57dsjmm/public_html/d132s/includes/modules/order_total/ot_reward_points_display.php on line 40
as my log. :(
Hi - I just upgraded to EO 4.1.4 (from 4.1.2 I believe) and since then, when tracking # is present, comment text doesn't get included in the email sent to the customer. The comment gets sent fine when there is no tracking # attached. Seems like a TPT problem, except it began after the EO upgrade, that's why I'm posting it here. Sadly, no error logs... (EO trace logs just list the products and OT values, but don't report any problem, either.)
I did make a huge mistake while upgrading and somehow TPT code flew out of the admin/orders.php file, however putting it back in didn't fix the problem. I checked and all of the other TPT and EO files are where they should be and have all the code they're supposed to have (unless I missed something, running on 2-3 hrs of sleep per day for the past week or so...).
Should I check all of my code again or is there a simpler answer to this issue? Any help will be much appreciated.
Thank you!
Magz :frusty:
You already posted the answer.. check your code.. You have borked the Ty Package Tracker code and that has NOTHING to do with Edit Orders..Quote:
Originally Posted by magz
Hi,
I've come across an error with the Edit Orders 4.1.4 module in that when clicking 'update' button an error message of:
WARNING: An Error occurred, please refresh the page and try again.
comes up and nothing is saved into the database. Edit orders module was installed with Admin New Order and Super Orders, which I understand are designed to work together and while the other 2 mods work okay, this one is throwing the error upon save.
I'm running ZC 1.5.1. Any ideas?
Regards,
dp
There will be an error log in your /logs directory. See what it says.
Hi,
The log comes out with the following:
============================================================
= Edit Orders (4.1.4) Action Log
============================================================
Order ID: 7616
Action Requested: update_order
Enabled Order Totals: ot_subtotal;ot_shipping;ot_coupon;ot_group_pricing;ot_tax;ot_gv;ot_total
Requested Products:
array (
8 =>
array (
'qty' => '1',
'name' => 'Bathroom Vanity Unit',
'onetime_charges' => '0.0000',
'attr' =>
array (
1 =>
array (
'value' => '46',
'type' => '0',
),
2 =>
array (
'value' => '51',
'type' => '0',
),
3 =>
array (
'value' => '55',
'type' => '0',
),
4 =>
array (
'value' => '60',
'type' => '0',
),
),
'model' => 'S502',
'tax' => '0',
'final_price' => '379.99',
),
)
============================================================
= Processing Requested Updates to Products
============================================================
Not sure what/where the error is within that output - I can only see that 'attr' doesn't have a value after it (I'm guessing here). I've tried using/not using the 'Mock Shopping Cart' and 'Strip Tags from Shipping' options within the EO 4 options to no avail either.
Regards,
dp
That's not the log that was asked for. There should be/expected to be a debug log in your /logs folder off of the root of your store.Quote:
Originally Posted by dp-web
That's not the log that was asked for. There should be/expected to be a debug log in your /logs folder off of the root of your store.Quote:
Originally Posted by dp-web
Sorry, I read the one from the /logs/edit_orders/ folder not the /logs/ folder.
This is the correct log:
[07-Mar-2014 13:27:30 UTC] PHP Fatal error: 1054:Unknown column 'p.products_quantity' in 'field list' :: SELECT `p`.`products_quantity` FROM `products` WHERE `p`.`products_id` = '531' in /home/mysite/public_html/includes/classes/db/mysql/query_factory.php on line 120
dp
Just a reminder to turn off the Edit Orders "action debug log" for performance reasons.Quote:
Originally Posted by dp-web
This is a known bug in Edit Orders 4.1.4 when product downloads are disabled. The fix will be included in the next release of Edit Orders.Quote:
Originally Posted by dp-web
Hi
Apologies for duplicating this, in a support thread of it's earlier version, but I still need to ask:
I am using ZC 1.5.1 and would like to install Super orders. The problem I have, is updating the invoice.php and orders.php and packingslip.php pages: because we have the Stock By Attributes plugin installed, we also need to include this in the code. However this is tricky as one of these pages has been completely re-written (I think it's the invoice page).
Please could anyone offer any advice on where I would need to add the 3 SBA blocks of code to the Super orders modified files. Please any help would be gratefully received.
Best regards
While I don't have an answer for you nor am I sure if this area is the correct place to post this question, it is also not stated which SBA module is being attempted to merge. Hopefully though an answer will be found and the question addressed in the correct area.Quote:
Originally Posted by dharrison
Hi mc
The latest version of SBA. version 1.5.3 that runs on 1.5.1.
It's only 3 blocks of code but only being able to follow patterns and syntax, this is impossible to do where the invoice.php page has been completely re-written. Shall I include the PHP for both pages?
Thank you lhungil, it was indeed that bug and all is now well and fixed. Thank you for your help.Quote:
Originally Posted by lhungil
Why is this posted in the Edit Orders support thread?????Quote:
Originally Posted by dharrison
You are welcome. Glad you were able to make the changes and get back to business!Quote:
Originally Posted by dp-web
I am sorry I thought I was on the correct thread. Instead of shrieking at every post I write, would you be so kind as to point me in the right direction?Quote:
Originally Posted by DivaVocals
"shrieking" eh?? Ummmm okay... For the record.. in the OTHER post you wrote on this I most certainly DID point you in the right direction as to WHERE to post.. but.. okay.. carry on..Quote:
Originally Posted by dharrison
Ok well I have found the right forum at long last. Thank you regardless :)
hello, this is kinda feature suggestion, to have the ability to add a coupon to an existing order without manually entering it
and exactly HOW would one add a coupon to the order in an order editing module without manually entering it????Quote:
Originally Posted by ShopVille
If you are going to suggest a feature.. it would help if you could explain how it should work.. IJS..:smile:
Hoping someone can help me out here. It has everything to do with this module and a little with another I am working on. Basically I am trying to generate a sales report that is accurate in it pulls the sales data from the orders_total table. Currently the sales report plug in pulls from the orders table and then recalculates the price on every order. This is causing me huge inaccuracies. So I have redone this report to pull from the table I need. It is accurate to the penny every time it is run. However, the inaccuracy comes when an order is edited. I am thinking this is because it updates the orders table and not the orders_total table. Is there an easy way to get the edit order module to update the orders_total table as well? Specifically I am looking to update the fields that appear starting with subtotal and go down to total. ie sub-total, shipping, sales tax, discounts, and total. Can anyone please help me out with this?
Thank you in advance!
I am thinking they want a drop down box to select from that would be populated from the coupons table.Quote:
Originally Posted by DivaVocals
Perhaps but a feature suggestion with no details leaves it for the VOLUNTEER developer to figure out what the suggestion means.. this presumes he/she has free time for GUESSING what someone meant.. IJS..Quote:
Originally Posted by southshorepizza
I would agree! As you can see in my question I tried to be very specific in what I wanted. Hopefully someone can help me out! :)
You are always very specific.. **lol** Wish I could help with your current question.. but I'm gonna leave it to the TRUE expert!:laugh:Quote:
Originally Posted by southshorepizza
Sometimes I think maybe I am too specific because I don't always get the help I need. Other times people bend over backwards to help out. The times they don't it seems I have asked for a too specific of a need.
I have figured out my question after a few hours of studying this. I was given bad information by a programer that charges. Imagine that!
Can you elaborate on what exactly is inaccurate (with Edit Orders)? Do you have any 3rd party order total modules installed? Was the order created at a time when ot_subtotal or ot_total were disabled (and then later edited)? Was the order previously edited by a version Edit Orders 4.0 (or older)?Quote:
Originally Posted by southshorepizza
Edit Orders 4.1 (and newer), does update both... It actually REQUIRES the order total modules ot_subtotal and ot_total to be installed and enabled (at this time) as it utilizes the values of these two modules. Further it loads and processes any enabled order total modules against the order (when editing) to ensure they are updated (and doing the math automatically).Quote:
Originally Posted by southshorepizza
Edit Orders 4.0 and earlier did their own calculations (and direct mysql calls to access the tables). They did not load or utilize the order total modules (although they did write to the database table). Using these older versions may require the store owner to do their own calculations and math... And then enter the correct information in the various fields.
My best guess too...Quote:
Originally Posted by southshorepizza
Would the cost (money and risk) really be worth the benefit? Especially considering how easy it is to navigate coupons already using the built in Zen Cart coupon admin page?
Store owners can use "admin" --> "gift certificate / coupons" --> "coupon admin" to look through the available coupons for their store. This existing tool lets them page through coupons very quickly to find the coupon they want to apply to an order. This tool also shows all the settings on each coupon and what the coupon does when applied to an order.
If the customer did not enter the coupon (or provide the coupon information if they called in) why would a store owner erode margin further (by spending the time to see if a valid coupon exists and then applying a discount coupon to the order)? Why even bother with a coupon if this case? Just lower the cost of the products if you plan to give every customer the discount... Or use the "group discount" modules... Or shell out the $$ for some of the order total discount modules written for Zen Cart...
<rant>
A dropdown with coupons could be problematic, especially on mature stores with a large number of coupons and gift certificates / vouchers (both are stored in the same database table). Would you really want potentially hundreds of items in a dropdown?
Next I'll hear "just filter them to ones which are applicable to the order"... So now you want to add additional processing time for each and every coupon? Not to mention issuing a considerable number of SQL queries? All needing to be performed EACH AND EVERY time the order is loaded (or edited) in Edit Orders?
Okay, and now that we have filtered the coupons... How do you know which coupon does what? Sure you have the coupon name in the dropdown, but it is only a name (and is not required to be unique). Coupons in Zen Cart can be applied in many different ways and contain many different settings...
So even with this "dropdown", in order to know what a coupon does (without applying it to the entire order and starting over back at the first paragraph), a store owner would need to go to the Zen Cart coupon admin page to see what the coupon does. So in this case, no time has been saved (quite the opposite actually)...
Add on top of this all the coding required to support such functionality (everything above, AJAX code for selection, PHP handlers for fallback when JavaScript fails or is disabled, etc). And now what happens if ot_coupon is changed in a future version (in order to filter the coupons we needed to directly use a method from this order total module)?
Who is going to PAY for the cost required to implement and maintain a coupon dropdown? Especially given the limited
</rant>
The only application I could envision something like this occurring is if say a discount is offered on a specific day for example, and the system went down for a period of time, but orders were still being manually processed to be updated later. Regardless, would think that such a coupon could be incorporated into a sale type situation instead or some other method, and that the quantity of such orders hopefully would be limited to a small number. And in that case would agree that the cost would seem high in comparison to the manual entries needed to catch up. (I use the term manual loosely though as there could be ways to populate en mass.)
@ Ilhungil In the post right above yours I stated that I had figured this out.
I have figured out my question after a few hours of studying this. I was given bad information by a programer that charges. Imagine that!
Thank you for taking the time to look at it. I am stuck on v 3.X because I keep getting errors when I install V 4.X I have posted here but haven't received any luck resolving my issue. Apparently Rewards Points and Edit Orders 4.X Don't play nice and I don't have the knowledge yet to fix it. My last post on the problem was #451. But I am finally taking some classes to learn it.
Thank you again for looking at this.
See post #450 in the Edit Orders 4.x Support Thread and post #2315 in the Reward Points Support Thread.Quote:
Originally Posted by southshorepizza
Making the changes listed in those threads should take care of the immediate problems loading the Reward Points Order Total modules from within the Zen Cart admin interface (and Edit Orders 4.1+).
Okay so I have done all of these things. I also have gone back in and found post 441-451 in this thread about my last attempt at the upgrade. I have the same results! :(
Log says
[28-Mar-2014 14:24:44] PHP Fatal error: Call to undefined function getrewardpoints() in /home4/w57dsjmm/public_html/order/includes/modules/order_total/ot_reward_points_display.php on line 40
however line 40 of said file is $reward_points=GetRewardPoints($order->products);
I feel as if this is ground hog day all over again!
And do you have a GetRewardPoints function in \admin\includes\functions\extra_functions\reward_points_functions.php. (case sensitivity counts..) You would copy over the one from the store side function file.. Saying you did what was suggested and still got an error doesn't provide enough info to determine why.. POST the changes you made to the admin functions file.. The error says you DON'T have the function in admin functions file.. might be best if you not only post the part you added but a couple of lines above and below it to make sure you didn't add e character that isn't supposed to be there.. (on the Rewards Points support thread of course :smile:)Quote:
Originally Posted by southshorepizza
I posted to the rewards site. Is this what is preventing edit orders 4.1.3 from working or do I have another issue as well? I have several domains. A public domain and a not advertised domain for our store to use for taking orders. Do you think I could uninstall the rewards module from the nonpublic domain and install edit orders 4.1.X and have it work there while the public domain is running the files for the rewards module? I don't give any points for orders our store takes. Only orders on the public site.
Thanks for your help!
So I have completely reinstalled via filezilla ftp Rewards points full suite and edited orders. I tried to edit an order and received the following error log
[29-Mar-2014 11:17:21] PHP Fatal error: 1054:Unknown column 'p.products_quantity' in 'field list' :: SELECT `p`.`products_quantity` FROM `zen_products` WHERE `p`.`products_id` = '8' in /home4/w57dsjmm/public_html/order/includes/classes/db/mysql/query_factory.php on line 120
Please help
Zencart 1.5.1
Getting a 404 page when clicking edit button. I have tried reinstalling and I get a upgrade OK green I have superorders along with ty tracker.
Any ideas
Thanks
Usual cause is something not installed correctly (or a misconfiguration in "configure.php"). If you can supply more information we may be able to help determine what went wrong and how to fix things. The posting tips (found directly above where you typed "Your Message") provide some valuable knowledge on what information to provide when asking for help. In addition, answers to the following would go a long ways towards helping us help you.Quote:
Originally Posted by remops
Version of Edit Orders?
This can be found by logging into the Zen Cart administrative interface and selecting "Configuration" --> "Edit Orders".
Link causing 404?
This will be listed in the "address bar" of your web browser. For example: "https://zencart.local/admin/edit_orders.php?page=1&oID=12&action=edit".
Installation order (TPT, SO, and EO)?
Which did you install first? Which did you install second? Which did you install third?
Were any upgrades?
Were any of the modules previously installed? If so, what modules and versions?
When did the 404 start appearing?
After installation on a "clean" version of Zen Cart? An upgraded copy of Zen Cart? After updating one of the modules? Etc?
I reinstall edit order and it started the 404 page. Thanks again for your quick replyQuote:
Originally Posted by lhungil
This usually indicates either Ty Package Tracker or Super Orders was updated AFTER Edit Orders was installed. Another possibility would be the user PHP is running as (on your webserver) does not have permissions to write to "/admin/orders.php".Quote:
Originally Posted by remops
Please re-run the installer for Edit Orders (this will make the necessary changes to order.php).
NOTE: As per the readme, Edit Orders will automatically update the relevant files including "/admin/orders.php" when the installer is run. Among other things it replaces FILENAME_ORDER_EDIT with FILENAME_EDIT_ORDERS.
I get the confirmation
Found previous version installed. Upgrading (or re-installing) Edit Orders (old 4.1.4 => new 4.1.4).
Success Edit Orders installation / upgrade completed!
All looks good untill I click the edit button, then I still get the 404 page.
Thanks again
I tried to edit the address field in the customer address, billing address, and shipping address columns. I received a blank page after clicking update and the following log
I searched this thread for validate_for_category() but didn't get any results.Code:PHP Fatal error: Call to undefined function validate_for_category() in
admin/includes/functions/extra_functions/edit_orders_functions.php on line 331
For some reason I missed this comment...Quote:
Originally Posted by remops
I'm guessing you overwrote the Super Orders version of "/admin/orders.php" with a copy from Ty Package Tracker. This means portions of the Super Orders plugin are probably broken. I would recommend re-installing / upgrading Super Orders.
Once everything with Ty Package Tracker and Super Orders is installed (and fully working), running the Edit Orders installer again should get you back up and running.
NOTE 1: Reading the README for Edit Orders, it states Ty Package Tracker and Super Orders should be installed PRIOR to Edit Orders... Reading the README for Super Orders, it states Ty Package Tracker should be installed PRIOR to installing Super Orders to avoid potential problems... So the correct order of installation to avoid issues would be Ty Package Tracker, Super Orders, Edit Order.
NOTE 2: As per the Edit Orders README, when using only Ty Package Tracker and Edit Orders (no Super Orders), one needs to manually merge the "/admin/orders.php" file from both (not automated by the installer). If using Super Orders and Ty Package Tracker, follow the installation instructions in Super Orders to install Super Orders before Edit Orders.
NOTE 3: At the minimum, you need to replace "/admin/orders.php" with the copy from Super Orders. However, there may be other files from Super Orders (or Edit Orders) accidentally overwritten when Ty Package Tracker was installed AFTER Super Orders and Edit Orders... If issues persist, I'd recommend starting over and following the installation order listed in NOTE 1 (and of course consulting the README files).
Affected Users:
Those running Edit Orders 4.1 and using coupons with category or product restrictions.
Observed Behavior:
When an order contains a "coupon" with a restriction based on category or product the order cannot be edited (and generates a PHP error).
The Fix:
Add the following (in red) to "/admin/includes/functions/extra_functions/edit_orders_functions.php":
Code:return false; //should never get here
}
}
if(!function_exists('validate_for_category')) {
function validate_for_category($product_id, $coupon_id) {
global $db;
$retVal = 'none';
$productCatPath = zen_get_product_path($product_id);
$catPathArray = array_reverse(explode('_', $productCatPath));
$sql = "SELECT count(*) AS total
FROM " . TABLE_COUPON_RESTRICT . "
WHERE category_id = -1
AND coupon_restrict = 'Y'
AND coupon_id = " . (int)$coupon_id . " LIMIT 1";
$checkQuery = $db->execute($sql);
foreach ($catPathArray as $catPath) {
$sql = "SELECT * FROM " . TABLE_COUPON_RESTRICT . "
WHERE category_id = " . (int)$catPath . "
AND coupon_id = " . (int)$coupon_id;
$result = $db->execute($sql);
if ($result->recordCount() > 0 && $result->fields['coupon_restrict'] == 'N') return true;
if ($result->recordCount() > 0 && $result->fields['coupon_restrict'] == 'Y') return false;
}
if ($checkQuery->fields['total'] > 0) {
return false;
} else {
return 'none';
}
}
}
if(!function_exists('validate_for_product')) {
function validate_for_product($product_id, $coupon_id) {
global $db;
$sql = "SELECT * FROM " . TABLE_COUPON_RESTRICT . "
WHERE product_id = " . (int)$product_id . "
AND coupon_id = " . (int)$coupon_id . " LIMIT 1";
$result = $db->execute($sql);
if ($result->recordCount() > 0) {
if ($result->fields['coupon_restrict'] == 'N') return true;
if ($result->fields['coupon_restrict'] == 'Y') return false;
} else {
return 'none';
}
}
}
// Start Edit Orders configuration functions
function eo_debug_action_level_list($level) {
Reported By:
Thank You to southshorepizza for finding this one!
Installed the files and all is good! :laugh:Quote:
Originally Posted by lhungil
Thanks
Glad you were able to get everything sorted.Quote:
Originally Posted by remops
Thank you for fixing that bug!!
Unable to remove a quantity discount when editing an order. I have this http://www.zen-cart.com/downloads.php?do=file&id=135 module installed. When you edit an order the quantity discount down in the total doesn't have a text box for the amount. It does have a text box for the title "quantity discount". But without the text box I can't adjust the amount. The discount also doesn't change if you remove any products. But that would be okay if I could adjust the amount of the discount or remove it. Thanks for your help.
If I give something to a customer for free I cannot zero out the tax on an order.